Commit Graph
938 Commits
Author SHA1 Message Date
Sergey Biryukov dd05a3a40f TinyMCE: Remove dashicon-no-alt.png, unused since [30694].
props kpdesign, MattyRob.
fixes #30791 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31073 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 23:31:16 +00:00
Andrew Ozz 3fdc11be29 Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167.
git-svn-id: https://develop.svn.wordpress.org/trunk@31070 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 22:47:32 +00:00
Sergey Biryukov 8e9b9bc458 Use localized format for Last Updated date on Add Plugins screen.
props tyxla.
fixes #30717.

git-svn-id: https://develop.svn.wordpress.org/trunk@31055 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-06 01:02:21 +00:00
Scott Taylor 14ddc6c9c0 If IMAGE_EDIT_OVERWRITE is defined as true, ensure that multiple edits to the same image does not result in the file being deleted (updating the meta fails because the old and new paths are identical).
Props hew.
Fixes #30394.


git-svn-id: https://develop.svn.wordpress.org/trunk@31043 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-04 02:51:20 +00:00
Scott Taylor 621e909a9b Improve the handling of comma-separated mime-types in wp_match_mime_types(), particularly as pertains to the mime-type selector on the Media list table screen.
Props mdgl.
Fixes #30788.


git-svn-id: https://develop.svn.wordpress.org/trunk@31042 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-04 02:31:29 +00:00
Scott Taylor 5df9963414 Respect query vars for taxonomies passed as URL parameters when in grid mode of Media Library.
Fixes #30584.


git-svn-id: https://develop.svn.wordpress.org/trunk@31037 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-03 08:23:06 +00:00
Scott Taylor ca8fe1a7a4 Use the 'not_found' label when there are no items for a taxonomy in the terms list table.
Props SergeyBiryukov.
Fixes #30586.


git-svn-id: https://develop.svn.wordpress.org/trunk@31035 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-03 06:19:46 +00:00
Scott Taylor 47f2c42528 Inline <script>s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need CDATA comments.
Props tw2113 for the initial patch.
See #18788.


git-svn-id: https://develop.svn.wordpress.org/trunk@31034 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-03 05:45:17 +00:00
Scott Taylor d5328fc674 When outputting JS with a Content-Type header:
`text/javascript` is obsolete, `application/x-javascript` was experimental. `application/javascript` is the recommended type per RFC 4329.

Props sergej.mueller.
Fixes #29196.


git-svn-id: https://develop.svn.wordpress.org/trunk@31029 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-03 02:56:14 +00:00
Scott Taylor 64784baa95 WP_List_Table's constructor registers an 'admin_footer' callback when AJAX is enabled. As such, if you create multiple instances of the class, you get multiple JS blobs on the page when the callbacks fire. Extra instances get made when wp_comment_reply() invokes the class constructor without checking for the existing instance via the $wp_list_table global.
We shall check the `$wp_list_table` global in `wp_comment_reply()`.

Props sorich87.
Fixes #17413.


git-svn-id: https://develop.svn.wordpress.org/trunk@31019 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-01 19:54:53 +00:00
Scott Taylor be8211beac Support chromeless Vimeo via MEjs:
* Bump MediaElement script loader versions to 2.16.2 - missed in [30634], oops!
* Add `Froogaloop` to `js/mediaelement` scripts for Vimeo
* Check for Vimeo in the same locations that YouTube is checked
* Dynamically load Froogaloop script in admin when editing a TinyMCE view
* Edit MediaElement to call `mejs.$.extend` instead of `$.extend` in `mejs.HtmlMediaElementShim.createPlugin()`, since `$` is not available via WP's jQuery (I will report this upstream):
https://github.com/johndyer/mediaelement/blob/6f9a78e008de2de796a1797077a74a94763320f9/src/js/me-shim.js#L631

Fixes #29267.


git-svn-id: https://develop.svn.wordpress.org/trunk@31016 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-31 20:40:05 +00:00
Andrew Nacin 25e332e473 Use correct function name in docs for get_plugin_data().
props eliorivero.
fixes #30699.


git-svn-id: https://develop.svn.wordpress.org/trunk@31008 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-31 08:07:09 +00:00
Boone Gorges e85543f68b When no plugins are active, return an empty array from validate_active_plugins().
This creates parity with the behavior of the function when plugins *are* active,
but none are invalid. It also makes it possible to write unit tests for the
function.

Props sgrant.
Fixes #30860.

git-svn-id: https://develop.svn.wordpress.org/trunk@31003 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-30 19:30:07 +00:00
Scott Taylor 061bfddda9 Comment List Tables:
* Declare `$extra_items` property
* Since `->get_column_info()` overrides its parent's method, it doesn't need to set `_column_headers`, which is an undeclared property that is only used for caching the lookup after the first run in the parent class, which isn't called in the child class.
* `$_args` in `WP_List_Table` has to be `protected` for `WP_Post_Comments_List_Table` to legally access it. `$_args` is awkward as is and should probably be only available via a getter.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30984 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 23:27:00 +00:00
Scott Taylor 44fe0ebf75 Correct the @param docs for arguments that are truthy/falsey.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30983 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 23:03:21 +00:00
Scott Taylor 218dd4fd6b For clarity, initialize some arrays that previously were only assigned via short circuit in loops.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30982 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 22:46:53 +00:00
Scott Taylor 91dcf8796b In image_size_input_fields():
* Declare `$out` as an empty array - this is not a strict PHP requirement, but is a good practice before loops
* Most of this function was tabbed twice, instead of once

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30981 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 22:18:12 +00:00
Scott Taylor a75c7977b9 In wp_import_handle_upload():
`$file` was essentially getting declared/overwritten 3 times. In lieu of this, return an array containing the error immediately instead of doing a short-circuit array key assignment on error. Rename the local variable to `$upload` and use its properties instead of creating 3 new local vars, one of which stomped the array.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30980 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 21:09:11 +00:00
Scott Taylor f6f12912e2 Improve some docs for @param. Remove an unneeded $wpdb global import.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30979 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 20:55:21 +00:00
Scott Taylor 04ed6499cd Improve some wp-admin/includes/class-wp-filesystem-*.php docs for @param.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30978 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 20:39:41 +00:00
Dominik Schilling (ocean90) 7560f4cf8c Pass locale to wordpress.org theme/plugin API.
In the future this will be used to return localized plugin/theme info.

see #30735.

git-svn-id: https://develop.svn.wordpress.org/trunk@30944 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 22:38:52 +00:00
Andrew Nacin daf16cdb63 Call it 'Distraction-free writing mode' and update the help string. fixes #30657.
git-svn-id: https://develop.svn.wordpress.org/trunk@30890 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 10:06:17 +00:00
Andrew Nacin 855ff22a53 Update/add plugin recommendation strings.
Update [30887], add a translation function to the Vine string.

fixes #30337. see #30435.


git-svn-id: https://develop.svn.wordpress.org/trunk@30889 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 10:05:09 +00:00
Andrew Nacin 07e7f03373 Updates to the 'Log out everywhere' implementation.
* Include a message and a disabled button when you're only logged in at one location.
 * Avoid leaking the session token in HTML.
 * Simplify, simplify, simplify.

see #30264.


git-svn-id: https://develop.svn.wordpress.org/trunk@30888 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 09:15:01 +00:00
Dion Hulse 28e22a4ec4 Background Updates: Pass back whether Group Writable support is being leveraged for an update to the WordPress.org API.
See #30245


git-svn-id: https://develop.svn.wordpress.org/trunk@30860 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 14:07:35 +00:00
Andrew Nacin b38c603682 Rename _wp_clear_update_cache() to wp_clean_update_cache().
This makes it match most cache-clearing functions, including the ones it wraps. Also no need for it to be prefixed as "private."

wp_clean_plugins_cache() doesn't always exist, so as a quick fix, clear the transient we care to clear.

see #30369.


git-svn-id: https://develop.svn.wordpress.org/trunk@30856 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 08:54:14 +00:00
Andrew Ozz 1bbc18c390 Improve text for the DFW admin pointer. Remove the concatenation.
Props kpdesign, ianmjones.
See #30671.

git-svn-id: https://develop.svn.wordpress.org/trunk@30837 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-12 22:11:46 +00:00
Andrew Ozz 9bda766f54 Fix the search field width in the media modal, media library grid and on the install new plugins screen. Props helen, fixes #30658.
git-svn-id: https://develop.svn.wordpress.org/trunk@30813 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-11 04:11:28 +00:00
Sergey Biryukov 27fefdf04b Revert [28948], which caused a regression.
see #29573 for trunk. see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@30791 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-08 21:13:56 +00:00
Andrew Ozz c8e8281a05 Plugins: move the recommender results to a separate tab. Any outstanding quality issues will be fixed on the API side without needing core changes. Props tellyworth, fixes #30337.
git-svn-id: https://develop.svn.wordpress.org/trunk@30782 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 23:39:54 +00:00
Andrew Ozz fce20e9784 Better docs for Plugin_Upgrader::deactivate_plugin_before_upgrade(). Props DrewAPicture. Fixes #29088.
git-svn-id: https://develop.svn.wordpress.org/trunk@30762 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 01:18:21 +00:00
Andrew Ozz d948f0bf32 Always return a value in Plugin_Upgrader::deactivate_plugin_before_upgrade(). Props jdgrimes. Fixes #29088.
git-svn-id: https://develop.svn.wordpress.org/trunk@30761 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 00:52:06 +00:00
Drew Jaynes (DrewAPicture) 3cdbc730d3 Add missing DocBlocks and parameter descriptions for a wide variety of properties and methods in WP_Upgrader, Plugin_Upgrader, Theme_Upgrader, Language_Pack_Upgrader, Core_Upgrader, and File_upload_Upgrader.
Props jdgrimes, DrewAPicture.

See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@30758 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 00:25:44 +00:00
Drew Jaynes (DrewAPicture) fffbee4ac7 Fix a typo in the return description for get_sample_permalink().
Props TobiasBg.
Fixes #30591.


git-svn-id: https://develop.svn.wordpress.org/trunk@30755 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 21:45:12 +00:00
John Blackbourn 7082b703b2 Improve various hook and filter docs so they are correctly parsed for the code reference.
Fixes #30558
Props DrewAPicture


git-svn-id: https://develop.svn.wordpress.org/trunk@30754 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 21:31:41 +00:00
Drew Jaynes (DrewAPicture) 7187da0b32 Convert various uses of (optional) in core parameter descriptions to use the style prescribed in the inline documentation standards for PHP.
The style for marking parameters optional in inline PHP docs is: `@param type $var Optional. Description. Accepts. Default.`, where Accepts can be omitted on a case-by-case basis.

Props coffee2code.
Fixes #30591.


git-svn-id: https://develop.svn.wordpress.org/trunk@30753 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 21:23:52 +00:00
Andrew Nacin 96dee2af62 Adjust [29806] and revert [29807] to restore placeholder and email copy order.
Avoids unnecessarily changing a (large, carefully formatted) translated string from 4.0.

fixes #21089.


git-svn-id: https://develop.svn.wordpress.org/trunk@30742 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-05 01:14:03 +00:00
John Blackbourn 99c61f2201 Correct the default value of the show_split_view argument for revisions so they are correctly displayed side by side ins
tead of inline.

Fixes #24908


git-svn-id: https://develop.svn.wordpress.org/trunk@30739 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-04 14:35:02 +00:00
Andrew Ozz 86c494d1b5 Update better description of the Screen Options checkbox for DFW v2 and editor-expand. Props johnbillion, kpdesign, fixes #30557.
git-svn-id: https://develop.svn.wordpress.org/trunk@30734 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-03 21:59:53 +00:00
Andrew Ozz 836b980715 Editor show the DFW v2 pointer for users that have disabled the visual editor. Fixes #30458.
git-svn-id: https://develop.svn.wordpress.org/trunk@30730 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-03 18:17:37 +00:00
Drew Jaynes (DrewAPicture) e3957f278e Use the correct hash notation syntax for the WP_Filesystem_Base::dirlist() DocBlock.
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@30722 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-03 10:10:07 +00:00
Andrew Ozz 9adaec183e Update the description of the Screen Options checkbox for turning editor-expand on/off to include DFW v2. Props kpdesign, fixes #30557.
git-svn-id: https://develop.svn.wordpress.org/trunk@30718 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 23:22:52 +00:00
Andrew Ozz f8a478af9d Update the DFW v2 pointer text. Props kpdesign, DrewAPicture, johnbillion. Fixes #30458.
git-svn-id: https://develop.svn.wordpress.org/trunk@30717 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 23:10:52 +00:00
Andrew Ozz 36dd60705f Editor: hide the DFW v2 button when editor-expand is off. Fixes #30568.
git-svn-id: https://develop.svn.wordpress.org/trunk@30711 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 20:39:13 +00:00
Drew Jaynes (DrewAPicture) 18f101b4bf Using let's properly in inline comments lets us move on to more pressing matters of inline documentation.
Props trepmal.
Fixes #30570.


git-svn-id: https://develop.svn.wordpress.org/trunk@30703 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 04:42:17 +00:00
John Blackbourn 16ec77cd70 Prevent the deletion of a theme while it has an active child theme.
Fixes #29580
Props karpstrucking, jesin


git-svn-id: https://develop.svn.wordpress.org/trunk@30697 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 02:20:14 +00:00
Drew Jaynes (DrewAPicture) 205a43ed05 Correctly capitalize JavaScript throughout core docs.
Fixes #30569.


git-svn-id: https://develop.svn.wordpress.org/trunk@30695 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 00:30:59 +00:00
Scott Taylor 095bfabfa9 Improve various @param docs.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30682 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 02:16:36 +00:00
Scott Taylor 8a4fa5662b Improve various @param docs for src/wp-admin/*.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30680 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:59:43 +00:00
Scott Taylor c0045bda84 Improve various @param docs for List Tables.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30679 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:32:19 +00:00