Scott Taylor
6fd11624d1
The keyword elseif should be used instead of else if so that all control keywords look like single words.
...
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs.
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:04:40 +00:00
Sergey Biryukov
3274f5fee6
Skip building the query in wp_count_posts() if cached results are used.
...
props MikeHansenMe.
fixes #30928 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31058 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-06 16:57:12 +00:00
Scott Taylor
621e909a9b
Improve the handling of comma-separated mime-types in wp_match_mime_types(), particularly as pertains to the mime-type selector on the Media list table screen.
...
Props mdgl.
Fixes #30788 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31042 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-04 02:31:29 +00:00
Scott Taylor
f014d0cf35
If you set '_wp_page_template' for a post, and then switch to a theme that doesn't support the template, subsequent calls to wp_insert_post() will bail early without running a plethora of hooks. This shouldn't happen. We should set the template to 'default' and continue through the rest of the function. The function will still bail if $wp_error is true via wp_insert_post( $arr, true ).
...
Props nofearinc.
Fixes #25334 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31020 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-01 20:34:19 +00:00
Scott Taylor
218dd4fd6b
For clarity, initialize some arrays that previously were only assigned via short circuit in loops.
...
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30982 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 22:46:53 +00:00
Scott Taylor
e37fb988b1
Give up on making uninterrupted hierarchies work in get_page_children() for now, reverts [30159], [30246], [30636].
...
Props boonebgorges.
See #14477 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30735 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-04 00:23:47 +00:00
Drew Jaynes (DrewAPicture)
d167ce0070
Improve formatting of inline documentation for get_pages().
...
Adds missing default values, corrects several argument types, backtick-escapes argument names used in descriptions.
See #28298 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30725 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-03 10:30:55 +00:00
Drew Jaynes (DrewAPicture)
0fee97e110
Use the correct hash notation syntax for the get_pages() DocBlock.
...
See #28298 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30723 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-03 10:15:08 +00:00
Scott Taylor
4de850c8ff
Improve the @param docs for src/wp-includes/post*.php.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30671 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:37:00 +00:00
Drew Jaynes (DrewAPicture)
973af104ff
Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-includes/post.php.
...
Affects DocBlocks for the following hooks:
* `post_type_labels_{$post_type}`
* `edit_{$field}`
* `{$field_no_prefix}_edit_pre`
* `pre_{$field}`
* `{$field_no_prefix}_save_pre`
* `{$field}_pre`
* `$field`
* `save_post_{$post->post_type}`
* `{$old_status}_to_{$new_status}`
* `{$new_status}_{$post->post_type}`
See #30552 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30653 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 11:55:58 +00:00
Scott Taylor
cb648b68e1
Ensure uniqueness when returning page lists in get_page_children(). Fixes failing unit tests.
...
Props boonebgorges.
Reverts [30246].
Fixes #14477 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30636 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 06:04:31 +00:00
John Blackbourn
76a9abd7a7
Check attachments as well as the current post type when checking for duplicate post slugs. This avoids creating a page with a slug which conflicts with an existing attachment (the inverse is already handled).
...
Updates the existing test for pages which should take priority over attachments in cases where an existing clash exists.
Fixes #18962
Props boonebgorges
git-svn-id: https://develop.svn.wordpress.org/trunk@30629 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 04:48:54 +00:00
Drew Jaynes (DrewAPicture)
76699122d0
Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
...
Affects DocBlocks for the following core elements:
* Backtick-escape HTML tags in several argument descriptions for `wp_link_pages()`
* Remove an HTML tag from the summary for `prepend_attachment()`
* Backtick-escape inline code in the description for `get_extended()`
* Backtick-escape inline code in the description for `get_post_type_labels()`
* Various markdown formatting in the description for `add_rewrite_endpoint()`
* Markdown-indent a code snippet in the file header for wp-includes/shortcodes.php
* Markdown-indent code snippets in the description for `add_shortcode()
Props rarst.
See #30473 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30545 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 06:14:03 +00:00
John Blackbourn
8fe059d426
Correct an SQL syntax error introduced in r30158. Adds tests.
...
Fixes #30339
See #18962
Props julien731
git-svn-id: https://develop.svn.wordpress.org/trunk@30480 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 16:45:48 +00:00
Drew Jaynes (DrewAPicture)
68f8703893
Fix incorrect documentation in the DocBlocks for get_lastpostmodified() and _get_last_post_time().
...
Props ericlewis for the initial patch.
Fixes #30249 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30287 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-08 21:07:46 +00:00
Drew Jaynes (DrewAPicture)
72cc949b5d
Fix the syntax for some status-related documentation introduced in [30155].
...
* Variables in DocBlocks should be backtick-escaped
* Parameter and return types should be as specific as possible
* `@param` types and variables should align with each other, but not intentionally with the `@return` description
See #30230 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30284 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-08 20:55:14 +00:00
Scott Taylor
5a2c0fef1e
In get_page_children(), only check $page->ancestors once to avoid duplicates when the function recurses. Adds an argument, $ancestors.
...
Fixes #18962 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30246 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-05 20:04:55 +00:00
Scott Taylor
4315c9c5c3
Allow get_pages(), with child_of passed to it, to work with interrupted hierarchies.
...
Adds unit test.
Fixes #18962 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30159 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:43:55 +00:00
Scott Taylor
59658c6547
All duplicate slugs across different post types.
...
Adds unit test.
Props mboynes, nacin.
Fixes #18962 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30158 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:36:23 +00:00
Scott Taylor
c8acddfdc8
Improve some post_status-related documentation.
...
Props ericlewis.
See #30230 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30155 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:19:26 +00:00
Drew Jaynes (DrewAPicture)
7cd15026bd
Correct references of @uses $wpdb in core documentation to use @global.
...
See #30191 , [30105].
Fixes #30217 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30122 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 17:55:39 +00:00
Drew Jaynes (DrewAPicture)
3cc10d77a0
Remove redundant and erroneous @uses tag from most core inline documentation.
...
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.
Fixes #30191 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30105 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 01:04:55 +00:00
Sergey Biryukov
6cbc9e03e1
When using 'show_in_menu' as a default value for 'show_in_admin_bar' in register_post_type(), cast to boolean instead of requiring a strict match.
...
props ipm-frommen.
fixes #30092 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30041 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-27 13:07:38 +00:00
Scott Taylor
701dce21b1
In wp_delete_attachment(): account for orphan sizes by looping over the sizes stored in metadata, instead of relying on the current sizes stored in $_wp_additional_image_sizes.
...
Props JoshuaAbenazer, desrosj, markoheijnen.
Fixes #24518 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29816 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 15:31:57 +00:00
Drew Jaynes (DrewAPicture)
191a7ead45
Add some missing information to the inline docs for get_post_types().
...
* Improves the `@see` reference for `register_post_type()` to mention that it contains information about accepted arguments
* Adds a description of the accepted values for the `$operator` parameter
* Fixes a typo
Fixes #29721 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29752 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-21 08:54:37 +00:00
Sergey Biryukov
6e0ca0d8d9
Make sure the $parent argument of wp_insert_attachment() still works as expected after [28579].
...
prop jesin, dikiy_forester.
fixes #29646 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@29745 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-15 14:23:31 +00:00
John Blackbourn
fcda873946
Correct the docblock for the registered_post_type action. Fixes #29184 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@29468 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-11 21:20:58 +00:00
Scott Taylor
d83ac79c38
Unbreak Media Trash after [28788].
...
Props SergeyBiryukov.
Fixes #29080 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29337 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 15:14:56 +00:00
Sergey Biryukov
7ac0669493
Avoid PHP notices in _count_posts_cache_key(), _update_blog_date_on_post_publish(), and _update_blog_date_on_post_delete() if post type is not registered.
...
props jesin.
fixes #28135 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29318 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 00:50:53 +00:00
Drew Jaynes (DrewAPicture)
e347ef267d
Convert default arguments documentation for get_posts() into a hash notation.
...
Props coffee2code for the initial patch.
See #28841 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29113 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 23:33:33 +00:00
Drew Jaynes (DrewAPicture)
f498128aa9
Fix syntax for inline comment line endings and a few line wraps in wp-includes/post.php inline documentation.
...
Fixes #25412 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29097 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 18:34:36 +00:00
Drew Jaynes (DrewAPicture)
93130f6a29
General inline documentation improvements in wp-includes/post.php.
...
Final-run. Fixes #25412 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29094 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 11:15:49 +00:00
Drew Jaynes (DrewAPicture)
51e97631f8
General inline documentation improvements in wp-includes/post.php.
...
Third-run. See #25412 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29093 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 10:27:02 +00:00
Drew Jaynes (DrewAPicture)
479b541dd1
General inline documentation improvements in wp-includes/post.php.
...
Second-run. See #25412 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29092 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 08:15:52 +00:00
Drew Jaynes (DrewAPicture)
628141afbf
Convert phpDoc for register_post_type() to use a hash notation for the $args array.
...
See #25412 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29091 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 07:55:38 +00:00
Drew Jaynes (DrewAPicture)
c7171e832d
General inline documentation improvements in wp-includes/post.php.
...
First-run. See #25412 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29090 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 07:00:38 +00:00
Drew Jaynes (DrewAPicture)
b1b454c7a0
Remove backticks on $post variables in some short parameter descriptions.
...
See [28653], [28654].
See #28388 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28976 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:27:54 +00:00
Drew Jaynes (DrewAPicture)
2d9bba0a5c
Specify the $single parameter default for get_post_meta(). Docs spacing.
...
See #28708 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28955 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 03:29:33 +00:00
Sergey Biryukov
65106eff1f
Mark $single parameter of get_post_meta() as optional.
...
props netweb.
fixes #28708 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28954 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 03:25:28 +00:00
Sergey Biryukov
00678ab0df
Notify developers when register_post_type() or register_taxonomy() fails because of post type or taxonomy key length.
...
props mattheweppelsheimer.
fixes #28683 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28902 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 21:53:35 +00:00
Scott Taylor
cf67d53408
Remove obsolete wp_cache_delete('get_pages', 'posts') from clean_post_cache().
...
Fixes #27459 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28875 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 02:15:45 +00:00
Scott Taylor
304f4f5ba9
Posts in the Trash should not drag attachment pages down with them.
...
Props ericlewis.
Fixes #14639 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28791 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 19:13:39 +00:00
Scott Taylor
a7c1728f2e
Reinstate the changes from [28579] with some adjustments:
...
* Check `! empty( $postarr['file'] )` before calling `update_attached_file()`
* Add a unit test: `test_update_attachment_fields()`
* Run the same logic for empty `guid` for attachments that always ran in `wp_insert_post()`, as per #18310 . This fixes a unit test that would have broken when this ticket was marked closed.
* Updated the unit test in `Tests_Media::test_wp_prepare_attachment_for_js()` to account for `url` no longer being empty
Props kovshenin, wonderboymusic.
See #21963 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28788 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 18:26:17 +00:00
Scott Taylor
84ad12b439
Replace all uses of like_escape() with $wpdb->esc_like().
...
Props miqrogroove.
See #10041 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28712 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 00:43:32 +00:00
Sergey Biryukov
83bffbc6c7
Correct @return value for get_children().
...
props ghost1227.
fixes #28422 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28677 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 15:52:51 +00:00
Drew Jaynes (DrewAPicture)
b884487767
Be more specific that $post_id does not default to the ID of the global $post in some cases.
...
See [28654]. See #28388 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28655 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-03 04:51:05 +00:00
Drew Jaynes (DrewAPicture)
d068c888f3
Ensure $post_id is documented as optional where applicable.
...
See #28388 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28654 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-03 04:43:47 +00:00
Andrew Nacin
0c7edb2045
Revert [28579] and [28582]. see #21963 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28601 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 18:13:55 +00:00
Scott Taylor
7f2cad1809
Fix some inline docs churn in wp_insert_post() after [28579].
...
Props kpdesign.
See #21963 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28582 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 00:23:21 +00:00
Scott Taylor
6cd28991e3
Combine wp_insert_attachment() and wp_insert_post(). wp_insert_attachment() becomes a wrapper. Update inline docs.
...
Props wonderboymusic, DrewAPicture.
See #21963 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28579 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-26 23:19:03 +00:00