Sergey Biryukov
de44adee46
Remove obsolete $wpdb reference from get_comments() docs.
...
props lamosty.
fixes #31748 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31870 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 15:42:09 +00:00
Gary Pendergast
22214ffdf9
Emoji: The regex for checking if the current glyph is a flag was checking the incorrect byte range, which was causing the South Korean flag to not be replaced in Firefox.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31869 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 09:57:44 +00:00
Andrew Ozz
fc1d327261
Introduce attachment_url_to_postid filter to let plugins manage the uploads location better.
...
Props mattwiebe. Fixes #31717 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31867 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 17:23:27 +00:00
Drew Jaynes
074eba3a53
4.2-beta2-31866
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31866 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 12:27:08 +00:00
Gary Pendergast
b3e3766233
Emoji: Gmail doesn't obey an <img>'s inline CSS height rule, transforming it to min-height. To avoid giant smiley faces everywhere, we're changing the height rule to max-height, which Gmail plays nicer with.
...
Props janhenckens.
Fixes #31719 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31864 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 12:07:47 +00:00
Dion Hulse
9eb9342a54
Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified.
...
* `H:i - 09:54`
* `g:i a - 9:54 am`
* `F j, Y - January 3, 2015`
These shouldn't be used without a/A (am/AM)
* `h:i - 01:23`
* `G:i - 1:23`
Props iseulde. Fixes #31121
git-svn-id: https://develop.svn.wordpress.org/trunk@31862 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 02:13:50 +00:00
Gary Pendergast
4d8a13fe33
Emoji: Set the emoji image protocol with set_url_scheme(), instead of defaulting to HTTPS.
...
Props extendwings.
Fixes #31735 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31861 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 02:10:35 +00:00
Gary Pendergast
48cb73bba1
Emoji: When we're replacing emoji with <img>s in email, we can only do that if the Content-Type is text/html - otherwise, they'll show up in the email as the HTML string.
...
Fixes #31720
git-svn-id: https://develop.svn.wordpress.org/trunk@31860 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-22 23:15:34 +00:00
Drew Jaynes
c1b0b8e97e
Fix a typo in the description for the _wp_filter_build_unique_id() DocBlock.
...
Props lamosty.
Fixes #31732 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31859 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-22 22:55:21 +00:00
Andrew Ozz
f6aa243908
TinyMCE: fix the icon for the wp_code button. Fixes #31733 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31858 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-22 22:53:32 +00:00
Andrew Ozz
e0e4780c9d
TinyMCE: when pasting an URL, check if the node it is pasted at is empty and remove any empty inline child elements.
...
Fixes #31158 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31856 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 20:33:55 +00:00
Drew Jaynes
601aee103a
Supplement hook documentation for the get_terms_fields filter to more clearly explain the expected consequences of using it to modify the fields to select in a terms query.
...
Props boonebgorges.
Fixes #31174 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31855 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 20:10:22 +00:00
Drew Jaynes
d66fffa31b
Document default arguments for paginate_links() as a hash notation.
...
Props atimmer.
Fixes #31433 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31854 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 20:03:04 +00:00
Drew Jaynes
e450904e35
Adjust DocBlocks for get_|the_post_thumbnail() to clarify the difference between the 'thumbnail' and 'post-thumbnail' image sizes.
...
Also fleshes out parameter documentation for the two functions.
Props magicroundabout for the initial patch.
Fixes #31351 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31853 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 19:56:16 +00:00
Drew Jaynes
b939e06b06
Add more verbose inline documentation inside of wpautop() to more clearly explain what's going on.
...
Props ericlewis, johneckman, azaozz.
Fixes #31041 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31852 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 19:46:41 +00:00
Drew Jaynes
34a7cdf926
Add hook documentation for the get_media_embedded_in_content_allowed filter, introduced in [31574].
...
Props valendesigns.
Fixes #26675 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31851 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 19:28:30 +00:00
Mark Jaquith
490fb1bf52
Trigger _doing_it_wrong() if register_sidebar() is not passed an id
...
* If you don't pass an `id`, WP sets an auto-increment one for you.
* But this depends on order of sidebar definition.
* Change the order or remove a sidebar? They jumble.
fixes #31675
props tschutter, valendesigns
git-svn-id: https://develop.svn.wordpress.org/trunk@31850 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 18:29:13 +00:00
Gary Pendergast
e3b2637699
When converting emoji in email to static images, check that the message is defined, otherwise we could cause PHP warnings.
...
Props nerrad.
Fixes #31708 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31847 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 12:31:30 +00:00
Gary Pendergast
182dd8606e
If the URL being visited has non-breaking spaces at the end of it, they were probably inserted by an errant URL copy/paste. Instead of showing a 404 for no obvious reason, let's just trim them.
...
Fixes #31499
git-svn-id: https://develop.svn.wordpress.org/trunk@31838 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 01:01:52 +00:00
Drew Jaynes
dd8511c35b
WordPress 4.2-beta2
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31835 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-19 19:18:37 +00:00
Andrew Ozz
e977f42a66
TinyMCE: revert stripping of tags from pasted URLs on beforeSetContent [31817] and [31819]. Clean up URLs on pastePreProcess.
...
See #31158 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31832 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-19 07:07:48 +00:00
Scott Taylor
2f20da29b5
Replace array_shift() with reset() where appropriate for performance.
...
Props SergeyBiryukov.
Fixes #31259 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31829 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-19 03:55:39 +00:00
Dominik Schilling (ocean90)
9c21bedcbb
Revert [31729] since <aside> seems not to be the appropriate HTML5 tag.
...
see #30556 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31826 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-18 22:25:20 +00:00
Dominik Schilling (ocean90)
60f95452a4
Don't try to call wp_clean_plugins_cache(); twice in wp_clean_update_cache().
...
props TobiasBg.
fixes #31503 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31825 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-18 22:06:17 +00:00
Helen Hou-Sandi
e771be8f7c
Toolbar: Protect against Firefox font rendering interference by themes.
...
props cbaldelomar.
fixes #30021 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31824 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-18 22:03:12 +00:00
Andrew Ozz
c2dc27adfd
TinyMCE emoji: fix highlighting of selected replacement images in Chrome.
...
Props iseulde. Fixes #31628 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31822 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-18 21:53:36 +00:00
Dominik Schilling (ocean90)
a3f6767a45
Comments: Move HTML tags for screen reader text into translatable strings.
...
Placeholders aren't helpful and it's much easier to make a mistake if you're dealing with placeholders.
Introduced in [31388].
props pento.
fixes #26553 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31821 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-18 21:51:36 +00:00
Andrew Ozz
639f5228c3
TinyMCE: small cleanup for stripping of tags from pasted URLs. See #31158 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31819 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-18 20:52:35 +00:00
Andrew Ozz
25a5f07d51
TinyMCE: strip tags from pasted URLs before testing if they are embeddable.
...
Props siobhan, iseulde. Fixes #31158 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31817 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-18 20:25:09 +00:00
Boone Gorges
31bded083b
Ensure that the $exclusions parameter of 'list_terms_exclusions' filter is always a string.
...
Props fhwebcs.
Fixes #31681 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31813 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-18 18:22:20 +00:00
Drew Jaynes
b9cb22f888
Add a changelog entry to the DocBlock for comment_form() for the class_submit argument added in 4.1.
...
See [29809]. See #20446 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31803 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-17 18:37:12 +00:00
Andrew Ozz
21da2ccd85
Press This: bump bookmarklet's version. See #31657 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31800 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-17 01:18:01 +00:00
Andrew Ozz
eb9cf72a1b
Press This:
...
- Test image sizes from JS after Press This loads, before adding them to "Suggested media".
- Clean up and simplify the HTML and JS a bit.
Fixes #31561 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31797 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-16 20:50:39 +00:00
Drew Jaynes
fb1873cfe6
Move the default arguments hash notation for WP_Comment_Query to the new constructor, where the argument definitions were moved in [31793].
...
Core style dictates that the default arguments should be documented in the same function or method where they are defined.
See [31793].
Fixes #24826 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31795 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-16 20:17:35 +00:00
Boone Gorges
12784e13d4
Improve method consistency in WP_Comment_Query.
...
* Introduce a `__construct()` method, which can accept an array of query vars.
* Move query logic out of `query()` method and into a new `get_comments()` method.
* Ensure that `$this->comments` is set whenever `get_comments()` returns a value.
* Introduce a `parse_query()` method, where query vars are parsed with default values and the 'parse_comment_query' action is fired.
These changes bring `WP_Comment_Query` syntax closer to that of `WP_Query`.
Props westonruter, morganestes, boonebgorges.
Fixes #24826 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31793 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-16 14:23:33 +00:00
Boone Gorges
ec49827b0b
In wp_insert_term(), allow a term with an existing name if a unique $slug has been provided.
...
`wp_insert_term()` protects against the creation of terms with duplicate names
at the same level of a taxonomy hierarchy. However, it's historically been
possible to override this protection by explicitly providing a value of `$slug`
that is unique at the hierarchy tier. This ability was broken in [31734], and
the current changeset restores the original behavior.
A number of unit tests are added and refactored in support of these changes.
See #17689 for discussion of a fix that was superceded by [31734]. This commit
retains the fix for the underlying bug described in that ticket.
See #31328 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31792 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-16 11:15:34 +00:00
Gary Pendergast
2b3cfead22
Emoji: Rename the email and feed filter functions to be _ prefixed, and @ignore-d in the PHPDocs.
...
See #31242
git-svn-id: https://develop.svn.wordpress.org/trunk@31791 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-16 10:45:29 +00:00
Sergey Biryukov
47c69c3207
Fix typo in a comment in [31752].
...
see #31242 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31790 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-16 01:55:53 +00:00
Drew Jaynes
7bbdceb336
Clean up some inline documentation for emoji functionality, including a missing @since for mail_emoji(), and a changelog entry for wp_insert_post().
...
See #31242 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31789 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-16 01:42:26 +00:00
Gary Pendergast
ad7456fe03
Emoji: Move a comment to match the restructure in [31779], and add an extra comment explaining how emoji rendering support is detected.
...
See #31242
git-svn-id: https://develop.svn.wordpress.org/trunk@31788 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-16 00:05:05 +00:00
Andrew Ozz
f078bc93aa
Emoji: fix few typos. See #31242 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31787 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-15 23:28:04 +00:00
Andrew Ozz
005ff9a8c8
Emoji:
...
- Add the styling for the replacement images to the admin CSS.
- Revert to using `.emoji` as replacement image class.
- When pasting in the editor, convert emoji images to our format so we can replace them with chars on saving.
- Some more clean up of both the plugin and wp-emoji.js.
See #31242 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31786 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-15 23:15:28 +00:00
Gary Pendergast
0ac085da11
WPDB: HHVM doesn't support passing a DB link to mysqli_get_client_version(). While we usually pass a DB link to every ext/mysql and mysqli function call, we don't really need to do that here, as there's no way for the client library to change mid page load.
...
Another fun fact is that `mysql_get_client_version()` doesn't exist, but `mysql_get_client_info()` (along with `mysqli_get_client_info()') do. So, we're switching to them, in order to add a pleasing symmetry to the client version check.
Fixes #31644
git-svn-id: https://develop.svn.wordpress.org/trunk@31783 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-15 12:19:12 +00:00
Gary Pendergast
3503aa4820
Smilies: The new smilies added in [31733] and [31745] are larger than the old smilies. While this is taken care of by the CSS on normal pages, it means they're disproportionally large when seen in RSS and email.
...
By adding a little bit of inline style to them, we get pleasingly sized smilies everywhere. :-)
See #31242
git-svn-id: https://develop.svn.wordpress.org/trunk@31781 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-15 11:40:16 +00:00
Andrew Ozz
e94b808f3b
Emoji: always export the methods in wp-emoji.js, even when dependencies are missing and we cannot initialize.
...
See #31242 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31780 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-15 00:16:47 +00:00
Andrew Ozz
59b22c284d
Emoji:
...
- Move the TinyMCE plugin CSS to wp-content.css.
- Change the replacement images class to `wp-emoji` inside the editor.
- Clean up both the plugin and wp-emoji.js, abstract and restructure a bit.
See #31242 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31779 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-14 23:49:00 +00:00
Andrew Ozz
262e849cdd
Emoji: yet another update for Twemoji, to 1.3.2. Props iseulde. See #31242 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31773 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-13 20:29:10 +00:00
Andrew Ozz
1f05ad1b50
Emoji: better regex when testing for only char emoji. Props iseulde. See #31242 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31772 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-13 20:26:39 +00:00
Sergey Biryukov
870da19630
Emoji and smiley images should be displayed inline.
...
see #31242 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31771 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-13 18:44:40 +00:00
Sergey Biryukov
3089244b6f
Restore line breaks before comment text in comment notification emails.
...
fixes #31508 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31770 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-13 18:28:52 +00:00