Commit Graph

910 Commits

Author SHA1 Message Date
Sergey Biryukov
27fefdf04b Revert [28948], which caused a regression.
see #29573 for trunk. see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@30791 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-08 21:13:56 +00:00
Andrew Ozz
c8e8281a05 Plugins: move the recommender results to a separate tab. Any outstanding quality issues will be fixed on the API side without needing core changes. Props tellyworth, fixes #30337.
git-svn-id: https://develop.svn.wordpress.org/trunk@30782 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 23:39:54 +00:00
Andrew Ozz
fce20e9784 Better docs for Plugin_Upgrader::deactivate_plugin_before_upgrade(). Props DrewAPicture. Fixes #29088.
git-svn-id: https://develop.svn.wordpress.org/trunk@30762 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 01:18:21 +00:00
Andrew Ozz
d948f0bf32 Always return a value in Plugin_Upgrader::deactivate_plugin_before_upgrade(). Props jdgrimes. Fixes #29088.
git-svn-id: https://develop.svn.wordpress.org/trunk@30761 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 00:52:06 +00:00
Drew Jaynes (DrewAPicture)
3cdbc730d3 Add missing DocBlocks and parameter descriptions for a wide variety of properties and methods in WP_Upgrader, Plugin_Upgrader, Theme_Upgrader, Language_Pack_Upgrader, Core_Upgrader, and File_upload_Upgrader.
Props jdgrimes, DrewAPicture.

See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@30758 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 00:25:44 +00:00
Drew Jaynes (DrewAPicture)
fffbee4ac7 Fix a typo in the return description for get_sample_permalink().
Props TobiasBg.
Fixes #30591.


git-svn-id: https://develop.svn.wordpress.org/trunk@30755 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 21:45:12 +00:00
John Blackbourn
7082b703b2 Improve various hook and filter docs so they are correctly parsed for the code reference.
Fixes #30558
Props DrewAPicture


git-svn-id: https://develop.svn.wordpress.org/trunk@30754 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 21:31:41 +00:00
Drew Jaynes (DrewAPicture)
7187da0b32 Convert various uses of (optional) in core parameter descriptions to use the style prescribed in the inline documentation standards for PHP.
The style for marking parameters optional in inline PHP docs is: `@param type $var Optional. Description. Accepts. Default.`, where Accepts can be omitted on a case-by-case basis.

Props coffee2code.
Fixes #30591.


git-svn-id: https://develop.svn.wordpress.org/trunk@30753 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 21:23:52 +00:00
Andrew Nacin
96dee2af62 Adjust [29806] and revert [29807] to restore placeholder and email copy order.
Avoids unnecessarily changing a (large, carefully formatted) translated string from 4.0.

fixes #21089.


git-svn-id: https://develop.svn.wordpress.org/trunk@30742 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-05 01:14:03 +00:00
John Blackbourn
99c61f2201 Correct the default value of the show_split_view argument for revisions so they are correctly displayed side by side ins
tead of inline.

Fixes #24908


git-svn-id: https://develop.svn.wordpress.org/trunk@30739 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-04 14:35:02 +00:00
Andrew Ozz
86c494d1b5 Update better description of the Screen Options checkbox for DFW v2 and editor-expand. Props johnbillion, kpdesign, fixes #30557.
git-svn-id: https://develop.svn.wordpress.org/trunk@30734 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-03 21:59:53 +00:00
Andrew Ozz
836b980715 Editor show the DFW v2 pointer for users that have disabled the visual editor. Fixes #30458.
git-svn-id: https://develop.svn.wordpress.org/trunk@30730 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-03 18:17:37 +00:00
Drew Jaynes (DrewAPicture)
e3957f278e Use the correct hash notation syntax for the WP_Filesystem_Base::dirlist() DocBlock.
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@30722 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-03 10:10:07 +00:00
Andrew Ozz
9adaec183e Update the description of the Screen Options checkbox for turning editor-expand on/off to include DFW v2. Props kpdesign, fixes #30557.
git-svn-id: https://develop.svn.wordpress.org/trunk@30718 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 23:22:52 +00:00
Andrew Ozz
f8a478af9d Update the DFW v2 pointer text. Props kpdesign, DrewAPicture, johnbillion. Fixes #30458.
git-svn-id: https://develop.svn.wordpress.org/trunk@30717 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 23:10:52 +00:00
Andrew Ozz
36dd60705f Editor: hide the DFW v2 button when editor-expand is off. Fixes #30568.
git-svn-id: https://develop.svn.wordpress.org/trunk@30711 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 20:39:13 +00:00
Drew Jaynes (DrewAPicture)
18f101b4bf Using let's properly in inline comments lets us move on to more pressing matters of inline documentation.
Props trepmal.
Fixes #30570.


git-svn-id: https://develop.svn.wordpress.org/trunk@30703 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 04:42:17 +00:00
John Blackbourn
16ec77cd70 Prevent the deletion of a theme while it has an active child theme.
Fixes #29580
Props karpstrucking, jesin


git-svn-id: https://develop.svn.wordpress.org/trunk@30697 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 02:20:14 +00:00
Drew Jaynes (DrewAPicture)
205a43ed05 Correctly capitalize JavaScript throughout core docs.
Fixes #30569.


git-svn-id: https://develop.svn.wordpress.org/trunk@30695 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 00:30:59 +00:00
Scott Taylor
095bfabfa9 Improve various @param docs.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30682 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 02:16:36 +00:00
Scott Taylor
8a4fa5662b Improve various @param docs for src/wp-admin/*.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30680 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:59:43 +00:00
Scott Taylor
c0045bda84 Improve various @param docs for List Tables.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30679 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:32:19 +00:00
Scott Taylor
7a7bb0d6b4 Improve various @param docs for src/wp-admin/includes/class-wp-filesystem-*.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30678 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:12:05 +00:00
Scott Taylor
3008fe1060 Improve the @param docs for src/wp-admin/includes/plugin.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30668 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:22:33 +00:00
Scott Taylor
9c95e2bb81 Use sanitize_mime_type() instead of urlencode() when string-building <option> values in ->get_views() for media list tables.
`urlencode()` was introduced in [28553] via _duck and yours truly.

Got weirder after [29625].

Props birgire.
Fixes #30123.


git-svn-id: https://develop.svn.wordpress.org/trunk@30661 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 20:22:23 +00:00
Drew Jaynes (DrewAPicture)
f45fd382b3 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*.
Also adds a few inline `@see` cross-references as they apply.

Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`

See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30648 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 11:27:19 +00:00
Drew Jaynes (DrewAPicture)
688b291312 Specify a type (array) for the $post_data parameter in the DocBlock for wp_autosave().
Props tillkruess.
See #30508.


git-svn-id: https://develop.svn.wordpress.org/trunk@30645 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 10:00:56 +00:00
Drew Jaynes (DrewAPicture)
33418eeed5 Improve the inline documentation for image_edit_apply_changes().
Including:
* Add a correct type (array) for the `$changes` parameter
* Add the `@since` version
* Add proper descriptions for both parameters and the return value.

Props tillkruess for the initial patch.
See #30508.


git-svn-id: https://develop.svn.wordpress.org/trunk@30644 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 09:58:54 +00:00
Andrew Ozz
8dabfb3b85 Editor: no pointer for DFW v2 when editor-scrolling is not used. Pass $post_type in the wp_editor_expand filter. See #30458.
git-svn-id: https://develop.svn.wordpress.org/trunk@30641 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 06:36:59 +00:00
Drew Jaynes (DrewAPicture)
9d74e43a4b Add missing DocBlocks for several functions in wp-admin/includes/ms.php.
Props dustyf.
See #30483.


git-svn-id: https://develop.svn.wordpress.org/trunk@30630 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 05:05:36 +00:00
Drew Jaynes (DrewAPicture)
4c44e257b5 Use the correct type (integer) for the $menu_id parameter in the wp_get_nav_menu_to_edit() DocBlock.
Also properly mark the parameter as optional and specify the default value.

Props jaimieolmstead for the initial patch.
Fixes #30540.


git-svn-id: https://develop.svn.wordpress.org/trunk@30627 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 04:24:25 +00:00
Boone Gorges
11ef3c3ee6 In get_default_post_to_edit(), let 'post_name' be passed to filter.
Previously, it was being overridden after the default post had been inserted
into the database, making it cumbersome to override with the 'wp_insert_post_data'
filter.

Props danielbachhuber.
Fixes #29847.

git-svn-id: https://develop.svn.wordpress.org/trunk@30626 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-29 19:25:36 +00:00
Drew Jaynes (DrewAPicture)
f240af96da 4.1 Docs Audit: Various formatting fixes for inline documentation in class-wp-list-table.php and comment-template.php.
See #30469.


git-svn-id: https://develop.svn.wordpress.org/trunk@30610 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-28 11:21:40 +00:00
Drew Jaynes (DrewAPicture)
ea329981d1 4.1 Docs Audit: Document the $post global in the DocBlock for wp_print_revision_templates().
See #30469.


git-svn-id: https://develop.svn.wordpress.org/trunk@30602 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-28 09:04:35 +00:00
Drew Jaynes (DrewAPicture)
ea4da9e13c 4.1 Docs Audit: Fix a variety of issues with the DocBlock for the default_page_template_title filter.
Includes hyphenating 'drop-down', ensuring the DocBlock itself is correctly indented, and wraps lines at an appropriate length.

See #30469.


git-svn-id: https://develop.svn.wordpress.org/trunk@30601 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-28 08:59:45 +00:00
Drew Jaynes (DrewAPicture)
ba21c68c23 4.1 Docs Audit: Convert a hook reference to an inline @see tag in the hook docs for the image_add_caption_text filter.
See #30469.


git-svn-id: https://develop.svn.wordpress.org/trunk@30600 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-28 08:55:46 +00:00
Sergey Biryukov
980ca1471b Add missing periods to strings introduced in [30333].
props DrewAPicture.
see #30264.

git-svn-id: https://develop.svn.wordpress.org/trunk@30596 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-28 06:25:14 +00:00
Drew Jaynes (DrewAPicture)
bcb88058f9 Improve inline documentation in wp_ajax_destroy_sessions().
If the token is set (`$keep` is a string), this means the user is viewing their own profile-editing screen and destroying their own sessions (except the current one). If it isn't set (`$keep` is null), the user is editing another user's profile and destroying all of their sessions with no exceptions.

See #30264, #30469


git-svn-id: https://develop.svn.wordpress.org/trunk@30595 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-28 03:47:43 +00:00
Andrew Ozz
8d578a1d1f Better error message when the admin is ssl and non-ssl oEmbed previews are not available in the editor. Props Japh, fixes #30533.
git-svn-id: https://develop.svn.wordpress.org/trunk@30591 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-27 22:36:48 +00:00
Andrew Ozz
abf9e56ef2 Editor: add a pointer for the new DFW button. Remove the wp350_media and wp360_revisions pointers from the same screens. See #30458.
git-svn-id: https://develop.svn.wordpress.org/trunk@30574 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-26 02:53:54 +00:00
Dominik Schilling (ocean90)
3ebd474750 Improve the focus style for review links in the plugin info modal.
props johnbillion.
fixes #30375.

git-svn-id: https://develop.svn.wordpress.org/trunk@30555 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 22:58:12 +00:00
Dominik Schilling (ocean90)
f38be98c89 Clear update caches when site language is changed.
The update screen has a re-install button which could show the wrong language locale after the site language was changed. That's because the update data is cached. 
Introduce `_wp_clear_update_cache()` as a helper function to clean up the update cache.

props SergeyBiryukov, ocean90.
fixes #30369.

git-svn-id: https://develop.svn.wordpress.org/trunk@30554 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 22:49:13 +00:00
Drew Jaynes (DrewAPicture)
a22e8b5354 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escape code snippets in the description for `get_object_taxonomies()`
* Backtick-escape inline code in a markdown-formatted unordered list in the description for `get_taxonomy_labels()`
* Remove an HTML tag from the summary for the `Walker_Category_Checklist` class
* Remove an HTML tag from the summary for `wp_category_checklist()`, various formatting
* Remove an HTML tag from the summary for `wp_terms_checklist()`
* Backtick-escape an HTML tag in the description for `wp_popular_terms_checklist()`
* Remove HTML tags from the summaries for `page_template_dropdown()`, `parent_dropdown()`, and `wp_dropdown_roles()`
* Backtick-escape HTML tags in a parameter description for `add_settings_error()`
* Various formatting in the description and summary for `settings_errors()`
* Markdown-indent code snippets in the descriptions for `wpdb::prepare()`, `wpdb::insert()`, `wpdb::replace()`, `wpdb::update()`, and `wpdb::delete()`
* Backtick-escape an HTML tag in a parameter description for `login_header()`
* Remove HTML tags from the summaries for the `lostpassword_form` and `signup_header` hooks

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30546 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 06:30:19 +00:00
Drew Jaynes (DrewAPicture)
5f574c7ec8 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the description for `wp_salt()`
* Backtick-escape inline code in the return description for `get_avatar()`
* Various markdown formatting in the description for `add_filter()`
* Markdown-indent a code snippet in the description for `apply_filters()`
* Backtick-escape inline code in the `@see` description for `apply_filters_ref_array()`
* Backtick-escape inline code in the description for `do_action()`
* Backtick-escape variables in the parameter and return descriptions for `do_action_ref_array()`
* Various markdown formatting in the description for `get_plugin_data()`

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30544 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 06:04:10 +00:00
Drew Jaynes (DrewAPicture)
6007c0c17d Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escape an HTML tag in the description for the `media_upload_mime_type_links()` hook
* Backtick-escape inline code in the description for `wp_get_active_network_plugins()`
* Remove HTML tags from the summaries for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks
* Backtick-escape HTML tags, add inline `@see` tags to parameter descriptions for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30543 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:52:45 +00:00
Drew Jaynes (DrewAPicture)
ad50389634 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Remove HTML tag from parameter description in `comment_form()`
* Remove HTML tag from a summary for the `comment_form_top` hook
* Markdown-indent a code snippet in the description for `get_linkobjectsbyname()`
* Markdown-indent a code snippet and format an unordered list in the description for `get_linkobjects()`
* Backtick-escape some inline code in the description for `clean_pre()`
* Remove HTML tag from the summary for the `rss_tag_pre` hook
* Various formatting fixes in the descriptions for `get_filesystem_method()` and `request_filesystem_credentials()`

Props rarst for the initial patch.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30538 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:18:56 +00:00
Drew Jaynes (DrewAPicture)
ccc5f88887 Ensure inline code is markdown-escaped as such, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escapes a `<link>` tag in a parameter description for the `embed_oembed_discover` hook
* Inline code fixes in the summary and return description for `WP_List_Table::get_table_classes()`
* Removes HTML markup from the summary for `WP_List_Table::display_rows_or_placeholder()`
* Backtick-escapes a `<tr>` tag in a parameter description for `WP_Users_List_Table::single_row()`
* Converts non-DocBlocks into multi-line comments in `WP_Dependencies::do_items()`
* Removes HTML markup from the summary for the `comment_form_top` hook.
* Inline code and snippet fixes in the description for `wp_get_schedules()`

Props rarst for the initial patch.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30537 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 04:57:17 +00:00
Helen Hou-Sandi
a8821f6b57 Admin notices: Add more variety and make more generically usable.
There is now a base class of `notice`, with additional classes of `notice-success`, `notice-warning`, `notice-error`, and a new blue `notice-info`.

Also corrects some misleading notice colors, such as plugin tested up to warnings and login messages.

props avryl, melchoyce.
fixes #27418.


git-svn-id: https://develop.svn.wordpress.org/trunk@30505 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 16:40:29 +00:00
Drew Jaynes (DrewAPicture)
3d2da1bf74 Minor syntactical adjustments to the inline documentation for the revision_text_diff_options hook.
Converts backticked-inline-code to inline `@see` tags (for the full benefit of Code Reference automagical behavior).

See [30396]. See #24908.


git-svn-id: https://develop.svn.wordpress.org/trunk@30497 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 03:49:43 +00:00
Andrew Nacin
05facab3d6 Validate image data.
git-svn-id: https://develop.svn.wordpress.org/trunk@30458 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 15:24:40 +00:00