Commit Graph
9341 Commits
Author SHA1 Message Date
Jonathan Desrosiers 2d4887f4c7 Customize: Remove “Update” link for themes on multisite installs.
In [38887], installing themes in the Customizer was disabled for multisite installs. However, an update link continues to be displayed when a theme update is available. Clicking the link causes a JavaScript error.

This removes that update link because updates cannot actually be performed in the Customizer in this situation.

Props desrosj, earnjam, mukesh27, audrasjb, garrett-eclipse.
Fixes #46997.

git-svn-id: https://develop.svn.wordpress.org/trunk@45527 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-13 15:30:37 +00:00
Andrea Fercia 2ce0519f60 Media: Make sure the bottom media toolbar content is fully visible with Internet Explorer 11.
Props mspatovaliyski.
Fixes #47502.


git-svn-id: https://develop.svn.wordpress.org/trunk@45526 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-13 14:11:57 +00:00
Andrea Fercia 6551660d55 Accessibility: Improve focus management in the Media Views.
- keeps focus management only where necessary to avoid focus losses
- removes focus management where a specific user workflow was assumed
- makes the "Attachment Details" navigation buttons really disabled when there are no next or previous attachments
- adds inline comments to clarify all the usages of focus()

Fixes #43169.


git-svn-id: https://develop.svn.wordpress.org/trunk@45524 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-12 21:02:03 +00:00
Andrew Ozz f3c91893a9 Privacy tools:
- Move the (remaining) privacy tools related functions from `wp-admin/includes/file.php` to `wp-admin/includes/privacy-tools.php`.
- Move the `WP_User_Request` class to a separate file.

See #43895.

git-svn-id: https://develop.svn.wordpress.org/trunk@45519 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-10 23:53:32 +00:00
Peter Wilson 66f7cee321 Site health: Introduce view_site_health_checks capability.
Introduces the faux primitive capability `view_site_health_checks` available to single site admins and multisite super-admin to view the site health page within the admin.

The capability is mapped to the `install_plugins` capability without being dependent on the file system being writable. This fixes a bug where the feature couldn't be used by sites unable to write to the file system or managed through version control.

The capability is granted on the `user_has_cap` filter.

Props birgire, Clorith, palmiak, peterwilsoncc, spacedmonkey.
Fixes #46957.



git-svn-id: https://develop.svn.wordpress.org/trunk@45507 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-10 07:41:12 +00:00
Andrea Fercia 0ddaeb1ad2 Accessibility: Fix the order of the Previous, Next, and Close buttons in the Attachment Details modal.
Making the visual and DOM order match benefits keyboard users who navigate documents sequentially and expect the focus order to be consistent with the sequential reading order.

Fixes #47458.


git-svn-id: https://develop.svn.wordpress.org/trunk@45506 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-09 15:47:43 +00:00
John Blackbourn 393960b182 I18N: Allow the length of automatically generated excerpts to be localized.
This introduces three new strings that can be used to control the maximum length of automatically generated excerpts for posts, comments, and draft post previews in the dashboard. Optionally combined with the existing word count type control this allows languages which include many multibyte characters to specify more appropriate maximum excerpt lengths.

Props miyauchi, birgire, johnbillion

Fixes #44541


git-svn-id: https://develop.svn.wordpress.org/trunk@45505 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-08 18:41:08 +00:00
johnbillion ea0a34c649 HTTP API: Ensure the http_api_debug hook is fired for all responses.
This means that logging and debugging functionality can access the error code and error message for erroneous responses under all conditions. The hook is not fired when a request is short-circuited with the `pre_http_request` filter, because this filter itself can be used in that situation.

Fixes #25747


git-svn-id: https://develop.svn.wordpress.org/trunk@45504 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-08 17:09:02 +00:00
Andrea Fercia c14ea1630f Accessibility: Improve the Screen Options and Help buttons order.
- makes the buttons visual order match the DOM order
- also, restores the focus style on the "hero" primary button after [34948]

Props vrimill, mukesh27 for reporting and testing.
Fixes #45094.


git-svn-id: https://develop.svn.wordpress.org/trunk@45503 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-08 16:30:15 +00:00
Andrea Fercia 226dc75154 Accessibility: Improve accessibility of all the media views form controls.
- changes the media views form controls to have explicitly associated labels with for/id attributes
- adds a few missing labels / aria-labels
- improves a few existing labels / aria-labels
- improves semantics in a few places, by adding visually hidden headings, fieldset + legend elements, aria-describedby attributes
- improves the image custom size input fields and their labelling
- adds `role="status"` to the "saved" indicator so that status messages are announced to assistive technologies
- swaps the columns source order in the image details template, to make visual and DOM order match
- swaps the "Replace" and "Back" buttons source order in the Replace Image view, to make visual and DOM order match
- gallery settings: move checkbox label to the right: checkboxes are supposed to have labels on the right
- merge similar strings, unified to "Drop files to upload" (removed "Drop files here", and "Drop files anywhere to upload")
- makes the "upload-ui" consistent across the media views
- hides the IE 11 "X" `::-ms-clear` button in the Insert from URL field, as it conflicts with the uploading spinner
- adds comments to all the media templates to clarify their usage
- slightly increases vertical spacing between form fields in the media sidebar
- removes some CSS selectors introduced as backwards compatibility for WordPress pre-4.4
- removes some CSS still targeting Internet Explorer 7 and 8

Fixes #47141.
Fixes #47122.


git-svn-id: https://develop.svn.wordpress.org/trunk@45499 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-07 20:43:26 +00:00
Sergey Biryukov 3f43833d5b Docs: Fix typo in comment_class() DocBlock.
Props mbabker.
Fixes #47499.

git-svn-id: https://develop.svn.wordpress.org/trunk@45496 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-06 23:51:24 +00:00
Sergey Biryukov f6bd90f2ef I18N: Merge duplicate "Original" strings used in the same context (referring to image size).
Props mukesh27.
Fixes #47486.

git-svn-id: https://develop.svn.wordpress.org/trunk@45494 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-05 15:22:22 +00:00
Sergey Biryukov 62385fdd00 I18N: Correct encoding for wp-includes/widgets/class-wp-widget-calendar.php, accidentally saved in ANSI instead of UTF-8.
See #47485.

git-svn-id: https://develop.svn.wordpress.org/trunk@45493 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-05 15:08:42 +00:00
Sergey Biryukov 3fc93cbbb6 I18N: Merge duplicate "A calendar of your site’s posts" strings used in the Calendar widget and the Calendar block in the editor.
Props jorgefilipecosta, ramiy.
Fixes #47485.

git-svn-id: https://develop.svn.wordpress.org/trunk@45492 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-05 15:02:56 +00:00
Sergey Biryukov 21b3d9031a Posts, Post Types: Switch the order of arguments for implode() in the_meta() to match the function notation.
Props loyaltymanufaktur.
Fixes #47481.

git-svn-id: https://develop.svn.wordpress.org/trunk@45491 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-05 00:15:06 +00:00
Sergey Biryukov ea4250beeb Docs: Correct parameter name for wp_new_user_notification_email_admin filter.
Props needle.
Fixes #47476.

git-svn-id: https://develop.svn.wordpress.org/trunk@45489 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-04 12:47:52 +00:00
Felix Arntz 2264493b0d Bundled Theme: Load Google fonts with display=fallback parameter for better UX in case the font cannot be loaded.
Providing this query parameter ensures the stylesheet contains the `font-display: fallback` rule. This changeset also updates the Open Sans font used by core accordingly.

Props westonruter.
Fixes #47282.


git-svn-id: https://develop.svn.wordpress.org/trunk@45485 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-31 10:09:39 +00:00
Riad Benguella 3b248eeb83 Block Editor: Update packages to the ones slated for WP5.2.2
- Fix the template validation notice
 - Fix for focus jumps when typing in meta attributes

Packages updated:

 - @wordpress/block-editor@2.0.3
 - @wordpress/block-library@2.4.6
 - @wordpress/e2e-tests@1.1.6
 - @wordpress/edit-post@3.3.6
 - @wordpress/editor@9.2.6
 - @wordpress/format-library@1.4.6

Props aduth, desrosj.
Fixes #47429.


git-svn-id: https://develop.svn.wordpress.org/trunk@45481 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 15:40:59 +00:00
Jonathan Desrosiers 01cbc28400 Docs: Add missing documentation for the locale meta field.
The user’s locale is passed in the `$meta` parameter for `insert_user_meta`. Added in [38705].

Props tmatsuur.
Fixes #47423.

git-svn-id: https://develop.svn.wordpress.org/trunk@45479 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 14:36:41 +00:00
Sergey Biryukov c60e468c6f CSS Coding Standards: Use unitless values for line-height in wp-includes/css/media-views.css.
Props ianbelanger, pbiron, afercia.
Fixes #46529. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45478 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 13:17:48 +00:00
Sergey Biryukov a348577580 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/editor.css.
Props ianbelanger, pbiron, afercia.
Fixes #46528. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45477 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:44:43 +00:00
Sergey Biryukov 42d0a9ff5d CSS Coding Standards: Use unitless values for line-height in wp-includes/css/buttons.css.
Props ianbelanger, pbiron, afercia.
Fixes #46526. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45476 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:41:56 +00:00
Sergey Biryukov 4154cb7762 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/wp-pointer.css.
Props ianbelanger, pbiron, afercia.
Fixes #46525. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45475 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:40:59 +00:00
Sergey Biryukov cfe0064c7a CSS Coding Standards: Use unitless values for line-height in wp-includes/css/wp-embed-template.css.
Props ianbelanger, pbiron, afercia.
Fixes #46524. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45474 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:39:26 +00:00
Sergey Biryukov f706a2d4c4 CSS Coding Standards: Use unitless values for line-height in wp-includes/functions.php.
Props ianbelanger, pbiron, afercia.
Fixes #46523. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45473 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:38:09 +00:00
Sergey Biryukov e7f7b81bcc CSS Coding Standards: Use unitless values for line-height in wp-includes/css/wp-auth-check.css.
Props ianbelanger, pbiron, afercia.
Fixes #46522. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45472 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:36:39 +00:00
Sergey Biryukov 6da8445436 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/jquery-ui-dialog.css.
Props ianbelanger, pbiron, afercia.
Fixes #46521. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45471 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:35:03 +00:00
Sergey Biryukov 6bd334d74b CSS Coding Standards: Use unitless values for line-height in wp-includes/css/customize-preview.css.
Props ianbelanger, pbiron, afercia.
Fixes #46520. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45470 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:33:13 +00:00
Sergey Biryukov bf0213bbc7 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/admin-bar.css.
Props ianbelanger, pbiron, afercia.
Fixes #46519. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45469 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:31:57 +00:00
Andrew Ozz 5bcaac6cfd Fix previous WPCS errors in script-loader.php triggered by [45456].
See #45346.

git-svn-id: https://develop.svn.wordpress.org/trunk@45457 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-28 03:31:55 +00:00
Andrew Ozz 2d02bb13d1 Script loader: prevent sorting of the load array in the query string when passing the script handles to load-scripts.php and load-styles.php.
Fixes #45346 #26886.

git-svn-id: https://develop.svn.wordpress.org/trunk@45456 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-28 02:42:24 +00:00
John Blackbourn 5b5ebdaa39 Docs: Improve docs for variadic functions relating to widgets and their controls.
See #37402


git-svn-id: https://develop.svn.wordpress.org/trunk@45449 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 22:04:04 +00:00
Andrew Ozz 9fcb362fa0 Privacy tools: Organize privacy functions into logical files and classes.
Props xkon, birgire, desrosj, garrett-eclipse, azaozz.
See #43895.

git-svn-id: https://develop.svn.wordpress.org/trunk@45448 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 20:49:04 +00:00
Sergey Biryukov ae81d63a2a I18N: Remove PHP function name from translatable string in WP_Recovery_Mode_Email_Service.
Props ramiy.
Fixes #47255.

git-svn-id: https://develop.svn.wordpress.org/trunk@45447 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 20:43:43 +00:00
John Blackbourn 814aa7149f Build/Test Tools: Remove the dependency on a globally installed Grunt.
The existing `"grunt": "grunt"` script in `package.json` allows for the use of `npm run grunt ...` which uses the local `grunt` binary in the project's `node_modules`.

Fixes #47380


git-svn-id: https://develop.svn.wordpress.org/trunk@45445 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 19:34:24 +00:00
Sergey Biryukov 68f7c2d7a5 I18N: Merge duplicate "Invalid post parent ID" strings.
Props ramiy.
Fixes #47270.

git-svn-id: https://develop.svn.wordpress.org/trunk@45444 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 19:04:58 +00:00
Sergey Biryukov 4af886494a Administration: Replace one more reference to "articles" with "posts" for greater consistency of terminology.
See #38517.

git-svn-id: https://develop.svn.wordpress.org/trunk@45443 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 18:50:28 +00:00
Sergey Biryukov d410033e9c I18N: Merge duplicate "Status is forbidden" strings.
Props ramiy.
Fixes #47037.

git-svn-id: https://develop.svn.wordpress.org/trunk@45442 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 18:46:43 +00:00
Sergey Biryukov 2fe447bd2d I18N: Remove unnecessary context for "WordPress.org" string in WP_Widget_Meta.
Props ramiy.
Fixes #47038.

git-svn-id: https://develop.svn.wordpress.org/trunk@45436 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 15:32:05 +00:00
Sergey Biryukov d2a7fa4bff I18N: Remove unnecessary HTML from "Previewing:" string in WP_Customize_Theme_Control.
Props ramiy.
Fixes #47271.

git-svn-id: https://develop.svn.wordpress.org/trunk@45435 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 15:29:21 +00:00
Sergey Biryukov 32557983ae Text Changes: Use consistent question wording for discarding unpublished changes in Customizer.
Props ramiy.
Fixes #47258.

git-svn-id: https://develop.svn.wordpress.org/trunk@45434 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 15:18:32 +00:00
Sergey Biryukov e1e3ba9f59 Docs: Correct @type annotation for wpdb::$last_query.
Props nextendweb, mukesh27.
Fixes #47095.

git-svn-id: https://develop.svn.wordpress.org/trunk@45430 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 02:29:56 +00:00
Sergey Biryukov 44a862bacd Docs: Correct @type annotation for WP_Customize_Widgets properties.
Props diddledan.
Fixes #46856.

git-svn-id: https://develop.svn.wordpress.org/trunk@45429 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 02:15:58 +00:00
Sergey Biryukov 9c4d3f8871 Docs: Correct @type annotation for WP_Customize_Selective_Refresh::$current_partial_id.
Props diddledan.
Fixes #46854.

git-svn-id: https://develop.svn.wordpress.org/trunk@45428 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 02:11:17 +00:00
Sergey Biryukov c365e1c4d9 Docs: Correct @type annotation for WP_Customize_Nav_Menu_Item_Setting::$value.
Props diddledan.
Fixes #46853.

git-svn-id: https://develop.svn.wordpress.org/trunk@45427 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 02:09:23 +00:00
Sergey Biryukov f128da7f65 Docs: Correct @type annotation for WP_Customize_Manager::$_changeset_data.
Props diddledan.
Fixes #46852.

git-svn-id: https://develop.svn.wordpress.org/trunk@45426 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 02:07:00 +00:00
Sergey Biryukov 10855438ea Date/Time: Replace all instances of date() with gmdate().
Use of `date()` in core depends on PHP timezone set to UTC and not changed by third party code (which cannot be guaranteed).

`gmdate()` is functionally equivalent, but is not affected by PHP timezone setting: it's always UTC, which is the exact behavior the core needs.

Props nielsdeblaauw, Rarst.
Fixes #46438. See #44491.

git-svn-id: https://develop.svn.wordpress.org/trunk@45424 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 00:11:37 +00:00
John Blackbourn 716e25e0df Docs: Correct a theme feature name.
See #45134


git-svn-id: https://develop.svn.wordpress.org/trunk@45423 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 23:45:19 +00:00
John Blackbourn 13bd882529 Docs: Improve documentation for variadic functions relating to post type support and theme support.
See #37402


git-svn-id: https://develop.svn.wordpress.org/trunk@45422 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 23:40:06 +00:00
John Blackbourn f0daff8dbf Docs: Correct a function name in the do_action() documentation.
See #37402


git-svn-id: https://develop.svn.wordpress.org/trunk@45421 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 22:52:45 +00:00