Commit Graph

6479 Commits

Author SHA1 Message Date
Sergey Biryukov
e21792cb37 Docs: Add requires_php to the list of fields returned by plugins_api().
Props ediamin.
Fixes #48291.

git-svn-id: https://develop.svn.wordpress.org/trunk@46463 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-12 02:33:13 +00:00
Anthony Burchell
42493b7ed8 Administration: Prevents horizontal scroll jumping around while admin menu is open.
This sets the `#adminmenuback` `position` CSS property to `fixed`.

Props promz, man4toman.
Fixes #47010.


git-svn-id: https://develop.svn.wordpress.org/trunk@46460 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-11 19:20:43 +00:00
Mike Schroder
68729adb57 Media: Update fallback previews to support _wp_make_subsizes()
Allows fallback previews (PDF by default, in core) to save image meta
after each size is generated to allow for resuming, and make sizes
immediately available.

Props azaozz, antpb, progremzion, mikeschroder.
See #48111.

git-svn-id: https://develop.svn.wordpress.org/trunk@46459 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-11 07:52:12 +00:00
Jonathan Desrosiers
1bcd41b7c1 Upgrade/Install: Detect the presence of the native PHP JSON extension before updating.
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), the related polyfills and workarounds have been removed (see [46205-46206,46208]).

However, even though the JSON extension is now included in PHP by default, it is still possible to disable the extension in a custom configuration. This change will prevent sites from upgrading if the JSON extension is disabled to prevent compatibility issues.

Props jrf, jorbin, dd32, desrosj.
Fixes #47699.

git-svn-id: https://develop.svn.wordpress.org/trunk@46455 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-09 22:20:37 +00:00
Jake Spurlock
c608c85b67 Administration: Ensure visual consistency with large titles in the sidebar.
Custom posts, and other menu titles that are long aren't wrapping correctly.

Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb, afercia, amolv, iqbalbary, davidbaumwald.
Fixes #42201


git-svn-id: https://develop.svn.wordpress.org/trunk@46453 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-09 04:56:55 +00:00
Sergey Biryukov
8ec0a21161 Docs: Add a @since note about new parameters with the spread operator added to function signatures.
Props jrf.
See #47678.

git-svn-id: https://develop.svn.wordpress.org/trunk@46451 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-09 04:26:22 +00:00
Sergey Biryukov
af634cc62a Themes: Properly align Close/Previous/Next icons in theme preview overlay.
Props chetan200891.
Fixes #48248.

git-svn-id: https://develop.svn.wordpress.org/trunk@46444 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 19:05:13 +00:00
Sergey Biryukov
a15cc93479 Themes: Adjust CSS media query for theme overlay to match the breakpoint for a folded admin menu.
Props chetan200891.
Fixes #48250.

git-svn-id: https://develop.svn.wordpress.org/trunk@46443 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 18:47:18 +00:00
John James Jacoby
0a818ec0fc Network Admin: Improve Site States in List Table rows.
This commit switches a comparison to a Yoda condition, performs a more strict `intval()` check on the value of the Site Status column, and prevents a specific Site State from appearing in List Table rows when filtering by that same Site State already (to match the behavior of other List Table State implementations.)

Fixes #37684. Props pbiron.

git-svn-id: https://develop.svn.wordpress.org/trunk@46441 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 17:44:42 +00:00
Sergey Biryukov
357a18da2b Docs: Add missing @deprecated tags in the file docblock of some deprecated files.
Props jrf.
Fixes #48254.

git-svn-id: https://develop.svn.wordpress.org/trunk@46439 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 17:17:07 +00:00
Andrea Fercia
5e943fad4a Accessibility: Improve and modernize user interface controls: Revert the new links focus style.
Thew new dotted outline for the links focus style introduced in [46241] doesn't appear to be ready to guarantee a good indication of focus.
It was agreed to restore the previous links focus style and postpone exploration for a new style to the next release cycle.
Partially reverts [46241] and [46293].

See #34904, #47153.


git-svn-id: https://develop.svn.wordpress.org/trunk@46425 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-07 19:55:58 +00:00
Andrea Fercia
ae8bef6419 Accessibility: Improve and modernize user interface controls: Improve the buttons active CSS class.
- improves the buttons `.active` CSS class for buttons that need to be styled as "pressed"
- update the alternate color schemes `.active` CSS class accordingly
- improves a few icons colors in the alternate color schemes

See #34904.


git-svn-id: https://develop.svn.wordpress.org/trunk@46423 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-07 18:45:45 +00:00
Andrew Ozz
022119d1a6 Upload: Set custom header with the attachment ID for all uploads from media_handle_upload(). Let the REST API endpoint set it separately.
Props timothyblynjacobs.
Fixes #48200.

git-svn-id: https://develop.svn.wordpress.org/trunk@46421 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-07 15:28:29 +00:00
Andrea Fercia
c2ffe16248 Accessibility: Improve and modernize user interface controls for better contrast: Further improvements to input heights and alignments.
- improves input fields height in the customizer
- improves input fields height for Internet Explorer 11
- improves input fields height in the Image Editor
- improves alignment of selects and buttons in the privacy policy pages
- makes the search themes fields font-size consistent

Props garrett-eclipse, afercia.
See #47477.


git-svn-id: https://develop.svn.wordpress.org/trunk@46419 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-07 13:18:19 +00:00
Andrea Fercia
42ef147e5d Accessibility: Media: Improve the search media field labelling.
Visible `<label>` elements benefit all users. The `placeholder` attribute should not be used as a replacement for visible labels.
Instead, it's supposed to be used only for a short hint to aid users with data entry e.g. a sample value or a brief description of the expected format.

Screen readers may not announce a `placeholder` attribute at all. Other users may suffer from the lack of a visible label and a placeholder used as replacement, for example:

- users with cognitive disabilities may have trouble remembering what the filled field does
- speech recognition users cannot see the name they can speak to set focus on the field
- low-vision users with high text-size may not be able to see the whole placeholder even when it's visible, if its value is clipped by the edge of the input

Props anevins, audrasjb, karmatosed, azaozz, SergeyBiryukov, afercia.
See #40331.
Fixes #47138.


git-svn-id: https://develop.svn.wordpress.org/trunk@46418 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-07 12:41:50 +00:00
Jake Spurlock
de0efbb825 Administration: Add a max-width to the Privacy Policy Page dropdown.
If there's a page with an extra long title, the Privacy Policy page dropdown in Privacy Settings overflows the page width.

Fixes #47366
Props garrett-eclipse, SergeyBiryukov, mukesh27, desrosj, adhitya03, jalpa1984, nrqsnchz, paresh07.


git-svn-id: https://develop.svn.wordpress.org/trunk@46411 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-06 06:40:36 +00:00
Sergey Biryukov
e2b7892a3e Docs: Format comments in wp-admin/includes/plugin.php as per the documentation standards.
Props dkarfa.
Fixes #48191.

git-svn-id: https://develop.svn.wordpress.org/trunk@46410 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-06 02:21:42 +00:00
Sergey Biryukov
f6357458f4 Taxonomy: Prevent Parent Category dropdown and field descriptions on Categories and Edit Category screens from extending beyond the other fields.
Props garrett-eclipse, dkarfa.
Fixes #48188.

git-svn-id: https://develop.svn.wordpress.org/trunk@46405 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 15:40:31 +00:00
Aaron Jorbin
e963c18719 Build/Test tools: Update grunt-contrib-imagemin and run it
Smaller images are good, so is not having npm vulnerabilities.

See #48203.
Fixes #48206.
Props whyisjake, netweb.



git-svn-id: https://develop.svn.wordpress.org/trunk@46404 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 14:19:20 +00:00
Sergey Biryukov
04293be9e8 Site Health: Improve the wording for UTF8MB4 test description.
Props garrett-eclipse, chetan200891, johnjamesjacoby, ayeshrajans.
Fixes #48044.

git-svn-id: https://develop.svn.wordpress.org/trunk@46402 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 02:38:14 +00:00
Sergey Biryukov
e99e14570e Filesystem API: Use strict type check in the in_array() call for the $skip_list parameter in copy_dir() and _copy_dir().
This ensures that parent folders with a numeric name are not accidentally skipped when only a subfolder is intended to be skipped.

Props codex-m.
Fixes #46581.

git-svn-id: https://develop.svn.wordpress.org/trunk@46400 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 02:15:13 +00:00
SergeyBiryukov
ef942c65bb Docs: Correct formatting of the @return value description in _wp_handle_upload().
See #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46399 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 02:08:01 +00:00
Sergey Biryukov
840a03335f Docs: Add missing documentation for the first parameter of the big_image_size_threshold filter.
Props dkarfa, desrosj, earnjam.
Fixes #48214.

git-svn-id: https://develop.svn.wordpress.org/trunk@46398 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 01:30:00 +00:00
Sergey Biryukov
c2bcdea8c9 Docs: Add missing description for $comment global.
Props immeet94, mukesh27.
Fixes #46928. See #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46391 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 22:18:11 +00:00
Sergey Biryukov
08ff597054 I18N: Add missing comma in a translator comment.
See #47515.

git-svn-id: https://develop.svn.wordpress.org/trunk@46390 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 22:08:34 +00:00
Dominik Schilling
a468719eb9 I18N: Fix translator comment for a themes list table string with numbered placeholders.
Props garrett-eclipse.
Fixes #47515.

git-svn-id: https://develop.svn.wordpress.org/trunk@46387 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 20:19:11 +00:00
Dominik Schilling
0b3bc89aba Docs: Convert 'Block Editor' to lowercase.
Props garrett-eclipse.
Fixes #45634.

git-svn-id: https://develop.svn.wordpress.org/trunk@46386 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 20:11:20 +00:00
Dominik Schilling
c7bd227390 Networks and Sites: Improve newly added strings for i18n.
* Remove unnecessary numbered placeholders.
* Add context to "All" and "Spam" status.
* Add translator comments.

Props pedromendonca.
Fixes #48210.

git-svn-id: https://develop.svn.wordpress.org/trunk@46385 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 19:57:08 +00:00
Jonathan Desrosiers
f183dd84f1 Networks and Sites: Fix issues processing additional fields displayed for the Sites list table.
This prevents a `The link you followed has expired.` error when using a filter and now uses `$_POST` instead of `$_GET` to capture all form values.

Props pbiron.
Fixes #45954.

git-svn-id: https://develop.svn.wordpress.org/trunk@46384 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 14:31:05 +00:00
Andrew Ozz
5e0904cf67 Upload: Fix the method used to create image sub-sizes when uploading fails with a PHP fatal error. Use a custom header to send the new attachment post ID even in HTTP 500 responses instead of an upload reference sent by the client. Also add another cap check and remove the action when deleting an attachment post during a failed upload cleanup.
Props timothyblynjacobs, clorith, azaozz.
Fixes #48200.

git-svn-id: https://develop.svn.wordpress.org/trunk@46382 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-03 21:00:10 +00:00
Jonathan Desrosiers
7c1662cba0 Docs: Fix code example for removing internal pointers.
Props daleharrison, swissspidy, garrett-eclipse, luciano-croce, jrf, desrosj.
Fixes #45529.

git-svn-id: https://develop.svn.wordpress.org/trunk@46381 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-03 20:38:08 +00:00
Jonathan Desrosiers
271fc0d151 Menus: Fix typo in the class attribute for the hidden title field in Walker_Nav_Menu_Checklist.
Each item that `Walker_Nav_Menu_Checklist` displays is accompanied by several hidden `<input/>` fields that specify default values for each item when added to a menu. These values are passed in JavaScript to the AJAX call triggered when an item is added to a menu.

The hidden field for the title attribute field incorrectly had an underscore instead of a hyphen. Because of this, it was impossible to supply a default value for the Title Attribute field of a nav menu item.

Props yanngarcia, davidbaumwald.
See #47838.

git-svn-id: https://develop.svn.wordpress.org/trunk@46380 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-03 20:02:28 +00:00
Sergey Biryukov
ee03b05605 Privacy: Remove unused $wpdb global in WP_Privacy_Requests_Table::prepare_items().
Props david.binda.
Fixes #48178.

git-svn-id: https://develop.svn.wordpress.org/trunk@46374 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-02 23:21:17 +00:00
Andrea Fercia
dc0b9dc2d3 Login and Registration: Hide the Edge browser "Reveal password" native button.
Props Clorith.
Fixes #42888.


git-svn-id: https://develop.svn.wordpress.org/trunk@46372 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-01 17:59:18 +00:00
Andrea Fercia
5ddfa37db0 Accessibility: Improve and modernize user interface controls for better contrast: Login screen improvements.
- allows the login input fields to better scale with text 
- improves the input fields layout on Internet Explorer 11
- uses the new focus style on the "Show password" button 
- adjusts the CSS for the interim login

See #47153.
See #42888.


git-svn-id: https://develop.svn.wordpress.org/trunk@46371 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-01 15:54:39 +00:00
Sergey Biryukov
4b93e1eff3 Docs: Fix typo in wp_get_missing_image_subsizes() DocBlock.
Props david.binda.
Fixes #48179.

git-svn-id: https://develop.svn.wordpress.org/trunk@46368 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-01 01:18:03 +00:00
Andrea Fercia
74f9cf79a0 Accessibility: Improve and modernize user interface controls: Improve new styles for the color picker.
Props audrasjb, garrett-eclipse.
Fixes #48131.


git-svn-id: https://develop.svn.wordpress.org/trunk@46360 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 18:04:59 +00:00
Anthony Burchell
4b152de517 Media: Prevents clipping of text when scaling image edit screen.
This reapplies [46354] clean as the previous commit had remnants of an unrelated patch.

Props sabernhardt, audrasjb, afercia.
See #47115.


git-svn-id: https://develop.svn.wordpress.org/trunk@46359 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 17:55:07 +00:00
Jonathan Desrosiers
d65349005c Site Health: Improve the message displayed to sites not utilizing HTTPS.
The new message better illustrates that there are many potential benefits of using HTTPS, not just a few.

Props garrett-eclipse, dkarfa, ocean90, afragen, desrosj.
Fixes #48118.

git-svn-id: https://develop.svn.wordpress.org/trunk@46358 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 17:53:53 +00:00
Andrea Fercia
f93cd8ceea Accessibility: Improve and modernize user interface controls: Improve the new form controls styles and heights.
Improves cross-browsers rendering and addresses most of the reported edge cases.

See #47477.


git-svn-id: https://develop.svn.wordpress.org/trunk@46356 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 17:23:06 +00:00
Anthony Burchell
48564fa823 Media: Revert [46354] preventing bad clipping of text in image details page.
See #47115.


git-svn-id: https://develop.svn.wordpress.org/trunk@46355 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 17:11:14 +00:00
Anthony Burchell
32b7a5e076 Media: Prevents clipping of text when scaling image edit screen.
Props sabernhardt, audrasjb, afercia.
See #47115.


git-svn-id: https://develop.svn.wordpress.org/trunk@46354 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 16:33:39 +00:00
Andrew Ozz
ba2d023bad Media: Move wp_get_original_image_path() to wp-content/post.php to make it easier to access from plugins.
Props pbiron.
See #47873.

git-svn-id: https://develop.svn.wordpress.org/trunk@46353 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 16:27:11 +00:00
Andrea Fercia
9288beb7b5 Accessibility: Improve and modernize user interface controls: Remove the CSS transform 1 pixel shift from the buttons active state.
Props Joen.
See #34904.


git-svn-id: https://develop.svn.wordpress.org/trunk@46350 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 10:52:36 +00:00
Andrea Fercia
f00bceaa86 Accessibility: Improve and modernize user interface controls: Improve the radio buttons blue dot alignment.
Props desrosj, garrett-eclipse, afercia.
See #47498.


git-svn-id: https://develop.svn.wordpress.org/trunk@46345 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-29 21:55:51 +00:00
Andrea Fercia
ef206a787f Accessibility: Improve and modernize user interface controls: Make the secondary buttons border blue.
Props drw158, youknowriad, kjellr, melchoyce, talldanwp, audrasjb.
See #34904.


git-svn-id: https://develop.svn.wordpress.org/trunk@46344 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-29 21:52:38 +00:00
Sergey Biryukov
65ec343e0b Docs: Improve documentation for ::display() methods in various list tables.
Props itowhid06.
Fixes #47947.

git-svn-id: https://develop.svn.wordpress.org/trunk@46341 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-29 11:03:14 +00:00
Andrea Fercia
d020b72508 Accessibility: After [46337]: make the select elements background white also on hover, active, and focus states.
See #47477.
See #48128.


git-svn-id: https://develop.svn.wordpress.org/trunk@46340 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-28 16:44:09 +00:00
Andrea Fercia
8408e42de9 Accessibility: Improve and modernize user interface controls. Style the select elements disabled state.
Props adhitya03, MarcosAlexandre, kjellr.
See #47477.
Fixes #48129.


git-svn-id: https://develop.svn.wordpress.org/trunk@46339 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-28 16:34:43 +00:00
Andrew Ozz
d47627d555 Fix the context (right-click) menu when clicking the placeholder for the post title field on the classic Edit Post screen.
Props masummdar, audrasjb, afercia.
Fixes #47318.

git-svn-id: https://develop.svn.wordpress.org/trunk@46338 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-28 16:19:49 +00:00