vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
40,607 Commits 1 Branch 0 Tags 243 MiB
e228178d1b
Commit Graph

235 Commits

Author SHA1 Message Date
John Blackbourn
e228178d1b Docs: Add missing docs for the auth_cookie_bad_session_token action. 
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46598 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-26 23:44:02 +00:00
John Blackbourn
4f281f1650 Docs: Switch more docs over to typed array notation, plus some fixes. 
See #48303, #41756


git-svn-id: https://develop.svn.wordpress.org/trunk@46596 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-26 21:07:10 +00:00
Jake Spurlock
f53a78fda7 Administration: Ensure that admin referer nonce is valid. 
Coding standards, ensure that nonce is valid with identical, rather then equal operator.

Props vortfu, xknown, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@46477 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-14 15:38:14 +00:00
Sergey Biryukov
0c75758333 Formatting: In wp_validate_redirect(), normalize the path when validating the location for relative URLs, to account for Windows paths. 
Props peterwilsoncc, rconde, jmmathc, mat-lipe, Sixes, justinahinon, cmagrin, daxelrod, SergeyBiryukov.
Fixes #47980.

git-svn-id: https://develop.svn.wordpress.org/trunk@46472 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-14 10:50:41 +00:00
Sergey Biryukov
a8259b8c5e Users: Make sure wp_logout() clears current user, so that a subsequent call to is_user_logged_in() works as expected. 
Props sebastian.pisula, donmhico, roytanck, juliobox.
Fixes #35488.

git-svn-id: https://develop.svn.wordpress.org/trunk@46467 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-12 03:08:56 +00:00
Sergey Biryukov
9a6bce9f5c Formatting: Make sure wp_sanitize_redirect() encodes spaces in URLs instead of stripping them out. 
Props donmhico, hlashbrooke, dd32, azaozz.
Fixes #36998.

git-svn-id: https://develop.svn.wordpress.org/trunk@46462 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-11 23:52:11 +00:00
John Blackbourn
6bd7097626 Docs: Docblock corrections and improvements, mostly related to various pre_* filters. 
See #47110


git-svn-id: https://develop.svn.wordpress.org/trunk@46232 602fd350-edb4-49c9-b593-d223f7449a82
 2019-09-21 17:40:58 +00:00
Sergey Biryukov
65b4c64440 Coding Standards: Fix WPCS issue in [46115]. 
See #43542.

git-svn-id: https://develop.svn.wordpress.org/trunk@46116 602fd350-edb4-49c9-b593-d223f7449a82
 2019-09-14 20:41:48 +00:00
Sergey Biryukov
848a329478 Mail: Avoid setting duplicate MIME-Version and X-Mailer headers in wp_mail(), they are added automatically by PHPMailer. 
Props lbenicio, junktrunk, danieltj, studyboi, bennemann.
Fixes #43542.

git-svn-id: https://develop.svn.wordpress.org/trunk@46115 602fd350-edb4-49c9-b593-d223f7449a82
 2019-09-14 20:13:37 +00:00
Sergey Biryukov
8552a9af15 Improve URL validation in wp_validate_redirect(). 
Props vortfu, whyisjake, peterwilsoncc.

git-svn-id: https://develop.svn.wordpress.org/trunk@45971 602fd350-edb4-49c9-b593-d223f7449a82
 2019-09-04 16:56:33 +00:00
Sergey Biryukov
00b03f2a6f I18N: Capitalize translator comments consistently, add trailing punctuation. 
Includes minor code layout fixes.

See #44360.

git-svn-id: https://develop.svn.wordpress.org/trunk@45932 602fd350-edb4-49c9-b593-d223f7449a82
 2019-09-03 00:39:13 +00:00
Sergey Biryukov
a7513ac8e0 I18N: Improve translator comments. 
* Add missing translator comments.
* Fix placement of some translator comments. Translator comments should be on the line directly above the line containing the translation function call for optimal compatibility with various `.pot` file generation tools. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translator comments.

Includes minor code layout fixes.

Polyglots, rejoice! All WordPress core files now have translator comments for all strings with placeholders!

Props jrf, subrataemfluence, GaryJ, webdados, Dency, swissspidy, alvarogois, marcomartins, mihaiiceyro, vladwtz, niq1982, flipkeijzer, michielatyoast, chandrapatel, thrijith, joshuanoyce, FesoVik, tessak22, bhaktirajdev, cleancoded, dhavalkasvala, garrett-eclipse, bibliofille, socalchristina, priyankkpatel, 5hel2l2y, adamsilverstein, JeffPaul, pierlo, SergeyBiryukov.
Fixes #44360.

git-svn-id: https://develop.svn.wordpress.org/trunk@45926 602fd350-edb4-49c9-b593-d223f7449a82
 2019-09-01 17:12:43 +00:00
Sergey Biryukov
e2b68a4253 Docs: Improve documentation for auth_redirect(). 
Props atachibana.
Fixes #47956.

git-svn-id: https://develop.svn.wordpress.org/trunk@45924 602fd350-edb4-49c9-b593-d223f7449a82
 2019-09-01 13:02:29 +00:00
Sergey Biryukov
c5438c3720 Docs: Improve documentation for wp_set_auth_cookie() and related functions. 
Props arafat, SergeyBiryukov.
Fixes #47886.

git-svn-id: https://develop.svn.wordpress.org/trunk@45822 602fd350-edb4-49c9-b593-d223f7449a82
 2019-08-17 13:22:26 +00:00
Sergey Biryukov
6ca6c447b9 Docs: Document the show_split_view argument for wp_text_diff(). 
Convert `$args` array documentation to hash notation.

Props riddhiehta02, jeremyfelt, SergeyBiryukov.
Fixes #47224.

git-svn-id: https://develop.svn.wordpress.org/trunk@45778 602fd350-edb4-49c9-b593-d223f7449a82
 2019-08-10 22:27:02 +00:00
Sergey Biryukov
750a5c4749 Users: Use clean_user_cache() in wp_insert_user(), wp_update_user(), wp_set_password(), add_user_to_blog(). 
Props spacedmonkey.
Fixes #47021.

git-svn-id: https://develop.svn.wordpress.org/trunk@45715 602fd350-edb4-49c9-b593-d223f7449a82
 2019-08-01 17:48:31 +00:00
SergeyBiryukov
1e0309b6e3 Users: Use get_password_reset_key() in wp_new_user_notification(). 
Props mrasharirfan, spacedmonkey.
Fixes #45745.

git-svn-id: https://develop.svn.wordpress.org/trunk@45712 602fd350-edb4-49c9-b593-d223f7449a82
 2019-08-01 15:29:02 +00:00
Gary Pendergast
d36eda33f7 Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged. 
Noteable changes:
- The `magic_quotes_runtime` and `magic_quotes_sybase` settings were removed in PHP 5.4, so no longer need to be set.
- Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
- Quite a few functions would cause errors if `safe_mode` was set. This setting was removed in PHP 5.4.
- Only a handful of `header()` calls needed corresponding `headers_sent()` checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.


git-svn-id: https://develop.svn.wordpress.org/trunk@45611 602fd350-edb4-49c9-b593-d223f7449a82
 2019-07-09 05:44:42 +00:00
Gary Pendergast
4503f93961 Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-includes. 
See #47632.



git-svn-id: https://develop.svn.wordpress.org/trunk@45590 602fd350-edb4-49c9-b593-d223f7449a82
 2019-07-02 23:41:16 +00:00
Sergey Biryukov
4512e94f9c Users: Pass $length, $special_chars, and $extra_special_chars parameters to the random_password filter in wp_generate_password(). 
Props roytanck.
Fixes #47092.

git-svn-id: https://develop.svn.wordpress.org/trunk@45568 602fd350-edb4-49c9-b593-d223f7449a82
 2019-06-27 00:47:41 +00:00
John Blackbourn
fc10b6bbcd Docs: Correct and improve the docs for a few nonce-related functions. 
See #47110


git-svn-id: https://develop.svn.wordpress.org/trunk@45565 602fd350-edb4-49c9-b593-d223f7449a82
 2019-06-25 17:06:57 +00:00
Sergey Biryukov
ea4250beeb Docs: Correct parameter name for wp_new_user_notification_email_admin filter. 
Props needle.
Fixes #47476.

git-svn-id: https://develop.svn.wordpress.org/trunk@45489 602fd350-edb4-49c9-b593-d223f7449a82
 2019-06-04 12:47:52 +00:00
John Blackbourn
bcf74af357 Docs: Remove incorrect information about usage of the "from" filters in wp_mail(), tidy up formatting. 
See #47110


git-svn-id: https://develop.svn.wordpress.org/trunk@45388 602fd350-edb4-49c9-b593-d223f7449a82
 2019-05-23 22:41:12 +00:00
Sergey Biryukov
4ee05756d2 Docs: Fix typo in wp_mail() description. 
Props seedsca.
Fixes #47208.

git-svn-id: https://develop.svn.wordpress.org/trunk@45302 602fd350-edb4-49c9-b593-d223f7449a82
 2019-05-10 09:52:13 +00:00
John Blackbourn
8b1ecf68d9 I18N: Improvements to and additions of translator comments for various email subject strings. 
Props ramiy

Fixes #46920


git-svn-id: https://develop.svn.wordpress.org/trunk@45204 602fd350-edb4-49c9-b593-d223f7449a82
 2019-04-15 22:38:59 +00:00
Jonathan Desrosiers
f01fd34f21 Text Changes: Use simpler language for login detail email subjects. 
Props: peterwilsoncc, desrosj.
Fixes #37940.

git-svn-id: https://develop.svn.wordpress.org/trunk@45173 602fd350-edb4-49c9-b593-d223f7449a82
 2019-04-12 18:15:15 +00:00
Gary Pendergast
f1bef8668b Text Changes: Tweak the wording of email notification subjects. 
This change brings more coherence between the subject lines of the various emails WordPress will send.

Props ramiy, pento.
Fixes #37940.


git-svn-id: https://develop.svn.wordpress.org/trunk@45137 602fd350-edb4-49c9-b593-d223f7449a82
 2019-04-08 06:16:41 +00:00
Sergey Biryukov
56e7d96070 Docs: Improve wording in a comment in wp_set_current_user(). 
Props nielsdeblaauw.
Fixes #45032.

git-svn-id: https://develop.svn.wordpress.org/trunk@44826 602fd350-edb4-49c9-b593-d223f7449a82
 2019-03-11 10:56:39 +00:00
Gary Pendergast
e79bddcb02 Users: Add extra checking to wp_new_user_notification(). 
Prevent a notification from being sent when an unrecognised value is passed in the `$notify` parameter.

Props cthreelabs, 360zen.
Fixes #44293.



git-svn-id: https://develop.svn.wordpress.org/trunk@44611 602fd350-edb4-49c9-b593-d223f7449a82
 2019-01-16 04:26:48 +00:00
Jonathan Desrosiers
65073950d3 Docs: Update since tag for X-Redirect-By header additions. 
See [42408-42409], [42633], [42647].

Fixes #42313.

git-svn-id: https://develop.svn.wordpress.org/trunk@44386 602fd350-edb4-49c9-b593-d223f7449a82
 2019-01-03 18:10:33 +00:00
Gary Pendergast
9bdb0eb1d5 i18n: Improve consistency of translator comments. 
Props ramonopoly.
Fixes #44998.



git-svn-id: https://develop.svn.wordpress.org/trunk@43668 602fd350-edb4-49c9-b593-d223f7449a82
 2018-10-02 19:50:48 +00:00
John Blackbourn
b2374bf1ad Docs: Correct and improve some docblocks. 
See #42505


git-svn-id: https://develop.svn.wordpress.org/trunk@43642 602fd350-edb4-49c9-b593-d223f7449a82
 2018-09-14 13:34:50 +00:00
Gary Pendergast
a75d153eee Coding Standards: Upgrade WPCS to 1.0.0 
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.



git-svn-id: https://develop.svn.wordpress.org/trunk@43571 602fd350-edb4-49c9-b593-d223f7449a82
 2018-08-17 01:50:26 +00:00
Sergey Biryukov
302a2297dd Posts, Post Types: Use COOKIEPATH when clearing post password cookie, as that's the path it's created with. 
See #44089.

git-svn-id: https://develop.svn.wordpress.org/trunk@43318 602fd350-edb4-49c9-b593-d223f7449a82
 2018-05-27 01:32:20 +00:00
Sergey Biryukov
daf0333601 Posts, Post Types: Clear post password cookie when logging out. 
Props skoldin, subrataemfluence, ianbelanger, johnbillion.
Fixes #44089.

git-svn-id: https://develop.svn.wordpress.org/trunk@43317 602fd350-edb4-49c9-b593-d223f7449a82
 2018-05-26 12:42:57 +00:00
Dominik Schilling (ocean90)
8df8cf2df1 Pinking shears. 
See #41057.

git-svn-id: https://develop.svn.wordpress.org/trunk@42843 602fd350-edb4-49c9-b593-d223f7449a82
 2018-03-18 14:22:09 +00:00
Sergey Biryukov
1fddd69163 I18N: Use the actual placeholder instead of a number in translator comments if the corresponding string does not use numbered placeholders. 
Add missing translator comments in `WP_Theme_Install_List_Table` and `wp_notify_postauthor()`.
Add missing commas in some translator comments.

Fixes #43523.

git-svn-id: https://develop.svn.wordpress.org/trunk@42827 602fd350-edb4-49c9-b593-d223f7449a82
 2018-03-11 16:43:59 +00:00
Drew Jaynes
1b46470b75 Docs: Link to the "Conditional Tags" article in the Theme Developer Handbook from the descriptions for a variety of core conditional tag functions. 
These notations largely serve to direct consumers (of both the source and the parsed code reference) to extended information on individual and related conditional tags throughout WordPress. The changeset also standardizes corresponding DocBlock summaries to use third-person singular verbs.

Notations been added for the following functions:

* comments_open()
* email exists()
* has_excerpt()
* has_post_thumbnail()
* has_tag()
* in_category()
* in_the_loop()
* is_404()
* is_active_sidebar()
* is_active_widget()
* is_admin()
* is_admin_bar_showing()
* is_archive()
* is_attachment()
* is_author()
* is_blog_installed()
* is_category()
* is_comments_popup()
* is_date()
* is_day()
* is_dynamic_sidebar()
* is_feed()
* is_front_page()
* is_home()
* is_local_attachment()
* is_main_query
* is_month()
* is_multi_author
* is_new_day()
* is_page()
* is_page_template()
* is_paged()
* is_plugin_active()
* is_plugin_active_for_network()
* is_plugin_inactive()
* is_plugin_page()
* is_post_type_archive()
* is_preview()
* is_rtl()
* is_search()
* is_single()
* is_singular()
* is_sticky()
* is_tag()
* is_tax()
* is_taxonomy_hierarchical()
* is_time()
* is_trackback()
* is_user_logged_in()
* is_year()
* pings_open()
* post_type_exists()
* taxonomy_exists()
* term_exists()
* username exists()
* wp_attachment_is_image()
* wp_script_is()

Props janalwin.
Fixes #43254.


git-svn-id: https://develop.svn.wordpress.org/trunk@42710 602fd350-edb4-49c9-b593-d223f7449a82
 2018-02-13 16:53:44 +00:00
John Blackbourn
d512973c84 Canonical: Add $x_redirect_by parameter to wp_safe_redirect(). 
See [42633] and [42408].

Fixes #42313.


git-svn-id: https://develop.svn.wordpress.org/trunk@42647 602fd350-edb4-49c9-b593-d223f7449a82
 2018-02-04 16:04:10 +00:00
Sergey Biryukov
40f76ae917 Canonical: Add $x_redirect_by parameter to wp_redirect() that allows applications doing the redirect to identify themselves. 
This complements the `x_redirect_by` filter added in [42408].

Props NathanAtmoz, johnbillion.
Fixes #42313.

git-svn-id: https://develop.svn.wordpress.org/trunk@42633 602fd350-edb4-49c9-b593-d223f7449a82
 2018-02-01 15:05:50 +00:00
Sergey Biryukov
fa5e8c13e7 Canonical: After [42408], remove sprintf() call for consistency with Location header. 
See #42313.

git-svn-id: https://develop.svn.wordpress.org/trunk@42409 602fd350-edb4-49c9-b593-d223f7449a82
 2017-12-18 01:10:36 +00:00
Sergey Biryukov
ab5222786a Canonical: Introduce x_redirect_by filter that allows applications to identify themselves via X-Redirect-By header when they're doing a redirect. 
Props joostdevalk.
Fixes #42313.

git-svn-id: https://develop.svn.wordpress.org/trunk@42408 602fd350-edb4-49c9-b593-d223f7449a82
 2017-12-18 01:03:06 +00:00
Sergey Biryukov
acb4856b65 Docs: Correct @staticvar entry for wp_rand(). 
Props chetan200891, birgire.
Fixes #42796.

git-svn-id: https://develop.svn.wordpress.org/trunk@42377 602fd350-edb4-49c9-b593-d223f7449a82
 2017-12-07 13:52:39 +00:00
Drew Jaynes
1c2b0762c7 Docs: Improve the usefulness of docs for wp_generate_password() by noting the use of wp_rand() vs rand() or mt_rand(). 
Props webdevmattcrom.
Fixes #42782.


git-svn-id: https://develop.svn.wordpress.org/trunk@42373 602fd350-edb4-49c9-b593-d223f7449a82
 2017-12-04 22:39:29 +00:00
Gary Pendergast
8f95800d52 Code is Poetry. 
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42343 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-30 23:09:33 +00:00
John Blackbourn
ab714bd549 General: Pass on the return value from wp_redirect() for wp_safe_redirect(). 
This brings the behaviour of the two functions in line with each other.

Props Drivingralle

Fixes 42108


git-svn-id: https://develop.svn.wordpress.org/trunk@42206 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-20 20:23:50 +00:00
John Blackbourn
605505e9f7 Docs: Improve inline docs for the wp_redirect() and wp_safe_redirect() functions. 
See #42505, #42108


git-svn-id: https://develop.svn.wordpress.org/trunk@42143 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-10 13:43:07 +00:00
Sergey Biryukov
609318a22d Comments: Change IP references in moderation option labels and email notifications to IP address for clarity. 
Props mako09, gk.loveweb, bradparbs.
Fixes #40382.

git-svn-id: https://develop.svn.wordpress.org/trunk@41704 602fd350-edb4-49c9-b593-d223f7449a82
 2017-10-03 13:08:48 +00:00
John Blackbourn
dd33fc9301 Docs: Remove & prefixes from parameter documentation to avoid doc parsing errors. 
Props sudar for the original patch.

See #35974


git-svn-id: https://develop.svn.wordpress.org/trunk@41686 602fd350-edb4-49c9-b593-d223f7449a82
 2017-10-02 22:01:23 +00:00
John Blackbourn
0c29992e72 Login and Registration: Pass the user session token to the set_auth_cookie and set_logged_in_cookie filters. 
This also adds some missing `@since` parameters for other uses of the token so that developers know when the token was first made available to various filters.

Fixes #41849


git-svn-id: https://develop.svn.wordpress.org/trunk@41365 602fd350-edb4-49c9-b593-d223f7449a82
 2017-09-10 21:08:19 +00:00