vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-09-22 00:40:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
28,700 Commits 1 Branch 0 Tags
e3ac341f2462829be6672bca5986534828e1e8f3
Commit Graph
981 Commits
Author SHA1 Message Date
Scott Taylor e3ac341f24 Add 2 noop methods to WP_List_Table: ->column_default() and ->column_cb(). 
`WP_List_Table` is essentially an `abstract` class. Some of its methods throw `die()` warnings if they aren't overridden in a child class.

These noop methods wouldn't be `abstract`, because they are not required in subclasses. However, `WP_List_Table` can call these methods in its own method, `->single_row_columns()`, whether a subclass defined them or not.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31210 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 17:41:50 +00:00
Scott Taylor 07d899740e In WP_Filesystem_Base subclasses that set $wp_base, remove this dead code. 
Unused since [8009] - "Make WP_Filesystem work with new directory constants"

There is currently no declared field and no `@property` annotation.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31209 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 17:22:07 +00:00
Scott Taylor b0c6a64fbd WP_Filesystem_Base should declare $errors and $options as fields for use by subclasses. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31208 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 17:09:35 +00:00
Scott Taylor 8ebe917c6b In wp_ajax_parse_media_shortcode(), don't require a global $post for all passed shortcodes. 
`embed` is the only shortcode that requires a post ID. This will allow MCE views to work for `playlist`, `audio`, and `video` outside of the Edit Post screen.

See #30835.


git-svn-id: https://develop.svn.wordpress.org/trunk@31201 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 05:18:17 +00:00
Scott Taylor 83b6fad852 In HTML5, the action attribute is no longer required. Remove this attribute when empty. 
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.


git-svn-id: https://develop.svn.wordpress.org/trunk@31200 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 04:15:52 +00:00
Scott Taylor 5acc6bdb58 In PHP 5.0.0, is_a() became deprecated in favour of the instanceof operator. Calling is_a() would result in an E_STRICT warning. 
In PHP 5.3.0, `is_a()` is no longer deprecated, and will therefore no longer throw `E_STRICT` warnings.

To avoid warnings in PHP < 5.3.0, convert all `is_a()` calls to `$var instanceof WP_Class` calls.

`instanceof` does not throw any error if the variable being tested is not an object, it simply returns `false`.

Props markoheijnen, wonderboymusic.
Fixes #25672.


git-svn-id: https://develop.svn.wordpress.org/trunk@31188 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 01:05:52 +00:00
Scott Taylor 102fb4ac5c Replace the 3 remaining occurrences of wpspin GIF with spinner. 
Props avryl.
Fixes #27482.


git-svn-id: https://develop.svn.wordpress.org/trunk@31187 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 00:32:45 +00:00
Helen Hou-Sandi 8ab449ae35 List tables: Use CSS :nth-child() selectors for zebra striping. 
Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the `.alternate` class for now. IE8 and below gracefully degrade by not having zebra striping.

There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation.

fixes #30981 and #26060. see #25060.


git-svn-id: https://develop.svn.wordpress.org/trunk@31181 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-14 22:13:03 +00:00
Scott Taylor 47ba5e6c2e WP_Themes_List_Table accesses $_pagination_args from the parent class. Switch $_pagination_args to protected in WP_List_Table. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31167 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:25:30 +00:00
Scott Taylor 47a74bb21f Add a private field to WP_Terms_List_Table, $level. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31166 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:22:38 +00:00
Scott Taylor b3f726efc4 Add a private field to WP_Posts_List_Table, $is_trash. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31165 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:21:08 +00:00
Scott Taylor e5672bd8c5 Add a private field to WP_Plugin_Install_List_Table, $error. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31164 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:18:52 +00:00
Scott Taylor 02eaef3ae0 In lieu of refactoring, add a private field to WP_MS_Themes_List_Table, $has_items. Ideally, this class would overload ->has_items() and not set a private field. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31163 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:16:16 +00:00
Scott Taylor f0c4ab3e69 Add 2 private fields to WP_Media_List_Table, $detached and $is_trash. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31162 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:07:41 +00:00
Scott Taylor 243d50d2f7 After [31146], properly declare $user_can as a private field in WP_Comments_List_Table. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31161 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:01:53 +00:00
Dion Hulse 32b020bf05 More concise documentation for wp_install_maybe_enable_pretty_permalinks() 
See #6481. Props ericlewis.


git-svn-id: https://develop.svn.wordpress.org/trunk@31160 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 04:32:35 +00:00
Dion Hulse 0aaa2f0f32 The new wp_install_maybe_enable_pretty_permalinks() function doesn't need to be pluggable. 
See #6481. Props nacin, valendesigns


git-svn-id: https://develop.svn.wordpress.org/trunk@31159 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 04:30:01 +00:00
Scott Taylor 274253629f In WP_List_Table, only call magic method internals again whitelists of properties and methods, $compat_fields and $compat_methods. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31146 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:19:58 +00:00
Scott Taylor ad6dd738b2 In WP_Filesystem_Base, make the only private member, $cache, public and remove magic methods. $cache was always public until [28487], has been essentially public via a magic method since. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31145 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:03:59 +00:00
Boone Gorges 77128eb048 Default $parent in category_exists() should default to null rather than 0. 
[29863] made the corresponding change in `term_exists()`. Failure to change the
default value in `category_exists()` meant that an unspecified value for
`$parent` would limit results to top-level categories.

Includes unit tests and corrected function documentation.

Props hissy.
Fixes #30975 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31140 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 01:25:19 +00:00
Scott Taylor 979ba60a57 Fix some @param docs that have chars too close them. 
Add `@property` annotations to `WP_User` and `WP_Post`.
Remove erroneous `@param`s from image editor class methods.
Officially add the property `$_column_headers` to `WP_List_Table`.	

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31127 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 06:56:51 +00:00
Scott Taylor 349e5cb318 Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Constructors do not have meaningful return values, anything that is returned from here is discarded. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31126 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 06:53:48 +00:00
Scott Taylor cb85e15f06 Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value - anything that is returned is discarded. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31125 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 06:12:25 +00:00
Scott Taylor bc723548a7 Declare $wp_version, $required_php_version, and $required_mysql_version as globals in install and upgrade admin files. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31124 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 05:56:45 +00:00
Scott Taylor 38e18d800c In wp-admin/includes/revision.php, $post->modified is a coding error. It should be $post->post_modified. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31123 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 05:49:24 +00:00
Scott Taylor 164b4f21c9 WP_Upgrader will take any "skin" that is passed to it, and set ->skin via composition. The default type of ->skin is WP_Upgrader_Skin, which doesn't have methods declared for ->bulk_header() and ->bulk_footer(). Add noop methods to WP_Upgrader_Skin. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31122 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 05:41:05 +00:00
Scott Taylor 44a3c002f5 In wp_ajax_upload_attachment(), wp_check_filetype_and_ext() doesn't need a 3rd param - it already defaults to null. Passing false would fail a strict check 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31119 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 04:54:13 +00:00
Sergey Biryukov 68191cc15c Add variable type for sync_category_tag_slugs() parameters. 
props tillkruess.
fixes #30718.

git-svn-id: https://develop.svn.wordpress.org/trunk@31113 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 11:18:22 +00:00
Sergey Biryukov 1c88f482bf Use localized format for Last Updated date in plugin details modal, for consistency with [31055]. 
see #30717.

git-svn-id: https://develop.svn.wordpress.org/trunk@31110 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 06:20:08 +00:00
Sergey Biryukov b641ca55f5 Improve documentation for media_handle_upload(). 
props ericlewis.
fixes #30962.

git-svn-id: https://develop.svn.wordpress.org/trunk@31109 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 05:04:59 +00:00
Scott Taylor 0c37f866f2 After [31105], don't ditch the isset() calls for BC. Declare $page_hook as null so it is initialized for all execution paths but will still fail isset() checks. 
Fixes #30958.


git-svn-id: https://develop.svn.wordpress.org/trunk@31106 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 22:51:30 +00:00
Scott Taylor c4e2ad04a2 Properly declare $hook_suffix, $plugin_page, $typenow, and $taxnow as globals in wp-admin/admin.php. 
Fixes #30958.


git-svn-id: https://develop.svn.wordpress.org/trunk@31105 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 22:14:58 +00:00
Scott Taylor 85595b73cc Overriding methods should do more than simply call the same method in the super class. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31101 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:19:24 +00:00
Scott Taylor 0522fcb3f9 Jump statements should not be followed by other statements (there were 5 lingering). 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31100 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:14:56 +00:00
Scott Taylor da9057fd6d Use && instead of and in the 3 places where and was used. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31099 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:11:46 +00:00
Scott Taylor 1ca58614b2 In wp-includes/plugin.php, collapse 3 else-newline-tab-if statements. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31091 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 07:12:42 +00:00
Scott Taylor 6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 07:04:40 +00:00
Dion Hulse d0767caf54 Enable Pretty Permalinks for new sites during install if the server supports it. 
See #6481, Props valendesigns, DrewAPicture & ericlewis


git-svn-id: https://develop.svn.wordpress.org/trunk@31089 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 06:46:55 +00:00
Scott Taylor 5d6cc49628 Perl-style comments should not be used 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31079 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 05:51:39 +00:00
Scott Taylor 97d6901048 Access Modifiers: 
* In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
* In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public`
* In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public`
* In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`.
* In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure`

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31078 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 05:43:54 +00:00
Scott Taylor 469164785f Pinking Shears. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31077 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 05:02:05 +00:00
Sergey Biryukov 621292d70f In dashboard activity widget, display a front-end link if the user cannot edit the post. 
props UaMV, DrewAPicture.
fixes #29025.

git-svn-id: https://develop.svn.wordpress.org/trunk@31075 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 00:25:26 +00:00
Sergey Biryukov ca34257bd6 Call the init() method for the upgrader in wp_can_install_language_pack() to avoid undefined index notices. 
props ocean90.
fixes #30827 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31074 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 23:42:48 +00:00
Sergey Biryukov dd05a3a40f TinyMCE: Remove dashicon-no-alt.png, unused since [30694]. 
props kpdesign, MattyRob.
fixes #30791 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31073 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 23:31:16 +00:00
Andrew Ozz 3fdc11be29 Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31070 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 22:47:32 +00:00
Sergey Biryukov 8e9b9bc458 Use localized format for Last Updated date on Add Plugins screen. 
props tyxla.
fixes #30717.

git-svn-id: https://develop.svn.wordpress.org/trunk@31055 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 01:02:21 +00:00
Scott Taylor 14ddc6c9c0 If IMAGE_EDIT_OVERWRITE is defined as true, ensure that multiple edits to the same image does not result in the file being deleted (updating the meta fails because the old and new paths are identical). 
Props hew.
Fixes #30394.


git-svn-id: https://develop.svn.wordpress.org/trunk@31043 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-04 02:51:20 +00:00
Scott Taylor 621e909a9b Improve the handling of comma-separated mime-types in wp_match_mime_types(), particularly as pertains to the mime-type selector on the Media list table screen. 
Props mdgl.
Fixes #30788.


git-svn-id: https://develop.svn.wordpress.org/trunk@31042 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-04 02:31:29 +00:00
Scott Taylor 5df9963414 Respect query vars for taxonomies passed as URL parameters when in grid mode of Media Library. 
Fixes #30584.


git-svn-id: https://develop.svn.wordpress.org/trunk@31037 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 08:23:06 +00:00
Scott Taylor ca8fe1a7a4 Use the 'not_found' label when there are no items for a taxonomy in the terms list table. 
Props SergeyBiryukov.
Fixes #30586.


git-svn-id: https://develop.svn.wordpress.org/trunk@31035 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 06:19:46 +00:00