Commit Graph

3882 Commits

Author SHA1 Message Date
Scott Taylor
e3bf970f2a Add missing access modifier to WP_Customize_Sidebar_Section::json().
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32877 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:05:08 +00:00
Scott Taylor
713a547aad Add missing access modifier to WP_Customize_Nav_Menus_Panel::wp_nav_menu_manage_columns().
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32876 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:04:24 +00:00
Scott Taylor
a38eefb475 Add missing access modifiers to WP_Customize_Nav_Menus.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32875 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:03:13 +00:00
Scott Taylor
89328eb69f Customizer et al, use elseif in PHP, not else if.
This was corrected via brute force in [31090].

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32874 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:00:33 +00:00
Scott Taylor
fa99a8af6e Add access modifier to WP_Customize_Nav_Menu_Item_Control::json()
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32873 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:54:37 +00:00
Scott Taylor
47068b95f7 Add access modifier to WP_Customize_Nav_Menu_Control::json()
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32872 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:53:59 +00:00
Scott Taylor
a484b6a634 Add get_language_attributes(), which is then used by (...drum roll...) language_attributes().
Props johnbillion, posykrat, PeterRKnight.
Fixes #28180.


git-svn-id: https://develop.svn.wordpress.org/trunk@32868 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:35:22 +00:00
Scott Taylor
ee4e5c4b35 Check is_callable() in do_shortcode_tag(), not add_shortcode().
Add a `_doing_it_wrong()` in `do_shortcode_tag()` when `is_callable()` is `false`.

Props aaroncampbell.
See #32445.


git-svn-id: https://develop.svn.wordpress.org/trunk@32867 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:32:31 +00:00
Scott Taylor
9123db3dcb Add a filter in wp_get_attachment_image_src() called attachment_image_src.
Props eclev91, MikeHansenMe.
Fixes #32363.


git-svn-id: https://develop.svn.wordpress.org/trunk@32866 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:26:30 +00:00
Scott Taylor
73fd2d1d81 Ugrade MediaElement to 2.17.0
Changelog: https://github.com/johndyer/mediaelement/compare/2.16.4...2.17.0

Fixes #32698.


git-svn-id: https://develop.svn.wordpress.org/trunk@32864 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 20:41:12 +00:00
Scott Taylor
ed8b9a8d27 wptexturize() improvements:
* Make sure that strings ending with a number and quotation mark get the proper smart quotes
* Introduce `wptexturize_primes()`, a logic tree to determine whether or not "7'." represents seven feet, then converts the special char into either a prime char or a closing quote char.

Adds unit tests.

Props miqrogroove.
Fixes #29256.


git-svn-id: https://develop.svn.wordpress.org/trunk@32863 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 20:05:52 +00:00
Scott Taylor
da826f59a5 Media Library Bulk Select button size should be smaller.
Props afercia.
Fixes #32325.


git-svn-id: https://develop.svn.wordpress.org/trunk@32862 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 18:55:52 +00:00
Scott Taylor
2da677b2f7 Improve focus when previewing an oEmbed from Add Media Panel
Props afercia.
Fixes #28820.


git-svn-id: https://develop.svn.wordpress.org/trunk@32861 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 18:48:06 +00:00
Scott Taylor
a06f5f6d90 Don't strip \0 (backslash+zero) from post content for users without "unfiltered_html"
Adds unit tests.

Props miqrogroove.
Fixes #28699.


git-svn-id: https://develop.svn.wordpress.org/trunk@32860 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 18:46:11 +00:00
Konstantin Obenland
59a9592125 Remove allowed tags from comment form.
It can be confusing to users and for most it is not relevant.
Commenters comfortable with HTML will know which tags are likely
to be accepted.

Props krogsgard, rachelbaker.
Fixes #30157.



git-svn-id: https://develop.svn.wordpress.org/trunk@32858 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 14:14:41 +00:00
Konstantin Obenland
82a26045e5 Check that current changes can be lost before editing another comment.
When replying to or editing a comment, double-clicking another comment will
open it in quick edit and changes to the current comment are lost.

Props pareshradadiya, chriscct7.
Fixes #21845.



git-svn-id: https://develop.svn.wordpress.org/trunk@32857 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 13:47:35 +00:00
Ella Iseulde Van Dorpe
fa5ec5077b Editor: restructure word count
* The WordCounter should only do one thing: count words. This makes it also easier to test.
* Add some really basic unit tests.
* Instead of only refreshing the count on enter and delete, refresh the count when the user stops typing. Also look at paste and content changes in TinyMCE.
* Use `match` instead of `replace` when it is appropriate.
* More readable code.

See #30966. Fixes #26620.



git-svn-id: https://develop.svn.wordpress.org/trunk@32856 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 10:34:59 +00:00
Konstantin Obenland
bfb8734652 Keep WP_Customize_Nav_Menus_Panel with other panels rather than controls.
Accidentally merged into the wrong file in [32806].
H/t celloexpressions for noticing.

See https://wordpress.slack.com/archives/core-customize/p1434696254000258.
See #32576.



git-svn-id: https://develop.svn.wordpress.org/trunk@32855 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 08:36:37 +00:00
Andrew Ozz
5cb9a4b019 Fix using htmlspecialchars() whit the $double_encode parameter. PHP < 5.4 doesn't validate the entities.
Props miqrogroove. Fixes #17780.

git-svn-id: https://develop.svn.wordpress.org/trunk@32851 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 01:52:48 +00:00
Scott Taylor
4d8c4295f3 Since PHP 5.2.3, the htmlspecialchars() function has an optional $double_encode parameter, which we can now use. This will save us a few expensive kses/html decoding calls.
Adds unit tests.

Props miqrogroove.
Fixes #17780.


git-svn-id: https://develop.svn.wordpress.org/trunk@32850 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 21:59:10 +00:00
John Blackbourn
b8180d3d14 Correct the docs for the post_type_labels_{$post_type} filter.
Fixes #32707
Props dlh


git-svn-id: https://develop.svn.wordpress.org/trunk@32849 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 21:32:53 +00:00
Dominik Schilling (ocean90)
413d24c47f Customizer: Improve accessibility of Add Menu Items button and its panel.
props afercia, ocean90.
fixes #32682.

git-svn-id: https://develop.svn.wordpress.org/trunk@32848 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 20:51:48 +00:00
Aaron Jorbin
301988d967 Add singular.php to template hierarchy
Singular is the only template context conditional that lacks a corresponding template. This allows some themes to simplify.

Fixes #22314.
Props chipbennett.



git-svn-id: https://develop.svn.wordpress.org/trunk@32846 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 19:00:09 +00:00
Scott Taylor
646c19accf Make sure that all Gravatars are generated by get_avatar() or at least run through apply_filters( 'get_avatar', $avatar ) for the sake of extensibility.
Props miqrogroove, GlennM, SergeyBiryukov.
Fixes #22650.


git-svn-id: https://develop.svn.wordpress.org/trunk@32845 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 18:35:04 +00:00
Konstantin Obenland
2ae17175b2 Use https for Google API external libraries.
Google recommends it and users are more likely to have the https version cached in their browser already.

Props rommelxcastro.
Fixes #32552.



git-svn-id: https://develop.svn.wordpress.org/trunk@32843 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 15:50:42 +00:00
Boone Gorges
7ae03917a9 When updating a user, only send email-change notification if email address is passed.
The notification, introduced in [32380], was firing incorrectly (and throwing
a PHP notice) when `wp_update_user()` was called without including 'user_email'
in the update data.

Props imath.
Fixes #32684. See #32430.

git-svn-id: https://develop.svn.wordpress.org/trunk@32838 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 13:29:41 +00:00
Boone Gorges
cf9044394b Add filters to wp_unique_term_slug().
This changeset adds two new filters:
* 'wp_unique_term_slug_is_bad_slug' lets developers control whether a test slug needs to be made unique, before the queries required to build a suffix are performed.
* 'wp_unique_term_slug' filters the output of the function.

These changes introduce parity with the filters in `wp_unique_post_slug()`.

Props coffee2code, bolo1988, boonebgorges.
Fixes #20783.

git-svn-id: https://develop.svn.wordpress.org/trunk@32837 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 13:19:12 +00:00
Ella Iseulde Van Dorpe
9941421f72 TinyMCE: wptextpattern: escape should undo
Props azaozz.
See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@32836 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 12:58:07 +00:00
Ella Iseulde Van Dorpe
fa1a214eb6 TinyMCE: wptextpattern: fix issue that removes content
* If the resulting text node is empty, don't remove all the content from the paragraph.
* If there's an empty text node at the start of the paragraph, ignore it and consider the next node to be the start.

See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@32832 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 11:33:11 +00:00
Ella Iseulde Van Dorpe
b1446f4221 TinyMCE: show inline toolbar after scroll/resize
Also:

* Reduce the amount of callbacks.
* Move everything under `preinit` (but prepend to the callback). The API shouldn't be availbale earlier, and some UI is not available yet, neither is `editor.dom`.
* Hide the toolbar if the target is out of view.

See #32604.



git-svn-id: https://develop.svn.wordpress.org/trunk@32831 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 11:09:56 +00:00
John Blackbourn
0da957471b Correct a typo in the inline docs for add_action().
Props nabil_kadimi, swissspidy
Fixes #32697


git-svn-id: https://develop.svn.wordpress.org/trunk@32829 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 08:36:39 +00:00
Dominik Schilling (ocean90)
cedda9aef1 Customizer: Decode HTML entities of panel/section titles.
Titles are now passed into Underscore templates but HTML-escaped, see #30737.

fixes #32670.

git-svn-id: https://develop.svn.wordpress.org/trunk@32822 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 19:47:58 +00:00
Mark Jaquith
3f215c6d1a Send emails when a user's email address or password is changed.
* In case of email change, email goes to the OLD address
* Prevents against issues where an account is compromised (say via cookie interception) and then the attacker silently takes over ownership via pw/email changes — now there will at least be a record that something is up

fixes #32430
props RMarks, MikeHansenMe, tharsheblows, obenland

git-svn-id: https://develop.svn.wordpress.org/trunk@32820 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 19:30:37 +00:00
Ella Iseulde Van Dorpe
361e7d9717 TinyMCE: show active inline toolbar after focus
This makes sure that e.g. the image toolbar shows up again after closing the media library modal.

See #32604.


git-svn-id: https://develop.svn.wordpress.org/trunk@32818 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 07:07:50 +00:00
Ella Iseulde Van Dorpe
f81208f55a TinyMCE: wplink: don't link a URL with a pasted URL
Fixes #32357.



git-svn-id: https://develop.svn.wordpress.org/trunk@32817 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 05:04:23 +00:00
Ella Iseulde Van Dorpe
33e63b7bda TinyMCE: improve reposition method inline toolbars
* Make sure the toolbar does not overlap the target, unless it is higher than half the visible editor area's height.
* Allow the toolbar to have the preference to position itself above or below the target.
* Cache DOM lookups.
* Simplify the logic and fix various positioning issues.

See #32604.



git-svn-id: https://develop.svn.wordpress.org/trunk@32816 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 04:41:59 +00:00
Boone Gorges
f9ae6b826a Split all shared taxonomy terms on upgrade to 4.3.
Dear Shared Terms, Welcome to Splitsville. Population: You.

See #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@32814 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 01:52:46 +00:00
Boone Gorges
4649b2345d Performance enhancements for _split_shared_term().
* Introduce a `$record` parameter, which defaults to true. When set to false, `_split_shared_term()` will not keep a record of split term data in wp_options. The judicious use of this flag can greatly improve performance when processing shared terms in batches.
* Allow term/tt objects to be passed to the `$term_id` and `$term_taxonomy_id` parameters. This has the potential to save database queries when the objects are already available.

See #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@32813 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 01:47:52 +00:00
John Blackbourn
177e0ed93e Ensure the create_users capability check checks the super admin status of the user in question, rather than the current user.
git-svn-id: https://develop.svn.wordpress.org/trunk@32811 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 00:02:08 +00:00
Drew Jaynes
991237783d Add line-wrapping to a long return description because readability in documentation is important.
See [32797]. See #32421.


git-svn-id: https://develop.svn.wordpress.org/trunk@32810 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 23:17:16 +00:00
Andrew Ozz
7ef6ece222 Editor: do not reuse the preview tab when the user has navigated away.
See #32588.

git-svn-id: https://develop.svn.wordpress.org/trunk@32809 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 23:12:21 +00:00
Dominik Schilling (ocean90)
c0a66eba79 Add menu management to the Customizer.
This brings in the Menu Customizer plugin: https://wordpress.org/plugins/menu-customizer/.

props celloexpressions, westonruter, valendesigns, voldemortensen, ocean90, adamsilverstein, kucrut, jorbin, designsimply, afercia, davidakennedy, obenland.
see #32576.

git-svn-id: https://develop.svn.wordpress.org/trunk@32806 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 22:07:08 +00:00
Scott Taylor
195b61009f In get_attachment_template(), pass an array of templates to get_query_template( 'attachment', $templates ), instead of bailing on the first found template.
Props willnorris, jfarthing84, SergeyBiryukov, DrewAPicture, wonderboymusic.
Fixes #15337.


git-svn-id: https://develop.svn.wordpress.org/trunk@32804 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 20:49:44 +00:00
Scott Taylor
d878213e55 In wp_nav_menu(), ensure that the $menu arg is populated when passed to filters.
Props greuben, chriscct7.
Fixes #16594.


git-svn-id: https://develop.svn.wordpress.org/trunk@32803 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 20:33:00 +00:00
Scott Taylor
a6a0480eb0 Add a class method to wpLink, buildHtml(). This will allows devs to duck-punch the implementation.
Props martinsachse.
Fixes #32180.


git-svn-id: https://develop.svn.wordpress.org/trunk@32802 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 20:19:54 +00:00
Scott Taylor
296c559baf if is a statment, not a function.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32800 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 20:00:15 +00:00
Scott Taylor
a4765f9e1b Document the default list of allowed protocols in the doc block for wp_allowed_protocols() and cross-reference in esc_url() and the kses_allowed_protocols filter.
Props GunGeekATX.
Fixes #32421.


git-svn-id: https://develop.svn.wordpress.org/trunk@32797 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 19:44:39 +00:00
Ella Iseulde Van Dorpe
a65f178bbb TinyMCE: wptextpattern: Add blockquote and headings
As discussed in the editor meeting 9 June.
We should re-evaluate these additions towards the end of the release.

See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@32795 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 13:51:37 +00:00
Dion Hulse
f5a914218d Add a filter to wp_safe_redirect() for the fallback URL.
Props anubisthejackle. Fixes #22612


git-svn-id: https://develop.svn.wordpress.org/trunk@32793 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 05:25:32 +00:00
Scott Taylor
86672e7d8c sanitize_option() needs to handle WP_Error. DRY the conditional calls to add_settings_error().
Props chriscct7 for an initial patch.
Fixes #32350.


git-svn-id: https://develop.svn.wordpress.org/trunk@32791 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 01:28:47 +00:00