Commit Graph

1233 Commits

Author SHA1 Message Date
adamsilverstein
e4ce30bfca Twenty Twenty-One: Improve transparent PNG logo visible on focus.
This ensures a transparent logo remains visible while focused. Also cleans up dark mode CSS, consolidating styles and removing overrides that are no longer needed.

Follow up to [50154].

Props poena, sabernhardt, ryelle.
Fixes #52257.



git-svn-id: https://develop.svn.wordpress.org/trunk@50423 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-23 20:15:02 +00:00
Kelly Choyce-Dwan
ccbfdd1485 Twenty Twenty-One: Add the px unit to the admin bar height custom property.
The admin bar height custom property is used in `calc` functions, which require consistent unit use, even when the value is zero. A unitless value returns an invalid value for the "height" property, where this variable is used. This also changes the stylelint rule in the theme to allow zero values with a unit, just in custom properties.

Props nico23.
Fixes #52564.



git-svn-id: https://develop.svn.wordpress.org/trunk@50388 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-18 20:44:24 +00:00
Sergey Biryukov
e23d442cd9 Twenty Nineteen: Add some space between the cookies checkbox and label in comment form.
Props sabernhardt, garrett-eclipse, mukesh27, monikarao, Boniu91.
Fixes #46601.

git-svn-id: https://develop.svn.wordpress.org/trunk@50365 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 20:13:48 +00:00
Kelly Choyce-Dwan
55f2f3f67b Twenty Twenty-One: Remove background color from Social Links the dark gray style.
This block variation doesn't support custom colors, so allowing a background color leads to a mismatch between frontend and editor styles.

Props poena, paaljoachim, audrasjb.
Fixes #52499.



git-svn-id: https://develop.svn.wordpress.org/trunk@50364 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 20:10:19 +00:00
Sergey Biryukov
0ff408d563 Twenty Ten: Correct the fallback to the default header if the featured image width is narrower than the twentyten_header_image_width setting.
Follow-up to [45581].

Props sabernhardt, macmanx, audrasjb.
Fixes #52516.

git-svn-id: https://develop.svn.wordpress.org/trunk@50361 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 19:25:26 +00:00
Sergey Biryukov
0337b93b01 Twenty Eleven: Correct the fallback to the default header if the featured image width is narrower than the twentyeleven_header_image_width setting.
Follow-up to [45581].

Props sabernhardt, macmanx, audrasjb.
See #52516.

git-svn-id: https://develop.svn.wordpress.org/trunk@50360 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 19:24:40 +00:00
Sergey Biryukov
5334a8dcca Twenty Twenty: Make sure the RTL list styles are preserved after npm run build.
Adjust the padding value for better consistency.

Props desrosj, sabernhardt, ryelle, mukesh27.
Fixes #52401.

git-svn-id: https://develop.svn.wordpress.org/trunk@50359 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 19:09:55 +00:00
Kelly Choyce-Dwan
686448dde2 Bundled Themes: Fix alignment and styles for quote, verse, and code blocks.
Updates older themes to fix alignment, spacing, and font issues to better match the frontend display. Applies to themes: Twenty Eleven, Twenty Thirteen, Twenty Fourteen, Twenty Sixteen, Twenty Seventeen, and Twenty Twenty.

Props burnuser, talldanwp, cristinasoponar, poena, kjellr
Fixes #52009.



git-svn-id: https://develop.svn.wordpress.org/trunk@50358 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 18:57:31 +00:00
Peter Wilson
d9ceb1c434 Twenty Twenty-One: Display inline-images inline.
Remove `display: block` property from inline images and display them center aligned vertically.

Props jeroenrotty, melchoyce, mukesh27, paaljoachim, poena, talldanwp.
Fixes #52287.



git-svn-id: https://develop.svn.wordpress.org/trunk@50351 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 02:24:11 +00:00
Peter Wilson
62614d976b Twenty Twenty-One: Match bullets between editor and frontend.
Change bullet style on frontend nested unordered lists to `circle` to match the editor styles.

Props poena, mukesh27, mahfuz01, tejwanihemant.
Fixes #52412.



git-svn-id: https://develop.svn.wordpress.org/trunk@50350 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 23:50:06 +00:00
Peter Wilson
ed55dc802e Twenty Twenty-One: Add CSS source map files to committed files.
Remove `*.css.map` files from the ignore properties of Twenty Twenty-One directories, add the unignored files.

Props poena, peterwilsoncc.
Fixes #52377.



git-svn-id: https://develop.svn.wordpress.org/trunk@50348 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 23:09:27 +00:00
Kelly Choyce-Dwan
caffd32f52 Bundled Themes: Support font size option for code block.
Adds font-size support to Twenty Fourteen, Twenty Sixteen, and Twenty Seventeen.

Props poena, paaljoachim, peterwilsoncc.
Fixes #52431.



git-svn-id: https://develop.svn.wordpress.org/trunk@50347 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 18:54:02 +00:00
Kelly Choyce-Dwan
c3bf0a2fec Twenty Thirteen: Fix alignment of child blocks within the Cover block.
Props kjellr, melchoyce.
Fixes #51224.



git-svn-id: https://develop.svn.wordpress.org/trunk@50346 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 18:31:01 +00:00
Peter Wilson
37f41ee040 Twenty Twenty-One: Correct accent marks in block pattern alt text.
Correct accents in "Roses Trémières" for block patterns and starter content.

Props audrasjb, geekzebre, kjellr, SergeyBiryukov.
Fixes #52500.



git-svn-id: https://develop.svn.wordpress.org/trunk@50293 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 00:01:08 +00:00
Sergey Biryukov
93db55f9be Twenty Twenty: Make ordered list styling in classic editor match the front-end style.
Props sabernhardt, sebastienserre, hareesh-pillai.
Fixes #50454.

git-svn-id: https://develop.svn.wordpress.org/trunk@50275 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 17:53:00 +00:00
Sergey Biryukov
22ffa08799 Twenty Twenty-One: Use correct value for the global line-height CSS variable.
Props acerempel, mukesh27, dd32, poena.
Fixes #52477.

git-svn-id: https://develop.svn.wordpress.org/trunk@50273 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 17:08:31 +00:00
Jonathan Desrosiers
73c1b28ec7 Twenty Twenty-One: Prevent Dark Mode related JavaScript error.
This prevents an `Uncaught TypeError` in the block editor when scrolling caused by the absence of a `#dark-mode-toggler` element.

Props ocean90, mukesh27, justinahinon.
Fixes #52473.

git-svn-id: https://develop.svn.wordpress.org/trunk@50269 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 14:54:48 +00:00
Peter Wilson
c25dcaf5e8 Twenty Twenty-One: Update editor styles of search block.
Update editor styles to more closely match the front-end following upstream changes.

Props poena, paaljoachim, hellofromTonya.
Fixes #52433.



git-svn-id: https://develop.svn.wordpress.org/trunk@50262 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 03:53:14 +00:00
Peter Wilson
59ff18165e Twenty Twenty-One: Adapt vertical buttons to text length.
Display vertically aligned buttons as inline elements.

Props poena, paaljoachim, hellofromTonya, jeroenrotty, rolfsiebers.
Fixes #52432.



git-svn-id: https://develop.svn.wordpress.org/trunk@50261 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 03:42:43 +00:00
Peter Wilson
223bd0ee52 Twenty Twenty-One: Support font size option for code block.
Props poena, paaljoachim, hellofromTonya.
See #52431.



git-svn-id: https://develop.svn.wordpress.org/trunk@50260 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 03:22:42 +00:00
Sergey Biryukov
ef0a312dc1 I18N: Use the actual placeholder instead of a number in translator comments if the corresponding string does not use numbered placeholders.
Adjust some newly introduced strings to remove unnecessary numbered placeholders for consistency.

Follow-up to [42827].

See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@50234 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-07 12:42:06 +00:00
Sergey Biryukov
cf8928cdfc Twenty Twenty-One: Capitalize translator comments consistently.
Follow-up to [45932].

See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@50233 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-07 12:26:41 +00:00
Jonathan Desrosiers
d96e9c4839 Twenty Twenty-One: Fix wrapping for long text within comments.
This ensures that word wrapping occurs within comment content. 

Props mayankmajeji, audrasjb.
Fixes #52380.

git-svn-id: https://develop.svn.wordpress.org/trunk@50158 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-02 19:38:16 +00:00
Anthony Burchell
5dad681286 Twenty Twenty-One: Make transparent PNG logo visible on focus.
This ensures a transparent logo remains visible while focused.

Props bduclos, poena, paaljoachim, hellofromTonya.
Fixes #52257.


git-svn-id: https://develop.svn.wordpress.org/trunk@50154 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-02 18:27:20 +00:00
Sergey Biryukov
51f88a4dfb Twenty Twenty-One: Correct filter name in twenty_twenty_one_get_starter_content() DocBlock.
Props sabernhardt.
Fixes #52410.

git-svn-id: https://develop.svn.wordpress.org/trunk@50118 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-01 11:47:24 +00:00
Jonathan Desrosiers
5e39171693 Twenty Nineteen: Update several devDependencies.
This updates the following dependencies:
- `@wordpress/browserslist-config` from `2.7.0` to `3.0.0`.
- `autoprefixer` from `9.8.5` to `9.8.6`.
- `node-sass` from `4.14.1` to `5.0.0`.
- `postcss-cli` from `7.1.1` to `7.1.2`.
- `postcss-focus-within` from `3.0.0` to `4.0.0`.
- `rtlcss` from `2.5.0` to `2.6.2`.

There are no changes after running `build`.

See #51801.

git-svn-id: https://develop.svn.wordpress.org/trunk@50081 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-29 21:10:16 +00:00
Jonathan Desrosiers
2841088ce1 Twenty Nineteen: Update the RTL stylesheet with the block-patterns tag.
Rebuilding the RTL stylesheet was missed in [49585].

See #51098, #51099.

git-svn-id: https://develop.svn.wordpress.org/trunk@50080 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-29 21:06:27 +00:00
Jonathan Desrosiers
6d08c03c6f Twenty Twenty: Update @wordpress/scripts to the latest version.
See #51801.

git-svn-id: https://develop.svn.wordpress.org/trunk@50079 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-29 20:44:07 +00:00
Jonathan Desrosiers
d6c7d0010b Twenty Twenty: Update several dependencies.
This updates the following packages:
- `@wordpress/browserslist-config` from `2.6.0` to `2.7.0`.
- `autoprefixer` from `9.6.1` to `9.8.6`.
- `concurrently` from `5.2.0` to `5.3.0`.
- `postcss-cli` from `7.1.1` to `7.1.2`.
- `rtlcss` from `2.5.0` to `2.6.2`.

See #51801.

git-svn-id: https://develop.svn.wordpress.org/trunk@50077 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-29 20:25:42 +00:00
Jonathan Desrosiers
5ad5060243 Twenty Twenty: Update the RTL stylesheet with the block-patterns tag.
Rebuilding the RTL stylesheet was missed in [49585].

See #51098, #51099.

git-svn-id: https://develop.svn.wordpress.org/trunk@50076 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-29 20:08:48 +00:00
Jonathan Desrosiers
75901d9ea2 Twenty Twenty-One: Update several devDependencies.
This updates the following dependencies:
- `@wordpress/browserslist-confg` from `2.7.0` to `3.0.0`.
- `@wordpress/eslint-plugin` from `7.3.0` to `8.0.1`.
- `sass` from `1.29.0` to `1.32.5`.
- `stylelint` from `13.8.0` to `13.9.0`

There are no changes after running `build`.

See #51801.

git-svn-id: https://develop.svn.wordpress.org/trunk@50073 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-29 19:42:45 +00:00
Joe Dolson
bc3177153d Twenty Twenty: Remove aria-expanded on search modal close button.
The Twenty Twenty search modal uses aria-expanded correctly on the Search button, but toggles the aria-expanded value on the 'close' button. The close button is a different control, however, so the attribute value toggling is uneven. The close button does not toggle any behavior; it only closes a control that has already been opened.

Props alexstine, audrasjb
Fixes #52355

git-svn-id: https://develop.svn.wordpress.org/trunk@50033 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-27 21:31:42 +00:00
Sergey Biryukov
4ea42e3a71 Twenty Twenty-One: Correct colors for the Menu button.
As per design, the background should be transparent and the text should be dark grey, not vice versa.

Follow-up to [49987].

Props poena.
Fixes #52374. See #51927.

git-svn-id: https://develop.svn.wordpress.org/trunk@50026 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-26 18:58:08 +00:00
Sergey Biryukov
21b667b840 External Libraries: First pass at fixing jQuery deprecations in WordPress core and bundled themes.
To be able to disable jQuery Migrate as step 3 of updating the jQuery version shipped with WordPress, all `JQMIGRATE` warnings in the browser console will have to be addressed.

This includes many minor adjustments to a wide array of core files.

Follow-up to:
* Step 1: Disabling jQuery Migrate 1.4.1 in WordPress 5.5: [48323], [48324]
* Step 2: Updating jQuery to 3.5.1 and adding jQuery Migrate 3.3.x in WordPress 5.6: [49101], [49338], [49615], [49649]

Props Clorith, azaozz.
See #51812.

git-svn-id: https://develop.svn.wordpress.org/trunk@50001 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-22 12:30:39 +00:00
Sergey Biryukov
f3d0d8a1c1 Twenty Twenty-One: Consistently use Yoda condition for display_title_and_tagline setting.
Props mukesh27.
Fixes #52329.

git-svn-id: https://develop.svn.wordpress.org/trunk@49994 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-21 12:15:47 +00:00
Sergey Biryukov
2b09df97d8 Twenty Twenty-One: Add missing HTML comments for </header> tag.
This brings some consistency to closing `</header>` tags in theme templates and ensures they all have an associated HTML comment.

Props freewebmentor, mukesh27.
Fixes #52328.

git-svn-id: https://develop.svn.wordpress.org/trunk@49993 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-21 12:08:50 +00:00
Sergey Biryukov
d10b9e9b88 Twenty Twenty-One: Add missing styles for <button> element.
Props poena, slaFFik.
Fixes #52029.

git-svn-id: https://develop.svn.wordpress.org/trunk@49988 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-20 07:04:32 +00:00
Sergey Biryukov
62b2606d7e Twenty Twenty-One: Clean up Button styles.
This change restructures the Button element styles for better a11y and expected color behaviors. Here what has changed:

- The `button-style()` mixin is now the ''single source or truth'' for how Button should look site-wide.
  - Button Block, File Block, and Search form Blocks all rely on this one mixin.
  - The same styles is also applied to the `<button>` element which appears in widgets, the 404 search form and comments form.
- Improves expected button styles for various conditions and contexts as follows: 
  - User color palette selections for Buttons are retained regardless of a parent block’s color settings or dark-mode.
  - Supports both Default/Filled styles and Outline styles.
  - More consistent `:hover` and `:active` styles.
  - `:focus` styles are now always visible and legible.
- Adds a `--local-color` color variable to scope color relationships to nested blocks.
- Reduces selectors in `style.css` output.
- 1:1 experience between editor and front end button styles.
- Properly supports Dark-mode.

Props allancole, poena, scruffian, megphillips91.
Fixes #51927.

git-svn-id: https://develop.svn.wordpress.org/trunk@49987 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-20 05:49:28 +00:00
Kelly Choyce-Dwan
2651809673 Twenty Twenty-One: Remove duplicate CSS rules.
Introduces a new PostCSS plugin, `postcss-discard-duplicates`, which will automatically remove any duplicate CSS rules. All the CSS that is removed shows up again later in the file. This also fixes a bug from `postcss-css-variables`, where media queries are duplicated.

Fixes #52158.
Props poena.



git-svn-id: https://develop.svn.wordpress.org/trunk@49980 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-18 17:51:58 +00:00
Sergey Biryukov
a78715e224 Twenty Twenty-One: Remove leftover file from build:rtl task.
The `style-dark-mode.css` file is now in `assets/css/` and has its own `build:dark-rtl` task.

Props yoavf.
Fixes #52293.

git-svn-id: https://develop.svn.wordpress.org/trunk@49960 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-14 12:12:46 +00:00
Sergey Biryukov
4033498a5b Twenty Twenty-One: Make sure filtering attachment image attributes only affects front end and not the admin area.
Props denisco.
Fixes #52212.

git-svn-id: https://develop.svn.wordpress.org/trunk@49930 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-04 17:43:30 +00:00
Sergey Biryukov
ae989102e1 Happy New Year!
Update copyright year to 2021 in `license.txt` and bundled themes.

git-svn-id: https://develop.svn.wordpress.org/trunk@49915 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-01 00:17:09 +00:00
Sergey Biryukov
8a26f7d2d9 Twenty Twenty-One: Remove extra brackets from :last-child CSS pseudo-class.
Props munyagu, mukesh27, activecoder.
Fixes #52176.

git-svn-id: https://develop.svn.wordpress.org/trunk@49914 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-31 07:36:24 +00:00
Sergey Biryukov
34d29e3c69 Twenty Nineteen: Correct @since version for twentynineteen_excerpt_more().
Follow-up to [49831].

See #46177.

git-svn-id: https://develop.svn.wordpress.org/trunk@49901 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-23 15:03:33 +00:00
Jonathan Desrosiers
7b1e52b973 Bundled Themes: Bump the versions of Twenty Twenty-One and Twenty Nineteen.
New versions:

- Twenty Twenty-One: 1.1.
- Twenty Nineteen: 1.9.

Props poena.
Fixes #52160.

git-svn-id: https://develop.svn.wordpress.org/trunk@49873 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-22 18:17:55 +00:00
Jonathan Desrosiers
4ccfb0a084 Twenty Nineteen: Add the block-patterns tag to the appropriate SASS file.
This prevents the tag from being removed from `styles.css` when rebuilding the CSS.

Props danfarrow
Fixes #52159.

git-svn-id: https://develop.svn.wordpress.org/trunk@49872 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-22 18:13:21 +00:00
Kelly Choyce-Dwan
516c843734 Twenty Twenty-One: Set a maximum width on inputs.
Text inputs with a size attribute can end up longer than the screen width on small screens. A max-width of 100% keeps the inputs from breaking out of the container.

Props basscan, kjellr, poena, sabernhardt
Fixes #52083.



git-svn-id: https://develop.svn.wordpress.org/trunk@49870 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-22 16:51:55 +00:00
Jonathan Desrosiers
2c3c216752 Twenty Twenty-One: Improve strings found in post navigations for easier translating.
This change adjusts strings found within post navigations to ensure translators are provided the full context needed to properly translate.

Props poena, SergeyBiryukov, aristath.
Fixes #52047.

git-svn-id: https://develop.svn.wordpress.org/trunk@49866 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-22 16:13:51 +00:00
Jonathan Desrosiers
c7be6359b4 Twenty Twenty-One: Only load IE specific polyfills when actually using Internet Exploreer.
The `twenty-twenty-one-ie11-polyfills` script now has a `null` source, and the new `twenty-twenty-one-ie11-polyfills-asset` (which points to the actual `polyfills.js` source) will be loaded only if IE is detected by through the use of `wp_get_script_polyfill()`.

Because the original script name remains the same, this change is backwards compatible with any code registering `twenty-twenty-one-id11-polyfills` as a script dependency.

Props poena, ismail.elkorchi, peterwilsoncc
Fixes #52098.

git-svn-id: https://develop.svn.wordpress.org/trunk@49865 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-22 15:42:14 +00:00
Jonathan Desrosiers
acbbbd18b3 Twenty Twenty-One: Improve striped table styling in Dark Mode.
This change improves the display of table blocks with the “Stripes” style selected.

Previously, the text was not visible in striped rows when using Dark Mode.

Props ryelle, poena, melchoyce, celendesign, audrasjb.
Fixes #52129.

git-svn-id: https://develop.svn.wordpress.org/trunk@49864 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-22 15:00:49 +00:00