vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-31 22:20:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
39,732 Commits 1 Branch 0 Tags
e7f7b81bcc2e3de508f8081e5a67b73cc348f9da
Commit Graph
13 Commits
Author SHA1 Message Date
Andrea Fercia 951b462ea2 Accessibility: Replace media placeholder clickable divs with buttons. 
`<button>` elements are natively interactive, supported by any assistive technology, and must be used instead of non-semantic, non-accessible `<div>` elements.

Also, this change aligns the Media Widgets and the Customizer site icon and site logo controls with the design pattern used in the new Block Editor for similar controls.

Props ramonopoly, welcher, afercia.
Fixes #43151.


git-svn-id: https://develop.svn.wordpress.org/trunk@44796 602fd350-edb4-49c9-b593-d223f7449a82
 2019-03-05 17:49:00 +00:00
Aaron Jorbin e421f262dc Replace usages of basename() with wp_basename() in order to support multibyte filenames 
This is focused on the pieces of code that touch media files and the tests that support them. `basename` isn't multibyte compatible out of the box. See http://php.net/basename and https://bugs.php.net/bug.php?id=62119.

See #43170.
Props Viper007Bond.


git-svn-id: https://develop.svn.wordpress.org/trunk@44785 602fd350-edb4-49c9-b593-d223f7449a82
 2019-03-01 20:57:26 +00:00
Gary Pendergast 8f95800d52 Code is Poetry. 
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42343 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-30 23:09:33 +00:00
Weston Ruter acd03e1ecb Customize: Improve Media control accessibility and compatibility for settings passed as arrays or as solitary setting. 
* Eliminate Media control template from having dependency on `params.settings.default` for element ID, to fix compat with `params.settings` array or single `params.setting`. See #36167.
* Move description out of label and add `aria-describedby` to Media control's Select button. See #30738, #33085.
* Obtain notification container whenever content is (re-)rendered (such as for Media control). See #38794.
* Re-render notifications after control content is re-rendered, if control is in expanded section. See #38794.

Amends [41390].
See #36167, #38794, #33085, #30738.


git-svn-id: https://develop.svn.wordpress.org/trunk@42031 602fd350-edb4-49c9-b593-d223f7449a82
 2017-10-27 20:17:49 +00:00
Weston Ruter d3c8a675ae Customize: Let media control button labels better automatically reflect the specified MIME type. 
Props Christian1012, celloexpressions, westonruter.
Fixes #38796.


git-svn-id: https://develop.svn.wordpress.org/trunk@41550 602fd350-edb4-49c9-b593-d223f7449a82
 2017-09-20 21:23:51 +00:00
Drew Jaynes b4d81bd654 Docs: Remove @access notations from method DocBlocks in wp-includes/* classes. 
Prior to about 2013, many class methods lacked even access modifiers which made the `@access` notations that much more useful. Now that we've gotten to a point where the codebase is more mature from a maintenance perspective and we can finally remove these notations. Notable exceptions to this change include standalone functions notated as private as well as some classes still considered to represent "private" APIs.

See #41452.


git-svn-id: https://develop.svn.wordpress.org/trunk@41162 602fd350-edb4-49c9-b593-d223f7449a82
 2017-07-27 00:40:27 +00:00
Weston Ruter b2ea5a2b11 Customize: Fix alignment of natural-width media buttons in site icon control. 
Amends [40653].
Props afercia.
Fixes #40220.


git-svn-id: https://develop.svn.wordpress.org/trunk@40671 602fd350-edb4-49c9-b593-d223f7449a82
 2017-05-15 18:50:50 +00:00
Weston Ruter c1ec341ddb Customize: Clean up media control CSS. 
Removes unnecessary wrapper elements and refactors class names to eliminate duplication of rule selectors.

Props celloexpressions.
Fixes #30618.


git-svn-id: https://develop.svn.wordpress.org/trunk@37426 602fd350-edb4-49c9-b593-d223f7449a82
 2016-05-12 20:22:45 +00:00
Weston Ruter d5bcff481f Customize: Remove use of reserved word default in Underscore template which breaks IE8. 
Fixes regression introduced in r30712.

Props adamsilverstein.
Fixes #36793.


git-svn-id: https://develop.svn.wordpress.org/trunk@37417 602fd350-edb4-49c9-b593-d223f7449a82
 2016-05-11 19:07:01 +00:00
Weston Ruter 0bc533e10b Customize: Put focus on change button instead of remove button in media control. 
Allow controls to specify the primary element to receive focus by adding a `control-focus` class.

Props adamsilverstein, westonruter.
Fixes #36337.


git-svn-id: https://develop.svn.wordpress.org/trunk@37152 602fd350-edb4-49c9-b593-d223f7449a82
 2016-03-30 21:40:43 +00:00
Weston Ruter f60e7fd99d Customize: Allow button_labels to be overridden in $args passed to WP_Customize_Media_Control and WP_Customize_Image_Control. 
Props chetanchauhan, celloexpressions.
See #33755.
Fixes #35542.


git-svn-id: https://develop.svn.wordpress.org/trunk@36769 602fd350-edb4-49c9-b593-d223f7449a82
 2016-02-29 00:39:33 +00:00
Scott Taylor 7301c115aa Accessibility: add missing alt attributes to a gaggle of <img>s. 
Props afercia.
Fixes #34583.


git-svn-id: https://develop.svn.wordpress.org/trunk@35567 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-07 16:11:38 +00:00
Scott Taylor b4c270030f Customize: move WP_Customize_Control subclasses to wp-includes/customize, they load in the exact same place. 
See #34432.


git-svn-id: https://develop.svn.wordpress.org/trunk@35389 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-24 18:56:07 +00:00