Commit Graph

9218 Commits

Author SHA1 Message Date
Andrew Ozz
e85b26d14c Site health, info tab:
- Change `recurse_dirsize()` to accept an array of excluded paths.
- Change so we don't calculate the sizes of dirs in wp-content twice.
- Add the size in bytes to the "debug" into.
- Add a custom DOM event after the dir sizes request is done. Can be used by plugins to "daisy chain" more requests.
- Move "WordPress directory location" and "WordPress directory size" to the top in the "Directories and Sizes" section.
- Move "Theme directory location" to the "Active Theme" section.
- Fix labels capitalization.

Props xkon, afercia, Clorith, azaozz.
Fixes #46707.

git-svn-id: https://develop.svn.wordpress.org/trunk@45220 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 23:01:45 +00:00
Adam Silverstein
70f16b6bf4 Media: move get_available_post_mime_types to wp-includes/post.php making it more generally available.
Address an issue since r44947 where calling `wp_enqueue_media` on the front-end would result in a PHP fatal.

Props david.binda.
Fixes #46795.


git-svn-id: https://develop.svn.wordpress.org/trunk@45219 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 20:29:42 +00:00
Sergey Biryukov
9fa1b6f332 Feeds: Amend [45208] to avoid phpcs:ignore.
See #46922.

git-svn-id: https://develop.svn.wordpress.org/trunk@45215 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 15:45:07 +00:00
Sergey Biryukov
65837fb178 Permalinks: Avoid a PHP notice in wp_resolve_numeric_slug_conflicts() when visiting a day archive with the /%postname%/ permalink structure.
Props thakkarhardik, thomstark.
Fixes #46828.

git-svn-id: https://develop.svn.wordpress.org/trunk@45214 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 15:33:38 +00:00
Felix Arntz
aa377f582d Bootstrap/Load: Allow more than one recovery link to be valid at a time.
While currently a recovery link is only made available via the admin email address, this will be expanded in the future. In order to accomplish that, the mechanisms to store and validate recovery keys must support multiple keys to be valid at the same time.

This changeset adds that support, adding an additional token parameter which is part of a recovery link in addition to the key. A key itself is always associated with a token, so the two are only valid in combination. These associations are stored in a new `recovery_keys` option, which is regularly cleared in a new Cron hook, to prevent potential cluttering from unused recovery keys.

This changeset does not have any user-facing implications otherwise.

Props pbearne, timothyblynjacobs.
Fixes #46595. See #46130.


git-svn-id: https://develop.svn.wordpress.org/trunk@45211 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 05:08:16 +00:00
Felix Arntz
2f8a683fdc General: Display fatal error handler notice in admin backend even if headers have been sent.
This ensures that at least for the admin, which is more predictable than the frontend, the user-friendlier error notice from the fatal error handler still shows if a runtime fatal error happens within the page generation process.

Props axaak.
Fixes #46811.


git-svn-id: https://develop.svn.wordpress.org/trunk@45210 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 04:37:46 +00:00
Sergey Biryukov
f83829ca4e Feeds: Remove whitespace from <updated> elements in Atom feeds.
Per Atom format's RFC, there must not be any whitespace in a Date construct or in any IRI.

Props josephwa.
Fixes #46922.

git-svn-id: https://develop.svn.wordpress.org/trunk@45208 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 00:45:05 +00:00
Sergey Biryukov
80817d3209 Bootstrap/Load: After [45016], make sure wp_die() does not cause _doing_it_wrong() notices if called before $wp_query global is set.
Props tmdesigned, TimothyBlynJacobs.
Fixes #46813.

git-svn-id: https://develop.svn.wordpress.org/trunk@45206 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 23:48:11 +00:00
Sergey Biryukov
d979017b64 Bootstrap/Load: Remove WP_Recovery_Mode_Cookie_Service constructor to avoid referencing cookie constants before they are defined.
Instantiating `WP_Recovery_Mode` should no longer have any required timing.

Props TimothyBlynJacobs, lkraav.
Fixes #46882.

git-svn-id: https://develop.svn.wordpress.org/trunk@45205 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 22:43:57 +00:00
John Blackbourn
8b1ecf68d9 I18N: Improvements to and additions of translator comments for various email subject strings.
Props ramiy

Fixes #46920


git-svn-id: https://develop.svn.wordpress.org/trunk@45204 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 22:38:59 +00:00
Sergey Biryukov
3d9f8c4d96 Docs: Adjust comments in wp_initial_constants() to conform to WPCS.
See #46543.

git-svn-id: https://develop.svn.wordpress.org/trunk@45203 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 22:09:31 +00:00
Dominik Schilling
c4d7d5e772 Docs: Add missing @since tag for [45031].
Props dimadin.
See #46667.

git-svn-id: https://develop.svn.wordpress.org/trunk@45191 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 14:16:57 +00:00
Sergey Biryukov
30caafae40 Bootstrap/Load: Remove duplicate leading slashes on inclusion of various files under ABSPATH.
Props dmsnell, birgire, szepe.viktor.
Fixes #46327.

git-svn-id: https://develop.svn.wordpress.org/trunk@45190 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 04:45:05 +00:00
Sergey Biryukov
78e868e4c7 Plugins: Introduce is_wp_version_compatible() and is_php_version_compatible() for checking compatibility with the current WordPress or PHP version.
Props afragen.
Fixes #46599.

git-svn-id: https://develop.svn.wordpress.org/trunk@45185 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 23:55:19 +00:00
Jonathan Desrosiers
a8e7d339ae Post WordPress 5.2 Beta 3 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@45183 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 21:26:49 +00:00
Jonathan Desrosiers
bb3c56a5bc WordPress 5.2 Beta 3.
git-svn-id: https://develop.svn.wordpress.org/trunk@45182 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 21:05:09 +00:00
Sergey Biryukov
b7c8eb8bcb Bootstrap/Load: Finalize recovery mode email language.
Props TimothyBlynJacobs, miss_jwo, desrosj.
Fixes #46898.

git-svn-id: https://develop.svn.wordpress.org/trunk@45181 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 20:48:05 +00:00
Sergey Biryukov
936db1b0e1 Site Health: i18n audit, take 2.
* Use `wp.i18n` to translate JavaScript strings.
* Use `_n()` for proper plural forms support.

Props TimothyBlynJacobs, ocean90, afercia.
Fixes #46683.

git-svn-id: https://develop.svn.wordpress.org/trunk@45178 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 20:33:48 +00:00
Joe McGill
5021d218ef Media: Fix deletion of files when using stream wrappers.
This fixes a bug introduced in [43392] which breaks file deletion on systems using stream wrappers, due to limitations of `realpath()`.

Props antonypuckey, pfiled.
Fixes #44563.


git-svn-id: https://develop.svn.wordpress.org/trunk@45177 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 20:00:42 +00:00
Jonathan Desrosiers
f01fd34f21 Text Changes: Use simpler language for login detail email subjects.
Props: peterwilsoncc, desrosj.
Fixes #37940.

git-svn-id: https://develop.svn.wordpress.org/trunk@45173 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 18:15:15 +00:00
Andrew Ozz
ac97906269 TinyMCE: Fix keyboard navigation when the dfw button is present but hidden. Ensure that button is added last in the DOM to match where it appears visually.
Props afercia, azaozz.
Fixes #46640.

git-svn-id: https://develop.svn.wordpress.org/trunk@45172 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 18:07:47 +00:00
Jonathan Desrosiers
ee18178416 Site Health: Ensure Site Health pages are correctly displayed for RTL locales.
Props: ebrahimzadeh, afercia, mohadeseghasemi.
Fixes #46868.

git-svn-id: https://develop.svn.wordpress.org/trunk@45168 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 16:38:57 +00:00
Sergey Biryukov
dc3783a450 Docs: Add missing @since tags for wp_targeted_link_rel() and wp_targeted_link_rel_callback().
See #43187, #46543.

git-svn-id: https://develop.svn.wordpress.org/trunk@45163 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-11 21:15:29 +00:00
Sergey Biryukov
4de03a542e Networks and Sites: Use numbered placeholder in a mailto: link in ms_site_check().
Props diddledan.
Fixes #46849.

git-svn-id: https://develop.svn.wordpress.org/trunk@45162 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-11 20:14:22 +00:00
Sergey Biryukov
428f9362eb Docs: Correct type for WP_Object_Cache::$blog_prefix.
Props diddledan.
Fixes #46851.

git-svn-id: https://develop.svn.wordpress.org/trunk@45161 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-11 20:09:09 +00:00
John Blackbourn
98e942e10c General: Fix a typo in the docs for _restore_wpautop_hook().
Props manzoorwani.jk

Fixes #46864


git-svn-id: https://develop.svn.wordpress.org/trunk@45159 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-11 17:26:03 +00:00
Gary Pendergast
632ad28223 Media: Remove an extra verb context missed in [45147].
Props garrett-eclipse.
See #44675.



git-svn-id: https://develop.svn.wordpress.org/trunk@45153 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 03:58:09 +00:00
Gary Pendergast
607bc079c3 Post WordPress 5.2 Beta version bump
git-svn-id: https://develop.svn.wordpress.org/trunk@45152 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 01:22:51 +00:00
Gary Pendergast
124cd857e9 WordPress 5.2 Beta 2
git-svn-id: https://develop.svn.wordpress.org/trunk@45151 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 01:12:00 +00:00
Gary Pendergast
8d7c644a7d UI: Remove vertical alignment from active primary buttons.
This caused the post-plugin installation actions to jump around when the "Activate Plugin" primary button became active.

Props seedsca, pratikthink, ianbelanger, mukesh27.
Fixes #44836.



git-svn-id: https://develop.svn.wordpress.org/trunk@45150 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 00:15:51 +00:00
Gary Pendergast
677c2a447b Media: Update the media bulk action labels for consistency.
Props ianbelanger, garrett-eclipse, afercia, Presskopp.
Fixes #44675.



git-svn-id: https://develop.svn.wordpress.org/trunk@45147 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:53:02 +00:00
Gary Pendergast
cfebdd3752 Widgets: Add rel="noopener noreferrer" to links with target="_blank" in the Image widget.
Props audrasjb, welcher, afercia.
Fixes #43280.



git-svn-id: https://develop.svn.wordpress.org/trunk@45144 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:22:14 +00:00
Gary Pendergast
5dfdc9b9c4 Widgets: Add rel="noopener noreferrer" to links with target="_blank" in the Text and HTML widgets.
Props audrasjb, birgire, mukesh27.
Fixes #46421.



git-svn-id: https://develop.svn.wordpress.org/trunk@45143 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:17:35 +00:00
Gary Pendergast
466a7443a6 Menus: Add rel="noopener" to target="_blank" links by default in menus.
This expands upon `rel="noopener"` being previously added to links in the content.

Props audrasjb, welcher.
Fixes #43290.



git-svn-id: https://develop.svn.wordpress.org/trunk@45141 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:05:22 +00:00
Gary Pendergast
8efcc32fde Help: Update support forum links.
There are a lot of places in Core that link to https://wordpress.org/support/ for the support forums, but that's now the URL for HelpHub. The new forums link is https://wordpress.org/support/forums/.

Props jitendrabanjara1991, dilipbheda, mukesh27, ianbelanger.
Fixes #46790.



git-svn-id: https://develop.svn.wordpress.org/trunk@45140 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 22:58:49 +00:00
Gary Pendergast
edd6a1f129 Blocks: Allow for nested the_content calls within do_blocks().
When `do_blocks()` is run, it sets up some special handling of the `wpautop` filter, as we don't want `wpautop` to run on block content, but we do want it to be available for subsequent runs of `the_content`, which may be happening on non-block content.

As we set this up before rendering dynamic blocks, however, a dynamic block choosing to run `the_content` will cause unintentially structural deficiences in this particular recursive block tower.

Moving this handling to after dynamic blocks are rendered makes our tower lean a little less.

Props aldavigdis, pento.
Fixes #45495.



git-svn-id: https://develop.svn.wordpress.org/trunk@45139 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 06:53:14 +00:00
Gary Pendergast
c9bb62507f Block Editor: Update packages to bring a selection of bugfixes in.
Props iseulde, kjellr, aduth, 0mirka00, mcsf, nosolosw, gziolo, jasmussen, talldanwp, notnownikki, swissspidy, jorgefilipecosta, noisysocks.
See https://github.com/WordPress/gutenberg/pull/14796.
Fixes #46801.



git-svn-id: https://develop.svn.wordpress.org/trunk@45138 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 06:36:33 +00:00
Gary Pendergast
f1bef8668b Text Changes: Tweak the wording of email notification subjects.
This change brings more coherence between the subject lines of the various emails WordPress will send.

Props ramiy, pento.
Fixes #37940.


git-svn-id: https://develop.svn.wordpress.org/trunk@45137 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 06:16:41 +00:00
Gary Pendergast
3652d05fcf HTTP: Add support for the host-only flag to Wp_Http_Cookie.
Props soulseekah.
Fixes #43231.


git-svn-id: https://develop.svn.wordpress.org/trunk@45135 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 05:31:35 +00:00
Gary Pendergast
11e97aae1e Emoji: Update Twemoji to version 12.0.0.
Props pento, superpoincare.
Fixes #46404, #46805.


git-svn-id: https://develop.svn.wordpress.org/trunk@45134 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 05:21:49 +00:00
Gary Pendergast
65e057daa2 Canonical: Ensure redirect query keys are URL encoded.
This prevents an infinite redirect loop when a request containing URL-encoded characters triggers `is_404()`.

Props soulseekah, wrwrwr0.
Fixes #43745.


git-svn-id: https://develop.svn.wordpress.org/trunk@45133 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 01:09:01 +00:00
Felix Arntz
a511415d0a Administration: Improve user experience and clarify when in recovery mode.
This changeset introduces several changes around usability when recovery mode is active:

* Display a notice in the admin clarifying that the user is in recovery mode.
* Use a highlight color for the admin bar link to exit recovery mode.
* Exit recovery mode automatically when logging out.
* Include a recovery mode indicator in the title tag.

Props aandrewdixon, azaozz, dhanukanuwan, flixos90, henrywright, karmatosed, mapk, melchoyce, spacedmonkey, TimothyBlynJacobs, tinkerbelly.
See #46608.


git-svn-id: https://develop.svn.wordpress.org/trunk@45117 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 16:59:34 +00:00
Felix Arntz
075a85c05e Bootstrap/Load: Do not redefine constants because tests don't like it.
See #46045.


git-svn-id: https://develop.svn.wordpress.org/trunk@45116 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 15:52:39 +00:00
Felix Arntz
dca58d725e Bootstrap/Load: Remove extension from the list of paused extensions when it is deactivated.
With this change, fatal errors recorded before a plugin was deactivated or a theme was switched away from do not persist. This ensures that re-enabling it re-checks for fatal errors correctly.

Props aandrewdixon, dhanukanuwan, henrywright.
Fixes #46812.


git-svn-id: https://develop.svn.wordpress.org/trunk@45115 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 15:32:31 +00:00
Felix Arntz
7f6adbb345 Bootstrap/Load: Ensure WP_Fatal_Error_Handler does not conflict with existing mechanisms treating fatal errors.
Prior to this change, resuming or activating a plugin or theme that is still broken would result in a redirect loop if in recovery mode. If outside recovery mode, it would cause the error template to be displayed.

Furthermore this applies to breaking a plugin or theme when editing from the backend.

Props aandrewdixon, azaozz, dhanukanuwan, henrywright, ocean90, ohiosierra, PandelisZ, xkon.
Fixes #46045, #46751.


git-svn-id: https://develop.svn.wordpress.org/trunk@45114 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 15:19:50 +00:00
Andrew Ozz
9945849317 Site health: fix usage of max_execution_time. When PHP is run from the cli the default is 0.
Fixes #46645.

git-svn-id: https://develop.svn.wordpress.org/trunk@45111 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-04 21:53:45 +00:00
Andrew Ozz
d5d4979921 Site health:
- Prevent fatal errors from timeouts on the Tools => Site Health => Info tab.
- Use the `get_dirsize()` and `recurse_dirsize()` functions to calculate directory sizes. The results are cached.
- Introduce "timeout protection" in `recurse_dirsize()`.

Props pento, Clorith, xkon, afercia, jeremyfelt, azaozz.
Fixes #46645.

git-svn-id: https://develop.svn.wordpress.org/trunk@45104 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 23:32:31 +00:00
Sergey Biryukov
f4e57f92e4 Widgets: Make sure changes to media widgets' instance schema via widget_{$this->id_base}_instance_schema filter are not overridden by subclasses.
Previously, `WP_Widget_Media_Audio`, `WP_Widget_Media_Image`, and `WP_Widget_Media_Video` used to override the changes due to reversed arguments in `array_merge()` call.

Props Toro_Unit, birgire.
Fixes #45029.

git-svn-id: https://develop.svn.wordpress.org/trunk@45100 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 22:12:11 +00:00
Jonathan Desrosiers
91ac8aeefc Administration: Remove unnecessary transition-delay values from Dashicons.
A unitless `0` value for a `<time>` CSS data type was reintroduced in [45040]. This is allowed for `<length>` data types, but is invalid for `<time>`.

See #43195.
Fixes #46774.

git-svn-id: https://develop.svn.wordpress.org/trunk@45097 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 13:18:35 +00:00
Sergey Biryukov
9cc5e3e760 Docs: Correct @param description for remove_theme_support().
Add `@return` description for `current_theme_supports()`.

See #46543.

git-svn-id: https://develop.svn.wordpress.org/trunk@45089 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 16:20:05 +00:00