Commit Graph

3675 Commits

Author SHA1 Message Date
Sergey Biryukov
e87d86b2ae Docs: Correct references to WP_Filesystem_Base methods in various DocBlocks.
Props pbiron.
Fixes #51087.

git-svn-id: https://develop.svn.wordpress.org/trunk@48835 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-21 00:41:43 +00:00
Sergey Biryukov
2b3bf40907 Comments: Revert unintended changes from [48822].
See #51044.

git-svn-id: https://develop.svn.wordpress.org/trunk@48823 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-19 01:57:29 +00:00
Sergey Biryukov
5f861293e6 Comments: Make sure the comment data passed to the preprocess_comment filter includes the comment_agent and comment_author_IP values.
Props zodiac1978, SergeyBiryukov.
Fixes #51044.

git-svn-id: https://develop.svn.wordpress.org/trunk@48822 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-19 01:55:12 +00:00
Sergey Biryukov
c65973e0f5 Plugins: Avoid a PHP notice if the update-supported key in plugin data is not set.
Props sanzeeb3.
Fixes #51052.

git-svn-id: https://develop.svn.wordpress.org/trunk@48820 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-18 20:36:42 +00:00
Sergey Biryukov
e6c2f66ab2 Site Health: Ensure that the tests returned by WP_Site_Health::get_tests() always have the required array keys: direct and async.
This avoids PHP notices if these keys were accidentally removed using the `site_status_tests` filter.

Props khag7, Ov3rfly, desrosj, Clorith.
Fixes #50858.

git-svn-id: https://develop.svn.wordpress.org/trunk@48808 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-17 02:01:04 +00:00
Sergey Biryukov
271ab2010a Site Health: Add site environment type to the debug information.
Follow-up to [47919], [48188], [48372].

Props joostdevalk, Clorith.
Fixes #50887.

git-svn-id: https://develop.svn.wordpress.org/trunk@48802 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-16 18:25:50 +00:00
Sergey Biryukov
e499354eee Site Health: Rename the $upload_max_size variable to $upload_max_filesize, for consistency with the PHP setting name.
Follow-up to [48535], [48538], [48539], [48544], [48800].

See #50945.

git-svn-id: https://develop.svn.wordpress.org/trunk@48801 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-16 17:52:25 +00:00
Sergey Biryukov
73671e85c5 Site Health: Only display the warning about the post_max_size PHP value when it's lower than upload_max_filesize.
Previously, the warning was displayed even if the value was higher than `upload_max_filesize`, which made the report inaccurate, as these values don't necessarily have to match.

Props oakesjosh, jeroenrotty, desrosj, Clorith.
Fixes #50945.

git-svn-id: https://develop.svn.wordpress.org/trunk@48800 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-16 17:46:51 +00:00
Sergey Biryukov
a1e05cff28 Docs: Fix typo in the $image parameter description in is_gd_image().
Follow-up to [48798].

See #50833.

git-svn-id: https://develop.svn.wordpress.org/trunk@48799 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-16 14:00:27 +00:00
Sergey Biryukov
cbaa88cb5a Code Modernization: Introduce is_gd_image() to check for PHP 8 GdImage object instances.
In PHP 8, the GD extension uses `GdImage` objects instead of resources for its underlying data structures.

This updates the existing `is_resource()` calls for image resources in core to accomodate for `GdImage` instances as well.

Props ayeshrajans, jrf.
Fixes #50833.

git-svn-id: https://develop.svn.wordpress.org/trunk@48798 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-16 13:31:57 +00:00
Sergey Biryukov
d41ac05964 Filesystem API: Use correct variable when closing the file handle in WP_Filesystem_FTPext::get_contents().
Props gothick@gothick.org.uk.
Fixes #51029.

git-svn-id: https://develop.svn.wordpress.org/trunk@48797 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-15 20:54:46 +00:00
Sergey Biryukov
8c378606ab Site Health: Recognize define( 'WP_AUTO_UPDATE_CORE', 'minor' ) as an acceptable value.
Previously, it was only incidentally recognized as valid due to a loose comparison with `true`.

With the strict comparison added to `WP_Site_Health_Auto_Updates::test_constants()`, this was no longer the case.

Follow-up to [47841].

Props sterndata, mukesh27, avixansa, desrosj, SergeyBiryukov.
Fixes #50912.

git-svn-id: https://develop.svn.wordpress.org/trunk@48792 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-14 20:37:42 +00:00
Sergey Biryukov
a84a5029be Docs: Consistently use third-person singular verbs for various filter descriptions, per the documentation standards.
See #50768.

git-svn-id: https://develop.svn.wordpress.org/trunk@48782 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-11 00:32:22 +00:00
Sergey Biryukov
f556437ef4 Coding Standards: Remove a few more extra brackets from some conditions in wp-admin/includes/plugin.php.
Follow-up to [48764].

See #50767.

git-svn-id: https://develop.svn.wordpress.org/trunk@48766 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-09 01:54:28 +00:00
Sergey Biryukov
18c0692773 Coding Standards: Fix WPCS issues in wp-admin/includes/plugin.php.
Includes minor code layout fixes for better readability.

Props rnaby for initial patch.
See #50767, #43848.

git-svn-id: https://develop.svn.wordpress.org/trunk@48764 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-08 21:02:18 +00:00
Sergey Biryukov
9eb6dd69c8 Coding Standards: Simplify some parts of user_can_access_admin_page() for better readability.
Props rnaby, valentinbora, khag7.
Fixes #43848.

git-svn-id: https://develop.svn.wordpress.org/trunk@48762 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-08 20:22:34 +00:00
Sergey Biryukov
5602ba4db7 Docs: Document the return value of get_settings_errors() using hash notation.
Props stevenlinx, webdevmattcrom, atachibana.
Fixes #42786.

git-svn-id: https://develop.svn.wordpress.org/trunk@48760 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-08 12:37:03 +00:00
Sergey Biryukov
29b58359ed Comments: Update DB version number used to trigger the upgrade routine for changing the comment_type DB field value in comments table.
Follow-up to [47597], [47626], [48225], [48227], [48748].

Props desrosj.
See #49236.

git-svn-id: https://develop.svn.wordpress.org/trunk@48751 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 16:30:32 +00:00
Sergey Biryukov
8c11d506e1 Docs: Correct usage of the dynamic auto_update_{$type} filter.
This ensures that the canonical name of the filter is used in Site Health debug data, as well as on plugin and theme screens, so the developer reference site remains correct.

Props johnbillion.
Fixes #50868.

git-svn-id: https://develop.svn.wordpress.org/trunk@48750 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 16:12:11 +00:00
Sergey Biryukov
9d1a31cd0a Site Health: Consistently pass an object to the auto_update_{$type} filter in Site Health debug data.
Previously, some instances of the filter received an array from a plugin or theme update response, potentially triggering PHP notices.

Props bpayton, pbiron.
Fixes #50852.

git-svn-id: https://develop.svn.wordpress.org/trunk@48745 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 13:26:11 +00:00
Sergey Biryukov
103d7d1613 Posts, Post Types: Use a consistent wording in messages about a locked post.
Props ramiy.
Fixes #50859.

git-svn-id: https://develop.svn.wordpress.org/trunk@48743 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-06 13:12:03 +00:00
Sergey Biryukov
f840046391 Site Health: Check if session_status() exists before calling it.
Props bgermann.
Fixes #50862.

git-svn-id: https://develop.svn.wordpress.org/trunk@48742 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-06 00:23:13 +00:00
Sergey Biryukov
55d73734e4 Comments: Remove a few more unnecessary instances of esc_html() in WP_Comments_List_Table::comment_status_dropdown().
Core translations are considered safe, and these labels are not escaped in any other instances.

Follow-up to [48521], [48722], [48724].

See #40188, #50815.

git-svn-id: https://develop.svn.wordpress.org/trunk@48741 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-05 13:52:01 +00:00
Sergey Biryukov
752379652d Plugins: Move the "Successfully installed the plugin" string to the correct Plugin_Upgrader method.
The string refers to the installation, and belongs in the `::install_strings()` method, not in `::upgrade_strings()`.

Props sswebster, nateinaction, SergeyBiryukov.
Fixes #50837.

git-svn-id: https://develop.svn.wordpress.org/trunk@48734 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 17:52:36 +00:00
Jake Spurlock
3fb50acb41 Site Health: Display auto-update properly for plugins that don't support auto-updates.
Properly filter `auto_update_plugin` when displaying the table.

Fixes #50822.
Props Gwendydd, pbiron, audrasjb, SergeyBiryukov, whyisjake.



git-svn-id: https://develop.svn.wordpress.org/trunk@48731 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 17:35:09 +00:00
Sergey Biryukov
a362852fcf Comments: Restore the ::has_items() call in WP_Comments_List_Table::extra_tablenav() for now, until unit tests are updated accordingly.
Follow-up to [48722].

Fixes #40188. See #50815.

git-svn-id: https://develop.svn.wordpress.org/trunk@48724 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 16:24:32 +00:00
Sergey Biryukov
21c0ed05c4 Comments: Use the existing static variable instead of calling ::has_items() again in WP_Comments_List_Table::extra_tablenav().
Additionally, removed unnecessary `esc_html()` on the Filter button label. Core translations are considered safe, and this label is not escaped in any other instance.

Props whyisjake, SergeyBiryukov.
Fixes #40188.

git-svn-id: https://develop.svn.wordpress.org/trunk@48722 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 15:55:25 +00:00
Sergey Biryukov
59ed4cbfc1 Administration: Allow wp_credits() to accept $version and $locale parameters.
This can be helpful for plugin developers to get credits information for older versions or different locales.

Props ramiy.
Fixes #35910.

git-svn-id: https://develop.svn.wordpress.org/trunk@48715 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-03 12:51:22 +00:00
Jake Spurlock
96b409c7f1 Upgrade/Install: Ensure the proper count of plugins that have auto-update enabled.
As certain plugins may not support updates, this count needs to accurately reflect that in the navbar.

Fixes 50808.
Props knutsp, audrasjb, pbiron, dd32, apedog, afragen, chriscct7, garyc40, whyisjake, SergeyBiryukov.


git-svn-id: https://develop.svn.wordpress.org/trunk@48703 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-31 17:19:34 +00:00
Jake Spurlock
d83942aa15 Upgrade/Install: Allow for WordPress.org to remotely disable auto-updates for plugins/themes
As auto-updates are rolled out across WordPress.org, the API response can modulate the response, ensuring that a rolled out could be stalled or staggered if needed for security or performance reasons.

Fixes #50824.
Props dd32, whyisjake, SergeyBiryukov.



git-svn-id: https://develop.svn.wordpress.org/trunk@48701 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-31 17:01:16 +00:00
Jake Spurlock
6d3207d564 Upgrade/Install: Pass the plugin file path into the plugin_auto_update_debug_string filter.
Adds better tooling for when user specific plugins can be updated, but platform specific ones cannot.

Fixes #50821.
Props bpayton, pbiron, audrasjb, SergeyBiryukov, whyisjake. 



git-svn-id: https://develop.svn.wordpress.org/trunk@48696 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-30 21:48:19 +00:00
Sergey Biryukov
a7e5570da6 Comments: Pass the $which parameter to the manage_comments_nav action.
This brings some consistency with the  `manage_users_extra_tablenav` and `manage_users_extra_tablenav` actions.

Props Tkama, wpgurudev.
Fixes #50736.

git-svn-id: https://develop.svn.wordpress.org/trunk@48693 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-30 13:25:10 +00:00
Sergey Biryukov
e53aaaeead Themes: Pass correct variable to is_php_version_compatible() in wp_theme_update_row().
This applies to the Themes screen in Multisite network admin.

Follow-up to [48660].

Props pbiron, afragen.
Fixes #48507. See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48689 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-29 21:06:47 +00:00
Jake Spurlock
20ac5dd62d Upgrade/Install: Only show auto-update for themes that support the feature.
Similar to the changes for plugins in [48669], let's only show the UI for themes when updates are supported for that theme.

See #50280.
Props dd32.


git-svn-id: https://develop.svn.wordpress.org/trunk@48688 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-29 19:59:30 +00:00
Sergey Biryukov
c1101f08d5 Upgrade/Install: Pass correct argument to clear_destination in Theme_Upgrader::install().
Follow-up to [48390].

Props afragen, sabernhardt.
Fixes #9757.

git-svn-id: https://develop.svn.wordpress.org/trunk@48685 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-29 13:07:35 +00:00
Sergey Biryukov
014b40e623 Media: Pass the $rel parameter to image_send_to_editor filter.
Props mihdan, pputzer.
Fixes #50765.

git-svn-id: https://develop.svn.wordpress.org/trunk@48684 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 21:19:53 +00:00
Jake Spurlock
355152a599 Upgrade/Install: Swap auto-update-supported to update-supported in update checks.
Ensures backwards compatability with external updaters.

See #50280.
Props everyone-in-the-core-updates-channel. 



git-svn-id: https://develop.svn.wordpress.org/trunk@48678 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 18:26:58 +00:00
Jonathan Desrosiers
0848bbf334 Upgrade/Install: Clarify the descriptions for install_(plugin|theme)_overwrite_actions.
See #9757.

git-svn-id: https://develop.svn.wordpress.org/trunk@48677 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 18:14:03 +00:00
Jonathan Desrosiers
b60cf9ca31 Upgrade/Install: Correct spelling of “overwrite” in new hooks and array indexes.
See #9757.

git-svn-id: https://develop.svn.wordpress.org/trunk@48676 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 17:54:52 +00:00
Sergey Biryukov
d3614d49fe Administration: Don't override the $mode global in WP_Screen::render_view_mode() if it's already set.
Follow-up to [48398], [48423], [48424], [48450].

See #49715.

git-svn-id: https://develop.svn.wordpress.org/trunk@48670 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 16:53:03 +00:00
Jake Spurlock
af4127ab84 Upgrade/Install: Enhance auto-updates to be disabled for plugins that don't suport updates.
This removes the toggle UI when updates aren't available. When plugins use the filter, the UI is updated to show that they are being controlled via code. And then removed entirely when not available.

See #50798.
Fixes #50280.

Props elrae, pbiron, SergeyBiryukov, audrasjb, azaozz, StephenCronin, whyisjake, dd32, TimothyBlynJacobs, desrosj.



git-svn-id: https://develop.svn.wordpress.org/trunk@48669 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 16:30:48 +00:00
Sergey Biryukov
828d287cab Administration: Pull the table_view_mode filter for now.
The extensibility of list table view modes will be explored in a future release.

Props audrasjb.
See #49715.

git-svn-id: https://develop.svn.wordpress.org/trunk@48668 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 16:17:13 +00:00
Sergey Biryukov
18f5561dfd Upgrade/Install: Disable the plugin/theme auto-updates UI if AUTOMATIC_UPDATER_DISABLED is defined and set as true.
Props pbiron, dd32.
Fixes #50798. See #50280.

git-svn-id: https://develop.svn.wordpress.org/trunk@48667 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 16:13:03 +00:00
Sergey Biryukov
9636a9d4d7 Upgrade/Install: Check WordPress and PHP version requirements when uploading a plugin or theme from ZIP file.
Props mariovalney, desrosj.
See #50593.

git-svn-id: https://develop.svn.wordpress.org/trunk@48666 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 16:05:39 +00:00
Sergey Biryukov
ae65f096b0 Docs: Add missing documentation for various upgrade/install class properties and methods.
Props ramiy.
Fixes #42923.

git-svn-id: https://develop.svn.wordpress.org/trunk@48661 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 11:55:19 +00:00
Sergey Biryukov
deb78bdf1c Themes: Display a message on Themes list table if a theme update requires a higher version of PHP or WordPress.
This applies to the Themes screen in Multisite network admin.

Props afragen, SergeyBiryukov.
Fixes #48507. See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48660 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 11:32:53 +00:00
Sergey Biryukov
d67c469b0d Themes: Include theme name in available update messages, for better accessibility and consistency with other similar messages.
Follow-up to [48652-48654].

See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48659 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 11:29:28 +00:00
Mike Schroder
81c39e949f Upgrade/Install: Improve wp_opcache_invalidate() performance.
Changes from using `preg_match()` based `.php` extension checking to using `substr()` in `wp_opcache_invalidate()`.

Props jnylen0, aaroncampbell, SergeyBiryukov, desrosj, mikeschroder.
Fixes #50784.

git-svn-id: https://develop.svn.wordpress.org/trunk@48657 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 08:07:04 +00:00
Jake Spurlock
5bb5053127 Site Health: Incorrect file path in require_once.
Ensure that background updater can be loaded for testing to see if auto-updates can enable automatic updates.

Fixes #50793.
Props dd32.


git-svn-id: https://develop.svn.wordpress.org/trunk@48655 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 02:19:17 +00:00
Sergey Biryukov
7ea44b5add Themes: Display a message in theme grid and Theme Details modal if a theme update requires a higher version of PHP or WordPress.
This applies to the Themes screen and the Customizer theme browser.

Props afragen, SergeyBiryukov.
See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48652 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 00:08:00 +00:00