Scott Taylor
f116de6203
Set @param back to $output, not $html, in the inline filter docs. This was a copy/paste mistake.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28419 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 05:07:18 +00:00
Scott Taylor
3e54a1fab5
Eliminate use of extract() in get_the_taxonomies(). Adds unit test.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28415 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:50:46 +00:00
Scott Taylor
e135cc2076
Eliminate use of extract() in gallery_shortcode().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28414 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:40:46 +00:00
Scott Taylor
e9f929443f
Update the inline docs for add_shortcode() to eliminate suggestion to use extract().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28413 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:27:17 +00:00
Scott Taylor
9d873771b7
Eliminate use of extract() in wp_xmlrpc_server::blogger_editPost().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28412 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:24:40 +00:00
Scott Taylor
27ff2a1cd0
Eliminate use of extract() in get_media_item().
...
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28407 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:45:01 +00:00
Scott Taylor
da440f54fd
Eliminate use of extract() in wp_list_bookmarks().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28405 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:17:52 +00:00
Scott Taylor
30564338b0
Eliminate use of extract() in _walk_bookmarks().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28404 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:04:50 +00:00
Scott Taylor
0dd9d3aeff
Eliminate use of extract() in get_bookmarks().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28403 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:57:24 +00:00
Scott Taylor
61faf32275
Eliminate use of extract() in Walker_Page::start_el().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28402 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:40:48 +00:00
Scott Taylor
c96d4a94b9
Eliminate use of extract() in wp_list_pages() which, surprisingly, didn't even use any of the extracted variables.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28401 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:21:20 +00:00
Scott Taylor
e4a800238f
Eliminate use of extract() in wp_dropdown_pages().
...
Adds unit tests to: `tests/post/template.php`.
There was previously only one wimpy assertion for `wp_dropdown_pages()`.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28399 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:11:21 +00:00
Scott Taylor
21e0370e5c
Eliminate use of extract() in wp_link_pages().
...
Adds unit tests to a new file: `tests/post/template.php`.
There were previously no unit tests for `wp_link_pages()`.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28398 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 00:43:40 +00:00
Scott Taylor
9e07b1037e
Eliminate use of extract() in paginate_links(). Adds unit tests. Moves tests/general/template.php (which only had one method) to tests/general/paginateLinks.php.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28397 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-14 22:28:08 +00:00
Scott Taylor
540826e4e3
Eliminate use of extract() in wp_list_authors().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28392 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 06:01:33 +00:00
Scott Taylor
ba8e36f94c
Eliminate use of extract() in the_title_attribute().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28383 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:47:11 +00:00
Scott Taylor
42d6b5dd1e
Eliminate use of extract() in trackback_url_list().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28382 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:43:22 +00:00
Scott Taylor
671b47ef73
Eliminate use of extract() in wp-includes/theme-compat/comments-popup.php.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28381 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:39:17 +00:00
Scott Taylor
77731c03fc
Eliminate use of extract() in wp_get_archives().
...
Adds unit tests: `tests/functions/getArchives.php`.
All other unit tests pass.
Props MikeHansenMe, wonderboymusic.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28379 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:28:56 +00:00
Drew Jaynes (DrewAPicture)
3c80d5f86a
Use a proper docs-specific variable for the first parameter passed to the embed_oembed_discover filter.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28378 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:28:30 +00:00
Drew Jaynes (DrewAPicture)
e2219e3d48
Add a complete short description to the get_attached_media filter documentation.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28377 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:20:12 +00:00
Scott Taylor
961f52d367
Add xps and oxps extensions to list of supported document types.
...
More: http://en.wikipedia.org/wiki/Open_XML_Paper_Specification
Fixes #15697 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28372 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 07:18:06 +00:00
Scott Taylor
8dc4b88fcf
In wp.media.view.Settings::update(), when handling checkboxes, check for a value of 'false' in addition to casting value to boolean. !! 'false' evaluates to true.
...
Props adamsilverstein.
Fixes #23954 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28371 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 07:02:05 +00:00
Scott Taylor
e8b8e881b2
Allow users to set overrides for MediaElement instances by always passing _wpmejsSettings instead of just _wpmejsSettings.pluginPath.
...
Props Otto42 for the initial patch.
Fixes #25243 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28370 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 06:24:58 +00:00
Scott Taylor
e1b341cc59
In the Attachment Details section of the media modal, only add box-shadow to images. Other mime-type icons look strange with an arbitrary border.
...
Props avryl.
Fixes #27949 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28369 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 06:18:02 +00:00
Scott Taylor
4826c12c47
Update the default (WP-defined) styles for MediaElement players to be more in-line with our flat aesthetic. Use the new official colors.
...
Props celloexpressions.
Fixes #27516 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28365 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 02:22:42 +00:00
Scott Taylor
9705736cdf
When pausing "all" players attached to MCE views, don't reach into global scope and pause "every" player. Only pause the players bound to MCE views.
...
Fixes #27971 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28364 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 02:06:36 +00:00
Scott Taylor
487da46928
Support loop for [audio] and [video] shortcodes that specify files that are played using MediaElement's Flash plugin bridge.
...
Fixes #27368 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28363 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 01:27:29 +00:00
Scott Taylor
b70967302b
In get_the_author_posts(), if there is no current $post, return 0 and bail.
...
Props krogsgard, aaroncampbell.
Fixes #27998 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28362 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 00:25:29 +00:00
Scott Taylor
8998c015b3
MediaElement players need clear: both to play nice with adjacent floated elements.
...
Fixes #27385 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28361 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 00:13:49 +00:00
Scott Taylor
2808673b0c
Remove the title attribute from markup generated in wp-includes/category-template.php:
...
* `get_category_parents()`
* `get_the_category_list()`
* `wp_generate_tag_cloud()`
* `Walker_Category::start_el()`
Props joedolson.
Fixes #26557 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28359 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-10 23:56:12 +00:00
Scott Taylor
a398f38024
First pass at wpview logic for the [embed] shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet.
...
Props avryl, wonderboymusic.
See #28195 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28358 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-10 23:35:08 +00:00
Drew Jaynes (DrewAPicture)
cb5852a813
Add inline documentation of the default arguments for wp_list_pages().
...
Props garza for the initial patches.
Fixes #11338 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28357 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-10 08:01:13 +00:00
Scott Taylor
7531fd0070
Leverage size_format() when displaying max_upload_size:
...
* In `media_upload_form()`
* The `uploader-inline` Underscore template in the media modal.
Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.
Fixes #25643 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28343 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 18:24:47 +00:00
Scott Taylor
bfe7d38650
audio, video, and playlist shortcodes:
...
* Convert all instances of variable variables to array properties
* Eradicate use of `extract()`
* Rename `$atts` to `$html_atts` where collision with new `$atts` (shortcode atts holder) var might occur
See #22400 , #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28342 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 17:35:09 +00:00
Scott Taylor
4bddd84276
In wpdb, remove dead code:
...
* In `->tables()`, `break` is unreachable after `return`
* In `->query()`, `$return` is always set, so doesn't need an initial value of `0`
* In `->delete()`, `$bits` is unused
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28339 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:55:32 +00:00
Scott Taylor
e47eb14575
In WP_Widget::update_callback(), $sidebars_widgets is unused.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28338 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:51:31 +00:00
Scott Taylor
f945487f45
In wp-includes/theme.php, break is unreachable after return.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28337 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:49:19 +00:00
Scott Taylor
b99dead052
In print_admin_styles(), $zip is never used after being set. $compress_css does not need to be imported.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28336 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:46:11 +00:00
Scott Taylor
b62ca9c298
In wp_default_scripts(), $max_upload_size and its entangled children $max_up and $max_post create quite the ternary operator... that is never used.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28335 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:44:06 +00:00
Scott Taylor
f63b6cde3a
In wp-includes/revision.php - remove dead code:
...
* In `wp_get_post_autosave()`, `break` is unreachable after `return`
* In `_wp_put_post_revision()`, `$post_id` is set then never used.
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28334 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:37:45 +00:00
Scott Taylor
098a5145c5
In WP_Query, remove duplicate variable setting:
...
* In `->parse_search_order()`, a value is always set for `$search_orderby`, no need for empty initialization
* In `->get_posts()`, `$fields` is always set, no need for empty initialization
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28333 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:42:28 +00:00
Scott Taylor
16a58e34a2
In get_pages(), $cache does not need to be reset to an empty array. update_post_cache( $pages ) takes care of priming.
...
In `set_post_thumbnail()`, (accidental) assignment is unnecessary for `$thumbnail_html` as it is not used.
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28332 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:38:23 +00:00
Scott Taylor
11e65eb200
In wp_get_attachment_link(), $post_title is set and then not used.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28331 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:34:10 +00:00
Scott Taylor
b626b11590
In Walker_Nav_Menu::start_el(), $class_names is set twice before it is used.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28330 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:32:25 +00:00
Scott Taylor
3f2a078f5e
In get_network_by_path(), $exact_domains is unused.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28329 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:31:14 +00:00
Scott Taylor
24b03d819b
In update_metadata_by_mid(), $original_value is unused.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28328 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:28:02 +00:00
Scott Taylor
e95edb29aa
In edit_post_link(), $post_type_obj is unused.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28327 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:26:20 +00:00
Scott Taylor
5cf2a50dba
In paginate_links(), break is unreachable after return.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28326 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:24:22 +00:00
Scott Taylor
ef5998eabb
In wp-includes/functions.php, remove dead code:
...
* In `current_time()`, `break` is unreachable after `return`.
* In `add_query_arg()`, `$ret` is set twice before being used.
* In `wp_mkdir_p()`, `$dir_perms` is set twice before being used.
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28325 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:22:22 +00:00