Commit Graph

48 Commits

Author SHA1 Message Date
Felix Arntz
f16b2a650e Role/Capability: Introduce capabilities dedicated to installing and updating language files.
The new meta capabilities are called `install_languages` and `update_languages`. Prior to this change, there were no proper capability checks applied. Instead only the filesystem and related constants were checked, and for actual permissions a rather vague fallback was used where a user needed to have at least one of the other updating capabilities. In addition to being generally more verbose, the new capabilities make it possible for example to allow a user to update languages, but nothing else. By default they fall back to the original way of how they were handled.

Props johnbillion, flixos90.
Fixes #39677.


git-svn-id: https://develop.svn.wordpress.org/trunk@41268 602fd350-edb4-49c9-b593-d223f7449a82
2017-08-18 18:30:28 +00:00
Felix Arntz
ca95a827b8 Multisite: Fix a user-facing message when adding a new site with a new user as admin.
Previously the message would falsely state that the username and password would be sent to the new user. It is actually a link to set the password that they receive in the email.

Props nishitlangaliya.
Fixes #41169.


git-svn-id: https://develop.svn.wordpress.org/trunk@41064 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-17 20:22:08 +00:00
John Blackbourn
f57f03b935 Networks and Sites: Correct a capability check when accessing the Sites -> Add New screen.
Props flixos90

See #39156


git-svn-id: https://develop.svn.wordpress.org/trunk@40433 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-15 17:29:55 +00:00
Jeremy Felt
2979167ba7 Multisite: Use get_network() and get_current_network_id() for current network data.
`get_network()` falls back to the current network when called without any arguments. Between this and `get_current_network_id()`, we can replace almost all instances of the global `$current_site` and all instances of `get_current_site()`.

This effectively deprecates `get_current_site()`, something that we'll do in a future ticket.

Props flixos90.
Fixes #37414.


git-svn-id: https://develop.svn.wordpress.org/trunk@38814 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-19 04:46:14 +00:00
Andrea Fercia
240b114fe8 Accessibility: Remove target=_blank from the Network screens help tabs links.
Stop taking control of users' browsers.

Props rianrietveld.
Fixes #38159. See #23432.


git-svn-id: https://develop.svn.wordpress.org/trunk@38721 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-04 07:02:48 +00:00
Jeremy Felt
61f014b9fc Multisite: Remove redundant is_multisite() checks in network admin templates.
`wp-admin/network/admin.php` is required by all of the individual network templates and begins with an `is_multisite()` check of its own. Because of this, we can remove the 26 other checks in the individual templates.

Props flixos90.
Fixes #37447.


git-svn-id: https://develop.svn.wordpress.org/trunk@38657 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-27 15:38:47 +00:00
Dominik Schilling (ocean90)
a1e9fbfc14 Multisite: Allow to set the site language of a new site to English.
An empty string in `WPLANG` is used to define the site language as `en_US`. The `! empty()` check didn't catch this case so that `wpmu_create_blog()` fell back to the network setting.

Fixes #36918.

git-svn-id: https://develop.svn.wordpress.org/trunk@38655 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-26 18:38:32 +00:00
Dominik Schilling (ocean90)
206380180e Text Changes: Unify permission error messages.
The new format looks like "Sorry, you are not allowed to <action>.". This provides a consistent experience for all error messages related to missing permissions. It also reduces the number of similar strings and allows translators to provide a consistent style in their language.

Props ramiy, Presskopp.
Fixes #34521.

git-svn-id: https://develop.svn.wordpress.org/trunk@37914 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-29 15:15:40 +00:00
Drew Jaynes
0a17fdaf07 Docs: Minorly improve the hook doc summary for the pre_network_site_new_created_user action, introduced in [35786].
See #33631. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36826 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 09:02:46 +00:00
Sergey Biryukov
0814a33464 I18N: Remove <code> tag from translatable string in wp-admin/network/site-new.php.
Props ramiy.
Fixes #35989.

git-svn-id: https://develop.svn.wordpress.org/trunk@36771 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 02:43:47 +00:00
Jeremy Felt
380fc2d093 Multisite: Use "Site Address (URL)" in site-new.php.
This uses the same string as single site and `site-info.php` when editing a site in multisite.

Fixes #35934.


git-svn-id: https://develop.svn.wordpress.org/trunk@36684 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-24 16:13:04 +00:00
Sergey Biryukov
d85d32f3a0 I18N: Add translator comments and context to "New Site Created" email notification strings.
Props ramiy.
Fixes #35716.

git-svn-id: https://develop.svn.wordpress.org/trunk@36669 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-24 02:03:25 +00:00
Jeremy Felt
181f39d2e0 Multisite: Add a hook to the end of the Add Site form.
The `network_site_new_form` action can be used to extend the new site form.

Props igmoweb, ocean90.
Fixes #34739.


git-svn-id: https://develop.svn.wordpress.org/trunk@36555 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-17 19:02:17 +00:00
Jeremy Felt
03310b2e22 MS: Update "Add New Site" address description text for accuracy.
Add hyphens to the list of allowed characters and add the `description` class to helper text paragraph tag.

Props thomaswm for the initial patch.
Fixes #26388.


git-svn-id: https://develop.svn.wordpress.org/trunk@35893 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 03:12:11 +00:00
Rachel Baker
c3b6753782 Multisite: Clarify purpose of hook from [35786] and match our naming convention.
`network_site_new_created_user_pending` -> `pre_network_site_new_created_user` 

See #33631


git-svn-id: https://develop.svn.wordpress.org/trunk@35789 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 20:31:04 +00:00
Rachel Baker
a9bf2e7aaa Multisite: Add hook before a new user is created during the creation of a new site.
New `network_site_new_created_user_pending` action fires before a new user will be created via the network site-new.php page. 

Props mackensen
Fixes #33631


git-svn-id: https://develop.svn.wordpress.org/trunk@35786 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 20:09:50 +00:00
Jeremy Felt
ecb75a16be MS: Show an error if a new site slug conflicts with an existing username.
Props utkarshpatel, dipesh.kakadiya.
Fixes #33804.


git-svn-id: https://develop.svn.wordpress.org/trunk@34996 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 01:41:43 +00:00
Jeremy Felt
599fb50e09 Revert [34778], continue using _site_option() for the current network.
The `_network_option()` parameter order will be changing to accept `$network_id` first. The `_site_option()` functions will remain in use throughout core as our way of retrieving a network option for the current network.

See #28290.


git-svn-id: https://develop.svn.wordpress.org/trunk@34912 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 17:11:01 +00:00
Drew Jaynes
fe383af11a Multisite: Introduce get_subdirectory_reserved_names(), which returns a filterable list of reserved subdirectory site names.
The function encapsulates the existing `subdirectory_reserved_names` filter and reduces the maintenance burden of keeping the value of (currently) two instances of the same hook in sync.

See #33615.


git-svn-id: https://develop.svn.wordpress.org/trunk@34854 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-06 04:34:03 +00:00
Scott Taylor
9fe13be519 oEmbed: add embed to $subdirectory_reserved_names.
Props jeremyfelt.
See #32522.


git-svn-id: https://develop.svn.wordpress.org/trunk@34850 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-06 03:44:25 +00:00
Jeremy Felt
3c177b8c6f MS: Use *_network_option() functions throughout core.
Replaces all uses of `*_site_option()` with the corresponding "network" function.

This excludes one usage in `wp-admin/admin-footer.php` that needs more investigation.

Props spacedmonkey.
See #28290.


git-svn-id: https://develop.svn.wordpress.org/trunk@34778 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-02 19:07:23 +00:00
Jeremy Felt
8f4a6370f0 Fixes #33816.
MS: Adjust formatting of code in `site-new.php` to improve readability.

Fixes #34066.


git-svn-id: https://develop.svn.wordpress.org/trunk@34673 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-28 23:29:40 +00:00
Scott Taylor
5dd7bec848 Multisite: as a precaution, make wp-json a reserved subdirectory name.
Props austinginder.
Fixes #33789.


git-svn-id: https://develop.svn.wordpress.org/trunk@34375 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:20:41 +00:00
Helen Hou-Sandi
3531c0bc10 Superglobals: Revert [34059] until further notice.
see #33837.


git-svn-id: https://develop.svn.wordpress.org/trunk@34265 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 12:32:20 +00:00
Boone Gorges
de7c9b6015 Move new user notification emails to add_action() callbacks.
When a new user is created in various places throughout the interface,
notifications are sent to the site admin and the new user. Previously, these
notifications were fired through direct calls to `wp_new_user_notification()`,
making it difficult to stop or modify the messages.

This changeset introduces a number of new action hooks in place of direct calls
to `wp_new_user_notification()`, and hooks the new wrapper function
`wp_send_new_user_notifications()` to these hooks.

Props dshanske, thomaswm, boonebgorges.
Fixes #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34251 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 22:18:33 +00:00
Dominik Schilling (ocean90)
08098026ce Passwords: Deprecate second parameter of wp_new_user_notification().
The second parameter `$plaintext_pass` was removed in [33023] and restored as `$notify` in [33620] with a different behavior. If you have a plugin overriding `wp_new_user_notification()` which hasn't been updated you would get a notification with your username and the password "both".
To prevent this the second parameter is now deprecated and reintroduced as the third parameter.

Adds unit tests.

Props kraftbj, adamsilverstein, welcher, ocean90.
Fixes #33654.

(Don't ask for new pluggables kthxbye)

git-svn-id: https://develop.svn.wordpress.org/trunk@34116 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 12:42:34 +00:00
Scott Taylor
33953cb392 Introduce wp_validate_action( $action = '' ), a helper function that checks $_REQUEST for action and returns it, or empty string if not present. If $action is passed, it checks to make sure they match before returning it, or an empty string. Strings are always returned to avoid returning multiple types.
Implementing this removes 27 uses of direct superglobal access in the admin.

For more reading:
https://codeclimate.com/github/WordPress/WordPress/wp-admin/edit-comments.php

See #33837.


git-svn-id: https://develop.svn.wordpress.org/trunk@34059 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 21:07:45 +00:00
Scott Taylor
f8b6a357a0 Multisite: Don't allow sites to be created with the following reserved slugs: wp-admin, wp-content, wp-includes
Props austinginder.
Fixes #33615.


git-svn-id: https://develop.svn.wordpress.org/trunk@33952 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 19:31:52 +00:00
John Blackbourn
38fe3c4db5 Implement a language chooser on the Network Admin -> Sites -> Add New screen.
Props DrewAPicture
Fixes #33528


git-svn-id: https://develop.svn.wordpress.org/trunk@33920 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:47:00 +00:00
Konstantin Obenland
e7a203cdf2 Passwords: Restore second parameter for wp_new_user_notification().
After [33023] users would always be notified, this restores previous behavior.

Props markjaquith, ocean90.
Fixes #33358.



git-svn-id: https://develop.svn.wordpress.org/trunk@33620 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 14:24:43 +00:00
Jeremy Felt
d8df19141a Don't autocapitalize or autocorrect domain or path when adding a new site in iOS.
Props @ohryan.
Fixes #32646.


git-svn-id: https://develop.svn.wordpress.org/trunk@33082 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 04:39:48 +00:00
Konstantin Obenland
e59592f87e Proper heading for admin screens.
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.



git-svn-id: https://develop.svn.wordpress.org/trunk@32974 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 15:40:27 +00:00
Scott Taylor
3f29a2101d Don't loosely compare functions that return bool against a literal bool.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32730 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 17:18:38 +00:00
Sergey Biryukov
e4be853426 Use correct closing tag.
props eligijus, TobiasBg.
fixes #32205.

git-svn-id: https://develop.svn.wordpress.org/trunk@32328 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-30 14:29:24 +00:00
Dominik Schilling (ocean90)
b0d6757918 Use HTTPS URLs for codex.wordpress.org.
see #27115.

git-svn-id: https://develop.svn.wordpress.org/trunk@32116 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-12 21:28:58 +00:00
Helen Hou-Sandi
35df5592f1 Admin notices: Make (most) core notices dismissible.
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.


git-svn-id: https://develop.svn.wordpress.org/trunk@31973 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 22:05:17 +00:00
Sergey Biryukov
3ecaee903e Add translator comments for placeholders in network-related strings.
props ramiy.
fixes #31834.

git-svn-id: https://develop.svn.wordpress.org/trunk@31956 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 13:25:55 +00:00
Jeremy Felt
ff0b2f7a6f Provide proper label associations and descriptions throughout the network admin
* Add labels previously missing for many inputs throughout the network admin screen.
* Add proper `aria-describedby` attributes to provide better descriptions.
* Wrap grouped inputs with `fieldset` elements.
* Remove now unneeded `title` attributes when appropriate.

Props cfoellmann, afercia, rianrietveld.

Fixes #38406.


git-svn-id: https://develop.svn.wordpress.org/trunk@31517 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-23 02:28:41 +00:00
Dominik Schilling (ocean90)
17cefe0288 Network Admin: Improve width of input fields on Add New Site and Edit Site screens.
props honeysilvas.
fixes #16383.

git-svn-id: https://develop.svn.wordpress.org/trunk@30578 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-26 19:50:20 +00:00
Jeremy Felt
f12a68e7c6 Differentiate between invalid and missing admin emails when adding a new site
Check the emptiness of the admin email before using `sanitize_email()` and `is_email()` to determine if the address is valid.

Fixes #17890


git-svn-id: https://develop.svn.wordpress.org/trunk@29877 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-12 00:21:02 +00:00
John Blackbourn
0a4e8b2b7e Implement email and url input types where appropriate. Props Kau-Boy. Fixes #22183.
git-svn-id: https://develop.svn.wordpress.org/trunk@29030 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-08 17:51:58 +00:00
Andrew Nacin
4cf6fc1a99 Use SSL when linking to WordPress.org. see #27115.
git-svn-id: https://develop.svn.wordpress.org/trunk@27469 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-08 04:13:28 +00:00
Helen Hou-Sandi
91b0e15ef8 Autocomplete for the new site admin email. Better than trying to remember which email address you used.
fixes #25348.


git-svn-id: https://develop.svn.wordpress.org/trunk@27046 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 23:09:08 +00:00
Andrew Ozz
b33d0da84c Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119
git-svn-id: https://develop.svn.wordpress.org/trunk@26518 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-02 03:52:23 +00:00
Sergey Biryukov
0262b2e4db Remove redundant current_user_can() check. props jeremyfelt. fixes #26057.
git-svn-id: https://develop.svn.wordpress.org/trunk@26236 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-16 17:37:26 +00:00
Drew Jaynes
d8f9cc6fff Mark subdirectory_reserved_names filter as duplicate in wp-admin/network/site-new.php.
Props ninio.
Fixes #25729.


git-svn-id: https://develop.svn.wordpress.org/trunk@25962 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 23:36:46 +00:00
Andrew Nacin
8d72ad52ff Don't rely on include_path to include files.
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.


git-svn-id: https://develop.svn.wordpress.org/trunk@25616 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-25 00:17:40 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00