Commit Graph

547 Commits

Author SHA1 Message Date
Scott Taylor
388690382c Bootstrap: Autoload classes using a Composer-generated PHP 5.2-compatible Autoloader.
* `wp-admin` and `wp-includes` are scanned for classes to autoload
* Several 3rd-party and Ryan McCue-shaped libraries are excluded when the classmap is generated, see `composer.json`: `autoload.exclude-from-classmap`
* `wp-vendor/autoload_52.php` is included at the top of `wp-settings.php` - no changes need to be made to unit tests to include the autoloader
* An avalanche of `require()` and `require_once()` calls that loaded class files have been removed from the codebase.

The following files have been added to `svn:ignore` - they are not 5.2-compatible and fail during pre-commit:
* src/wp-vendor/autoload.php
* src/wp-vendor/composer/autoload_real.php
* src/wp-vendor/composer/autoload_static.php
* src/wp-vendor/composer/ClassLoader.php

We favor these files instead:
* src/wp-vendor/autoload_52.php
* src/wp-vendor/composer/autoload_real_52.php
* src/wp-vendor/composer/ClassLoader52.php

When new PHP classes are added to the codebase, simply run `composer install` or `composer update` from the project root to update the autoloader.

The future is now.

See #36335.


git-svn-id: https://develop.svn.wordpress.org/trunk@38399 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-27 09:15:01 +00:00
Scott Taylor
55f5577813 Multisite: move get_current_site() to load.php so that it can be used in more places, instead of importing global $current_site.
See #37699.


git-svn-id: https://develop.svn.wordpress.org/trunk@38388 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 21:34:36 +00:00
Scott Taylor
3586ac294f Bootstrap: load option.php in wp-settings.php, not in functions.php.
See #36335.


git-svn-id: https://develop.svn.wordpress.org/trunk@38386 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 21:10:30 +00:00
Andrew Ozz
861bdc722f TinyMCE: fix toolbars alignment in RTL.
Fixes #37760 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@38349 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-25 01:19:24 +00:00
Sergey Biryukov
5ae7139efa I18N: Add translator comments for strings in wp-includes/functions.php.
Props ramiy.
Fixes #37802.

git-svn-id: https://develop.svn.wordpress.org/trunk@38344 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 23:47:28 +00:00
Scott Taylor
3aee745492 AJAX: add a new function, wp_doing_ajax(), which can replace... (wait for it...) DOING_AJAX checks via the constant.
Props Mte90, sebastian.pisula, swissspidy.
Fixes #25669.


git-svn-id: https://develop.svn.wordpress.org/trunk@38334 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 14:32:18 +00:00
Scott Taylor
0774c039f4 General: remove variable set needlessly in wp_check_jsonp_callback().
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38308 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-22 20:50:31 +00:00
Scott Taylor
d911ef44dc Media: when calling pathinfo(), also pass a PATHINFO_* constant to avoid array notices for unset keys.
Props JaworskiMatt.
Fixes #37608.


git-svn-id: https://develop.svn.wordpress.org/trunk@38294 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-20 23:35:50 +00:00
Helen Hou-Sandi
1e21bf9bf7 System fonts: Don't quote single-word font names, per our coding standards.
props ocean90, netweb.
see #36753.


git-svn-id: https://develop.svn.wordpress.org/trunk@38152 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-26 16:38:49 +00:00
Drew Jaynes
c750ff2d3c Docs: Fix formatting, tense, verb conjugation, and other syntax for wp-includes/* elements introduced or changed in 4.6.
Part 1/2.

See #37318.


git-svn-id: https://develop.svn.wordpress.org/trunk@38121 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-20 16:56:21 +00:00
Jeremy Felt
4f2008a104 Meta: Remove object subtype handling from register_meta().
Registration is now based solely on object type, which allows the code around this to be simplified significantly.

In the process of making this adjustment:

* `register_meta()`, `unregister_meta_key()`, `get_registered_metadata()`, and `registered_meta_key_exists()` no longer return `WP_Error` objects.
* The recently introduced `wp_object_type_exists()` function and the restriction on object type has been removed.

Note: No guarantee of uniqueness is made across object subtypes. Registered meta keys should be uniquely prefixed to avoid conflict.

Fixes #35658.


git-svn-id: https://develop.svn.wordpress.org/trunk@38095 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-18 21:15:37 +00:00
John Blackbourn
a501d6c8be Meta: Add a missing @since param for wp_object_type_exists().
See #35658


git-svn-id: https://develop.svn.wordpress.org/trunk@38038 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-12 13:20:55 +00:00
Drew Jaynes
5cf0ef170a Docs: Standardize capitalization of Ajax throughout core documentation per the core spelling guide.
Ajax, while considered an acronym for Asynchronous JavaScript and XML, is most commonly capitalized only in the first character.

Part props ocean90.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@38028 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-10 00:50:21 +00:00
Dominik Schilling
c68f1ec772 Bootstrap: Enhance core's memory limit handling.
* Don't lower memory limit if the current limit is greater than `WP_MAX_MEMORY_LIMIT`.
* Set `WP_MEMORY_LIMIT` and `WP_MAX_MEMORY_LIMIT` to current limit if the `memory_limit` setting can't be changed at runtime.
* Use `wp_convert_hr_to_bytes()` when parsing the value of the `memory_limit` setting because it can be a shorthand or an integer value.
* Introduce `wp_raise_memory_limit( $context )` to raise the PHP memory limit for memory intensive processes. This DRYs up some logic and includes the existing `admin_memory_limit` and `image_memory_limit` filters. The function can also be used for custom contexts, the `{$context}_memory_limit` filter allows to customize the limit.
* Introduce `wp_is_ini_value_changeable( $setting )` to determine whether a PHP ini value is changeable at runtime.
* Remove a `function_exists( 'memory_get_usage' )` check. Since PHP 5.2.1 support for memory limit is always enabled.

Related commits: [38011-38013]

Props jrf, A5hleyRich, swissspidy, ocean90.
Fixes #32075.

git-svn-id: https://develop.svn.wordpress.org/trunk@38015 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-08 14:36:37 +00:00
Helen Hou-Sandi
495ff0c633 Meta: Make registration error conditions return consistently.
In doing this, non-core object types are no longer forcibly blocked and are instead checked against `wp_object_type_exists()` which has a filterable return value. Still, filter that at your own risk.

props Faison for the initial patch.
see 35658.


git-svn-id: https://develop.svn.wordpress.org/trunk@37991 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-06 18:08:55 +00:00
Sergey Biryukov
920f29616a Docs: Use 3-digit, x.x.x-style semantic versioning for _doing_it_wrong(), _deprecated_function(), _deprecated_argument(), and _deprecated_file() throughout core.
Props metodiew.
Fixes #36495.

git-svn-id: https://develop.svn.wordpress.org/trunk@37985 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-06 12:39:01 +00:00
Sergey Biryukov
eb176b40b8 I18N: Adjust the regex in wp_maybe_decline_date() to avoid \w and \b, as they don't work with Unicode characters correctly in PHP 5.3.3 and earlier versions.
See [37975] for unit tests.

See #36790.

git-svn-id: https://develop.svn.wordpress.org/trunk@37979 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-05 21:42:06 +00:00
Dominik Schilling
c259f4c35d General: Return "O B" when passing 0 to size_format().
Props swissspidy.
Fixes #36635.

git-svn-id: https://develop.svn.wordpress.org/trunk@37962 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-05 10:35:24 +00:00
Gary Pendergast
b3a6124e3d General: Remove the Pragma header from responses.
`Pragma` is supposed to be a request header, but we've been including it in responses since the beginning of time.

This is a relic dating all the way back to b2, probably originally added because Internet Explorer version 5 and earlier didn't understand the `Cache-Control` header in responses, but they did (incorrectly) obey the `Pragma` header.

Internet Explorer 6 and 7 will obey the `Pragma` response header only if no other cache-related response headers are present (in our case, they are always present), and all other browsers ignore the `Pragma` response header.

Props geekysoft.
Fixes #37250.



git-svn-id: https://develop.svn.wordpress.org/trunk@37944 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-04 04:01:19 +00:00
Jeremy Felt
bba8b1271f Docs: Remove duplicate text for is_main_site() parameter.
Props Kenshino.
Fixes #37241.


git-svn-id: https://develop.svn.wordpress.org/trunk@37932 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-30 17:16:03 +00:00
Boone Gorges
c97f234e6f Allow action and filter hooks to be deprecated.
When a filter or action hook is deprecated, the corresponding `apply_filters()`
or `do_action()` calls should be switched out with `apply_filters_deprecated()`
or `do_action_deprecated()`. The latter functions will throw a deprecation
before invoking the original hook.

Props solarissmoke, SergeyBiryukov, DrewAPicture.
Fixes #10441.

git-svn-id: https://develop.svn.wordpress.org/trunk@37861 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-25 19:56:19 +00:00
Sergey Biryukov
89304a579f I18N: Adjust the regex in wp_maybe_decline_date() to handle word boundaries correctly.
Props semil.
Fixes #36790.

git-svn-id: https://develop.svn.wordpress.org/trunk@37717 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-15 17:44:45 +00:00
SergeyBiryukov
aea4c0d86a In size_format() and wp_convert_bytes_to_hr(), replace kB with KB for consistency with other units.
Props Presskopp, dashaluna.
Fixes #37037.

git-svn-id: https://develop.svn.wordpress.org/trunk@37702 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-14 21:40:02 +00:00
Jeremy Felt
2b2dde968b Login: Fire wp_no_robots() in wp_die() only if function exists.
This covers cases where `wp_die()` is used before `general-template.php` is loaded.

Fixes #34401.


git-svn-id: https://develop.svn.wordpress.org/trunk@37689 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-12 00:33:27 +00:00
Drew Jaynes
831a186108 Boostrap: Move is_ssl() to wp-includes/load.php.
Moving to load.php introduces parity with other commonly evaluated `is_*()` functions such as `is_admin()` or `is_multisite()`.  It also makes `is_ssl()` available much earlier in the loading process, such as for use in drop-ins like advanced-cache.php.

Props johnjamesjacoby.
Fixes #35844.


git-svn-id: https://develop.svn.wordpress.org/trunk@37677 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-10 18:55:33 +00:00
Peter Wilson
db0195c936 DOCS: Replace HTTP links with HTTPS.
Replaces unsecure links in documentation and translator comments with their secure versions.

Props johnpgreen, netweb

Fixes #36993


git-svn-id: https://develop.svn.wordpress.org/trunk@37674 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-10 04:49:09 +00:00
Jeremy Felt
15a12ce4f0 Multisite: Introduce get_current_network_id()
Similar to `get_current_blog_id`, this can be used to get the ID of the `$current_site` global. If not available, it will fallback to the main network ID. In single site, this will return 1.

Props spacedmonkey, flixos90.
Fixes #33900.


git-svn-id: https://develop.svn.wordpress.org/trunk@37670 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-09 20:33:35 +00:00
Rachel Baker
0c990ffb73 Users: Stop WP_List_Table notices from persisting on pagination navigation.
Adds the keyboard navigation query vars to `wp_removable_query_args()` and passes the results of said function to remove_query_var() inside the WP_List_Table pagination method.

Props EFAREM for the initial patch.
Fixes #35620.

git-svn-id: https://develop.svn.wordpress.org/trunk@37663 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-09 01:55:40 +00:00
Rachel Baker
25c3618138 REST API: Create the general wp_check_jsonp_callback() function for validating JSONP callback functions.
Move the REST API JSONP callback validation check into a separate function named `wp_check_jsonp_callback()`. This allows plugins to use the built-in validation when handling JSONP callbacks.
Extremely Important Note: If you send JSONP in your custom response, make sure you prefix the response with `/**/`. This will mitigate the Rosetta Flash exploit. You should also send the `X-Content-Type-Options:nosniff` header, or even better, use the REST API infrastructure.

Props rmccue.
Fixes #28523.

git-svn-id: https://develop.svn.wordpress.org/trunk@37646 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-06 21:33:30 +00:00
Drew Jaynes
194583a770 Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.

See #36921.


git-svn-id: https://develop.svn.wordpress.org/trunk@37543 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-23 19:00:41 +00:00
Drew Jaynes
39908cb2bb Docs: Standardize filter docs in wp-includes/functions.php to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.


git-svn-id: https://develop.svn.wordpress.org/trunk@37510 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 18:35:24 +00:00
Ryan McCue
bd49bb180e REST API: Use prepared JSON data correctly.
This was modifying a variable that was never used. Oops.

Fixes #36358.
Props jrf.


git-svn-id: https://develop.svn.wordpress.org/trunk@37444 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-17 03:54:37 +00:00
Drew Jaynes
195572596b Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.

Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.

Props ocean90.
Fixes #36835.


git-svn-id: https://develop.svn.wordpress.org/trunk@37431 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-13 18:40:19 +00:00
Helen Hou-Sandi
0671f3a8d3 Drop Open Sans in the admin in favor of system fonts.
Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.

At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.

There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.

The style remains registered, as it is almost certainly in use by themes and plugins.

props mattmiklic.
see #36753.


git-svn-id: https://develop.svn.wordpress.org/trunk@37361 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-04 22:06:27 +00:00
Drew Jaynes
c7bed4f8c6 Docs: Remove inline @see tags from function, class, and method references in inline docs.
Known functions, classes, and methods are now auto-linked in Code Reference pages following #meta1483.

Note: Hook references are still linked via inline `@see` tags due to the unlikelihood of reliably matching for known hooks based on a RegEx pattern.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@37342 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-02 03:59:56 +00:00
Gary Pendergast
74e88010c0 Emoji: The :roll: smiley is now an emoji.
Unicode 8 added `U+1F644`, "Face with Rolling Eyes", which matches our `:roll:` smiley. Continuing our ever present quest to rid the world of legacy smilies, we now translate that smiley into its emoji form.

Sadly, `:mrgreen:` remains sorely under-represented in the Unicode standard, I'm inclined to think that we should buy a voting membership of the Unicode Consortium, in order to rectify that situation. (Personally, I'm hoping for a green skin tone modifier.)

Fixes #36365.
 



git-svn-id: https://develop.svn.wordpress.org/trunk@37296 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-22 06:28:51 +00:00
Dominik Schilling (ocean90)
8be6905a89 Media: Don't cache the results of wp_mkdir_p() in a persistent cache.
To improve the performance of `wp_upload_dir()` the result of `wp_mkdir_p()` was stored in a persistent cache, introduced in [36565]. But this becomes an issue when WordPress is scaled horizontally. You may end up caching a value for a server where the directory doesn't exist which will prevent further uploads on other servers because of the persistent cache.
The fix is to use a non-persistent cache.

Props azaozz, ocean90.
See #34359.
Fixes #36621.

git-svn-id: https://develop.svn.wordpress.org/trunk@37285 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 19:57:03 +00:00
John Blackbourn
6fe6d25f01 Add noindexing to the default wp_die() handler to avoid unnecessary crawl errors in web search engines.
Fixes #34401
Props rodrigosprimo


git-svn-id: https://develop.svn.wordpress.org/trunk@37210 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-15 02:04:54 +00:00
Boone Gorges
26a5e78d94 Improve testability and coverage of wp_ext2type().
* Following pattern of `wp_get_mime_types()`, introduce `wp_get_ext_types()` function. New function returns a filtered list of file types with their extensions.
* Use this function in new tests for `wp_ext2type()`.

Props borgesbruno.
Fixes #35987.

git-svn-id: https://develop.svn.wordpress.org/trunk@37189 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-13 03:11:25 +00:00
Drew Jaynes
89cfbe98f1 Docs: Improve DocBlock syntax for wp_get_upload_dir(), introduced in [36565].
See #34359. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36925 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 03:37:43 +00:00
Dion Hulse
8d9b0a9d22 Filesystem: Support Windows shares/DFS roots in wp_normalize_path().
Props rilwis for initial patch.
Fixes #35996.


git-svn-id: https://develop.svn.wordpress.org/trunk@36881 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-08 05:59:45 +00:00
Sergey Biryukov
cab3a242f7 Docs: Correct $number type in number_format_i18n().
Props salcode.
Fixes #35893.

git-svn-id: https://develop.svn.wordpress.org/trunk@36644 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-23 18:43:47 +00:00
Andrew Ozz
2dc9766688 In wp_upload_dir() do not cache error from wp_mkdir_p() when a directory cannot be created. Keep trying to create the dirs. This happens mostly in file upload context.
See #34359.

git-svn-id: https://develop.svn.wordpress.org/trunk@36628 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-23 15:57:23 +00:00
Andrew Ozz
bb49a958d2 Replace wp_upload_dir() with the new wp_get_upload_dir() in all cases where a file is not being uploaded. Deprecate _wp_upload_dir_baseurl(), and replace it with wp_get_upload_dir().
See #34359.

git-svn-id: https://develop.svn.wordpress.org/trunk@36569 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-18 00:23:04 +00:00
Andrew Ozz
c7936b8785 Improve the performance of wp_upload_dir():
- Cache the output in non-persistent cache.
- Cache the result from `wp_mkdir_p()` in persistent cache (when present).
- Introduce `wp_get_upload_dir()` for use when not uploading files. It is equivalent to `wp_upload_dir()` but does not check for the existence or create the upload directory.
- Change tests to use the non-cached `_wp_upload_dir()`. They change options on the fly (should never be used in production) to simulate different environments.
- Introduce `_upload_dir_no_subdir()` and `_upload_dir_https()` to facilitate testing. These use the proper `upload_dir` filter to simulate different environments.

Props kovshenin, azaozz.
See #34359.

git-svn-id: https://develop.svn.wordpress.org/trunk@36565 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-17 22:51:01 +00:00
Dominik Schilling (ocean90)
a440256da0 Introduce a $parent_class parameter for _deprecated_constructor().
Use the parameter for the deprecated constructor warning in `WP_Widget` to provide an indication to which widget is using the PHP4 style constructor.

Props sebastian.pisula.
Fixes #33440.

git-svn-id: https://develop.svn.wordpress.org/trunk@36541 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-16 23:19:38 +00:00
Drew Jaynes
1c80e8ca46 Docs: Make a couple of minor improvements to the DocBlock for wp_get_raw_referer(), introduced in [36266].
* Uses a third-person singular verb in the summary
* Makes the return types more specific with `string|false` vs `string|bool`.

See #27152. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36500 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-07 08:08:48 +00:00
Eric Andrew Lewis
27361e6ffe Networks and sites: Replace "blog" usage with "site" in docs.
Multisite functions use the term "blog" to refer to what we now call a "site," e.g. `get_current_blog_id()`. These functions are here to stay because of our commitment to backwards compatibility. What we can do is set the documentation straight.

See #35417.


git-svn-id: https://develop.svn.wordpress.org/trunk@36417 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-28 03:50:26 +00:00
Ella Iseulde Van Dorpe
70430c8076 Emoji: adjust $wpsmiliestrans
Swap simple-smile.png with SLIGHTLY SMILING FACE
and frownie.png with SLIGHTLY FROWNING FACE

Fixes #31710.



git-svn-id: https://develop.svn.wordpress.org/trunk@36336 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-17 22:27:52 +00:00
Pascal Birchler
053733f8c0 Filesystem API: Add a filter to wp_unique_filename().
Props SergeyBiryukov, MikeHansenMe, johnbillion, swissspidy.
Fixes #19121.

git-svn-id: https://develop.svn.wordpress.org/trunk@36310 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-15 09:38:30 +00:00
Joe Hoyle
b9e083e360 Add missing HTTP status code descriptions (specifically 308 and 421.)
Props kraftbj.
Fixes 35336.


git-svn-id: https://develop.svn.wordpress.org/trunk@36274 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-13 02:54:33 +00:00
Joe Hoyle
9a93e87d37 Add support for 451 http status code (Unavailable For Legal Reasons.)
Though this is technically still in the proposal stage, there is support from the core team and precedent in #16914

Props andizer.
Fixes #35333.


git-svn-id: https://develop.svn.wordpress.org/trunk@36273 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-13 02:48:37 +00:00
Pascal Birchler
3a358c33d3 Introduce wp_get_raw_referer() to retrieve unvalidated referer.
For things like redirects `wp_get_referer()` should be used instead.

Props voldemortensen for initial patch.
Fixes #27152.

git-svn-id: https://develop.svn.wordpress.org/trunk@36266 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-12 08:31:10 +00:00
Pascal Birchler
d92ead50c8 Ensure wp_get_referer() returns false when the referrer URL is the current URL.
Adds unit tests.

Fixes #19856.

git-svn-id: https://develop.svn.wordpress.org/trunk@36242 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 14:35:03 +00:00
Sergey Biryukov
27ccbb591c Docs: Clarify that wp_filter_object_list() accepts 'not' as its $operator parameter.
Props barryceelen.
See #35225.

git-svn-id: https://develop.svn.wordpress.org/trunk@36090 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 00:36:12 +00:00
John Blackbourn
858cf7d215 Docs: Miscellaneous docblock code quality tweaks.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36074 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 07:52:04 +00:00
Andrea Fercia
82e5450328 Accessibility: Improvements for the Authentication Check modal dialog "Close X".
Removes the title attribute and uses a `<button>` element instead of a `<div>`.
Also simplifies the CSS and takes care of the hover/focus style.

Fixes #35142.

git-svn-id: https://develop.svn.wordpress.org/trunk@36014 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:50:13 +00:00
Andrea Fercia
e17a5cee94 Authentication modal dialog: the spinner should disappear when loading is done.
Also, when using spinners as background images, the re-painted area should be the
smallest possible one. See similar performance issue in #33311.

Fixes #34951.

git-svn-id: https://develop.svn.wordpress.org/trunk@35925 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 16:39:48 +00:00
Sergey Biryukov
bbce167f29 I18N: In wp_maybe_decline_date(), bail early if translation functions are not available, e.g. in SHORTINIT mode.
Fixes #34967 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@35880 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 01:41:24 +00:00
Sergey Biryukov
bfe32a4d38 I18N: Move translatable Codex URLs to separate strings in wp-includes/functions.php.
Props ramiy.
See #34687.

git-svn-id: https://develop.svn.wordpress.org/trunk@35667 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 17:40:43 +00:00
Sergey Biryukov
7d039b4e40 Replace 7 * DAY_IN_SECONDS with WEEK_IN_SECONDS in get_weekstartend().
Props MikeHansenMe.
Fixes #34603.

git-svn-id: https://develop.svn.wordpress.org/trunk@35556 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-06 16:36:57 +00:00
Sergey Biryukov
8cbd66ca86 Introduce wp_maybe_decline_date() for languages where certain date formats need to be declined, and hook it to the date_i18n filter.
If the locale specifies that month names require a genitive case in certain formats like `'j F Y'` or `'j. F'`, the month name will be replaced with a correct form. 

Fixes #11226.

git-svn-id: https://develop.svn.wordpress.org/trunk@35517 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 21:27:41 +00:00
Andrea Fercia
f25e642086 Accessibility: Improve buttons focus and links style in the install screens.
Fixes #34530.

git-svn-id: https://develop.svn.wordpress.org/trunk@35494 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 17:58:15 +00:00
John Blackbourn
0b05c7aa24 Add wp-post-new-reload to the list of removable query vars so it doesn't persist in the URL.
Fixes #34510


git-svn-id: https://develop.svn.wordpress.org/trunk@35460 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 18:05:31 +00:00
Helen Hou-Sandi
3d64414d5c wp_die(): Update colors and button styling.
see #34388, #31459.


git-svn-id: https://develop.svn.wordpress.org/trunk@35327 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 15:23:01 +00:00
Drew Jaynes
a28e35e462 Filesystem: Following the introduction of the KB|MB|GB|TB_IN_BYTES constants in [35286], use them in various places in core.
Props sudar.
Fixes #22405.


git-svn-id: https://develop.svn.wordpress.org/trunk@35325 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 14:02:59 +00:00
Drew Jaynes
7972ba8126 Media: Introduce the enclosure_links filter, which makes it possible to adjust the list of audio and video enclosure links derived from post content before querying the database.
Props niallkennedy, stevenkword.
Fixes #19890.


git-svn-id: https://develop.svn.wordpress.org/trunk@35288 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 07:08:59 +00:00
Scott Taylor
fdd8106001 Formatting: when making unique filenames in wp_unique_filename() by adding an incrementing number, prefix it with a dash to disambiguate from files that end in numbers.
Updates unit tests.

Props mikejolley, tyxla.
Fixes #21453.


git-svn-id: https://develop.svn.wordpress.org/trunk@35276 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 04:04:26 +00:00
Drew Jaynes
0cb7c0bd9f Docs: Add missing descriptions for the $wpdb global in DocBlocks all the places.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35170 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 23:43:10 +00:00
Sergey Biryukov
4a2184d00c Feeds: Pass the feed name to do_feed_{$feed} action.
Props johnbillion.
See #34259.

git-svn-id: https://develop.svn.wordpress.org/trunk@35115 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 02:43:30 +00:00
Drew Jaynes
681d100fd6 Feeds: Simplify logic for checking if the do_feed_{$feed} action is hooked to any callbacks.
See [35097] for where the aforementioned hook was renamed to actually be dynamic, thus rendering creation of the extra `$hook` variable moot.

See #34264.


git-svn-id: https://develop.svn.wordpress.org/trunk@35098 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:06:26 +00:00
Drew Jaynes
1246590769 Feeds: Adjust the do_feed_{$feed} hook name to actually be dynamic, rather than pre-storing the tag name in a variable and referencing that.
Props johnbillion.
Fixes #34264.


git-svn-id: https://develop.svn.wordpress.org/trunk@35097 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:02:47 +00:00
Sergey Biryukov
34a716709c In number_format_i18n(), check if $wp_locale is set before using it.
Props pauldewouters.
Fixes #31553.

git-svn-id: https://develop.svn.wordpress.org/trunk@35092 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 00:29:18 +00:00
Sergey Biryukov
724b83ab0e In do_robots(), allow crawling for admin-ajax.php, since it's often used on front-end.
Props dmchale, joostdevalk.
Fixes #33156.

git-svn-id: https://develop.svn.wordpress.org/trunk@34985 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-09 05:15:01 +00:00
Ryan McCue
374b39d6ba REST API: Add wp_is_numeric_array helper function
The API uses this to do special operations on list responses (used
for collections), so we need to detect whether an array is
associative or numeric-indexed.

After much discussion, the bikeshed is to be painted green and gold.

See #33982.


git-svn-id: https://develop.svn.wordpress.org/trunk@34927 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 02:13:02 +00:00
Ryan McCue
0f657d21cc REST API: Add JsonSerializable compatibility to wp_json_encode
Following on from r34845, the JsonSerializable shim needs support
on the encoding side too. _wp_json_prepare_data handles this when
we've loaded the shim.

Props chriscct7.

See #33982. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34926 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 01:29:50 +00:00
John Blackbourn
b877e3c692 Add an optional $description parameter to status_header() so custom HTTP status descriptions can be provided.
Fixes #21472
Props nbachiyski, iamfriendly


git-svn-id: https://develop.svn.wordpress.org/trunk@34914 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 21:25:54 +00:00
Jeremy Felt
599fb50e09 Revert [34778], continue using _site_option() for the current network.
The `_network_option()` parameter order will be changing to accept `$network_id` first. The `_site_option()` functions will remain in use throughout core as our way of retrieving a network option for the current network.

See #28290.


git-svn-id: https://develop.svn.wordpress.org/trunk@34912 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 17:11:01 +00:00
Boone Gorges
7cfee3c41d Move wp_installing() to load.php.
Various functions in load.php need to check whether WP is in installation mode.
Let's let them.

Props adamsilverstein.
See #31130.

git-svn-id: https://develop.svn.wordpress.org/trunk@34896 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 03:01:27 +00:00
Scott Taylor
aac08d7735 Introduce wp_get_server_protocol() to DRY protocol parsing logic and make adding more protocols, like HTTP/2, easier.
Props johnbillion, wonderboymusic.
Fixes #34131.


git-svn-id: https://develop.svn.wordpress.org/trunk@34894 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 02:34:58 +00:00
Scott Taylor
5d0718497c REST API: add a utility function, mysql_to_rfc3339() to functions.php
Background:
6d0ad766ca

Props rmmcue.
See #33982.


git-svn-id: https://develop.svn.wordpress.org/trunk@34846 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-06 03:18:45 +00:00
Boone Gorges
578134d4ff Use wp_installing() instead of WP_INSTALLING constant.
The `WP_INSTALLING` constant is a flag that WordPress sets in a number of
places, telling the system that options should be fetched directly from the
database instead of from the cache, that WP should not ping wordpress.org for
updates, that the normal "not installed" checks should be bypassed, and so on.

A constant is generally necessary for this purpose, because the flag is
typically set before the WP bootstrap, meaning that WP functions are not yet
available.  However, it is possible - notably, during `wpmu_create_blog()` -
for the "installing" flag to be set after WP has already loaded. In these
cases, `WP_INSTALLING` would be set for the remainder of the process, since
there's no way to change a constant once it's defined. This, in turn, polluted
later function calls that ought to have been outside the scope of site
creation, particularly the non-caching of option data. The problem was
particularly evident in the case of the automated tests, where `WP_INSTALLING`
was set the first time a site was created, and remained set for the rest of the
suite.

The new `wp_installing()` function allows developers to fetch the current
installation status (when called without any arguments) or to set the
installation status (when called with a boolean `true` or `false`). Use of
the `WP_INSTALLING` constant is still supported; `wp_installing()` will default
to `true` if the constant is defined during the bootstrap.

Props boonebgorges, jeremyfelt.
See #31130.

git-svn-id: https://develop.svn.wordpress.org/trunk@34828 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-05 15:05:26 +00:00
John Blackbourn
96faf97a0f Adjust _default_wp_die_handler() formatting so it doesn't confuse Sublime Text's parsing and syntax highlighting.
Fixes #34135


git-svn-id: https://develop.svn.wordpress.org/trunk@34793 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-03 01:31:26 +00:00
Jeremy Felt
3c177b8c6f MS: Use *_network_option() functions throughout core.
Replaces all uses of `*_site_option()` with the corresponding "network" function.

This excludes one usage in `wp-admin/admin-footer.php` that needs more investigation.

Props spacedmonkey.
See #28290.


git-svn-id: https://develop.svn.wordpress.org/trunk@34778 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-02 19:07:23 +00:00
John Blackbourn
0058018799 Deprecate force_ssl_login(), which is simply a wrapper for force_ssl_admin() and is not used in core.
Fixes #34011


git-svn-id: https://develop.svn.wordpress.org/trunk@34700 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-29 21:27:40 +00:00
John Blackbourn
1bb2876fe6 callback is not a valid type in PHP, PSR-5, or phpDocumentor. callable should be used instead.
Fixes #34032


git-svn-id: https://develop.svn.wordpress.org/trunk@34566 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-25 23:57:46 +00:00
Drew Jaynes
2703af7691 Docs: Clarify the summary and optional $query parameter description for remove_query_arg().
Props johnbillion.
Fixes #33912.


git-svn-id: https://develop.svn.wordpress.org/trunk@34512 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 19:33:07 +00:00
Drew Jaynes
c406171d12 Docs: Overhaul the DocBlock for add_query_arg() to attempt to better explain the various call signatures it accepts.
Also adds a couple of in-DocBlock examples illustrating single key and value, and associative array usage. Retains the note about the unescaped return value.

Props johnbillion.
See #33912.


git-svn-id: https://develop.svn.wordpress.org/trunk@34511 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 19:31:40 +00:00
Scott Taylor
ed7d34cb13 Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload().
Fixes #20523.


git-svn-id: https://develop.svn.wordpress.org/trunk@34348 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 03:51:55 +00:00
Helen Hou-Sandi
3531c0bc10 Superglobals: Revert [34059] until further notice.
see #33837.


git-svn-id: https://develop.svn.wordpress.org/trunk@34265 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 12:32:20 +00:00
Drew Jaynes
8c65cfc7f4 Docs: Add a reminder to the DocBlock description for add_query_arg() mentioning that the output is not escaped by default.
Props brentvr for the initial patch. (first props!)
See #33912. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34264 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 09:38:56 +00:00
Scott Taylor
79656b5fdd Uploader: Fire 'wp_handle_upload' in wp_upload_bits(). Thusly, the filter in wp_xmlrpc_server::mw_newMediaObject() is redundant.
Props dllh.
Fixes #33539.


git-svn-id: https://develop.svn.wordpress.org/trunk@34257 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 04:46:00 +00:00
Scott Taylor
166ee8674b More comment functions can accept a full object instead of comment_ID to reduce cache/db lookups.
See ##33638.



git-svn-id: https://develop.svn.wordpress.org/trunk@34129 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 21:39:46 +00:00
Dion Hulse
9555882e90 When running on windows systems, normalise the capitalisation of the drive letter for more reliable string comparisons.
Props tyxla
Fixes #33265


git-svn-id: https://develop.svn.wordpress.org/trunk@34104 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 01:58:03 +00:00
Scott Taylor
33953cb392 Introduce wp_validate_action( $action = '' ), a helper function that checks $_REQUEST for action and returns it, or empty string if not present. If $action is passed, it checks to make sure they match before returning it, or an empty string. Strings are always returned to avoid returning multiple types.
Implementing this removes 27 uses of direct superglobal access in the admin.

For more reading:
https://codeclimate.com/github/WordPress/WordPress/wp-admin/edit-comments.php

See #33837.


git-svn-id: https://develop.svn.wordpress.org/trunk@34059 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 21:07:45 +00:00
Scott Taylor
9eefbd1999 Deprecate wp_get_http() - function isn't used anywhere (apart from itself).
Props swissspidy.
Fixes #33709.


git-svn-id: https://develop.svn.wordpress.org/trunk@33969 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 04:25:24 +00:00
John Blackbourn
46c336e78a Introduce wp_removable_query_args(), which returns an array of single-use query variables which can be removed from a URL.
Also applies the function to the return URL when the Customizer is closed.

Fixes #32692
Props swissspidy, Mte90


git-svn-id: https://develop.svn.wordpress.org/trunk@33849 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 11:28:11 +00:00
Gary Pendergast
2b67add6dd When wp_json_encode() calls json_encode(), the latter will generate warnings if the string contains non-UTF-8 characters. No-one likes warnings, so we need to do something about that.
The good news is, the point of `wp_json_encode()` is to handle those non-UTF-8 characters. It'll totally just fix them up, no problem.

Anyway, we can just ignore those warnings.

Fixes #33524.



git-svn-id: https://develop.svn.wordpress.org/trunk@33747 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 03:25:15 +00:00
Scott Taylor
3b8c5529cb foreach is a statement, not a function.
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33734 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 20:27:56 +00:00
Drew Jaynes
9bfee68719 Fix inline documentation syntax for a few general-purpose functions and hooks added in 4.3.
* `_deprecated_constructor()` See [32989]
* `deprecated_constructor_trigger_error` See [32989]
* `get_main_network_id()` See [32775]
* `wp_post_preview_js()` See [32809]

See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33226 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 21:34:35 +00:00
Aaron Jorbin
6c8944b6ea Add Deprecated Constructor Function
This function is one that can be called in core to indicate that a PHP4 style constructor is used. PHP4 style constructors are deprecated in PHP7.

Props jorbin, DrewAPicture for docs
See #31982



git-svn-id: https://develop.svn.wordpress.org/trunk@32989 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 14:55:33 +00:00
Scott Taylor
2a5278e2dd Some doc blocks should use bool instead of true|false
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32963 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 00:44:21 +00:00
Drew Jaynes
991237783d Add line-wrapping to a long return description because readability in documentation is important.
See [32797]. See #32421.


git-svn-id: https://develop.svn.wordpress.org/trunk@32810 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 23:17:16 +00:00
Andrew Ozz
7ef6ece222 Editor: do not reuse the preview tab when the user has navigated away.
See #32588.

git-svn-id: https://develop.svn.wordpress.org/trunk@32809 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 23:12:21 +00:00
Scott Taylor
296c559baf if is a statment, not a function.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32800 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 20:00:15 +00:00
Scott Taylor
a4765f9e1b Document the default list of allowed protocols in the doc block for wp_allowed_protocols() and cross-reference in esc_url() and the kses_allowed_protocols filter.
Props GunGeekATX.
Fixes #32421.


git-svn-id: https://develop.svn.wordpress.org/trunk@32797 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 19:44:39 +00:00
Jeremy Felt
7819ac5d16 Introduce get_main_network_id()
Expand on the logic previously available as part of `is_main_network()` and provide a way to obtain the ID of the main network. Most useful in multi-network configurations.

Props @johnjamesjacoby for the initial patch.
Fixes #30294.


git-svn-id: https://develop.svn.wordpress.org/trunk@32775 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 21:44:45 +00:00
Scott Taylor
c8a44d437a Add @static* annotations where they are missing.
Initialize all static vars that are not, most to `null`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32650 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 15:42:40 +00:00
Scott Taylor
531e31b598 Add missing doc blocks to wp-includes/functions.php.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32595 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-25 16:10:59 +00:00
Jeremy Felt
365c82b0c9 s/anbled/enabled/ in global_terms_enabled filter documentation.
Fixes #32436.


git-svn-id: https://develop.svn.wordpress.org/trunk@32513 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 06:34:18 +00:00
John Blackbourn
8bcd566ee0 Add a viewport meta tag to wp_die().
Props leogopal

Fixes #29336


git-svn-id: https://develop.svn.wordpress.org/trunk@32501 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-13 04:07:46 +00:00
Andrew Nacin
df717e8294 Add a comment to maybe_serialize().
git-svn-id: https://develop.svn.wordpress.org/trunk@32458 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 16:26:13 +00:00
Boone Gorges
a4625b51eb Add 'webcal' to the list of URI protocols whitelisted by default.
Fixes #31666.

git-svn-id: https://develop.svn.wordpress.org/trunk@32346 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 00:37:14 +00:00
Sergey Biryukov
51b69b1f7f Fix typo in a comment in wp_guess_url().
props ixkaito.
fixes #32179.

git-svn-id: https://develop.svn.wordpress.org/trunk@32325 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 07:18:35 +00:00
Gary Pendergast
332750a40d Revert [30640], as it was incorrectly checking some filenames.
git-svn-id: https://develop.svn.wordpress.org/trunk@32171 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 06:38:08 +00:00
Dominik Schilling (ocean90)
b0d6757918 Use HTTPS URLs for codex.wordpress.org.
see #27115.

git-svn-id: https://develop.svn.wordpress.org/trunk@32116 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-12 21:28:58 +00:00
Gary Pendergast
b007147ab4 Smilies: One more tweak to matching smilies with emoji.
Props iseulde.

See #31709.



git-svn-id: https://develop.svn.wordpress.org/trunk@32107 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-11 02:16:34 +00:00
Gary Pendergast
1de9bc1670 Smilies: Tweak which smiley matches which emoji.
Props iseulde.

See #31709.



git-svn-id: https://develop.svn.wordpress.org/trunk@32105 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-10 06:29:49 +00:00
Gary Pendergast
3bd66eff61 Smilies: Update our few remaining smilies to better align with Twemoji, and add frownie.png until Twemoji provide a build containing it.
Props joen.

See #31709.



git-svn-id: https://develop.svn.wordpress.org/trunk@32104 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-10 06:19:39 +00:00
Boone Gorges
a143f7f03b Avoid the use of array_replace() in add_query_arg().
`array_replace()` was introduced PHP 5.3+. Instead, we walk the array manually.

See [31966].

Fixes #31306.

git-svn-id: https://develop.svn.wordpress.org/trunk@31967 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 19:39:24 +00:00
Scott Taylor
d1235e323e Respect numerical keys in add_query_arg(), use array_replace() instead of array_merge().
Adds unit test.

Props tyxla.
Fixes #31306.


git-svn-id: https://develop.svn.wordpress.org/trunk@31966 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 19:14:46 +00:00
Drew Jaynes
9cd90a9a10 Clarify the DocBlock summary for wp_scheduled_delete() to mention that it includes posts of any type where the 'trash' status is used.
Props dkotter for the initial patch.
Fixes #31757.


git-svn-id: https://develop.svn.wordpress.org/trunk@31891 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 22:44:26 +00:00
Andrew Ozz
8bbb5869e9 TinyMCE: fix error and PHP warning when adding more than one instance in RTL mode.
Part props maimairel. Fixes #31578.

git-svn-id: https://develop.svn.wordpress.org/trunk@31874 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 20:32:23 +00:00
Gary Pendergast
ae391ec226 Add emoji support, with Twemoji fallback.
Replace exisiting smilies with equivalent emoji, or with shiny new smiley images where no emoji existed.

Props batmoo, joen and mkaz for the original plugin upon which this is based.

Props pento, iseulde, kraftbj and peterwilsoncc for making the internet's dreams come true.

See #31242



git-svn-id: https://develop.svn.wordpress.org/trunk@31733 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-11 22:48:16 +00:00
Drew Jaynes
c2d677a4a4 Add an entry to the changelog for wp_get_mime_types() mentioning that GIMP (xcf) file support was added in 4.2.
See [31578].
Fixes #31146.


git-svn-id: https://develop.svn.wordpress.org/trunk@31590 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-01 07:09:48 +00:00
Scott Taylor
7656a776af Support GIMP files in the Media Library. We already support Photoshop files.
Props MikeHansenMe.
Fixes #31146.


git-svn-id: https://develop.svn.wordpress.org/trunk@31578 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-27 19:46:19 +00:00
Scott Taylor
212d6d8046 Make a new function, wp_delete_file(). Use it.
Props scribu, wonderboymusic.
Fixes #17864.


git-svn-id: https://develop.svn.wordpress.org/trunk@31575 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-27 16:50:14 +00:00
Scott Taylor
79706ee8a8 Don't call the size function count() as part of a test condition in loops. Compute the size beforehand, and not on each iteration.
Scrutinizer added a Performance label: these are the only violations.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31554 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 05:47:53 +00:00
Boone Gorges
0efce8c89c Improve documentation for return value of wp_list_pluck().
`wp_list_pluck()` will preserve the original array keys if no `$index_key`
parameter is provided. This changeset updates the documentation accordingly.

Props adamsilverstein.
Fixes #31316.

git-svn-id: https://develop.svn.wordpress.org/trunk@31451 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-13 16:51:55 +00:00
Scott Taylor
5743898e1e @param cleanup:
* `get_metadata()` will return literally anything, needs to be `mixed`
* `wp()` and `WP_Query::__construct()` no longer just take a query string
* Clarify a few others

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31212 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 19:02:26 +00:00
Drew Jaynes (DrewAPicture)
9b0cf1bd5b Ensure we're using the correct @ignore phpDocumentor tag to mark elements that should be skipped when parsing.
Up to this point, various core elements' DocBlocks incorrectly included an `@internal` tag as a means for skipping the parsing process. When paired with a description (inline or otherwise), `@internal` is a valid tag meant to provide internal-only context, but not necessarily to skip parsing the entire element.

See #30987.


git-svn-id: https://develop.svn.wordpress.org/trunk@31170 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-13 00:50:32 +00:00
Scott Taylor
c3bd2252f5 Use PHP_SAPI constant instead of php_sapi_name() in iis7_supports_permalinks(), wp_fix_server_vars(), and wp_redirect().
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31120 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-10 04:58:49 +00:00
Scott Taylor
6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words.
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:04:40 +00:00
Scott Taylor
8108c0babe PHP keywords and constants "true", "false", "null" should be in lower case - there was one lingering capitalized false in _http_build_query().
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31086 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 06:13:05 +00:00
Gary Pendergast
eb4d356e29 size_format() incorrectly included a trailing space for B values: less than 1024 bytes.
Also add a unit test to check for this, so we don't do it again.

Fixes #30908.

Props tillkruess.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@31052 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-05 13:12:06 +00:00
Scott Taylor
49d19a367a ImageMagick expects TIFF files to have .tiff as an extension, so the key in wp_get_mime_types() should be 'tiff|tif' not 'tif|tiff' so the proper extension is returned in WP_Image_Editor->get_extension() subclass invocations.
Fixes #30211.


git-svn-id: https://develop.svn.wordpress.org/trunk@31044 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-04 03:08:48 +00:00
Scott Taylor
0632a3de68 Improve various @param docs.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30674 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 23:23:37 +00:00
Drew Jaynes (DrewAPicture)
e587324180 Docs Formatting: Backtick-escape inline code for all remaining dynamic hook docs in wp-includes/*.
Affects DocBlocks for the following hooks:
* `auth_post_meta_{$meta_key}`
* `term_links-$taxonomy`
* `customize_render_control_ . $this->id`
* `customize_render_panel_{$this->id}`
* `customize_render_section_{$this->id}`
* `customize_preview_{$this->id}`
* `customize_save_ . $this->id_data[ 'base' ]`
* `customize_update_ . $this->type`
* `customize_value_ . $this->id_data[ 'base' ]`
* `customize_sanitize_js_{$this->id}`
* `comment_form_field_{$name}`
* `comment_{$old_status}_to_{$new_status}`
* `comment_{$new_status}_{$comment->comment_type}`
* `extra_{$context}_headers`
* `get_template_part_{$slug}`
* `get_the_generator_{$type}`
* `get_{$adjacent}_post_join`
* `get_{$adjacent}_post_where`
* `get_{$adjacent}_post_sort`
* `{$adjacent}_post_rel_link`
* `{$adjacent}_post_link`
* `{$adjacent}_image_link`
* `blog_option_{$option}`
* `$permastructname . _rewrite_rules`
* `{$type}_template`
* `theme_mod_{$name}`
* `pre_set_theme_mod_$name`
* `current_theme_supports-{$feature}`
* `get_user_option_{$option}`
* `edit_user_{$field}`
* `pre_user_{$field}`
* `user_{$field}`

See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30656 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 12:09:56 +00:00
Scott Taylor
a411918199 Adjust the RegEx in wp_check_filetype() to be aware that query strings are thing that exist sometimes in URLs.
Adds unit tests.

Props voldemortensen.
Fixes #30377.


git-svn-id: https://develop.svn.wordpress.org/trunk@30640 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 06:32:16 +00:00
Drew Jaynes (DrewAPicture)
f7e01d5331 Improve line-wrapping and formatting in the DocBlock for wp_send_json_error().
See #30469.


git-svn-id: https://develop.svn.wordpress.org/trunk@30614 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-28 11:38:59 +00:00
Drew Jaynes (DrewAPicture)
7bf6ff37e2 4.1 Docs Audit: Ensure optional arguments in wp_json_encode() are properly documented as such.
See #30469.


git-svn-id: https://develop.svn.wordpress.org/trunk@30613 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-28 11:35:39 +00:00
Gary Pendergast
0cb93dd166 When json_encode() returns a JSON string containing 'null' in PHP 5.4 or earlier, wp_json_encode() will now sanity check the data, as older versions of PHP failed to encode non UTF-8 characters correctly, instead returning 'null'.
Fixes #30471.


git-svn-id: https://develop.svn.wordpress.org/trunk@30561 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 05:00:36 +00:00
Drew Jaynes (DrewAPicture)
d93bfdce56 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the description for `_deprecated_argument()`
* Markdown-indent a code snippet in the description for `wp_localize_script()`
* Backtick-escape HTML tags in two parameter descriptions for `wp_register()`
* Various DocBlock formatting in the description for `get_bloginfo()`
* Remove HTML tag from the summary for `_wp_render_title_tag()`
* Backtick-escape a HTML tag in the description for `get_archives_link()`
* Markdown-indent a code snippet in the description for `wp_admin_css_color()`
* Markdown-indent a code snippet in the description for the `welcome_panel` hook

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30541 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:38:44 +00:00
Drew Jaynes (DrewAPicture)
4f331ec1df Improve return description for get_file_data() documentation.
Also convert an incorrect use of `@see` to `@link`.

Props 5um17 for the initial patch.
Fixes #30466.


git-svn-id: https://develop.svn.wordpress.org/trunk@30532 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-23 17:56:14 +00:00
John Blackbourn
3afb2efae4 Update the inline docs for wp_die() to reflect parameter changes made in r30355
See #10551


git-svn-id: https://develop.svn.wordpress.org/trunk@30507 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 17:07:42 +00:00
John Blackbourn
8ea65c3c0d Add support for WP_Error objects passed to wp_send_json_error(). The error object gets output as an array of error codes and messages, rather than as an empty object.
Fixes #28978
Props paulschreiber


git-svn-id: https://develop.svn.wordpress.org/trunk@30506 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 16:55:28 +00:00
Drew Jaynes (DrewAPicture)
aa2c1e6e73 Ensure the mixed type of string|int is reflected on the $title parameter in wp_die().
The ability to pass an error code as short-hand to the `$title` and `$args` parameters was added in r30355. Changes also include cleaned-up formatting and line-wraps for other documentation in the DocBlock.

See [30355]. Fixes #10551.


git-svn-id: https://develop.svn.wordpress.org/trunk@30379 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-18 16:46:36 +00:00
John Blackbourn
4e1e4745ff Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors.
Fixes #10551
Props nacin


git-svn-id: https://develop.svn.wordpress.org/trunk@30356 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 06:15:29 +00:00
John Blackbourn
b68026bbfb Allow the response code to be passed as a shorthand to the $title or $args parameter of wp_die(), for brevity.
See #10551 and #11286
Props nacin


git-svn-id: https://develop.svn.wordpress.org/trunk@30355 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 06:10:58 +00:00
Boone Gorges
2b6df5f8ce Ignore case when checking string 'false' in wp_validate_boolean().
Props TobiasBg, kitchin.
Fixes #30238.

git-svn-id: https://develop.svn.wordpress.org/trunk@30207 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 15:54:42 +00:00
Scott Taylor
2443090c23 Correct the @param type for the $query arg for remove_query_arg().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30191 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:28:47 +00:00
Scott Taylor
5f09d235f0 In _wp_json_convert_string(), when $use_mb is false, perhaps pass a variable that actually exists to wp_check_invalid_utf8().
Introduced in [30055].
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30162 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 21:59:58 +00:00
Drew Jaynes (DrewAPicture)
7cd15026bd Correct references of @uses $wpdb in core documentation to use @global.
See #30191, [30105].
Fixes #30217.


git-svn-id: https://develop.svn.wordpress.org/trunk@30122 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 17:55:39 +00:00
Drew Jaynes (DrewAPicture)
3cc10d77a0 Remove redundant and erroneous @uses tag from most core inline documentation.
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.


git-svn-id: https://develop.svn.wordpress.org/trunk@30105 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 01:04:55 +00:00
Mark Jaquith
42456d35fd Docs and code standards cleanup for [30055] (wp_json_encode() & friends)
fixes #28786
props TobiasBg

git-svn-id: https://develop.svn.wordpress.org/trunk@30078 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 21:28:34 +00:00
Scott Taylor
1e8635fcea Adjust caching for get_term_by() calls:
* Remove md5 hashes for term name cache keys
* Remove the namespace for the keys for `names` and `slugs` and add them to the group names
* Remove `wp_get_last_changed()`, which @nacin hated
 
Props tollmanz.
Fixes #21760.


git-svn-id: https://develop.svn.wordpress.org/trunk@30073 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 21:04:52 +00:00
Gary Pendergast
d871bf86ca Fix a PHPDoc typo for wp_json_encode().
Props JustinSainton.

See #28786.


git-svn-id: https://develop.svn.wordpress.org/trunk@30058 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:53:10 +00:00
Gary Pendergast
0e68ecc0b6 Add wp_json_encode(), a wrapper for json_encode() that ensures everything is converted to UTF-8.
Change all core calls from `json_encode()` to `wp_json_encode()`.

Fixes #28786.



git-svn-id: https://develop.svn.wordpress.org/trunk@30055 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:34:16 +00:00
Scott Taylor
0d58d32462 Cache get_term_by() calls:
* Add a helper function, `wp_get_last_changed()`, to retrieve a last-modified timestamp by cache group
* When caching a term, also make cache entries for slug and name via `slug:{$term_id}` and `name:{$term_id}` keys in the `$taxonomy:$last_changed` bucket that reference the term_id
* In `clean_term_cache()` and `update_term_cache()`, respect `$_wp_suspend_cache_invalidation`
* Original term cache entries maintain BC

Adds unit tests.

Props wonderboymusic, tollmanz, boonebgorges.
Fixes #21760.


git-svn-id: https://develop.svn.wordpress.org/trunk@29915 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 04:44:13 +00:00
Scott Taylor
07a38ff81a Allow PSDs (Photoshop documents) to be uploaded.
Props michalzuber, ccprice.
Fixes #28805.


git-svn-id: https://develop.svn.wordpress.org/trunk@29833 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 19:51:56 +00:00
Mark Jaquith
7063377539 Use HTTPS URLs for core.trac.wordpress.org
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29788 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 13:27:55 +00:00
Scott Taylor
f00f28cce0 wp_extract_urls() needs to also grab URLs with query strings and hashes.
Updates unit test.

Props hauvong, dlh.
Fixes #29314.


git-svn-id: https://develop.svn.wordpress.org/trunk@29756 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 02:49:22 +00:00
Scott Taylor
91517ce620 Clarify that get_the_date(), get_the_time(), get_post_time() and get_post_modified_time() should return false when get_post() is null.
Adds unit tests.

Props GaryJ, SergeyBiryukov, tollmanz.
Fixes #28310.


git-svn-id: https://develop.svn.wordpress.org/trunk@29344 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 18:39:22 +00:00
Sergey Biryukov
6be5fc19b3 Make sure phpinfo() is not disabled before calling it in apache_mod_loaded().
props rohan013, harmr.
fixes #26772.

git-svn-id: https://develop.svn.wordpress.org/trunk@29330 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-30 17:27:54 +00:00
Dominik Schilling (ocean90)
080f52ceb9 Revert [28894] as it's currently unused in core.
see #28487.

git-svn-id: https://develop.svn.wordpress.org/trunk@29309 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 17:15:22 +00:00
Drew Jaynes (DrewAPicture)
551f829c55 Inline documentation cleanup for 4.0 audit.
Various improvements:
* Adds `@see` reference for `wp_list_comments()` in 'wp_list_comments_args' filter docs, added in [28285]
* Various phpDoc tweaks for the 'run_wptexturize' filter docs, added in [28715]
* Sentence and wrapping changes for `is_https_url()`, added in [28894]
* Documents the `$args` parameter for `wp_dropdown_languages()`, added in [29007]
* Adds a period to the parameter description for `_update_posts_count_on_delete()`, added in [28835]
* Documents a global in `is_customize_preview()`, added in [28999]
* phpDoc tweaks, adds an access modifier for `wpdb::esc_like()`, added in [28711]

See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29163 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 01:01:22 +00:00
Drew Jaynes (DrewAPicture)
0be40edabc Fix inconsistent language in two function descriptions in wp-includes/functions.php.
Also adds correct coding standards to a code sample in `_deprecated_argument()`.

Props TobiasBg.
Fixes #26185.


git-svn-id: https://develop.svn.wordpress.org/trunk@29013 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-07 07:07:17 +00:00
Drew Jaynes (DrewAPicture)
2a07fc794e General inline documentation improvements in wp-includes/functions.php.
Final run. Fixes #26185.


git-svn-id: https://develop.svn.wordpress.org/trunk@29011 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-07 06:18:05 +00:00
Sergey Biryukov
fd4ad167b2 Some fixes for get_weekstartend() docs.
see #26185.

git-svn-id: https://develop.svn.wordpress.org/trunk@28937 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 14:58:37 +00:00
Drew Jaynes (DrewAPicture)
ecb39eaccb General inline documentation improvements in wp-includes/functions.php.
Second run. See #26185.


git-svn-id: https://develop.svn.wordpress.org/trunk@28936 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 01:43:48 +00:00
Sergey Biryukov
4114ff052f Remove free-spacing modifier and extra spaces from wp_extract_urls() pattern.
fixes #28222.

git-svn-id: https://develop.svn.wordpress.org/trunk@28933 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 23:08:48 +00:00
Drew Jaynes (DrewAPicture)
99faddd819 General inline documentation improvements in wp-includes/functions.php.
First run. See #26185.


git-svn-id: https://develop.svn.wordpress.org/trunk@28918 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 03:55:03 +00:00
Drew Jaynes (DrewAPicture)
0c8b5722d2 Improve inline documentation for date_i18n(), _http_build_query(), wp_checkdate(), and wp_auth_check().
Props morganestes.
See #26185.


git-svn-id: https://develop.svn.wordpress.org/trunk@28917 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 03:46:22 +00:00
Andrew Nacin
02094174f9 Add index key support for wp_list_pluck(), à la array_column().
props trepmal.
fixes #28666.


git-svn-id: https://develop.svn.wordpress.org/trunk@28900 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 21:25:21 +00:00
John Blackbourn
3c77cf1140 Introduce is_https_url() for testing whether the scheme for a given URL is https. See #28487.
git-svn-id: https://develop.svn.wordpress.org/trunk@28894 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 11:31:25 +00:00
Scott Taylor
56e66c79b4 wp_extract_urls() should not match dates.
Updates unit tests.

Props hinnerk, sergej.mueller.
Fixes #28222.


git-svn-id: https://develop.svn.wordpress.org/trunk@28882 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 04:15:30 +00:00
Scott Taylor
782bd3ee67 Do not touch absint(). Reverts [28855].
git-svn-id: https://develop.svn.wordpress.org/trunk@28858 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 18:44:45 +00:00
Scott Taylor
8ec1723e03 Revert [28856] at nacin's behest. See #23383.
git-svn-id: https://develop.svn.wordpress.org/trunk@28857 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 18:33:50 +00:00
Scott Taylor
ce6de601e3 absint() should always return PHP_INT_MAX if the resulting value exceeds it.
See [28855].
Fixes #23383.


git-svn-id: https://develop.svn.wordpress.org/trunk@28856 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 18:23:51 +00:00
Scott Taylor
df04529010 Add a second optional parameter to absint() to limit the result to PHP_INT_MAX.
See #23383.


git-svn-id: https://develop.svn.wordpress.org/trunk@28855 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 17:51:52 +00:00
Scott Taylor
6d924f9d53 Add mime support for 3gp, 3g2 and 3gpp video formats. These are not supported by MediaElement or the WP media shortcodes, just an FYI.
Props azaozz, m_uysl.
Fixes #23380.


git-svn-id: https://develop.svn.wordpress.org/trunk@28841 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 01:42:54 +00:00
Sergey Biryukov
2120ede170 Remove mbstring_binary_safe_strlen(). Use mbstring_binary_safe_encoding() and reset_mbstring_encoding() directly.
fixes #28162.

git-svn-id: https://develop.svn.wordpress.org/trunk@28808 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 22:20:23 +00:00
Sergey Biryukov
4fd715c937 Introduce a binary-safe wrapper for strlen() and use it in seems_utf8(), utf8_uri_encode(), and wp_read_image_metadata().
Use binary-safe POMO_Reader::strlen() in MO::export_to_file_handle().

fixes #28162.

git-svn-id: https://develop.svn.wordpress.org/trunk@28806 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 14:47:08 +00:00
Andrew Nacin
c45a47efdd Stop denying wp-includes/* in our default robots.txt.
props joostdevalk.
fixes #28604.


git-svn-id: https://develop.svn.wordpress.org/trunk@28794 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 21:01:29 +00:00
Scott Taylor
db7816dd0c smilies_init(), treat &nbsp; like whitespace when converting smilies.
Adds unit tests.

Props miqrogroove.
Fixes #27587.


git-svn-id: https://develop.svn.wordpress.org/trunk@28717 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 02:02:23 +00:00
Scott Taylor
84ad12b439 Replace all uses of like_escape() with $wpdb->esc_like().
Props miqrogroove.
See #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28712 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 00:43:32 +00:00
John Blackbourn
7a220d7e95 Deprecate url_is_accessable_via_ssl(). Fixes #19555. Props jgadbois.
git-svn-id: https://develop.svn.wordpress.org/trunk@28709 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-09 22:02:50 +00:00
Sergey Biryukov
d4b336ded2 Fix typo in mbstring_binary_safe_encoding() description.
props ghost1227.
fixes #28423.

git-svn-id: https://develop.svn.wordpress.org/trunk@28648 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-01 05:05:44 +00:00
Scott Taylor
de685a9f73 Move default to the bottom in _wp_mysql_week().
See #28409.


git-svn-id: https://develop.svn.wordpress.org/trunk@28634 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 18:09:43 +00:00
Scott Taylor
2cd825a21b Cleanup for switch statements:
* Move `default` to the bottom in `WP_Theme_Install_List_Table`
* `switch/endswitch` syntax is not supported in Hack. Switch to `switch (...) {  .... }` syntax. (A few template-type instances linger).

Fixes #28409.
See #27881.



git-svn-id: https://develop.svn.wordpress.org/trunk@28633 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 17:57:51 +00:00
Andrew Nacin
961459ee31 Forcing SSL logins now forces SSL for the entire admin, with no middle ground.
fixes #10267.


git-svn-id: https://develop.svn.wordpress.org/trunk@28609 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 03:58:41 +00:00
Sergey Biryukov
a25a5de409 Update documentation for is_new_day().
props obenland.
fixes #28333.

git-svn-id: https://develop.svn.wordpress.org/trunk@28588 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 11:40:11 +00:00
Scott Taylor
d6f1c4f904 Because PHP can be configured without --filter, it is not 100% safe to use filter_var(). This is problematic for casting "false" to false, as PHP always casts it to true. FILTER_VALIDATE_BOOLEAN fixes this, but it may not be available.
Add a new function, `wp_validate_boolean()`, to replace `filter_var( $var, FILTER_VALIDATE_BOOLEAN )`.

Fixes #28170.



git-svn-id: https://develop.svn.wordpress.org/trunk@28542 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 18:33:34 +00:00
Scott Taylor
bb4ea7ae3f Eliminate the use of extract() in wp_check_filetype_and_ext().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28426 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 06:21:51 +00:00
Scott Taylor
961f52d367 Add xps and oxps extensions to list of supported document types.
More: http://en.wikipedia.org/wiki/Open_XML_Paper_Specification

Fixes #15697.



git-svn-id: https://develop.svn.wordpress.org/trunk@28372 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 07:18:06 +00:00
Scott Taylor
ef5998eabb In wp-includes/functions.php, remove dead code:
* In `current_time()`, `break` is unreachable after `return`.
* In `add_query_arg()`, `$ret` is set twice before being used.
* In `wp_mkdir_p()`, `$dir_perms` is set twice before being used.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28325 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:22:22 +00:00
Scott Taylor
2b1619329e Add .dfxp and .srt files to mime-type whitelist in wp_get_mime_types(). They are both captioning formats supported by MediaElement.
Props joedolson.
Fixes #27643.



git-svn-id: https://develop.svn.wordpress.org/trunk@28259 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 20:07:53 +00:00
Sergey Biryukov
b9834e8275 Correct @return value for current_time().
props arnee.
fixes #27940.

git-svn-id: https://develop.svn.wordpress.org/trunk@28240 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-02 11:24:23 +00:00
Drew Jaynes (DrewAPicture)
11f2a0dc31 Inline documentation for hooks in wp-includes/functions.php.
Props jesin, GaryJ.
Fixes #27715.


git-svn-id: https://develop.svn.wordpress.org/trunk@28109 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-14 00:19:37 +00:00
Andrew Ozz
3396375d47 RTL for TinyMCE:
- Add _dir: 'rtl' to the TinyMCE translation object.
- Fix editor.css for RTL.
- Fix the Edit and Delete buttons position for wpview and images.
- For _mce_set_direction(), update documentation and fix adding the 'ltr' button.
Fixes #27773

git-svn-id: https://develop.svn.wordpress.org/trunk@28094 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 00:22:56 +00:00
Dominik Schilling (ocean90)
64f5807b32 Adjust colors in wp_die() and install.css.
Missed in [26788] and [26837], see #25858.
fixes #27589.

git-svn-id: https://develop.svn.wordpress.org/trunk@27855 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 23:05:12 +00:00
Andrew Nacin
b6195eb82a In is_serialized(), use substr() rather than array access, for compatibility with multibyte overloading.
props SergeyBiryukov.
fixes #18007.


git-svn-id: https://develop.svn.wordpress.org/trunk@27565 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 20:08:25 +00:00
Scott Taylor
d39e5ecafd Video editing in the media modal:
* Add a state: `Add Subititles`
* Add `text/vtt` to the list of allowed mime-types, files end in `.vtt`. `.srt` files are served as `text/plain`.
* The content body of a video shortcode should be used for adding `<track>` elements only. This happens dynamically in the modal. If added by hand, they can still be parsed and managed.

See #27016.



git-svn-id: https://develop.svn.wordpress.org/trunk@27481 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-09 10:31:36 +00:00
John Blackbourn
f00a18712f Update the list of HTTP status code descriptions. Fixes #16914. Props sirzooro and hakre for the original patches.
git-svn-id: https://develop.svn.wordpress.org/trunk@27422 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-05 22:00:29 +00:00
Andrew Nacin
8a617607a7 Strip backslashes, not just forward slashes, from untrailingslashit().
trailingslashit() will now remove any forward or backslashes from the end of a string before appending a forward slash.

props knutsp, willmot.
fixes #22267.


git-svn-id: https://develop.svn.wordpress.org/trunk@27344 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-01 21:44:43 +00:00
Andrew Nacin
ef8c2d0020 Keep redirect_to when hitting the log out AYS.
props mitchoyoshitaka for initial patch.
fixes #17398.


git-svn-id: https://develop.svn.wordpress.org/trunk@27272 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-25 20:01:36 +00:00
Drew Jaynes
647f80595d Remove all @package and @subpackage PHPDoc tags not at the file- or class-levels in core.
See #27200.


git-svn-id: https://develop.svn.wordpress.org/trunk@27262 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-25 17:13:08 +00:00
Andrew Nacin
1916576840 Allow current_time() to accept a date format string, adding to 'timestamp' and 'mysql'.
props danielbachhuber.
fixes #21653.


git-svn-id: https://develop.svn.wordpress.org/trunk@27259 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-25 17:00:36 +00:00
Andrew Nacin
b7be4e98fe Detect and handle symlinking of plugins in plugin_basename().
props rmccue, MikeSchinkel, jdgrimes.
see #16953.


git-svn-id: https://develop.svn.wordpress.org/trunk@27158 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-10 22:59:40 +00:00
Andrew Ozz
4951bdc964 Remove unused arg from wp_auth_check(), see #27081.
git-svn-id: https://develop.svn.wordpress.org/trunk@27154 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 22:33:56 +00:00
Dominik Schilling (ocean90)
d58d7e8158 Update @return statement of wp_nonce_url(): The URL is escaped.
props c3mdigital.
see #4221.

git-svn-id: https://develop.svn.wordpress.org/trunk@27070 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 10:52:33 +00:00
Scott Taylor
62b57d8899 In wpdb::db_connect(), allow the loading of a custom database error template - this is already allowed in dead_db().
In `dead_db()`, move the call to `wp_load_translations_early()` before the inclusion of the `db-error.php` file to allow translation in both locations before the template is loaded.

Props sbruner, kovshenin.
Fixes #25703.



git-svn-id: https://develop.svn.wordpress.org/trunk@27056 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-29 05:27:24 +00:00
Dion Hulse
3428afee5a Uploads: Fix the Order of Operations for wp_mkdir_p() which caused this branch to never be hit. Props fboender. Fixes #26781 for trunk. See #25822
git-svn-id: https://develop.svn.wordpress.org/trunk@26926 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-08 23:12:37 +00:00
Ryan Boren
cfd5c395bb The Pinking Shears stir from their slumber, awakened by what may seem, to those
innocent in the ways of The Shears, a triviality, a nothing-of-consequence. But there are consequences indeed for recklessly trailing your whitespace. Naturally, they a dire!

One, two! One, two! And through and through
The Pinking Shears went snicker-snack!
They plucked your tail and with your space
They went sniksnuking back.

Let me tell you, that can be uncomfortable, so always pre-sniksnuk your trailing whites. May The Shears be with you.


git-svn-id: https://develop.svn.wordpress.org/trunk@26851 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-11 19:48:29 +00:00
Dion Hulse
22738bc3d5 Remove the experimental RSS.JS feed, and move it to a plugin for feature development. Unprops pento. See #25639
git-svn-id: https://develop.svn.wordpress.org/trunk@26644 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-04 22:23:02 +00:00
Dion Hulse
d3e135b888 Fix a regression in wp_mkdir_p() where the $mode of the parent folder is not correctly applied to all created paths. Fixes #25822 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@26449 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-28 02:19:24 +00:00
Matt Thomas
ec65012ce7 Update error screens with the new visual design:
* Bring in new styles for backgrounds/text/link/borders/buttons
* Switch to device-width for the viewport and tweak margins etc so the layout works nicely on all device sizes

Fixes #25956, props johnbillion.



git-svn-id: https://develop.svn.wordpress.org/trunk@26299 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-21 00:24:23 +00:00
Andrew Nacin
555703dff2 Add an experimental rssjs feed based on the experimental rss.js spec.
This is simply a JSON representation of the RSS 2.0 feed, accessible at /feed/rssjs/ anywhere.

props pento.
see #25639.


git-svn-id: https://develop.svn.wordpress.org/trunk@26294 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-20 22:57:09 +00:00
Sergey Biryukov
2e52eeb484 Use get_current_site() instead of the $current_site global in wp-admin/admin-header.php and is_main_network().
fixes #25158.

git-svn-id: https://develop.svn.wordpress.org/trunk@26235 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-16 13:45:28 +00:00
Scott Taylor
15c1c2f130 Don't place smilies inside of pre or code tags. Don't skip smilie after a smilie with an 8 in it. Fix regular expression used for smiley translations to work when there is only one registered emoticon.
Props solarissmoke, soulseekah, mdbitz, yonasy. ht to mdbitz for the Unit Tests and a comprehensive patch.
Fixes #16448, #20124, #25303.



git-svn-id: https://develop.svn.wordpress.org/trunk@26191 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-15 02:45:39 +00:00
Dion Hulse
24c2774076 Fix a case where wp_guess_url() would leave a prefixed path in the generated URL when symlinks were involved. Fixes #25797
git-svn-id: https://develop.svn.wordpress.org/trunk@26031 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-07 03:33:11 +00:00
Sergey Biryukov
3d26edf1fe Remove irrelevant @see references. props mt8.biz. fixes #25843.
git-svn-id: https://develop.svn.wordpress.org/trunk@26022 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 10:16:55 +00:00
Sergey Biryukov
a1fe0926b3 Remove incorrect @return value from status_header(). Rename some variables for clarity.
props tivnet for initial patch.
fixes #25451.

git-svn-id: https://develop.svn.wordpress.org/trunk@25990 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 22:43:08 +00:00
Andrew Nacin
3c067c1ec2 Avoid a notice in is_main_network() when called in single site. see #25030.
git-svn-id: https://develop.svn.wordpress.org/trunk@25827 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 05:16:41 +00:00
Sergey Biryukov
a541f2e31e Correct phpdoc for wp_check_filetype_and_ext(). props dimadin. fixes #25513.
git-svn-id: https://develop.svn.wordpress.org/trunk@25713 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-07 15:33:19 +00:00
Andrew Nacin
cff3bb14e6 Order search results by relevance, rather than by date.
The ordering logic is as follows:
 * Full sentence matches in post titles.
 * All search terms in post titles.
 * Any search terms in post titles.
 * Full sentence matches in post content.

Each section and any remaining posts are then sorted by date.

Introduces some filters:
 * wp_search_stopwords, to filter stop words ignored in WHERE.
 * posts_search_orderby, to filter the ORDER BY when ordering search results.

props azaozz, wonderboymusic.
fixes #7394.


git-svn-id: https://develop.svn.wordpress.org/trunk@25632 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-27 17:33:36 +00:00
Dominik Schilling (ocean90)
1de9497eef Add 'image' type/extensions to wp_ext2type() and make it case insensitive. props xparham. fixes #25176.
git-svn-id: https://develop.svn.wordpress.org/trunk@25437 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-14 14:33:19 +00:00
Dion Hulse
87e014a245 Account for Windows and CLI instances in wp_guess_url(). Props SergeyBiryukov. See #25317
git-svn-id: https://develop.svn.wordpress.org/trunk@25436 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-14 03:42:38 +00:00
Andrew Nacin
1851da1382 Return false from wp_get_original_referer() if it is called before wp_validate_redirect() is defined.
see #25294.


git-svn-id: https://develop.svn.wordpress.org/trunk@25400 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 13:35:35 +00:00
Andrew Nacin
cc5477c7d9 Return false from wp_get_referer() if it is called before wp_validate_redirect() is defined.
see #25294.


git-svn-id: https://develop.svn.wordpress.org/trunk@25399 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 13:32:41 +00:00
Dion Hulse
cccac649d5 Fix wp_guess_url() to work in every scenario I could find, allows us to use it to determine the correct path to the WordPress Site URL before installation for install.php and setup-config.php redirects. Fixes #24480 Fixes #16884
git-svn-id: https://develop.svn.wordpress.org/trunk@25396 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 06:56:20 +00:00
Helen Hou-Sandi
f1ef5c0e23 Indicate that the fall-through in is_serialized() is deliberate. fixes #24023.
git-svn-id: https://develop.svn.wordpress.org/trunk@25371 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 03:40:25 +00:00
Dion Hulse
052d276215 Add a set of helpers to turn the behaviour of mbstring.func_overload off when needed. Fixes #25259
git-svn-id: https://develop.svn.wordpress.org/trunk@25346 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 07:22:05 +00:00
Andrew Nacin
a1470e6161 Avoid error in ms-files.php after [25317].
git-svn-id: https://develop.svn.wordpress.org/trunk@25344 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 04:48:43 +00:00
Andrew Nacin
3b314a0adf Improve clarity and speed of [25320].
git-svn-id: https://develop.svn.wordpress.org/trunk@25338 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 03:22:09 +00:00
Scott Taylor
a963ab0852 Remove dead code in add_query_arg().
Props hakre, c3mdigital.
Fixes #16942.



git-svn-id: https://develop.svn.wordpress.org/trunk@25333 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 23:37:23 +00:00
Andrew Nacin
9d7689c4ba Loose validation for is_serialized() in maybe_serialize().
git-svn-id: https://develop.svn.wordpress.org/trunk@25320 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:09:36 +00:00
Andrew Nacin
ac3361e997 Validate referrers to prevent off-domain redirects.
git-svn-id: https://develop.svn.wordpress.org/trunk@25318 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:06:43 +00:00
Andrew Nacin
31482a7968 Tighten allowed upload file types.
git-svn-id: https://develop.svn.wordpress.org/trunk@25317 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:03:26 +00:00
Scott Taylor
5a75531f19 Replace the ancient phpfreaks.com RegEx to extract urls to ping with a more robust matcher. URLs with commas and things like &amp; were not being pinged. The new matcher even works for most IDN URLs. Adds unit tests.
Fixes #9064.



git-svn-id: https://develop.svn.wordpress.org/trunk@25313 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 03:17:51 +00:00
Andrew Nacin
ee2baada7b Be less verbose when erroring out in do_feed() for an invalid feed template. fixes #24874.
git-svn-id: https://develop.svn.wordpress.org/trunk@25190 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-30 23:36:58 +00:00
Andrew Nacin
022e5c2227 The main site of a secondary network should not use the original wp-content/uploads upload path.
props jeremyfelt.
fixes #25030.


git-svn-id: https://develop.svn.wordpress.org/trunk@25148 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 03:35:44 +00:00
Andrew Nacin
dc0d29b59b Introduce is_main_network().
By default, a network ID of 1 is assumed to be the main network.
Otherwise, it is the first network listed in the wp_site table.

If PRIMARY_NETWORK_ID is defined, it is considered main network.

props jeremyfelt.
see #25030.


git-svn-id: https://develop.svn.wordpress.org/trunk@25147 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 03:34:50 +00:00
Sergey Biryukov
d6ea70e296 Add description for _wp_timezone_choice_usort_callback(). props neoxx. fixes #25125.
git-svn-id: https://develop.svn.wordpress.org/trunk@25101 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-23 13:56:35 +00:00
Dion Hulse
cd9e0814e6 Make use of the recursive option in mkdir() in wp_mkdir_p(). Avoids a bunch of silenced PHP Notices being logged. Fixes #23196
git-svn-id: https://develop.svn.wordpress.org/trunk@25047 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-17 03:08:50 +00:00
Andrew Nacin
9aa5512e94 Add a function to return an empty string, for filters. props wpsmith, trepmal. fixes #20357.
git-svn-id: https://develop.svn.wordpress.org/trunk@25037 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-16 20:01:06 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00