Commit Graph

197 Commits

Author SHA1 Message Date
Joe Dolson
32ba91e6f5 Administration: Switch order of label/checkbox in WP_List_Table.
Move the label after the checkbox in `WP_List_Table` instances. Resolve a false positive that will be presented by automated accessibility testing tools. Follow up to [55954].

Props dimitrism, joedolson, sabernhardt, oglekler, marybaum, tobiasbg.
Fixes #58703.

git-svn-id: https://develop.svn.wordpress.org/trunk@56665 602fd350-edb4-49c9-b593-d223f7449a82
2023-09-22 19:56:48 +00:00
Joe Dolson
f058bd1217 Administration: Use wp_admin_notice() more in wp-admin/.
Add additional usage of `wp_admin_notice()` in `wp-admin/` on `.error` and miscellaneous usages previously overlooked. 

Follow up to [56408], [56409], [56410], [56518], [56570], [56571], [56572], [56573], [56576], [56589], [56590], [56597], [56599].

Props costdev, joedolson.
See #57791.

git-svn-id: https://develop.svn.wordpress.org/trunk@56600 602fd350-edb4-49c9-b593-d223f7449a82
2023-09-17 15:31:32 +00:00
Joe Dolson
3cefc7c7ff Administration: Use wp_admin_notice() in /wp-admin/.
Add usages of `wp_admin_notice()` and `wp_get_admin_notice()` on `.notice-[type]` in the root level of `/wp-admin/`. Ongoing task to implement new function across core.

Props costdev, joedolson.
See #57791.

git-svn-id: https://develop.svn.wordpress.org/trunk@56570 602fd350-edb4-49c9-b593-d223f7449a82
2023-09-14 00:52:45 +00:00
Sergey Biryukov
1118e37f48 Coding Standards: Remove superfluous blank lines at the end of various functions.
Note: This is enforced by WPCS 3.0.0.

Follow-up to [56536], [56547].

Props jrf.
See #59161, #58831.

git-svn-id: https://develop.svn.wordpress.org/trunk@56548 602fd350-edb4-49c9-b593-d223f7449a82
2023-09-08 10:01:14 +00:00
Sergey Biryukov
36fe58a8c6 Upgrade/Install: Remove unused globals in core_upgrade_preamble().
Follow-up to [49638].

Props upadalavipul.
See #59254.

git-svn-id: https://develop.svn.wordpress.org/trunk@56505 602fd350-edb4-49c9-b593-d223f7449a82
2023-09-01 11:05:32 +00:00
joedolson
1db31132eb Menus: Revert unintentional changes in [56449].
Accidentally committed two simultaneous patches; reverting unintended list table changes.

Unprops joedolson.
See #56594.

git-svn-id: https://develop.svn.wordpress.org/trunk@56450 602fd350-edb4-49c9-b593-d223f7449a82
2023-08-24 16:12:01 +00:00
Joe Dolson
b21d72b39d Menus: Fix proximity of controls to Save and Delete menus.
Move the position of the Save and Delete buttons in menu editing so they are immediate neighbors, improving the proximity of related controls. 

Props 90lines, sabernhardt, costdev.
See #56594.

git-svn-id: https://develop.svn.wordpress.org/trunk@56449 602fd350-edb4-49c9-b593-d223f7449a82
2023-08-24 15:56:34 +00:00
Andrew Ozz
9f80bbceeb Help/About: Fix typo in [56171]: support forum "topic", not "ticket".
Props: tobifjellner.
Fixes: #58199.

git-svn-id: https://develop.svn.wordpress.org/trunk@56237 602fd350-edb4-49c9-b593-d223f7449a82
2023-07-14 22:09:51 +00:00
Jb Audras
05fd462d1c Docs: Replace multiple single line comments with multi-line comments.
This changeset updates various comments as per WordPress PHP Inline Documentation Standards.
See https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#5-inline-comments.

Follow-up to [56174].

Props costdev, audrasjb.
See #58459.




git-svn-id: https://develop.svn.wordpress.org/trunk@56175 602fd350-edb4-49c9-b593-d223f7449a82
2023-07-09 19:54:42 +00:00
Jb Audras
890f982250 Help/About: Add Help text for Rollback feature.
This changeset adds a new Help text for Rollback feature in the WordPress Updates screen. Also adds a link to the "Common Errors" HelpHub documentation page.

Follow-up to [51857].

Props costdev, afragen, audrasjb, kebbet, marybaum.
Fixes #58199.




git-svn-id: https://develop.svn.wordpress.org/trunk@56171 602fd350-edb4-49c9-b593-d223f7449a82
2023-07-09 14:47:22 +00:00
Jb Audras
b58eebb2a5 Upgrade/Install: Only show errors if there is nothing to update.
Previously, when the `do-plugin-upgrade` or `do-theme-upgrade` actions were accessed directly on `update-core.php`, an error message stating "Select one or 
more (plugins|themes) to update" would be shown even if there was nothing to update.

This ensures that the error message only appears when there is something to update.

Props Presskopp, sabernhardt, pbiron, afragen, zunaid321, shuvoaftab, ugyensupport, costdev.
Fixes #57999.




git-svn-id: https://develop.svn.wordpress.org/trunk@56107 602fd350-edb4-49c9-b593-d223f7449a82
2023-06-29 07:19:04 +00:00
Jb Audras
3a340b69ca Upgrade/Install: Move location of $upgrade_notice for better consistency.
Since the `$auto_upgrade_notice` has been added to the `update-core.php` table listing if an `$upgrade_notice` is present by virtue of the `readme.txt` 
containing data in the `== Upgrade Notice ==` section, this text will appear in between the compatibility information and the auto update information.

This changeset provides a more consistent appearance in the interface.

Props afragen, costdev, zunaid321.
Fixes #57939.




git-svn-id: https://develop.svn.wordpress.org/trunk@56001 602fd350-edb4-49c9-b593-d223f7449a82
2023-06-23 15:01:28 +00:00
Joe Dolson
0b6911113b Administration: Make checkbox column clickable.
Change the `label` for `.check-column` inside list tables to a block filling the entire cell. Improves accessibility by increasing the target area for the control.

Props mitchoyoshitaka, lessbloat, sabernhardt, ogleker, tacoverdo, joostdevalk, karmatosed.

Fixes #21516.

git-svn-id: https://develop.svn.wordpress.org/trunk@55954 602fd350-edb4-49c9-b593-d223f7449a82
2023-06-21 01:52:16 +00:00
Jb Audras
6837a90e49 Docs: Use third-person singular verbs in various function descriptions, as per docblocks standards.
Follow-up to [55911], [55916].

Props costdev.
See #57840.




git-svn-id: https://develop.svn.wordpress.org/trunk@55917 602fd350-edb4-49c9-b593-d223f7449a82
2023-06-14 14:06:03 +00:00
Sergey Biryukov
a10e2bcf05 Docs: Fix a few more typos in inline comments.
Follow-up to [9117], [11005], [12097], [18632], [26192], [55823].

Props Presskopp.
See #58334, #57840.

git-svn-id: https://develop.svn.wordpress.org/trunk@55824 602fd350-edb4-49c9-b593-d223f7449a82
2023-05-18 12:34:22 +00:00
Jb Audras
abc6873057 Help/About: Use the new /documentation/ URLs for links about WordPress version.
As `https://wordpress.org/support/` was redirected to `https://wordpress.org/documentation/`, this changeset replaces various `/support/*` links with `/documentation/*` to avoid extra redirects. This addresses a missed occurrence from [55624].

Follow-up to [55412], [55413], [55414], [55624].

Props wildworks.
See #58052, #57726.


git-svn-id: https://develop.svn.wordpress.org/trunk@55625 602fd350-edb4-49c9-b593-d223f7449a82
2023-04-04 22:41:27 +00:00
Jb Audras
0a422d3f4b Help/About: Use the new /documentation/ URLs for HelpHub links in WordPress Admin.
As `https://wordpress.org/support/` was redirected to `https://wordpress.org/documentation/`, this changeset replaces various `/support/article/*` links with `/documentation/article/*` to avoid an extra redirect.

This also updates links to Support Forums by replacing `https://wordpress.org/support/` URLs with `https://wordpress.org/support/forums/`.

Props SergeyBiryukov, audrasjb, dhrupo, hasanmisbah, sakibmd, sabernhardt.
See #57726.


git-svn-id: https://develop.svn.wordpress.org/trunk@55412 602fd350-edb4-49c9-b593-d223f7449a82
2023-02-23 10:36:33 +00:00
Sergey Biryukov
6d7430cfe1 I18N: Mark screen reader strings as such with translator comments.
This aims to provide better context for translators and make it easier to determine that some strings contain hidden accessibility text and are not displayed in the UI.

Props kebbet, mercime, pavelevap, ocean90, swissspidy, Chouby, jipmoors, afercia, desrosj, costdev, audrasjb, SergeyBiryukov.
Fixes #29748.

git-svn-id: https://develop.svn.wordpress.org/trunk@55276 602fd350-edb4-49c9-b593-d223f7449a82
2023-02-07 17:08:26 +00:00
Jb Audras
a2485d0e8b Coding Standards: Use consistent markup for line break tags on update-core.php.
This changeset replaces <br/> with <br /> on various places, as per WordPress Coding Standards.
See https://developer.wordpress.org/coding-standards/wordpress-coding-standards/html/#self-closing-elements

Follow-up to [54062].

Props rajanpanchal2028, alberuni-azad, sabernhardt.
Fixes #57226.
See #56791.


git-svn-id: https://develop.svn.wordpress.org/trunk@54897 602fd350-edb4-49c9-b593-d223f7449a82
2022-11-29 21:28:01 +00:00
Jb Audras
657d6e3cf6 Help/About: Fix inconsistency in auto-updates help tabs.
This changeset ensures the wording of auto-updates related help tabs is consistent with other help tabs.

Props NekoJonez, SergeyBiryukov, mukesh27, audrasjb.
Fixes #56921.


git-svn-id: https://develop.svn.wordpress.org/trunk@54839 602fd350-edb4-49c9-b593-d223f7449a82
2022-11-14 21:51:57 +00:00
Sergey Biryukov
12e6142687 Coding Standards: Use strict comparison in wp-admin/update-core.php.
This updates a conditional in `do_core_upgrade()` to use strict comparison for error codes that are static strings.

Follow-up to [8595], [36349].

Props rezakhan995, kebbet, mukesh27, jrf, SergeyBiryukov.
Fixes #56866.

git-svn-id: https://develop.svn.wordpress.org/trunk@54654 602fd350-edb4-49c9-b593-d223f7449a82
2022-10-20 14:28:25 +00:00
Jb Audras
60284ca751 Coding standards: Properly escape URLs returned by self_admin_url() calls.
This address some other echoed instances missed by [53839].

Fixes #56329.


git-svn-id: https://develop.svn.wordpress.org/trunk@53840 602fd350-edb4-49c9-b593-d223f7449a82
2022-08-05 06:10:04 +00:00
Jb Audras
ad03949f7b Coding standards: Properly escape URLs returned by self_admin_url() calls.
Props krishaweb, audrasjb, SergeyBiryukov.
Fixes #56329.


git-svn-id: https://develop.svn.wordpress.org/trunk@53839 602fd350-edb4-49c9-b593-d223f7449a82
2022-08-05 05:58:01 +00:00
Sergey Biryukov
0c4114395d Text Changes: Improve consistency of punctuation in some strings.
* Move the colon inside the `<strong>` tags in some `Error:` prefixes, to match other strings.
* Move the full stop at the end of some sentences outside of the `<strong>` tags used for individual phrases.

Follow-up to [11669], [23844], [53118], [53458], [53476].

Props NekoJonez, Presskopp.
Fixes #56027.

git-svn-id: https://develop.svn.wordpress.org/trunk@53700 602fd350-edb4-49c9-b593-d223f7449a82
2022-07-14 14:08:21 +00:00
Sergey Biryukov
5a49274a92 Code Modernization: Replace phpversion() function calls with PHP_VERSION constant.
`phpversion()` return value and `PHP_VERSION` constant value are identical, but the latter is several times faster because it is a direct constant value lookup compared to a function call.

Props ayeshrajans, jrf, mukesh27, costdev, hellofromTonya, SergeyBiryukov.
Fixes #55680.

git-svn-id: https://develop.svn.wordpress.org/trunk@53426 602fd350-edb4-49c9-b593-d223f7449a82
2022-05-20 17:36:23 +00:00
Jb Audras
6c270d0d17 Administration: Replace contracted verb forms for better consistency.
This changeset replaces contracted verb forms like `doesn't`, `can't`, or `isn't` with non-contracted forms like `does not`, `cannot`, or `is not`, for better consistency across the WordPress administration. It also updates some corresponding unit tests strings.

Props Presskopp, socalchristina, aandrewdixon, francina, SergeyBiryukov, JeffPaul, audrasjb, hellofromTonya.
Fixes #38913.
See #39176.


git-svn-id: https://develop.svn.wordpress.org/trunk@52978 602fd350-edb4-49c9-b593-d223f7449a82
2022-03-22 16:23:32 +00:00
Jb Audras
0fb4f90030 Themes: Add version to theme screenshot URL for better browser cache handling.
This change appends the theme version number to the URL of screenshots that appear in various place of the WordPress Admin. As a result, browsers will be able to refresh the screenshot as needed when the theme is updated.

Props codente, desrosj, audrasjb, SergeyBiryukov.
Fixes #53370.



git-svn-id: https://develop.svn.wordpress.org/trunk@52947 602fd350-edb4-49c9-b593-d223f7449a82
2022-03-17 22:19:58 +00:00
Sergey Biryukov
0ee45ae917 Upgrade/Install: Make sure the "Show hidden updates" button is visible and works as expected.
The [https://api.jquery.com/toggle-event/ .toggle( handler, handler )] method signature was deprecated in jQuery 1.8 and removed in jQuery 1.9. 

This commit updates the click handler function to work with jQuery 1.9+.

Follow-up to [9441], [9543], [42785], [48323].

Props malinevskiy, SergeyBiryukov.
Fixes #54886.

git-svn-id: https://develop.svn.wordpress.org/trunk@52644 602fd350-edb4-49c9-b593-d223f7449a82
2022-01-26 13:09:52 +00:00
Jb Audras
fb23461742 Upgrade/Install: Add timezone info to last checked update time.
The time displayed on the Updates screen matches the server time which may not be the timezone the person viewing the page is in. This change includes the timezone information with the time.

Props mkaz.
Fixes #53554.


git-svn-id: https://develop.svn.wordpress.org/trunk@52203 602fd350-edb4-49c9-b593-d223f7449a82
2021-11-18 09:23:51 +00:00
Jb Audras
5036d60706 Upgrade/Install: Differentiate en_US version strings from localized ones.
Adds a condition to `$version_string` to determine whether the Core update is the original en_US package, or a localized one.

This change fixes an issue where these packages were not differentiated and duplicate messages were displayed.

Props Presskopp, benjamingosset.
Fixes #53710.


git-svn-id: https://develop.svn.wordpress.org/trunk@52197 602fd350-edb4-49c9-b593-d223f7449a82
2021-11-17 16:22:19 +00:00
Sergey Biryukov
d802fecf97 Coding Standards: Consistently escape form action URL in wp-admin/update-core.php.
Follow-up to [10166], [23739], [25806].

Props sabbirshouvo, mukesh27.
Fixes #54278.

git-svn-id: https://develop.svn.wordpress.org/trunk@51914 602fd350-edb4-49c9-b593-d223f7449a82
2021-10-17 20:29:58 +00:00
Sergey Biryukov
41df21e70d Docs: Add a comment about the $title global usage in various admin files.
This should make it clear that the variable is used as part of the HTML `<title>` tag on admin screens.

Props ravipatel, hellofromTonya, sabernhardt, audrasjb, SergeyBiryukov.
Fixes #53729.

git-svn-id: https://develop.svn.wordpress.org/trunk@51475 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-22 13:51:58 +00:00
Sergey Biryukov
510b9d60ae Docs: Correct DocBlock formatting for Core_Upgrader::upgrade().
Document the `$auto_update_settings` parameter of the `after_core_auto_updates_settings` action.

Follow-up to [49254].

See #52628.

git-svn-id: https://develop.svn.wordpress.org/trunk@51185 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-19 21:36:01 +00:00
Sergey Biryukov
984c194bf2 Upgrade/Install: Display plugin and theme update counts on WordPress Updates screen.
This restores the information that was previously included in a title attribute tooltip on pending updates link in the toolbar.

Follow-up to [50801].

Props sabernhardt, audrasjb, mukesh27, davidbaumwald.
Fixes #53031.

git-svn-id: https://develop.svn.wordpress.org/trunk@50803 602fd350-edb4-49c9-b593-d223f7449a82
2021-05-02 16:52:46 +00:00
Sergey Biryukov
f552384ebd Coding Standards: Add a space before / character in some self-closing HTML tags.
While this has no effect on the code, it fixes a minor inconsistency with the rest of core.

Props laxman-prajapati.
Fixes #52870.

git-svn-id: https://develop.svn.wordpress.org/trunk@50556 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-20 18:28:32 +00:00
Sergey Biryukov
3d8a5fd839 Upgrade/Install: Display version number on the "Update now" button on WordPress Updates screen.
Additionally, adjust the "Update to latest nightly" button to include the major version number of the nightly build.

This makes the button labels more accurate and provides more clear understanding of what the update will be.

Follow-up to [49984].

Props afragen, pbiron, SergeyBiryukov.
Fixes #52513.

git-svn-id: https://develop.svn.wordpress.org/trunk@50506 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-08 11:29:37 +00:00
Sergey Biryukov
6ef5edd41f Upgrade/Install: Allow WordPress sites to opt-in to development releases.
The `WP_AUTO_UPDATE_CORE` constant now supports `development` and `branch-development` values.

This makes it possible for sites to opt-in to updating to nightly builds without having to install a plugin.

Follow-up to [49245], [49292].

Props xkon, knutsp, afragen, audrasjb, dd32.
Fixes #51978.

git-svn-id: https://develop.svn.wordpress.org/trunk@50082 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-30 10:32:10 +00:00
Sergey Biryukov
9264f3ef77 Upgrade/Install: Display version number on the "Re-install now" button on WordPress Updates screen.
This makes the button label more clear and allows for removing unnecessary description.

Props afragen, audrasjb.
Fixes #51774.

git-svn-id: https://develop.svn.wordpress.org/trunk@49984 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-19 16:46:50 +00:00
Sergey Biryukov
19864318cc Upgrade/Install: Display "You are using a development version" message on WordPress Updates screen for Beta or RC versions.
This ensures that the message is displayed when the `WP_AUTO_UPDATE_CORE` constant is set to `beta` or `rc` and the user is on a development version.

Follow-up to [49245], [49254], [49292], [49638], [49708].

Props afragen, audrasjb, azaozz, SergeyBiryukov.
Fixes #51822.

git-svn-id: https://develop.svn.wordpress.org/trunk@49709 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-30 13:40:02 +00:00
Sergey Biryukov
31315dd401 Docs: Update syntax for multi-line comment in core_auto_updates_settings() per the documentation standards.
Follow-up to [49677].

See #51827.

git-svn-id: https://develop.svn.wordpress.org/trunk@49681 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-22 15:57:19 +00:00
Andrew Ozz
8e7ca8320e Upgrade/Install: Replace the conditionals that check the AUTOMATIC_UPDATER_DISABLED constant and the automatic_updater_disabled filter in update-core.php with a call to WP_Automatic_Updater::is_disabled(). This prevents a PHP warning, fixes the logic, and considers wp_is_file_mod_allowed( 'automatic_updater' ) when determining the UI state.
Props jamesros161, pbiron, audrasjb, azaozz.
Fixes #51827.

git-svn-id: https://develop.svn.wordpress.org/trunk@49677 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-22 13:01:46 +00:00
Sergey Biryukov
6884e1340d Coding Standards: Remove redundant isset() check in core_upgrade_preamble().
`isset()` can be safely used to check properties and subproperties of objects directly.

Follow-up to [49638].

See #51799.

git-svn-id: https://develop.svn.wordpress.org/trunk@49668 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-19 12:03:11 +00:00
Helen Hou-Sandi
8372bbdfa5 Upgrade/Install: Consistent layout and accurate messages on the update screen.
* Clarifies that if you are on maintenance/security auto-updates that you are only on those and therefore there are more options available.
* Adds a message if a version control system has been detected, as automatic updates are disabled in that case.
* Ensures only one heading between `update available`, `you are on a dev version`, and `you are on latest` appears at any given time, falling back to `you are on latest` if something strange happens with the returned update data.
* Removes some older strings related to auto-updates, which greatly simplifies the above.
* Strips the `core-major-auto-updates-saved` query arg from the URL, as it is related to a dismissible notice.

Props audrasjb, pbiron, helen.
Fixes #51742.


git-svn-id: https://develop.svn.wordpress.org/trunk@49638 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 20:26:32 +00:00
Sergey Biryukov
62d0303bb1 Plugins: Make sure the HTML ID attributes for plugin checkboxes are unique.
Follow-up to [48374].

Props helen, sabernhardt, kishanjasani, mukesh27, hareesh-pillai.
Fixes #51256.

git-svn-id: https://develop.svn.wordpress.org/trunk@49631 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 16:46:30 +00:00
Andrew Ozz
33c782abeb Upgrade/Install: Ensure the current user can update core when saving the auto-update options.
See #51742.

git-svn-id: https://develop.svn.wordpress.org/trunk@49593 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-13 16:55:48 +00:00
Sergey Biryukov
5fa6731441 Upgrade/Install: Account for the automatic_updater_disabled filter in core auto-update settings UI.
Follow-up to [49587].

Props markparnell, audrasjb.
See #51742.

git-svn-id: https://develop.svn.wordpress.org/trunk@49592 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-13 11:12:55 +00:00
Sergey Biryukov
0d27319c73 I18N: Remove HTML tags from translatable strings on WordPress Updates screen.
Follow-up to [49587].

Props fierevere.
See #51742.

git-svn-id: https://develop.svn.wordpress.org/trunk@49591 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-13 10:48:24 +00:00
Helen Hou-Sandi
9fb87a2d24 Upgrade/Install: Better UI for auto-update settings on update screen.
This adds clearer messages about what your current settings mean for updates, uses a more compact link-based action instead of a checkbox to change the setting, and respects constants and filters.

Props audrasjb, karmatosed, helen, azaozz, hedgefield, marybaum.
Fixes #51742.


git-svn-id: https://develop.svn.wordpress.org/trunk@49587 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 22:35:54 +00:00
Jonathan Desrosiers
cd369595fe Upgrade/Install: Change the notice displayed after saving auto-update settings to .notice-success.
This better conveys the message of the notice and brings consistency with other success notices throughout Core.

Props audrasjb.
Fixes #51701.

git-svn-id: https://develop.svn.wordpress.org/trunk@49490 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-03 17:53:34 +00:00
Helen Hou-Sandi
d6653ff05b Upgrade/Install: Update help tab text to include major WordPress updates.
Props audrasjb.
Fixes #51653.


git-svn-id: https://develop.svn.wordpress.org/trunk@49483 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 20:14:25 +00:00