vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-31 14:10:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
48,934 Commits 1 Branch 0 Tags
f80516dfabca785d5cd3a746bdbb17543e77cd56
Commit Graph
294 Commits
Author SHA1 Message Date
Scott Taylor 0f2078bc9e When clicking "Show More Comments" in the Comments meta box on the Edit Post screen, change the click behavior to call a new class method on commentsBox, ->load(), that resets st (cool name) to the number of visible <tr>s before calling ->get(). This will account for spam'd and trash'd comments when returning comments at the proper offset. 
Props utkarshpatel.
Fixes #33829.


git-svn-id: https://develop.svn.wordpress.org/trunk@34069 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 02:27:50 +00:00
Scott Taylor db702bc3ea After [33961], pass $comment to get_comment_author_link() where possible to avoid extra cache/db lookups. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@34039 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 06:04:22 +00:00
Scott Taylor 47287f8d51 After [33961], ensure that comment filters that expect a comment ID are receiving one. 
Props dimadin.
Fixes #33809.


git-svn-id: https://develop.svn.wordpress.org/trunk@34008 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 18:09:15 +00:00
Scott Taylor 38d374ab01 After [33891], get_comment() returns global $comment if no args are passed and the global is set (after setting the default to null here). This allows us to ditch global comment imports. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33963 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 02:50:43 +00:00
Scott Taylor 8088ffafd6 Walker_Comment should be in its own file. Loaded now via wp-includes/comment.php, which makes it 100% BC. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33962 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 02:40:53 +00:00
Scott Taylor 95247e5bd8 After [33891], a lot of comment functions can take WP_Comment instead of only accepting comment_ID. Update the @param docs to reflect this. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33961 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 02:33:19 +00:00
Scott Taylor 542ac152fc In wp_list_comments(), update the comment meta cache when the comments derive from WP_Query and the new ->comment_meta_cached prop is false. 
There are no uses of `wp_list_comments()` in Core where `$comments` are passed as the 2nd argument.

Adds unit tests.

Props wonderboymusic, bradt.
Fixes #16894.


git-svn-id: https://develop.svn.wordpress.org/trunk@33925 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 22:24:16 +00:00
Sergey Biryukov f8f8de0ecf Merge two strings in Walker_Comment::comment() and Walker_Comment::html5_comment(). 
Props pavelevap.
Fixes #33744.

git-svn-id: https://develop.svn.wordpress.org/trunk@33919 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:45:13 +00:00
Scott Taylor 60ba8b05e4 Introduce WP_Comment class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity. 
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33891 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 18:16:35 +00:00
Sergey Biryukov dcc6fb838f Restore rel='nofollow' for comment reply links to reduce extra crawling by search engines. 
This reverts [16230], which didn't have enough review at the time of commit.

props joostdevalk.
see #22889, #18547, #16881.

git-svn-id: https://develop.svn.wordpress.org/trunk@33047 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-02 11:08:42 +00:00
Mark Jaquith fcd4f3ea0f Revert [33038] because of objections raised on #22889 and #31590 
git-svn-id: https://develop.svn.wordpress.org/trunk@33042 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-02 00:46:28 +00:00
Mark Jaquith 165b3fccaa Restore $noreplytext default value in comment_form_title() 
props ocean90
see #22889

git-svn-id: https://develop.svn.wordpress.org/trunk@33039 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-01 21:50:13 +00:00
Mark Jaquith bac0e68b48 Say goodbye to ?replytocom=123 links and their URL pollution. 
* Comment reply links continue to use JS as before.
* ?replytocom=123 links are deprecated.

props joostdevalk
fixes #22889

git-svn-id: https://develop.svn.wordpress.org/trunk@33038 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-01 21:41:17 +00:00
Konstantin Obenland 59a9592125 Remove allowed tags from comment form. 
It can be confusing to users and for most it is not relevant.
Commenters comfortable with HTML will know which tags are likely
to be accepted.

Props krogsgard, rachelbaker.
Fixes #30157.



git-svn-id: https://develop.svn.wordpress.org/trunk@32858 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-19 14:14:41 +00:00
Scott Taylor e88721433c In get_comment_reply_link(), when generating the reply link, add the replytocom query arg to the result of get_permalink() on the current $post, instead of the current global request URI. 
Props nazmul.hossain.nihal.
Fixes #31333.


git-svn-id: https://develop.svn.wordpress.org/trunk@32786 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-16 00:18:39 +00:00
Andrew Nacin cda77232fe Update comment caches in WP_Comment_Query, rather than comments template. 
props dd32.
fixes #31081.


git-svn-id: https://develop.svn.wordpress.org/trunk@32769 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-14 19:20:12 +00:00
Scott Taylor 39ef6a72c5 Use void instead of null where appropriate when pipe-delimiting @return types. If a @return only contains void, remove it. 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32568 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-24 05:39:47 +00:00
Scott Taylor abca40cf44 Add missing doc blocks to comment-template.php. 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32567 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-24 05:18:59 +00:00
Sergey Biryukov 09bd58b4c9 In comment_form(), ensure that filtered arguments contain all required default values. 
props boonebgorges.
fixes #32312 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32511 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-19 01:03:39 +00:00
Sergey Biryukov 2848b8a911 Replace echo __() with _e(). 
props marsjaninzmarsa.
fixes #32239.

git-svn-id: https://develop.svn.wordpress.org/trunk@32333 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-03 16:17:06 +00:00
Helen Hou-Sandi 3fb766782d Don't add a class for comment authors who are members of the current site. 
Reverts [32245] and [31518]. We'll keep the whitespace and comment clarification, though.

see #24054.


git-svn-id: https://develop.svn.wordpress.org/trunk@32259 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-21 23:35:55 +00:00
Helen Hou-Sandi 10640611f6 Comment: rename the comment-author-is-site-member class to bysiteuser for consistency. 
Final decision on keeping the class yet to be made.

props DrewAPicture.
see #24054.


git-svn-id: https://develop.svn.wordpress.org/trunk@32245 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-21 14:19:58 +00:00
Drew Jaynes e984069608 Remove backtick-escaping around a core function in the hook docs for the comment_form_submit_field filter. 
See [31699]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32037 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-05 15:38:57 +00:00
Dominik Schilling (ocean90) a3f6767a45 Comments: Move HTML tags for screen reader text into translatable strings. 
Placeholders aren't helpful and it's much easier to make a mistake if you're dealing with placeholders.
Introduced in [31388].

props pento.
fixes #26553.

git-svn-id: https://develop.svn.wordpress.org/trunk@31821 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-18 21:51:36 +00:00
Drew Jaynes b9cb22f888 Add a changelog entry to the DocBlock for comment_form() for the class_submit argument added in 4.1. 
See [29809]. See #20446.


git-svn-id: https://develop.svn.wordpress.org/trunk@31803 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-17 18:37:12 +00:00
Boone Gorges 8072fe7db6 Improved customizability for the Submit button in comment_form(). 
The new 'submit_button' and 'submit_field' parameters for `comment_form()`
allow developers to modify the markup of the submit button and its wrapper.
These params are accompanied by targeted 'comment_form_submit_button' and
'comment_form_submit_field' filters on the concatenated markup.

Props coffee2code, morpheu5, DrewAPicture, boonebgorges.
Fixes #15015.

git-svn-id: https://develop.svn.wordpress.org/trunk@31699 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-10 19:07:31 +00:00
Jeremy Felt a86c3114ae Add comment-author-is-site-member class to comment output for site members. 
Add a class to allow targeting of comments made by members of a site rather than users of the entire network.

Props Viper007Bond, MikeHansenMe.

Fixes #24054.


git-svn-id: https://develop.svn.wordpress.org/trunk@31518 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-23 02:51:49 +00:00
Sergey Biryukov 5aac59d178 Replace hardcoded usage of comment-page with the comment pagination base. 
props johnbillion, SergeyBiryukov, webord.
fixes #18084.

git-svn-id: https://develop.svn.wordpress.org/trunk@31459 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-14 03:47:02 +00:00
Sergey Biryukov 5d35c181dc Add .comment-reply-login class to get_post_reply_link(), for consistency with get_comment_reply_link(). 
props johnjamesjacoby.
fixes #31298.

git-svn-id: https://develop.svn.wordpress.org/trunk@31412 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-11 16:10:54 +00:00
Sergey Biryukov c8a361712b Switch to a string placeholder, as number_format_i18n() returns a string. 
see #26553.

git-svn-id: https://develop.svn.wordpress.org/trunk@31402 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-10 05:44:21 +00:00
Sergey Biryukov 74ad70419e Use _n() in comments_popup_link() when setting the default string to display if there are more than one comment. 
see #26553.

git-svn-id: https://develop.svn.wordpress.org/trunk@31401 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-10 02:50:58 +00:00
Aaron Jorbin 5abd98618d Add translator comments for new strings. 
These strings were added in [31388].

Props ocean90.
Fixes 26553.



git-svn-id: https://develop.svn.wordpress.org/trunk@31389 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-09 20:14:19 +00:00
Aaron Jorbin cf09359d34 Use screen reader text instead of a title attribute in comments_popup_link 
To better understand screen reader text, check out https://make.wordpress.org/accessibility/2015/02/09/hiding-text-for-screen-readers-with-wordpress-core/

Screen Reader text improves the user experience for screen reader users. It provides additional context for links, document forms and other pieces of a page that may exist visually, but are lost when looking only at the html of a site.  This does change the output of comments_popup_link if you don't pass in values for $zero, $one, $more or $none. Theme authors can and should style <code>.screen-reader-text</code> in ways that are recommended in the above article to hide it visually.

Props joedolson
Fixes #26553





git-svn-id: https://develop.svn.wordpress.org/trunk@31388 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-09 19:26:56 +00:00
Scott Taylor db1ace58ca In comment_form(), add the HTML5 required attribute next to aria-required in fields that utilize it. 
Props MMN-o.
Fixes #24732.


git-svn-id: https://develop.svn.wordpress.org/trunk@31204 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 15:55:50 +00:00
Sergey Biryukov c96947757a Remove a redundant inline comment with a typo. 
props nicnicnicdevos.
fixes #30956.

git-svn-id: https://develop.svn.wordpress.org/trunk@31103 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:28:11 +00:00
Scott Taylor 6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 07:04:40 +00:00
Scott Taylor fdef2cc755 Remove whitespace side effects from comment_form(). 
Props timersys.
Fixes #30500.


git-svn-id: https://develop.svn.wordpress.org/trunk@31036 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 06:26:38 +00:00
Drew Jaynes (DrewAPicture) 205a43ed05 Correctly capitalize JavaScript throughout core docs. 
Fixes #30569.


git-svn-id: https://develop.svn.wordpress.org/trunk@30695 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-02 00:30:59 +00:00
Scott Taylor 4d46475b3d Improve various @param docs for src/wp-includes/*. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30681 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-01 01:33:34 +00:00
Drew Jaynes (DrewAPicture) e587324180 Docs Formatting: Backtick-escape inline code for all remaining dynamic hook docs in wp-includes/*. 
Affects DocBlocks for the following hooks:
* `auth_post_meta_{$meta_key}`
* `term_links-$taxonomy`
* `customize_render_control_ . $this->id`
* `customize_render_panel_{$this->id}`
* `customize_render_section_{$this->id}`
* `customize_preview_{$this->id}`
* `customize_save_ . $this->id_data[ 'base' ]`
* `customize_update_ . $this->type`
* `customize_value_ . $this->id_data[ 'base' ]`
* `customize_sanitize_js_{$this->id}`
* `comment_form_field_{$name}`
* `comment_{$old_status}_to_{$new_status}`
* `comment_{$new_status}_{$comment->comment_type}`
* `extra_{$context}_headers`
* `get_template_part_{$slug}`
* `get_the_generator_{$type}`
* `get_{$adjacent}_post_join`
* `get_{$adjacent}_post_where`
* `get_{$adjacent}_post_sort`
* `{$adjacent}_post_rel_link`
* `{$adjacent}_post_link`
* `{$adjacent}_image_link`
* `blog_option_{$option}`
* `$permastructname . _rewrite_rules`
* `{$type}_template`
* `theme_mod_{$name}`
* `pre_set_theme_mod_$name`
* `current_theme_supports-{$feature}`
* `get_user_option_{$option}`
* `edit_user_{$field}`
* `pre_user_{$field}`
* `user_{$field}`

See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30656 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-30 12:09:56 +00:00
Drew Jaynes (DrewAPicture) f240af96da 4.1 Docs Audit: Various formatting fixes for inline documentation in class-wp-list-table.php and comment-template.php. 
See #30469.


git-svn-id: https://develop.svn.wordpress.org/trunk@30610 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-28 11:21:40 +00:00
Peter Westwood 7e349ec5c4 Fix the passing of commenter cookie data to the comment API so that we don't try and fetch all unapproved comments for users with no-email address when we only have an author. 
Fixes #19623


git-svn-id: https://develop.svn.wordpress.org/trunk@30547 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-24 10:50:38 +00:00
Drew Jaynes (DrewAPicture) ad50389634 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Remove HTML tag from parameter description in `comment_form()`
* Remove HTML tag from a summary for the `comment_form_top` hook
* Markdown-indent a code snippet in the description for `get_linkobjectsbyname()`
* Markdown-indent a code snippet and format an unordered list in the description for `get_linkobjects()`
* Backtick-escape some inline code in the description for `clean_pre()`
* Remove HTML tag from the summary for the `rss_tag_pre` hook
* Various formatting fixes in the descriptions for `get_filesystem_method()` and `request_filesystem_credentials()`

Props rarst for the initial patch.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30538 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-24 05:18:56 +00:00
Drew Jaynes (DrewAPicture) 325c0622c9 Update the changelogs for the comment hook parameters added in [30092]. 
Parameters were added to the `get_comment_author`, `comment_author`, `get_comment_author_email`, `author_email`, `comment_email`, `get_comment_author_link`, `get_comment_author_IP`, `get_comment_author_url`, `comment_url`, `get_comment_excerpt`, `comment_excerpt`, `get_comment_ID`, and `get_comment_type` filters.

Fixes #22380.


git-svn-id: https://develop.svn.wordpress.org/trunk@30111 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-30 03:51:28 +00:00
Peter Westwood ed19e5a1f3 Comment Template Tags: Improve the availability of context information in comment template tag filters. 
Fixes #22380 props momo360modena, tareq1988.


git-svn-id: https://develop.svn.wordpress.org/trunk@30092 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-29 19:07:00 +00:00
Sergey Biryukov 2672e35d43 Add 'comment_reply_link_args' filter for get_comment_reply_link() arguments. 
props joedolson, aaroncampbell, DrewAPicture.
fixes #10569.

git-svn-id: https://develop.svn.wordpress.org/trunk@30039 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-27 11:44:40 +00:00
Boone Gorges 348c8958da Use the comment API rather than direct SQL queries in comments_template(). 
`comments_template()` is used by most themes to display a post's comments. It
shows all comments that have been approved, and also shows all pending comments
by the current visitor (as determined by the comment cookies). However, the
comments API previously had no way of querying for "all comments that are
either approved, or are unapproved but written by foo@example.com". The
workaround was a direct SQL query: uncached, not subject to the same filters as
other comment queries, and just generally icky.

The new `include_unapproved` parameter for `WP_Comment_Query` accepts an array
of user IDs or email addresses. Pending comments associated with users in this
array will be included in query results, regardless of the value of the 'status'
parameter. In `comments_template()`, we leap from direct SQL queries to
`get_comments()` plus `include_unapproved', striving to put right what once
went wrong.

Props boonebgorges, simonwheatley, hardy101, jesin.
Fixes #19623.

git-svn-id: https://develop.svn.wordpress.org/trunk@29965 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-19 19:38:16 +00:00
Dominik Schilling (ocean90) 5d7e30e7d9 Comments: Don't print an empty HTML markup when comment_reply_link() returns no link. 
props obenland.
fixes #29895.

git-svn-id: https://develop.svn.wordpress.org/trunk@29908 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-15 21:55:31 +00:00
Sergey Biryukov 564598f068 Add aria-describedby attributes to comment_form(). 
props joedolson, bramd.
fixes #24148.

git-svn-id: https://develop.svn.wordpress.org/trunk@29846 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-06 22:10:08 +00:00
Sergey Biryukov dc62eeff36 Make link construction in get_comment_reply_link() and get_post_reply_link() more readable. 
see #16433.

git-svn-id: https://develop.svn.wordpress.org/trunk@29823 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 20:44:34 +00:00