Commit Graph

144 Commits

Author SHA1 Message Date
Dion Hulse
fb0b86a078 Upgrader: Fix the order of arguements passed to wp_parse_args() in the Upgrader, introduced with [25272]. See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25495 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-19 08:39:51 +00:00
Drew Jaynes
a989e79cf8 Add phpdoc blocks in wp-admin/credits.php.
Props siobhan, markoheijnen.
Fixes #20425.


git-svn-id: https://develop.svn.wordpress.org/trunk@25491 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-19 02:26:24 +00:00
Drew Jaynes
44cd294f64 Add missing phpdoc block for export_date_options().
Props siobhan for the initial patch. See #20425


git-svn-id: https://develop.svn.wordpress.org/trunk@25490 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-19 02:08:53 +00:00
Sergey Biryukov
a4f3fc3489 Update inline documentation for hooks in wp-admin/includes/ms.php.
props jamescollins.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25486 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-19 00:04:16 +00:00
Sergey Biryukov
801f56dec2 Clean up the documentation for hooks in wp-admin/includes/plugin.php.
props DrewAPicture.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25482 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-18 19:35:10 +00:00
Sergey Biryukov
8834a52e40 Inline documentation for hooks in wp-admin/includes/ms.php.
props enej, DrewAPicture.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25481 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-18 18:21:46 +00:00
Sergey Biryukov
7069b5c47c Correct @since for hooks in wp-admin/includes/plugin.php. see #25229.
git-svn-id: https://develop.svn.wordpress.org/trunk@25477 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-18 11:57:18 +00:00
Peter Westwood
e71b7b15cf Inline documentation for hooks in wp-admin/includes/plugin.php
See #25229 props dllh


git-svn-id: https://develop.svn.wordpress.org/trunk@25474 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-18 07:37:39 +00:00
Sergey Biryukov
89c1b75ada Deprecate the_attachment_links(), unused since [6910]. props vinod dalvi. fixes #25340.
git-svn-id: https://develop.svn.wordpress.org/trunk@25472 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-17 09:07:12 +00:00
Sergey Biryukov
8a46168489 Inline documentation for hooks in wp-admin/user-new.php.
props bftrick.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25470 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-17 08:32:07 +00:00
Dion Hulse
ea24e2ce0d WordPress Upgrades: When defining the default filesystem permissions for files/directories, base the value on the existing ABSPATH & index.php file permissions - so as to respect the executable bit (if set) and not set global read if not required.
This sets a minimum permission set to 750 and 640 for directories and files, so any systems requring less permission than that will still need to define the constants themselves. Fixes #20069 


git-svn-id: https://develop.svn.wordpress.org/trunk@25469 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-17 08:05:23 +00:00
Dion Hulse
ed8f918e4e WordPress Core Automatic Updates: Remove some debug. See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25468 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-17 04:07:35 +00:00
Dion Hulse
d1dcc8cca3 WordPress Core Automatic Updates: Switch from using a transient for locking the upgrade process, to using a site option. See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25467 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-17 02:27:21 +00:00
Helen Hou-Sandi
54c6cd2793 Make sure quick edited non-alternate taxonomy list table rows don't become alternate. props c3mdigital. fixes #25059.
git-svn-id: https://develop.svn.wordpress.org/trunk@25463 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-16 21:10:27 +00:00
Sergey Biryukov
3af290b2c8 Check if the post type supports title. see #24423.
git-svn-id: https://develop.svn.wordpress.org/trunk@25461 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-16 20:50:11 +00:00
Andrew Nacin
fb1759e417 Only focus the title field when it is empty. Remove ancient code that provided for an alternate condition.
props scruffian for initial patches.
props helen.
fixes #24423.


git-svn-id: https://develop.svn.wordpress.org/trunk@25459 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-16 20:36:35 +00:00
Sergey Biryukov
7e6d20733e Clarify a string in Network Dashboard help text. props DrewAPicture. see #23163.
git-svn-id: https://develop.svn.wordpress.org/trunk@25457 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-16 20:13:36 +00:00
Andrew Nacin
c89f2e38a8 Add nginx detection to the Permalink Settings screen.
Introduces got_url_rewrite() and a corresponding filter, which should now be used in lieu of the got_rewrite filter in got_mod_rewrite().

This does not write or even suggest nginx configuration; rather, it prevents nginx from being considered as either Apache or as an unrecognized server.

props johnbillion.
fixes #25098.


git-svn-id: https://develop.svn.wordpress.org/trunk@25456 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-16 20:06:27 +00:00
Andrew Nacin
fdc9bc6130 Allow callback args to be passed from wp_add_dashboard_widget() to add_meta_box().
props jdgrimes.
fixes #25152.


git-svn-id: https://develop.svn.wordpress.org/trunk@25454 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-16 18:06:05 +00:00
Andrew Nacin
400e27e71c Let the wp_redirect to media-new.php from post-new.php?post_type=attachment be canceled using the wp_redirect filter.
props DrewAPicture.
fixes #25216.


git-svn-id: https://develop.svn.wordpress.org/trunk@25453 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-16 17:51:58 +00:00
Andrew Nacin
e24a1ac0dc Use get_terms() in the ajax tag search.
props Chouby.
fixes #25231.


git-svn-id: https://develop.svn.wordpress.org/trunk@25452 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-16 17:50:16 +00:00
Andrew Nacin
1d80307d5d Multisite blogs table: Convert the archived field from enum to tinyint to match the other status fields. fixes #12832.
git-svn-id: https://develop.svn.wordpress.org/trunk@25448 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-15 23:11:30 +00:00
Dion Hulse
3ec962dd56 WordPress Core Automatic Updates: Remove an accidental closure which isn't supported in PHP 5.2. See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25447 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-15 01:25:56 +00:00
Andrew Nacin
e539910e1a Move to JSON for three api.wordpress.org endpoints. see #25311.
git-svn-id: https://develop.svn.wordpress.org/trunk@25441 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-14 19:30:44 +00:00
Andrew Nacin
7fe981c578 Remove unnecessary printf(). fixes #25321.
git-svn-id: https://develop.svn.wordpress.org/trunk@25439 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-14 19:11:37 +00:00
Scott Taylor
535ae26afd Fix several esoteric errors related to AJAX unit tests for comments:
* `wp_ajax_get_comments()` relies on the `$post_id` global - even though `$_POST['p']` is passed to every action in the test methods. If `$post_id` is still lingering in between tests and doesn't match `p` in the request, the cap check might pass while the queries for comments will blow up. I added `unset( $GLOBALS['post_id'] )` to `Tests_Ajax_GetComments::setUp()`.
* If the global `$post_id` is empty, but `$_REQUEST['p']` is not, `$post_id` is now set to `absint( $_REQUEST['p'] )` and sanity-checked in `wp_ajax_get_comments()`.
* `map_meta_cap()` always assumes that `get_comment()` succeeds when checking for the `edit_comment` cap. It doesn't. I added sanity checks in a few places where it will break early if `get_post()` or `get_comment()` are empty.
* `wp_update_comment()` always assumes `get_comment()` succeeds. It doesn't. I added a check for empty.

All AJAX unit tests run and pass in debug mode. All general unit tests pass against these changes.

Fixes #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25438 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-14 18:35:43 +00:00
Sergey Biryukov
64eec20413 Inline documentation for hooks in wp-admin/export.php.
props mordauk.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25435 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-14 01:01:49 +00:00
Sergey Biryukov
27d3a78193 Inline documentation for hooks in wp-admin/includes/comment.php.
props mordauk.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25434 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-14 01:00:44 +00:00
Scott Taylor
402e61f269 Fix some undefined index notices related to Comment unit tests:
* There are several places where a `$_POST` index was unchecked before setting a variable
* In `wp_notify_postauthor()`, `$comment` was being returned null, but its properties were being accessed.
* In `check_ajax_referer()`, 3 different values can be checked for nonce on `$_REQUEST`, but only 1 had an `isset()`

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25433 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 22:17:51 +00:00
Scott Taylor
ac23d53402 * Avoid notices in tests/ajax/Autosave by bailing early when get_post() returns nothing.
* Check for the existence of `$_POST['catslist']` before using it in `wp_ajax_autosave()`.

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25430 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 21:21:16 +00:00
Dion Hulse
9c1b30860c Upgrader: Allow plugins to short-circuit the package download. Props rmccue and DrewAPicture. Fixes #22378
git-svn-id: https://develop.svn.wordpress.org/trunk@25427 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 12:52:28 +00:00
Sergey Biryukov
a57529c720 Avoid a PHP warning in network admin if a constant corresponding to a drop-in is not defined. fixes #25301.
git-svn-id: https://develop.svn.wordpress.org/trunk@25425 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 09:36:08 +00:00
Sergey Biryukov
f2c1db3663 Inline documentation for hooks in wp-admin/ms-delete-site.php.
props NikV.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25424 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 09:10:18 +00:00
Dion Hulse
5959a7011b WordPress Core Automatic Updates: Pass the Filesystem path as $context to request_filesystem_credentials(). See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25422 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 06:52:11 +00:00
Dion Hulse
63956aa479 WordPress Core Automatic Updates: Add the first slice of Automatic Upgrades, This is presently disabled, and requires a filter to enable ( 'auto_upgrade_core' ). See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25421 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 06:18:16 +00:00
Sergey Biryukov
96d12ddd9d Better alignment for wp_prepare_revisions_for_js() inline docs. see #25283.
git-svn-id: https://develop.svn.wordpress.org/trunk@25420 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 23:14:55 +00:00
Sergey Biryukov
529c973323 Inline documentation fixes and additions for wp-admin/revision.php and wp-admin/includes/revision.php.
props adamsilverstein.
see #25283.

git-svn-id: https://develop.svn.wordpress.org/trunk@25419 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 22:58:45 +00:00
Andrew Nacin
bb2908d613 Clear all transients (regardless of expiration) on all database upgrades. see #20316.
git-svn-id: https://develop.svn.wordpress.org/trunk@25416 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 21:13:18 +00:00
Andrew Nacin
8917f2b3bd Add populate_network_meta filter to populate_network().
props jeremyfelt.
fixes #25020.


git-svn-id: https://develop.svn.wordpress.org/trunk@25414 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 20:48:20 +00:00
Andrew Nacin
3631b81545 Fix comma placement in [25179].
props gradyetc.
see #15004, fixes #25298.


git-svn-id: https://develop.svn.wordpress.org/trunk@25413 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 20:15:30 +00:00
Helen Hou-Sandi
91d14be2e2 No space between // and duplicate_hook. see #25229
git-svn-id: https://develop.svn.wordpress.org/trunk@25412 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 18:56:32 +00:00
Helen Hou-Sandi
67633ef09e Inline docs for hooks in wp-admin/options-writing.php. props siobhyb. see #25229.
git-svn-id: https://develop.svn.wordpress.org/trunk@25411 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 18:52:38 +00:00
Helen Hou-Sandi
435c2b5686 Add file size to attachment publish meta box. props desrosj. fixes #25170.
git-svn-id: https://develop.svn.wordpress.org/trunk@25403 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 15:09:35 +00:00
Dion Hulse
cccac649d5 Fix wp_guess_url() to work in every scenario I could find, allows us to use it to determine the correct path to the WordPress Site URL before installation for install.php and setup-config.php redirects. Fixes #24480 Fixes #16884
git-svn-id: https://develop.svn.wordpress.org/trunk@25396 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 06:56:20 +00:00
Sergey Biryukov
1b012770eb Inline documentation for hooks in wp-admin/options.php.
props siobhyb.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25372 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 03:43:48 +00:00
Sergey Biryukov
a56e83373d Consistently call skin methods in WP_Upgrader. fixes #25254.
git-svn-id: https://develop.svn.wordpress.org/trunk@25370 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 02:42:10 +00:00
Sergey Biryukov
c05412b16c Fix invalid markup when searching for installed themes. fixes #25288.
git-svn-id: https://develop.svn.wordpress.org/trunk@25369 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 00:03:01 +00:00
Dion Hulse
ea6da7d5dc Make use of the mbstring.func_overload helper functions in WP_Filesystem so byte lengths are properly determined. See #25259 Fixes #25237
git-svn-id: https://develop.svn.wordpress.org/trunk@25349 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:26:57 +00:00
Dion Hulse
47c25b41af Switch unzip_file() over to using the mbstring.func_override helper functions. See #25259
git-svn-id: https://develop.svn.wordpress.org/trunk@25347 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:08:35 +00:00
Scott Taylor
270cc9702d Check $profileuser->rich_editing for empty before using it in Edit User admin code.
Props sorich87, c3mdigital.
Fixes #17328.



git-svn-id: https://develop.svn.wordpress.org/trunk@25330 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:48:27 +00:00