Scott Taylor
4b9ccd27b1
After [33723], ensure that $i is properly set before looping.
...
See #16865 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33867 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:47:51 +00:00
Sergey Biryukov
5cf9c22518
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/themes.php.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33677 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33866 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:44:07 +00:00
Sergey Biryukov
45237109dc
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/press-this.php.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33676 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33865 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:37:28 +00:00
Sergey Biryukov
89fca37568
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/post-new.php.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33675 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33864 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:35:05 +00:00
Sergey Biryukov
2dcbf39e2d
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/options.php.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33674 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33863 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:30:58 +00:00
Sergey Biryukov
31caf44a24
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/nav-menus.php.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33673 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33862 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:20:53 +00:00
Sergey Biryukov
50224510ec
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/edit.php.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33671 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33861 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:14:14 +00:00
Sergey Biryukov
0299c00fbb
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/edit-comments.php.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33669 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33860 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:03:10 +00:00
Sergey Biryukov
1ec4b77ac2
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/customize.php.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33668 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33857 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 17:05:01 +00:00
Andrea Fercia
2ffd8b52cf
Customize: use correct CSS selectors for the Menu Customizer reorder-toggle button after [33604].
...
Fixes #33633 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33856 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:55:46 +00:00
Sergey Biryukov
22919f8150
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/custom-header.php.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33667 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33854 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:28:18 +00:00
Sergey Biryukov
1efad51200
Provide more helful feedback than just "Cheatin' uh?" for permission errors in wp-admin/media-upload.php.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33672 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33853 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:20:46 +00:00
Sergey Biryukov
029964a5ed
Provide more helful feedback than just “Cheatin’ uh?” for permission errors in wp-admin/edit-tags.php.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33670 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33852 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:05:07 +00:00
John Blackbourn
46c336e78a
Introduce wp_removable_query_args(), which returns an array of single-use query variables which can be removed from a URL.
...
Also applies the function to the return URL when the Customizer is closed.
Fixes #32692
Props swissspidy, Mte90
git-svn-id: https://develop.svn.wordpress.org/trunk@33849 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 11:28:11 +00:00
Jeremy Felt
4d2dbebb35
Multisite: Remove duplicate span element output from row actions
...
Fixes #32961 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33848 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 21:50:33 +00:00
Sergey Biryukov
cfff91526f
Merge two similar strings.
...
props pavelevap.
fixes #33643 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33842 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 13:45:15 +00:00
Weston Ruter
57a7ed15a7
Customizer: Collapse any expanded panel/sections before expanding other panel/sections
...
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.
Props celloexpressions, westonruter.
Fixes #33396 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@33837 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 23:07:57 +00:00
Andrew Ozz
43d053318e
Editor, Press This: force a page reload when the user publishes a post and then clicks the back button.
...
Fixes #23691 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33836 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 23:07:36 +00:00
Sergey Biryukov
79907af59c
Add 'dashboard_secondary_items' filter for the number of secondary link items in the 'WordPress News' dashboard widget.
...
props MikeHansenMe, DrewAPicture.
fixes #31434 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33833 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 21:56:50 +00:00
SergeyBiryukov
f0ab8b5a06
Add 'update_right_now_text' filter for the text displayed in the 'At a Glance' dashboard widget.
...
props obenland.
fixes #33355 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33832 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 21:44:02 +00:00
Drew Jaynes
f7507e511d
Docs: Add a duplicate filter comment to the comment_email filter call in WP_Comments_List_Table, introduced in [33829].
...
See #11566 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33830 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 21:21:14 +00:00
Scott Taylor
e10c682b83
Remove the hamburger global'ing from [33828]: since no args are passed to comment_author_email_link(), the internals can be simplified and applied inline.
...
See #11566 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33829 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 21:08:17 +00:00
Scott Taylor
fef8794b2c
Fix warnings after [33826]. Only only one function call needs a global $comment, we shall hamburger it.
...
See #11566 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33828 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:58:12 +00:00
Scott Taylor
0f59069a7f
WP_Comments_List_Table::single_row() has no reason to set the $comment global. No other methods use it, and we are not in template/loop context. This can mess with the response of get_comment() elsewhere, since get_comment() internally bypasses the cache/db when a global is set.
...
See #11566 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33826 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:41:09 +00:00
Sergey Biryukov
20767f42aa
Use wp_html_excerpt() to properly cut comment author URL for display on Comments screen.
...
props brettz95, solarissmoke.
fixes #15659 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33825 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:40:28 +00:00
Scott Taylor
af101dec19
Comments: dynamically update the document title text of the Comments List Table page when dynamically updating the number of comments awaiting moderation.
...
Fixes #33414 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33821 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 17:57:32 +00:00
Sergey Biryukov
ff7e86d14c
Bump H3 headings to H2 on Themes screen for better accessibility.
...
props joehills.
fixes #33560 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33820 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:50:05 +00:00
Sergey Biryukov
0de0c060c1
Bump H3 headings to H2 on Tools screen for better accessibility.
...
props Cheffheid.
fixes #33607 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33819 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:31:38 +00:00
Sergey Biryukov
77b54f319d
Bump H3 headings to H2 on Permalink Settings screen for better accessibility.
...
props Cheffheid.
fixes #33611 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33818 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:28:32 +00:00
Sergey Biryukov
7f3b90bc77
Bump H3 headings to H2 on WordPress Updates screen for better accessibility.
...
props Cheffheid.
fixes #33559 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33817 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:25:27 +00:00
Scott Taylor
413df72474
Favor using the consistent and agnostic string 'Attach' over 'Attach to a post' in the media list table.
...
Props pavelevap.
Fixes #33515 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33810 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 03:09:25 +00:00
Sergey Biryukov
a47ee912ac
Make a period translatable.
...
props mako09.
fixes #33594 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33802 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-29 01:39:51 +00:00
John Blackbourn
a4808224ff
Bring network admin user searching to parity with single site user searching by wrapping search terms in asterisks. This means that searches don't require an exact match and therefore significantly reduces friction when searching for users on the network admin screens.
...
Fixes #32913
git-svn-id: https://develop.svn.wordpress.org/trunk@33801 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-29 00:18:06 +00:00
Sergey Biryukov
d5dd61424d
Network Admin: Hide the bulk actions checkbox for super admins.
...
See [25125] for hiding the checkbox for the main site in Sites table.
props bordoni.
fixes #28529 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33777 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 03:48:47 +00:00
Helen Hou-Sandi
0c19c94561
Drop the hyphen from e-mail and standardize on email.
...
The AP Stylebook changed this in 2011, and we're woefully inconsistent, so let's go with the standard.
props morganestes, voldemortensen, niallkennedy (for patching on the previous AP style).
fixes #26156 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33774 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 03:16:02 +00:00
John Blackbourn
d89398f945
Don't change the View Post button permalink in the sample permalink HTML when updating the slug on a published or future post.
...
Fixes #32954
Props boonebgorges, johnbillion
git-svn-id: https://develop.svn.wordpress.org/trunk@33773 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 20:56:54 +00:00
Sergey Biryukov
65c07b81c0
Remove wp-includes/comment-functions.php from the $_old_files array. See [33750].
...
props rachelbaker.
fixes #33569 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33772 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 20:39:58 +00:00
John Blackbourn
0d0a8353f5
Remove error from the query variables when cleaning up a URL in wp_admin_canonical_url().
...
Fixes #32847
git-svn-id: https://develop.svn.wordpress.org/trunk@33770 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 17:25:15 +00:00
John Blackbourn
e95ce848f9
Correct the hook docs for the user_profile_update_errors action.
...
Fixes #33537
Props yamchhetri
git-svn-id: https://develop.svn.wordpress.org/trunk@33769 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 17:15:54 +00:00
Sergey Biryukov
30eb4853f0
Prevent unintended password change after clicking "Generate Password" and then "Cancel" when editing a user profile.
...
props peterwilsoncc.
fixes #33419 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@33766 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 00:10:39 +00:00
Sergey Biryukov
a69c9ff66f
Make post meta box toggles accessible.
...
props joedolson.
fixes #33544 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33762 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 15:22:57 +00:00
Weston Ruter
9c4f261598
Customizer: Ensure persistence of unchanged active state for controls, sections, and panels.
...
Props nikeo, westonruter.
Fixes #33428 for trunk.
See also #33494 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33754 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 07:25:20 +00:00
Weston Ruter
e32f3cd3e1
Customizer: Prevent JS error during init when nav_menus panel is removed by plugin.
...
Fixes #33411 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@33753 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 06:42:16 +00:00
Sergey Biryukov
6598033243
Remove rounded corners from "Choose from the most used tags" result in Tags meta box.
...
props tyxla.
fixes #31560 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33742 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 23:13:30 +00:00
Scott Taylor
ff7fcf5f04
In WP_Users_List_Table::single_row(), $actions is not always set before being used.
...
See #33491 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33735 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 20:37:50 +00:00
Scott Taylor
3b8c5529cb
foreach is a statement, not a function.
...
See #33491 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33734 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 20:27:56 +00:00
Scott Taylor
755d109d10
Instead of [33713], allow WP_Posts_List_Table::get_bulk_actions() to check edit_posts AND delete_posts.
...
Props DeBAAT.
Fixes #29789 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33733 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 20:11:27 +00:00
Sergey Biryukov
b59d10ccac
Multisite: Add 'invite_user' action that fires immediately after a user is invited to join a site, but before the notification is sent.
...
props ebinnion, MikeHansenMe, DrewAPicture.
fixes #33008 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33732 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 17:47:26 +00:00
Drew Jaynes
40ce8c68fe
Docs: The type for the $t_time parameter in the post_date_column_time filter docs should be string, not array.
...
Props jjeaton
Fixes #33540 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33731 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 17:14:28 +00:00
Scott Taylor
e1b1541932
Media:
...
When inserting an image into a post, the values in `wp.media.controller.Library` should not default to linking the image when no user settings are present.
The default display setting value for `link` is now `none`. User settings persist and will override or confirm this value based on user actions.
Props liljimmi, janhenckens, eherman24, wonderboymusic.
Fixes #31467 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33729 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 12:12:59 +00:00