Commit Graph
3192 Commits
Author SHA1 Message Date
Scott Taylor fef8794b2c Fix warnings after [33826]. Only only one function call needs a global $comment, we shall hamburger it.
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33828 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:58:12 +00:00
Scott Taylor 0f59069a7f WP_Comments_List_Table::single_row() has no reason to set the $comment global. No other methods use it, and we are not in template/loop context. This can mess with the response of get_comment() elsewhere, since get_comment() internally bypasses the cache/db when a global is set.
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33826 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:41:09 +00:00
Sergey Biryukov 20767f42aa Use wp_html_excerpt() to properly cut comment author URL for display on Comments screen.
props brettz95, solarissmoke.
fixes #15659.

git-svn-id: https://develop.svn.wordpress.org/trunk@33825 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:40:28 +00:00
Scott Taylor af101dec19 Comments: dynamically update the document title text of the Comments List Table page when dynamically updating the number of comments awaiting moderation.
Fixes #33414. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33821 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 17:57:32 +00:00
Sergey Biryukov ff7e86d14c Bump H3 headings to H2 on Themes screen for better accessibility.
props joehills.
fixes #33560.

git-svn-id: https://develop.svn.wordpress.org/trunk@33820 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:50:05 +00:00
Sergey Biryukov 0de0c060c1 Bump H3 headings to H2 on Tools screen for better accessibility.
props Cheffheid.
fixes #33607.

git-svn-id: https://develop.svn.wordpress.org/trunk@33819 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:31:38 +00:00
Sergey Biryukov 77b54f319d Bump H3 headings to H2 on Permalink Settings screen for better accessibility.
props Cheffheid.
fixes #33611.

git-svn-id: https://develop.svn.wordpress.org/trunk@33818 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:28:32 +00:00
Sergey Biryukov 7f3b90bc77 Bump H3 headings to H2 on WordPress Updates screen for better accessibility.
props Cheffheid.
fixes #33559.

git-svn-id: https://develop.svn.wordpress.org/trunk@33817 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:25:27 +00:00
Scott Taylor 413df72474 Favor using the consistent and agnostic string 'Attach' over 'Attach to a post' in the media list table.
Props pavelevap.
Fixes #33515.


git-svn-id: https://develop.svn.wordpress.org/trunk@33810 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 03:09:25 +00:00
Sergey Biryukov a47ee912ac Make a period translatable.
props mako09.
fixes #33594.

git-svn-id: https://develop.svn.wordpress.org/trunk@33802 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-29 01:39:51 +00:00
John Blackbourn a4808224ff Bring network admin user searching to parity with single site user searching by wrapping search terms in asterisks. This means that searches don't require an exact match and therefore significantly reduces friction when searching for users on the network admin screens.
Fixes #32913


git-svn-id: https://develop.svn.wordpress.org/trunk@33801 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-29 00:18:06 +00:00
Sergey Biryukov d5dd61424d Network Admin: Hide the bulk actions checkbox for super admins.
See [25125] for hiding the checkbox for the main site in Sites table.

props bordoni.
fixes #28529.

git-svn-id: https://develop.svn.wordpress.org/trunk@33777 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 03:48:47 +00:00
Helen Hou-Sandi 0c19c94561 Drop the hyphen from e-mail and standardize on email.
The AP Stylebook changed this in 2011, and we're woefully inconsistent, so let's go with the standard.

props morganestes, voldemortensen, niallkennedy (for patching on the previous AP style).
fixes #26156.


git-svn-id: https://develop.svn.wordpress.org/trunk@33774 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 03:16:02 +00:00
John Blackbourn d89398f945 Don't change the View Post button permalink in the sample permalink HTML when updating the slug on a published or future post.
Fixes #32954
Props boonebgorges, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@33773 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 20:56:54 +00:00
Sergey Biryukov 65c07b81c0 Remove wp-includes/comment-functions.php from the $_old_files array. See [33750].
props rachelbaker.
fixes #33569.

git-svn-id: https://develop.svn.wordpress.org/trunk@33772 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 20:39:58 +00:00
John Blackbourn 0d0a8353f5 Remove error from the query variables when cleaning up a URL in wp_admin_canonical_url().
Fixes #32847


git-svn-id: https://develop.svn.wordpress.org/trunk@33770 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 17:25:15 +00:00
John Blackbourn e95ce848f9 Correct the hook docs for the user_profile_update_errors action.
Fixes #33537
Props yamchhetri


git-svn-id: https://develop.svn.wordpress.org/trunk@33769 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 17:15:54 +00:00
Sergey Biryukov 30eb4853f0 Prevent unintended password change after clicking "Generate Password" and then "Cancel" when editing a user profile.
props peterwilsoncc.
fixes #33419 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@33766 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 00:10:39 +00:00
Sergey Biryukov a69c9ff66f Make post meta box toggles accessible.
props joedolson.
fixes #33544.

git-svn-id: https://develop.svn.wordpress.org/trunk@33762 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 15:22:57 +00:00
Weston Ruter 9c4f261598 Customizer: Ensure persistence of unchanged active state for controls, sections, and panels.
Props nikeo, westonruter.
Fixes #33428 for trunk.
See also #33494.


git-svn-id: https://develop.svn.wordpress.org/trunk@33754 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 07:25:20 +00:00
Weston Ruter e32f3cd3e1 Customizer: Prevent JS error during init when nav_menus panel is removed by plugin.
Fixes #33411 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33753 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 06:42:16 +00:00
Sergey Biryukov 6598033243 Remove rounded corners from "Choose from the most used tags" result in Tags meta box.
props tyxla.
fixes #31560.

git-svn-id: https://develop.svn.wordpress.org/trunk@33742 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 23:13:30 +00:00
Scott Taylor ff7fcf5f04 In WP_Users_List_Table::single_row(), $actions is not always set before being used.
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33735 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 20:37:50 +00:00
Scott Taylor 3b8c5529cb foreach is a statement, not a function.
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33734 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 20:27:56 +00:00
Scott Taylor 755d109d10 Instead of [33713], allow WP_Posts_List_Table::get_bulk_actions() to check edit_posts AND delete_posts.
Props DeBAAT.
Fixes #29789.


git-svn-id: https://develop.svn.wordpress.org/trunk@33733 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 20:11:27 +00:00
Sergey Biryukov b59d10ccac Multisite: Add 'invite_user' action that fires immediately after a user is invited to join a site, but before the notification is sent.
props ebinnion, MikeHansenMe, DrewAPicture.
fixes #33008.

git-svn-id: https://develop.svn.wordpress.org/trunk@33732 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 17:47:26 +00:00
Drew Jaynes 40ce8c68fe Docs: The type for the $t_time parameter in the post_date_column_time filter docs should be string, not array.
Props jjeaton
Fixes #33540.


git-svn-id: https://develop.svn.wordpress.org/trunk@33731 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 17:14:28 +00:00
Scott Taylor e1b1541932 Media:
When inserting an image into a post, the values in `wp.media.controller.Library` should not default to linking the image when no user settings are present.

The default display setting value for `link` is now `none`. User settings persist and will override or confirm this value based on user actions.

Props liljimmi, janhenckens, eherman24, wonderboymusic.
Fixes #31467.


git-svn-id: https://develop.svn.wordpress.org/trunk@33729 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 12:12:59 +00:00
Dion Hulse 3b525395cc Term Splitting: Switch to a faster cron unschedule process to benefit sites with thousands of affected jobs. Fix the cron hook name in the failsafe rescheduler.
Props Otto42, dd32, peterwilsoncc
See #33423


git-svn-id: https://develop.svn.wordpress.org/trunk@33727 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 04:31:52 +00:00
Scott Taylor 5f3879e37c With a few modifications in wp-admin/menu.php, we can eliminate the extra logic for Post and Page menu registration. Instead, they can just declare menu_position on post type registration.
Props scribu, wonderboymusic.
Fixes #16865.


git-svn-id: https://develop.svn.wordpress.org/trunk@33723 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 21:18:20 +00:00
Scott Taylor 9596ae0993 Posts List Table:
Don't show bulk actions if the user can't edit posts.

Props DrewAPicture.
Fixes #29789.


git-svn-id: https://develop.svn.wordpress.org/trunk@33713 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 16:27:44 +00:00
Scott Taylor e76b48a26c update-core.php help docs, update string to include translations: themes, plugins, and translations
Props netweb, DrewAPicture.
Fixes #28201.


git-svn-id: https://develop.svn.wordpress.org/trunk@33704 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 16:24:58 +00:00
Scott Taylor e4f8047716 In wp_ajax_add_meta(), do not juggle the value of $_POST and alter it directly. This was done so that edit_post() could pull $_POST out of the air by-reference and alter it (equally as bad). edit_post() accepts a $post_data array. Do that instead.
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33697 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 18:12:56 +00:00
Scott Taylor a1e5332489 Make 'Docs Committer' translatable.
Props dimadin. 
Fixes #33424.


git-svn-id: https://develop.svn.wordpress.org/trunk@33695 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 17:46:54 +00:00
Scott Taylor ab71eb93b1 When createing "Sample Page" on install, comments should be closed.
Props macmanx. 
Fixes #33490.


git-svn-id: https://develop.svn.wordpress.org/trunk@33693 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 17:41:16 +00:00
Scott Taylor 7dd261ce61 Comment List Tables:
* Toggle visibility of pending bubble when a comment is dynamically moderated
* Add a CSS class to the pending bubble to hide it / remove to show it

See #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33692 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 17:25:06 +00:00
Drew Jaynes e6466911d7 Docs: Add a changelog entry for the $post_type parameter added to the restrict_manage_posts hook in [33644].
Props pavelevap
Fixes #17891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33691 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 16:11:31 +00:00
Helen Hou-Sandi 961dd71cf3 List tables: Allow filtering of hidden and default hidden columns.
Similar to `get_hidden_meta_boxes()`, there are now filters named `default_hidden_columns` and `hidden_columns`.

props Compute, MikeHansenMe, chriscct7.
fixes #32499.


git-svn-id: https://develop.svn.wordpress.org/trunk@33689 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 15:31:30 +00:00
Dion Hulse 466500743f WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user.
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.

Props jobst.
Fixes #33480 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@33688 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 11:42:04 +00:00
Drew Jaynes e803952278 Docs: Fix some minor inline documentation syntax issues in the hook docs for the post_edit_category_parent_dropdown_args filter, introduced in [33682].
See #32246. See #33026.


git-svn-id: https://develop.svn.wordpress.org/trunk@33686 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 04:54:00 +00:00
Drew Jaynes a65c2e068a Docs: Fix a variety of inline documentation syntax issues and add some strategic spacing.
Fixes #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33685 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 04:12:45 +00:00
Drew Jaynes c53fe2779e Docs: Add missing @access tags to properties and methods in wp-admin/includes/class-wp-upgrader.
See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33684 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 04:04:23 +00:00
Drew Jaynes 3721940e0f Docs: Correct a typo in the summary for the Theme_Upgrader->bulk property.
Also adds a couple of missing `@access` tags.

Props kraftbj
See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33683 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 03:14:35 +00:00
Boone Gorges 57592ef976 Filter the arguments passed to wp_dropdown_categories() in the Categories post edit metabox.
The new 'post_edit_category_parent_dropdown_args' provides parity with other
places in wp-admin where `wp_dropdown_categories()` args are filtered, such as
'taxonomy_parent_dropdown_args'.

Props theMikeD.
Fixes #33026.

git-svn-id: https://develop.svn.wordpress.org/trunk@33682 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 01:27:15 +00:00
Drew Jaynes b09cedbd11 Docs: Standardize @deprecated tag formatting for deprecated functions in wp-admin/includes/ms-deprecated.php.
Props Alphawolf for the initial patch
Props DrewAPicture

See #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33675 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 22:25:41 +00:00
Scott Taylor 3b1e7ba1e0 After [33666], fix broken sprintf cruff.
See #17609.


git-svn-id: https://develop.svn.wordpress.org/trunk@33672 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 21:36:03 +00:00
Drew Jaynes 8edff9c979 Docs: Standardize @deprecated tag formatting and add missing DocBlocks to deprecated functions in wp-admin/includes/deprecated.php.
Opted not to use the multi-function DocBlock syntax in the name of not taking shortcuts in documentation for the sake of brevity.

Props Alphawolf for the initial patch.
See #28806


git-svn-id: https://develop.svn.wordpress.org/trunk@33671 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 21:22:26 +00:00
Drew Jaynes 5e6f651daf Docs: Add a missing summary to the DocBlock for wp_media_upload_handler().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33670 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 21:00:42 +00:00
Drew Jaynes 0af6d275b0 Docs: Clarify the different return conditions in the DocBlock for WP_List_Table->handle_row_actions().
This clarification follows the introduction of primary columns in 4.3. See #33313.

Props morganestes.
Fixes #33436.


git-svn-id: https://develop.svn.wordpress.org/trunk@33668 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 20:21:45 +00:00
Scott Taylor 695560bf58 In WP_Posts_List_Table::inline_edit(), check that $post_formats[0] is an array before traversing.
Props DrewAPicture.
Fixes #33025.



git-svn-id: https://develop.svn.wordpress.org/trunk@33667 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 20:18:35 +00:00