Scott Taylor
af101dec19
Comments: dynamically update the document title text of the Comments List Table page when dynamically updating the number of comments awaiting moderation.
...
Fixes #33414 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33821 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 17:57:32 +00:00
Sergey Biryukov
ff7e86d14c
Bump H3 headings to H2 on Themes screen for better accessibility.
...
props joehills.
fixes #33560 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33820 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:50:05 +00:00
Sergey Biryukov
30eb4853f0
Prevent unintended password change after clicking "Generate Password" and then "Cancel" when editing a user profile.
...
props peterwilsoncc.
fixes #33419 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@33766 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 00:10:39 +00:00
Sergey Biryukov
a69c9ff66f
Make post meta box toggles accessible.
...
props joedolson.
fixes #33544 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33762 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 15:22:57 +00:00
Weston Ruter
9c4f261598
Customizer: Ensure persistence of unchanged active state for controls, sections, and panels.
...
Props nikeo, westonruter.
Fixes #33428 for trunk.
See also #33494 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33754 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 07:25:20 +00:00
Weston Ruter
e32f3cd3e1
Customizer: Prevent JS error during init when nav_menus panel is removed by plugin.
...
Fixes #33411 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@33753 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 06:42:16 +00:00
Scott Taylor
7dd261ce61
Comment List Tables:
...
* Toggle visibility of pending bubble when a comment is dynamically moderated
* Add a CSS class to the pending bubble to hide it / remove to show it
See #11200 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33692 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 17:25:06 +00:00
Scott Taylor
25004acaa6
After [33662], remove unused var.
...
See #11200 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33663 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 17:18:51 +00:00
Scott Taylor
28e0ad2de1
Comment List Tables:
...
* Ensure that dynamic bubble counts are in sync by `comment_post_ID`
* Scope `:animated` to `#the-comment-list`
See #11200 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33662 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 16:35:21 +00:00
Scott Taylor
89ecad8808
JSHint after [33655].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@33660 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 06:30:48 +00:00
Scott Taylor
64944b7a87
Comments List Table:
...
* In a view that initially has comments, but they get removed due to user actions: show the `No Items` row instead of bombing out and showing nothing (which looks broken)
* To accomplish this, in `WP_Comments_List_Table::display()`: call `->display_rows_or_placeholder()` instead of `->display()`
* Listen for the end of row `.fadeOut()`s if necessary using jQuery Promises
Fixes #11200 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33657 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 05:53:41 +00:00
Scott Taylor
88e804f6c0
Comments List Table:
...
* Properly increment/decrement approved/pending bubbles in `response` column
See #11200 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33656 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 04:01:35 +00:00
Scott Taylor
9b6f5b6270
Comments List Table:
...
* Show count next to "Approved"
* Properly increment/decrement counts when row actions are clicked
* In `_wp_ajax_delete_comment_response()`, return the comment's `status` with the `supplemental` data
* Handle counts properly on each scenario of `undo`
See #11200 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33655 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 02:50:20 +00:00
Konstantin Obenland
2ec26f617f
Themes: Open preview when requesting a single theme in the installer.
...
Props kraftner, obenland.
Fixes #28735 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33650 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-19 18:53:36 +00:00
Scott Taylor
9b37cc043c
Correct typo in JSDoc for wp.updates.decrementCount
...
Props mt8.biz.
Fixes #33363 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33638 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-18 21:46:19 +00:00
Konstantin Obenland
e7c16b2d0a
Passwords: Use keyup event to prevent IE8's misinterpretation of propertychange.
...
Props adamsilverstein, peterwilsoncc.
Fixes #33385 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33625 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 18:45:33 +00:00
Andrew Ozz
b30fcd7597
Fix creating of extra <br /> tags in both PHP and JS variants of wpautop(). Add PHP tests to catch similar problems in the future.
...
Props valendesigns, azaozz. Fixes #33377 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33624 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 17:35:58 +00:00
Helen Hou-Sandi
7abf08a52c
Menu customizer: Ensure the search results section is full height.
...
fixes #33375 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33618 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-14 21:31:23 +00:00
Weston Ruter
a4bbc4454c
Customize: Fix keyboard accessibility for toggling screen options and contextual help.
...
Also fix layout of search results in mobile.
Props valendesigns, afercia, adamsilverstein.
Fixes #33184 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33617 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-14 21:22:57 +00:00
Weston Ruter
80bc70fc4b
Customize: Fix layout issues in panels and sections when resizing and autofocusing.
...
Also reverts [33157] which is no longer needed.
Props valendesigns, mattwiebe, westonruter, ocean90.
Fixes #33220 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33610 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-11 23:55:40 +00:00
Helen Hou-Sandi
0999b0182b
Customizer: Rename WP_New_Menu_Customize_Control to WP_Customize_New_Menu_Control for consistency.
...
props DrewAPicture.
fixes #33324 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33602 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-10 18:06:01 +00:00
Dominik Schilling (ocean90)
3f7b1ca2ff
Customizer: Remove obsolete .control-panel-back and .customize-overlay-close buttons.
...
props afercia, ocean90.
see #31336 .
fixes #33229 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33599 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-09 18:59:34 +00:00
Dominik Schilling (ocean90)
2d6c10b842
Customizer: Restore Shift + Clicking on widgets to open the widgets panel.
...
Includes an alternative for jQuery UI's `:focusable` selector because it has an ancestor visibility requirement, see https://github.com/jquery/jquery-ui/pull/1583 .
props westonruter.
fixes #33258 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33596 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-08 09:36:55 +00:00
Dominik Schilling (ocean90)
d834719f34
Nav menus: Adjust redundant titles in accessibility helpers.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@33540 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-03 21:03:59 +00:00
Helen Hou-Sandi
4f2573a707
Remove debug cruft from [33511].
...
see #32710 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33515 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 23:52:46 +00:00
Helen Hou-Sandi
3fd1376418
Menu customizer: More clearly separate search results from available items.
...
Available items now fade from view while you're searching, and there is an explicit way to clear search results. No results gives a better message, though still brief this time around.
props valendesigns, designsimply, DH-Shredder, helen.
fixes #32710 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33511 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 23:39:54 +00:00
Dominik Schilling (ocean90)
55b1dd3411
Nav menus: Make the selector for the edit menu item link more specific. Prevents clashing with other elements which have the same class.
...
fixes #33129 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33502 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 21:29:54 +00:00
Weston Ruter
05c32013d7
Customizer: Update nav_menu_locations[...] controls to remove placeholder menus from the dropdown options upon Save & Publish.
...
See #32814 .
Fixes #33176 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33496 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 19:33:07 +00:00
Mark Jaquith
37aa0574c4
Persist (and mask) the password on the install screen if the install does not proceed due to errors.
...
If you forget or enter an invalid username/e-mail, the password choosing shouldn't start over.
fixes #33162
git-svn-id: https://develop.svn.wordpress.org/trunk@33495 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 19:21:26 +00:00
Dominik Schilling (ocean90)
faac72a070
Themes: Remove legacy theme preview.
...
The pre-3.4 theme previewer doesn't work when using a static front page.
We kept the old theme preview for no-JS and some browsers that were less capable. But since browsers are doing a better job today we don't need to continue fixing/shipping this legacy code. Bye!
fixes #33178 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33492 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 18:35:40 +00:00
Weston Ruter
dbcb95c022
Customizer: Ensure that all existing menus are shown in the Custom Menu widget's dropdown.
...
* Ensure that a Custom Menu widget selecting a newly-inserted menu gets updated to use the new menu ID upon Save & Publish.
* Dynamically update the visibility of the Custom Menu widget's "no menus" message when the number of menus changes between 0 and 1+.
* Send all dirty Customized settings in `update-widget` Ajax request and `preview()` them so that the widget update/form callbacks have access to any data dependencies in the current Customizer session (such as newly created unsaved menus).
* Update link in Custom Menu widget to point to Menus panel as opposed to Menus admin page, when in the Customizer.
* Fix an issue with extra space at top immediately after creating new menu.
* Fix doubled `update-widget` Ajax requests when changing select dropdown; prevent initial from being aborted.
* Add missing `wp_get_nav_menus()` hooks to preview Customizer updates/inserts for `nav_menu` settings; includes tests.
* Update `wp_get_nav_menu_object()` to allow a menu object to be passed in (and thus passed through).
Props westonruter, adamsilverstein.
Fixes #32814 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33488 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 16:02:08 +00:00
Dominik Schilling (ocean90)
8db3eeec7d
Customizer: Add an aria-expanded attribute to Edit menu item toggles.
...
props afercia.
fixes #33129 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33483 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 09:49:55 +00:00
Mark Jaquith
11f4909315
Do not re-generate the password after pressing "cancel". Persist the state.
...
Also removes pass2 code not needed since we're generating from one field.
fixes #33164
git-svn-id: https://develop.svn.wordpress.org/trunk@33475 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 04:29:36 +00:00
Mark Jaquith
c13b00709b
Re-work user-profile.js so the password meter works in IE8 and password managers can fill multiple times.
...
props adamsilverstein
fixes #32886
git-svn-id: https://develop.svn.wordpress.org/trunk@33473 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 03:26:20 +00:00
Andrew Ozz
1558be9dfa
Fix updating of nonces on the Edit Post screen after the log in expires and the user logs in again.
...
Props iseulde, azaozz. Fixes #33098 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33468 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-28 22:06:52 +00:00
Mark Jaquith
90e39719d8
Lose the clunky setTimeout() code and just track the password value changes.
...
see #32886
git-svn-id: https://develop.svn.wordpress.org/trunk@33465 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-28 21:10:16 +00:00
Sergey Biryukov
962cc345ae
Plugins list table: Make selector for Details links more specific to prevent the Description header from being announced as "clickable".
...
props afercia.
fixes #32968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33462 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-28 14:49:41 +00:00
Weston Ruter
b53cbb1279
Customizer: Hide empty space in footer on small screens since it is only populated on larger screens.
...
Props obenland.
Fixes #33138 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33454 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-28 03:42:36 +00:00
Scott Taylor
68ff8b1a80
Passwords UI: clean up the new JS in wp-admin/js/user-profile.js.
...
Instead of wrapping `#pass1` in a `<span>` dynamically, add the `<span>` to the HTML in PHP. It currently has no styling.
Fixes #33145 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33450 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-27 21:24:36 +00:00
Konstantin Obenland
6bca6cb0b2
Customizer: Use correct spelling when instantiating CustomizeImageCropper.
...
Introduced in [33329].
git-svn-id: https://develop.svn.wordpress.org/trunk@33445 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-27 15:54:51 +00:00
Ella Iseulde Van Dorpe
aed9a8c5bc
Editor: word count: better names for types.
...
Also fix it in wp_trim_words().
Fixes #30966 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33440 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-27 11:18:55 +00:00
Mark Jaquith
80c9c8cfca
Toggle between dashicons-hidden and dashicons-visibility in the password hide/show button.
...
fixes #33135
git-svn-id: https://develop.svn.wordpress.org/trunk@33438 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-27 03:12:55 +00:00
Sergey Biryukov
67f74ea9c1
Comment status box: Move focus back to Edit link when changing the date.
...
props afercia.
fixes #33062 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33422 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-26 02:25:43 +00:00
Dominik Schilling (ocean90)
cac1d55621
Customizer: Add missing text or labels to some nav menu UI controls.
...
props afercia, celloexpressions, westonruter.
fixes #32715 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33413 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-24 20:27:04 +00:00
Dominik Schilling (ocean90)
c412fd0398
Customizer: Hide inactive reorder buttons for menu items from assistive technologies.
...
props afercia.
fixes #33114 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33412 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-24 17:56:50 +00:00
Weston Ruter
3ceb11bea4
Customizer: Update JS variable to reference renamed data attribute for available nav menu object.
...
Fixes regression for a change that was missed in [33366].
Props valendesigns.
Fixes #32708 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33392 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-23 06:01:30 +00:00
Mark Jaquith
b77d19aa8b
Do not propagate empty passwords from the hidden form field.
...
fixes #32886
git-svn-id: https://develop.svn.wordpress.org/trunk@33384 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-23 04:59:04 +00:00
Weston Ruter
9e383a560a
Customizer: Introduce customize_nav_menu_available_item_types and customize_nav_menu_available_items filters.
...
Allows for new available menu item types/objects to be registered in addition to filtering the available items that are returned for each menu item type/object.
Props valendesigns, imath, westonruter.
See #32832 .
Fixes #32708 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33366 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-22 20:28:03 +00:00
Mark Jaquith
2d85378c52
Soothe JSHint's rankled spirits
...
git-svn-id: https://develop.svn.wordpress.org/trunk@33365 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-22 18:55:27 +00:00
Mark Jaquith
9ca3978a3e
Introduce a Cancel button and onUnload warning for password changes.
...
fixes #33079
props johnjamesjacoby
git-svn-id: https://develop.svn.wordpress.org/trunk@33364 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-22 18:35:51 +00:00