Commit Graph
5538 Commits
Author SHA1 Message Date
Boone Gorges fff6412f91 Move excluded_terms filter in get_adjacent_post().
The filter was added in 4.4 [34528] #9571, but in a place where it could not
affect the adjacent post query.

Fixes #35211.

git-svn-id: https://develop.svn.wordpress.org/trunk@36078 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 19:56:32 +00:00
Boone Gorges d7fccb6c01 Respect $_wp_suspend_cache_invalidation in clean_object_term_cache().
Props mwidmann.
Fixes #35208.

git-svn-id: https://develop.svn.wordpress.org/trunk@36076 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 19:28:06 +00:00
John Blackbourn 858cf7d215 Docs: Miscellaneous docblock code quality tweaks.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36074 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 07:52:04 +00:00
johnbillion ec46b01201 Docs: @see != @since.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36073 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 07:12:02 +00:00
John Blackbourn a6556195d8 Docs: Miscellaneous docblock corrections.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36069 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 06:30:09 +00:00
Andrew Ozz 83f93e5e70 Editor: remove the format_for_editor filter from the_editor_content after it runs as the next editor instance on the same page may not need it.
Props marcochiesi, azaozz.
Fixes #28403.

git-svn-id: https://develop.svn.wordpress.org/trunk@36062 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-22 22:39:01 +00:00
John Blackbourn 5ce7879548 Revert [35804]. This change has unintended side effects, notably that media URLs in the admin area now unexpectedly use the https scheme. A more comprehensive approach will be taken in 4.5.
See #13941, #35120


git-svn-id: https://develop.svn.wordpress.org/trunk@36061 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-22 13:01:31 +00:00
Gary Pendergast 0b9d32a614 Embeds: Don't show embed discovery link on a static front page.
There's currently no iframe content being generated for a static front page. Giving out a link to that isn't an ideal user experience.

Props peterwilsoncc.

Fixes #35194 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@36059 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-22 10:49:20 +00:00
Boone Gorges 1bf73525e8 Order terms by 'name' when populating object term cache.
[34217] removed the `ORDER BY` clause from `update_object_term_cache()`, for
improved performance. But this proved to cause problems in cases where users
were expecting the results of `get_the_terms()` to be ordered by 'name'. Let's
revert the change for the time being, and look into more disciplined ordering
in a future release.

Props afercia.
See #28922. Fixes #35180.

git-svn-id: https://develop.svn.wordpress.org/trunk@36056 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-22 01:50:08 +00:00
John Blackbourn da011967e7 Login: Revert [34213] and [35897]. It has become apparent that there is a need for a separate function (and corresponding filter) which allows for the login form action URL to differ from the URL used to access the login form, so that plugins or implementations which change the login URL do not need to worry about handling the form submission at the same URL.
For now, we'll revert to the pre-4.4 behaviour of hard-coding the login form action URL as `wp-login.php` and look at implementing a separate function and corresponding filter in 4.5.

Props KrissieV, salcode, JPry
Fixes #34925
See #35103


git-svn-id: https://develop.svn.wordpress.org/trunk@36042 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 03:22:32 +00:00
Boone Gorges 817013978d Respect approval status when determining comment page count in comments_template().
Since 4.4, when fetching the first page of comments and the 'newest' comments
are set to display first, `comments_template()` must perform arithmetic to
determine which comments to show. See #8071. This arithmetic requires the
total comment count for the current post, which is calculated with a separate
`WP_Comment_Query`. This secondary comment query did not properly account for
non-approved comment statuses; all unapproved comments should be part of the
comment count for admins, and individual users should have their own
unapproved comments included in the count. As a result, `comments_template()`
was, in some cases, being fooled into thinking that a post had fewer comments
available for pagination than it actually had, which resulted in empty pages
of comments.

We correct this problem by mirroring 'status' and 'include_unapproved' params
of the main comment query within the secondary query used to calculate
pagination.

Fixes #35068.

git-svn-id: https://develop.svn.wordpress.org/trunk@36040 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 03:06:41 +00:00
John Blackbourn 4024cb673a Comments: When a comment is submitted, ensure the user_ID element in the array that's passed to the preprocess_comment filter gets populated.
Fixes #34997


git-svn-id: https://develop.svn.wordpress.org/trunk@36038 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 02:46:44 +00:00
Gary Pendergast 59b8f0da7c Texturize: Transform & into & in tag attributes.
[35709] was overly broad, and stopped transforming `&` characters within tag attributes. So that sites aren't generating invalid HTML, we need to restore this functionality, while continuing to not transform `&` within blocked tags.

Fixes #35008 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@36036 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 02:42:30 +00:00
Gary Pendergast d6bf586de3 Query: Remove title from the public query vars list.
[33706] added `title` as a public query var, but there's not really a practical need for this, and it interferes with any plugin that uses `title` as a query var for itself.

Props tyxla.

Fixes #35115 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@36034 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 00:42:43 +00:00
Drew Jaynes 2213bfba0c Docs: Add missing notations for the optional $tab_index and $extended parameters in the DocBlock for the deprecated the_editor() function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36033 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-20 21:20:14 +00:00
Andrew Ozz 58b7d3e136 Responsive images: fix calculations when determining whether to include particular image file in srcset.
Props joemcgill.
Fixes #34955 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36031 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-20 02:38:34 +00:00
Drew Jaynes c593ceb5e8 Docs: Add missing parameter and return notations to the DocBlock for the deprecated get_usernumposts() function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36030 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 19:40:28 +00:00
Drew Jaynes 6e8b83cb65 Docs: Add missing parameter and return notations in the DocBlock for get_profile().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36028 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 09:03:11 +00:00
Drew Jaynes 44fc67cc24 Docs: Properly mark the $classname parameter as optional.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36027 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:59:49 +00:00
Drew Jaynes bb8067b666 Docs: Add missing parameter and return notations to the DocBlock for the deprecated wp_specialchars() function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36026 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:57:49 +00:00
Drew Jaynes a052a682a1 Docs: Add missing parameter notations and descriptions in the DocBlock for get_link().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36025 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:53:55 +00:00
Drew Jaynes e2be10ec2c Docs: Add missing parameter and return notations in the DocBlock for the deprecated _nc() function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36024 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:47:12 +00:00
Drew Jaynes 62e657a2f0 Docs: Add a missing summary, parameter, and return descriptiosn to the DocBlock for the deprecated function, get_linkrating().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36023 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:23:00 +00:00
Drew Jaynes a2f5cdb5bb Docs: Add a missing notation for the $gmt_time parameter in the DocBlock for spawn_cron().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36022 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:19:54 +00:00
Drew Jaynes f8119eef50 Docs: Add missing DocBlocks for hash_hmac() and _hash_hmac().
Both will be ignored from parsing as and serve as compat functions for PHP's `hash_hmac()`.

Introduced in [18111].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36021 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 05:10:29 +00:00
Drew Jaynes 64592f8c0b Docs: Fix inline comment syntax in _mb_strlen(), an internal compat method for mb_strlen().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36020 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 04:58:59 +00:00
Drew Jaynes df9291938c Docs: Add missing DocBlocks for mb_strlen() and _mb_strlen().
Both will be ignored from parsing as and serve as compat functions for PHP's `mb_strlen()`, which is not enabled by default.

Introduced in [32114].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36019 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 04:55:50 +00:00
Drew Jaynes 73b701b030 Docs: Fix inline comment syntax in _mb_substr(), an internal compat method for mb_substr().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36018 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 04:49:42 +00:00
Drew Jaynes c848b5f670 Docs: Add missing DocBlocks for mb_substr() and _mb_substr().
Both will be ignored from parsing as and serve as compat functions for PHP's `mb_substr()`, which is not enabled by default.

Introduced in [17621].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36017 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 04:46:43 +00:00
Andrea Fercia 82e5450328 Accessibility: Improvements for the Authentication Check modal dialog "Close X".
Removes the title attribute and uses a `<button>` element instead of a `<div>`.
Also simplifies the CSS and takes care of the hover/focus style.

Fixes #35142.

git-svn-id: https://develop.svn.wordpress.org/trunk@36014 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:50:13 +00:00
Drew Jaynes fe89f7620f Docs: Add missing parameter and return descriptions to the DocBlocks for _wp_object_name_sort_cb() and _wp_object_count_sort_cb(), both uasort() callbacks.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36013 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:37:58 +00:00
Drew Jaynes 96c5ced339 Docs: Add a missing notation for the $context parameter in the DocBlock for _nx_noop().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36012 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:15:50 +00:00
Drew Jaynes f8fc65acb3 Docs: Fix the syntax for the get_previous_post_link() DocBlock to ensure it's read and parsed as such instead of as a multi-line comment.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36011 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:13:03 +00:00
Drew Jaynes df5f99d5e3 Docs: Add a missing summary, description, and @since version to the DocBlock for wp_redirect_admin_locations().
Introduced in [19880].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36010 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:07:53 +00:00
Drew Jaynes cb6348b7ce Docs: Add a missing notation for the $bookmark_id parameter in the DocBlock for clean_bookmark_cache().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36009 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:00:07 +00:00
Boone Gorges aa38888d60 Add current-cat-ancestor class to ancestor items in wp_list_categories().
Pairs nicely with `current-cat-parent`.

Props jrchamp, swisssipdy, ardathksheyna, wonderboymusic.
Fixes #10676.

git-svn-id: https://develop.svn.wordpress.org/trunk@36008 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 18:37:41 +00:00
Aaron Jorbin 3969f2968f Remove RDIO from oEmbed providers
RDIO is shutting down. https://www.rdio.com/farewell/

Props swissspidy
Fixes #35152



git-svn-id: https://develop.svn.wordpress.org/trunk@36007 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 18:15:28 +00:00
Boone Gorges 6d9f50febd Ensure that wp_list_categories() supports comma-separated lists for 'exclude' and 'exclude_tree'.
[34696] introduced a regression whereby comma-separated values for 'exclude'
and 'exclude_tree' would be handled improperly when merging the two parameters,
resulting in category IDs being incorrectly dropped from the combined array.

Props gblsm, hnle.
Fixes #35156.

git-svn-id: https://develop.svn.wordpress.org/trunk@36005 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 18:11:44 +00:00
Boone Gorges fdeed90e77 Ensure get_terms() results are unique when using 'meta_query'.
The introduction of 'meta_query' to `get_terms()` in 4.4 made it possible for
`get_terms()` to erroneously return duplicate results. To address the issue,
we add the `DISTINCT` keyword to the SQL query when a 'meta_query' parameter
has been provided.

Props @jadpm.
Fixes #35137.

git-svn-id: https://develop.svn.wordpress.org/trunk@36003 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 17:43:46 +00:00
Sergey Biryukov cca910fcbd Docs: Fix copy/paste error in wp_remote_retrieve_cookies() description.
Props mark8barnes.
Fixes #35157.

git-svn-id: https://develop.svn.wordpress.org/trunk@36002 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 17:22:52 +00:00
Pascal Birchler ab8cff7827 In WP::handle_404(), make sure $wp_query->post is a WP_Post object before cloning it.
Props igmoweb for initial patch.
See #35013.

git-svn-id: https://develop.svn.wordpress.org/trunk@35994 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 18:12:50 +00:00
Drew Jaynes 203199de6f Docs: Add missing parameter notations to the DocBlock for get_author_posts_url().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35993 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 17:29:39 +00:00
Drew Jaynes 8fd68ed6ea Docs: Add a better summary, missing @since version, parameter and return descriptions to the DocBlock for _get_widget_id_base().
Introduced in [11484].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35992 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 17:26:28 +00:00
Drew Jaynes d8174f6046 Docs: Add a missing summary, @since version, and parameter descriptions in the DocBlock for _register_widget_form_callback().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35991 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 17:22:40 +00:00
Drew Jaynes 90cee037c2 Docs: Fix syntax for marking parameters optional in the DocBlock for is_active_widget().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35990 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 17:18:53 +00:00
Drew Jaynes 87653e2eb3 Docs: Add a missing summary, @since version, and parameter descriptions to the DocBlock for _register_widget_update_callback().
Introduced in [10798].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35989 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 17:15:53 +00:00
Drew Jaynes b56bcec8cc Docs: Add missing parameter and return descriptions to the DocBlock for _wp_get_user_contactmethods().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35986 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 16:40:18 +00:00
Drew Jaynes ae560a7712 Docs: Add a missing summary and @since version to the DocBlock for _maybe_update_core().
Introduced in [10583].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35985 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 16:37:25 +00:00
Boone Gorges 22b0cb2029 Introduce 'tag-link-position-x' class to tag cloud links.
The new class describes the cardinal position of a link in the cloud, allowing
more fine-grained CSS and JS targeting.

Props Mte90, chmac.
Fixes #5172.

git-svn-id: https://develop.svn.wordpress.org/trunk@35984 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 16:26:06 +00:00
Drew Jaynes 34bb276504 Docs: Add a missing summary, parameter, and return notations to the DocBlock for strip_shortcode_tag().
Introduced in [18952].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35982 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 23:22:33 +00:00