Commit Graph

  • e3ac341f24 Add 2 noop methods to WP_List_Table: ->column_default() and ->column_cb(). Scott Taylor 2015-01-16 17:41:50 +00:00
  • 07d899740e In WP_Filesystem_Base subclasses that set $wp_base, remove this dead code. Scott Taylor 2015-01-16 17:22:07 +00:00
  • b0c6a64fbd WP_Filesystem_Base should declare $errors and $options as fields for use by subclasses. Scott Taylor 2015-01-16 17:09:35 +00:00
  • 60f2983b2e Bail out of hierarchy loops in _get_term_children(). Boone Gorges 2015-01-16 17:09:11 +00:00
  • 8ae64f6384 Bail out of hierarchy loops in _pad_term_counts(). Boone Gorges 2015-01-16 16:45:21 +00:00
  • 18dbceee8c Add <s> to $allowedtags in KSES. Scott Taylor 2015-01-16 16:06:47 +00:00
  • db1ace58ca In comment_form(), add the HTML5 required attribute next to aria-required in fields that utilize it. Scott Taylor 2015-01-16 15:55:50 +00:00
  • af146fef8c In paginate_links(), don't override custom format arguments when setting up default 'add_args'. Boone Gorges 2015-01-16 15:48:24 +00:00
  • 7c707c6633 Add @ignore to _wp_scripts_maybe_doing_it_wrong(). Scott Taylor 2015-01-16 05:37:06 +00:00
  • 8ebe917c6b In wp_ajax_parse_media_shortcode(), don't require a global $post for all passed shortcodes. Scott Taylor 2015-01-16 05:18:17 +00:00
  • 83b6fad852 In HTML5, the action attribute is no longer required. Remove this attribute when empty. Scott Taylor 2015-01-16 04:15:52 +00:00
  • c8c8b66bae When a hyphen - or double hyphen -- was at the start or the end of a string, it wasn't texturized correctly. Gary Pendergast 2015-01-16 03:54:00 +00:00
  • d266ecd5b2 Media: Prevent filter selects from jiggling when the spinner shows. Helen Hou-Sandi 2015-01-16 02:59:59 +00:00
  • c6ba804b33 Make _wp_scripts_maybe_doing_it_wrong( $function ) "private". Scott Taylor 2015-01-16 02:41:07 +00:00
  • 58d931dfc7 Allow comment_post_ID to be passed to wp_update_comment(), so that a comment can be moved to a different post. Gary Pendergast 2015-01-16 02:38:30 +00:00
  • 28d654837d After [31192], create a function, wp_styles(), to reduce duplicated code in functions.wp-styles.php. The style functions can reuse wp_scripts_maybe_doing_it_wrong( $function ) internally. Scott Taylor 2015-01-16 02:30:08 +00:00
  • e1da69195d In wp_print_scripts(), bail if $handles is false and the $wp_scripts global has not been instantiated. Scott Taylor 2015-01-16 02:27:49 +00:00
  • 7ccdc6b470 functions.wp-scripts.php contains a lot of duplicated code. Make 2 new functions: wp_scripts() and wp_scripts_maybe_doing_it_wrong( $function ), to encapsulate the repeated logic. Scott Taylor 2015-01-16 02:06:03 +00:00
  • acbf60c9a6 After [31186], remove figcaption from the list of inline elements that are autop'd in Tests_Formatting_Autop::test_that_wpautop_treats_inline_elements_as_inline(). Scott Taylor 2015-01-16 01:50:47 +00:00
  • bcc7f9e093 In WP_User, ->get_role_caps() and ->update_user_level_from_caps() must be called inside ->add_cap() and ->remove_cap() after updating user meta. ->has_cap() checks are currently failing directly after calling ->add_cap(). Scott Taylor 2015-01-16 01:48:36 +00:00
  • 5412af65d8 Revert [31032], this did not get much love. Scott Taylor 2015-01-16 01:10:39 +00:00
  • 5acc6bdb58 In PHP 5.0.0, is_a() became deprecated in favour of the instanceof operator. Calling is_a() would result in an E_STRICT warning. Scott Taylor 2015-01-16 01:05:52 +00:00
  • 102fb4ac5c Replace the 3 remaining occurrences of wpspin GIF with spinner. Scott Taylor 2015-01-16 00:32:45 +00:00
  • 0c71d0033a Ensure that <figcaption> is not autop'd. Scott Taylor 2015-01-16 00:26:36 +00:00
  • adc9a1d565 TinyMCE: remove the fade in/out when opening/closing native modals to match the rest of our UI. Props afercia, avryl. Fixes #27388. Andrew Ozz 2015-01-15 23:28:39 +00:00
  • ff779e2d0e Twenty Fifteen: move js and no-js class name functionality out of header template and into a wp_head hook in functions.php file so that the JavaScript functionality isn't hard-coded into a template file. Lance Willett 2015-01-15 23:09:07 +00:00
  • f09026e439 Twenty Fifteen: remove unused CSS rules for wp_page_menu since are not used in the theme. And a bit of CSS cleanup. Lance Willett 2015-01-15 23:04:28 +00:00
  • 541ec337cf Twenty Fifteen: remove border on post navigation when post thumbnail is available. Lance Willett 2015-01-15 23:02:24 +00:00
  • 8ab449ae35 List tables: Use CSS :nth-child() selectors for zebra striping. Helen Hou-Sandi 2015-01-14 22:13:03 +00:00
  • 84c0411bcc TinyMCE: select the iframe element by id. Needed as some browser extensions insert extra elements in the page. Props avryl, see #30785. Andrew Ozz 2015-01-14 21:32:23 +00:00
  • 4b6957c852 Support array values in WP_Date_Query::validate_date_values(). Boone Gorges 2015-01-14 16:50:09 +00:00
  • 1a930c5d43 Don't overcheck the expected return from get_blog_details() in get_blogaddress_by_id() Jeremy Felt 2015-01-14 05:32:19 +00:00
  • 02d9bcbb7c Revert [31173] and target only taxonomy and link manager tables in keyboard focus code. Sergey Biryukov 2015-01-13 14:00:15 +00:00
  • 74bb197a4a Customizer: Use deep-link for Widgets in toolbar on front-end. Sergey Biryukov 2015-01-13 07:44:57 +00:00
  • 4b498e9201 Twenty Fifteen: Add print section to the table of contents in the stylesheet. Sergey Biryukov 2015-01-13 07:20:51 +00:00
  • b61f6f3a60 Scope attachment selectors in media views to avoid interfering with attachment pages on front-end. Sergey Biryukov 2015-01-13 07:15:24 +00:00
  • cfa5aa457d Reveal row actions on focus on taxonomy screens. Sergey Biryukov 2015-01-13 07:01:49 +00:00
  • 819a53be46 Add 'user_id' to the list of fields wp_update_comment() can update. Sergey Biryukov 2015-01-13 06:47:33 +00:00
  • a744bb9a5f Add 'comment_type' to the list of fields wp_update_comment() can update. Sergey Biryukov 2015-01-13 06:41:19 +00:00
  • 9b0cf1bd5b Ensure we're using the correct @ignore phpDocumentor tag to mark elements that should be skipped when parsing. Drew Jaynes (DrewAPicture) 2015-01-13 00:50:32 +00:00
  • 1f9ee350fc Remove an erroneous @internal tag from the DocBlock for get_children(). Drew Jaynes (DrewAPicture) 2015-01-13 00:07:39 +00:00
  • 865185903b There are some random add_action() and add_filter() calls littered around some files in wp-includes/. These should be moved to wp-includes/default-filters.php with the rest of the registered hooks. It seems like this was the best practice for awhile and then we randomly stopped. This file loads way before any of the includes, so the hooks will be registered for any request that loads WordPress, even SHORTINIT - a lot of the hooks registered won't run anyways (that's already the case). Scott Taylor 2015-01-12 16:39:39 +00:00
  • 47ba5e6c2e WP_Themes_List_Table accesses $_pagination_args from the parent class. Switch $_pagination_args to protected in WP_List_Table. Scott Taylor 2015-01-12 16:25:30 +00:00
  • 47a74bb21f Add a private field to WP_Terms_List_Table, $level. Scott Taylor 2015-01-12 16:22:38 +00:00
  • b3f726efc4 Add a private field to WP_Posts_List_Table, $is_trash. Scott Taylor 2015-01-12 16:21:08 +00:00
  • e5672bd8c5 Add a private field to WP_Plugin_Install_List_Table, $error. Scott Taylor 2015-01-12 16:18:52 +00:00
  • 02eaef3ae0 In lieu of refactoring, add a private field to WP_MS_Themes_List_Table, $has_items. Ideally, this class would overload ->has_items() and not set a private field. Scott Taylor 2015-01-12 16:16:16 +00:00
  • f0c4ab3e69 Add 2 private fields to WP_Media_List_Table, $detached and $is_trash. Scott Taylor 2015-01-12 16:07:41 +00:00
  • 243d50d2f7 After [31146], properly declare $user_can as a private field in WP_Comments_List_Table. Scott Taylor 2015-01-12 16:01:53 +00:00
  • 32b020bf05 More concise documentation for wp_install_maybe_enable_pretty_permalinks() See #6481. Props ericlewis. Dion Hulse 2015-01-12 04:32:35 +00:00
  • 0aaa2f0f32 The new wp_install_maybe_enable_pretty_permalinks() function doesn't need to be pluggable. See #6481. Props nacin, valendesigns Dion Hulse 2015-01-12 04:30:01 +00:00
  • 0eb9f7e414 Use a less complex approach for enforcing path slashes in update_blog_details() Jeremy Felt 2015-01-12 04:20:47 +00:00
  • d759c0ef23 Check for existence of data from get_blogaddress_by_id() before returning a URL Jeremy Felt 2015-01-12 02:23:43 +00:00
  • 331262b544 Update home and siteurl after path slashes are validated in update_blog_details() Jeremy Felt 2015-01-12 01:56:04 +00:00
  • f9e9287875 Enforce leading and trailing slashes on paths updated with update_blog_details() Jeremy Felt 2015-01-12 01:42:46 +00:00
  • 0b993ffe35 If get_avatar_data() is passed an empty value for the default avatar, we should be using the site's avatar_default option instead. Gary Pendergast 2015-01-12 00:22:12 +00:00
  • 69f8b26d89 In get_avatar_data(), there's no need to return false if we couldn't find an avatar, as Gravatar can handle being given an empty email hash. This allows the default avatar to show when no email address is given. Gary Pendergast 2015-01-12 00:19:34 +00:00
  • d0fab598e7 In get_avatar(), revert the <img> tag attributes to using single quotes, instead of double quotes. This behaviour was changed in [31107], but caused problems for code that attempted to parse the <img> tag. Gary Pendergast 2015-01-12 00:02:31 +00:00
  • 156a673660 In WP_Query, only call magic method internals again whitelists of properties and methods, $compat_fields and $compat_methods. Remove __unset() since __set() is not implemented. Scott Taylor 2015-01-11 22:40:53 +00:00
  • 1178e8a6e1 In WP_Comment_Query, only allow __call() to run against ->get_search_sql(). Scott Taylor 2015-01-11 22:32:44 +00:00
  • f6d7c5e52f In wp_xmlrpc_server, only allow __call() to run against ->_multisite_getUsersBlogs(). Scott Taylor 2015-01-11 22:30:26 +00:00
  • cd3fde69bb In WP_oEmbed, only allow __call() to run against a whitelist of methods, $compat_methods. Scott Taylor 2015-01-11 22:26:55 +00:00
  • 5b6858eff8 In WP_Roles, only allow __call() to run against ->_init(). Scott Taylor 2015-01-11 22:23:00 +00:00
  • 274253629f In WP_List_Table, only call magic method internals again whitelists of properties and methods, $compat_fields and $compat_methods. Scott Taylor 2015-01-11 22:19:58 +00:00
  • ad6dd738b2 In WP_Filesystem_Base, make the only private member, $cache, public and remove magic methods. $cache was always public until [28487], has been essentially public via a magic method since. Scott Taylor 2015-01-11 22:03:59 +00:00
  • bbc7ca2d0d In WP_User_Query, only call magic method internals against a whitelist of properties, $compat_fields. Scott Taylor 2015-01-11 21:59:54 +00:00
  • 43b2de66c6 TinyMCE wpView: when clicking in the editor optimize the caret placement before or after a view. Props avryl, fixes #30938. Andrew Ozz 2015-01-11 20:41:36 +00:00
  • 5a29757b92 TinyMCE: fix (switch) the indent/outdent icons in RTL mode so the arrow points at the proper direction. Props avryl, fixes #21281. Andrew Ozz 2015-01-11 20:29:56 +00:00
  • 29d06de35d Walker::$has_children should be public for backward compatibility. Boone Gorges 2015-01-11 01:55:34 +00:00
  • 77128eb048 Default $parent in category_exists() should default to null rather than 0. Boone Gorges 2015-01-11 01:25:19 +00:00
  • f323dc9b48 WP_Ajax_Response has one property only, $responses. It was public until [28508], when it became private in name only. Is it worth 4 magic methods to pretend that this property is private? It is not. Scott Taylor 2015-01-11 00:12:47 +00:00
  • ad81bf20db In WP_Error: Scott Taylor 2015-01-11 00:00:05 +00:00
  • 406b174a55 In Walker: Scott Taylor 2015-01-10 23:43:43 +00:00
  • 14555b3af2 In WP_MatchesMapRegex: Scott Taylor 2015-01-10 23:27:00 +00:00
  • f90b923777 In WP_Text_Diff_Renderer_Table: Scott Taylor 2015-01-10 22:57:17 +00:00
  • cdb5c75ab2 In Custom_Image_Header: wonderboymusic 2015-01-10 22:10:02 +00:00
  • b23a9d9dff In Custom_Background: Scott Taylor 2015-01-10 21:58:19 +00:00
  • a8cf928200 get_post() takes $output as its 2nd param. The @return annotation should reflect the function's ability to return an array. Scott Taylor 2015-01-10 21:37:23 +00:00
  • 358b309da9 In edit-form-advanced.php: Scott Taylor 2015-01-10 21:20:01 +00:00
  • d4c4205f31 get_header_image() can return false. In Custom_Image_Header->step_1(), check the value before setting the background-image portion of the style attribute. Setting the the URL to empty string will cause the current request to be set as the source of the background image. Scott Taylor 2015-01-10 21:07:54 +00:00
  • 0f54cc95b3 Since get_theme_mod() returns false on failure, $background_image_thumb can be set to it and checked instead of calling get_background_image() 3 times in Custom_Background->admin_page(). Scott Taylor 2015-01-10 20:43:12 +00:00
  • 061daaa7ee Declare $action as a global in wp-admin/comment.php. Scott Taylor 2015-01-10 20:41:04 +00:00
  • 979ba60a57 Fix some @param docs that have chars too close them. Add @property annotations to WP_User and WP_Post. Remove erroneous @params from image editor class methods. Officially add the property $_column_headers to WP_List_Table. Scott Taylor 2015-01-10 06:56:51 +00:00
  • 349e5cb318 Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Constructors do not have meaningful return values, anything that is returned from here is discarded. Scott Taylor 2015-01-10 06:53:48 +00:00
  • cb85e15f06 Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value - anything that is returned is discarded. Scott Taylor 2015-01-10 06:12:25 +00:00
  • bc723548a7 Declare $wp_version, $required_php_version, and $required_mysql_version as globals in install and upgrade admin files. Scott Taylor 2015-01-10 05:56:45 +00:00
  • 38e18d800c In wp-admin/includes/revision.php, $post->modified is a coding error. It should be $post->post_modified. Scott Taylor 2015-01-10 05:49:24 +00:00
  • 164b4f21c9 WP_Upgrader will take any "skin" that is passed to it, and set ->skin via composition. The default type of ->skin is WP_Upgrader_Skin, which doesn't have methods declared for ->bulk_header() and ->bulk_footer(). Add noop methods to WP_Upgrader_Skin. Scott Taylor 2015-01-10 05:41:05 +00:00
  • 77cffd8edf Admin globals: Scott Taylor 2015-01-10 05:28:46 +00:00
  • c3bd2252f5 Use PHP_SAPI constant instead of php_sapi_name() in iis7_supports_permalinks(), wp_fix_server_vars(), and wp_redirect(). Scott Taylor 2015-01-10 04:58:49 +00:00
  • 44a3c002f5 In wp_ajax_upload_attachment(), wp_check_filetype_and_ext() doesn't need a 3rd param - it already defaults to null. Passing false would fail a strict check Scott Taylor 2015-01-10 04:54:13 +00:00
  • 23d6e28390 TinyMCE editor-expand: when kitchensink is off hide the statusbar on loading, and when the editor is shorter then the viewport. Props avryl, fixes #30961. Andrew Ozz 2015-01-10 01:32:00 +00:00
  • 47cfdb5ced Media modal: do not attempt to focus the hidden file input field added by Plupload when tabbing. Props afercia, fixes #30392. Andrew Ozz 2015-01-09 21:46:03 +00:00
  • b3322a9604 In Custom_Background and Custom_Header: Scott Taylor 2015-01-09 21:06:13 +00:00
  • 38f87e7c56 After [31016], would be cool if we actually included the froogaloop file to interact with Vimeo. Scott Taylor 2015-01-09 20:03:58 +00:00
  • d5c9eb41d7 In get_permalink(), don't resolve to pretty permalink if post has 'future' status. Boone Gorges 2015-01-09 16:39:56 +00:00
  • 68191cc15c Add variable type for sync_category_tag_slugs() parameters. Sergey Biryukov 2015-01-09 11:18:22 +00:00
  • 1710690c99 Avoid a PHP notice in _WP_Editors::wp_fullscreen_html() when no $post global is set. Sergey Biryukov 2015-01-09 10:27:05 +00:00
  • 1e5ed7fdfd Toolbar: Make network admin accessible via keyboard. Sergey Biryukov 2015-01-09 09:50:39 +00:00
  • 1c88f482bf Use localized format for Last Updated date in plugin details modal, for consistency with [31055]. Sergey Biryukov 2015-01-09 06:20:08 +00:00