Commit Graph

  • c4b23f9fc3 Eliminate use of extract() in Walker_Category_Checklist::start_el(). Scott Taylor 2014-05-15 03:13:44 +00:00
  • 85d6f8e54f Eliminate use of extract() in wp_terms_checklist(). Scott Taylor 2014-05-15 03:08:46 +00:00
  • 98ca12ef2e Eliminate use of extract() in wp_star_rating(). Scott Taylor 2014-05-15 02:56:56 +00:00
  • 5e046b92fd (REALLY) Eliminate use of extract() in wp_insert_link(). Scott Taylor 2014-05-15 02:54:27 +00:00
  • 27ff2a1cd0 Eliminate use of extract() in get_media_item(). Scott Taylor 2014-05-15 02:45:01 +00:00
  • e0ddd2ebf0 Eliminate use of extract() in wp_insert_link(). Scott Taylor 2014-05-15 02:27:55 +00:00
  • da440f54fd Eliminate use of extract() in wp_list_bookmarks(). Scott Taylor 2014-05-15 02:17:52 +00:00
  • 30564338b0 Eliminate use of extract() in _walk_bookmarks(). Scott Taylor 2014-05-15 02:04:50 +00:00
  • 0dd9d3aeff Eliminate use of extract() in get_bookmarks(). Scott Taylor 2014-05-15 01:57:24 +00:00
  • 61faf32275 Eliminate use of extract() in Walker_Page::start_el(). Scott Taylor 2014-05-15 01:40:48 +00:00
  • c96d4a94b9 Eliminate use of extract() in wp_list_pages() which, surprisingly, didn't even use any of the extracted variables. Scott Taylor 2014-05-15 01:21:20 +00:00
  • c47d71feb2 Add unit tests for wp_list_pages(). Scott Taylor 2014-05-15 01:17:37 +00:00
  • e4a800238f Eliminate use of extract() in wp_dropdown_pages(). Scott Taylor 2014-05-15 01:11:21 +00:00
  • 21e0370e5c Eliminate use of extract() in wp_link_pages(). Scott Taylor 2014-05-15 00:43:40 +00:00
  • 9e07b1037e Eliminate use of extract() in paginate_links(). Adds unit tests. Moves tests/general/template.php (which only had one method) to tests/general/paginateLinks.php. Scott Taylor 2014-05-14 22:28:08 +00:00
  • 46f15a84ab Eliminate use of extract() in display_setup_form(). Only needs to read password and password_message. Scott Taylor 2014-05-14 16:42:42 +00:00
  • 44e4e3e4d0 Twenty Thirteen: add accessibility-ready tag. Fixes #28225, props BODA1982. Lance Willett 2014-05-13 23:10:00 +00:00
  • cfc1b74ddb Properly split and document the admin_post* actions into the following four hooks: Drew Jaynes (DrewAPicture) 2014-05-13 07:23:35 +00:00
  • 1954f9b7d4 Clarify inline documentation for back-compat load-* action hooks. Drew Jaynes (DrewAPicture) 2014-05-13 06:27:11 +00:00
  • 540826e4e3 Eliminate use of extract() in wp_list_authors(). Scott Taylor 2014-05-13 06:01:33 +00:00
  • bc17731c23 Eliminate use of extract() in post_tags_meta_box() and post_categories_meta_box(). Scott Taylor 2014-05-13 05:47:03 +00:00
  • b72bd1c40f Eliminate use of extract() in WP_Terms_List_Table::display_rows_or_placeholder(): Scott Taylor 2014-05-13 05:36:22 +00:00
  • 7c0e12f5c6 Eliminate use of extract() in WP_List_Table::pagination(): Scott Taylor 2014-05-13 05:26:34 +00:00
  • 31e187faa3 Eliminate use of extract() in WP_Plugin_Install_List_Table::get_table_classes(). It only needs to read plural, no need to extract. Scott Taylor 2014-05-13 05:16:39 +00:00
  • fac2faee93 Eliminate use of extract() in WP_List_Table::ajax_response(): Scott Taylor 2014-05-13 05:13:09 +00:00
  • a2122e6f7b Eliminate use of extract() in WP_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary. Scott Taylor 2014-05-13 05:07:11 +00:00
  • 878a974477 Eliminate use of extract() in WP_Post_Comments_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary. Scott Taylor 2014-05-13 05:03:26 +00:00
  • f57bdbd238 Eliminate use of extract() in Custom_Image_Header::step_2(). Scott Taylor 2014-05-13 04:53:13 +00:00
  • ba8e36f94c Eliminate use of extract() in the_title_attribute(). Scott Taylor 2014-05-13 04:47:11 +00:00
  • 42d6b5dd1e Eliminate use of extract() in trackback_url_list(). Scott Taylor 2014-05-13 04:43:22 +00:00
  • 671b47ef73 Eliminate use of extract() in wp-includes/theme-compat/comments-popup.php. Scott Taylor 2014-05-13 04:39:17 +00:00
  • 6a63c5b59d Fix a phpdoc typo and multi-line comment syntax in wp-cron.php. Drew Jaynes (DrewAPicture) 2014-05-13 04:38:15 +00:00
  • 77731c03fc Eliminate use of extract() in wp_get_archives(). Scott Taylor 2014-05-13 04:28:56 +00:00
  • 3c80d5f86a Use a proper docs-specific variable for the first parameter passed to the embed_oembed_discover filter. Drew Jaynes (DrewAPicture) 2014-05-13 04:28:30 +00:00
  • e2219e3d48 Add a complete short description to the get_attached_media filter documentation. Drew Jaynes (DrewAPicture) 2014-05-13 04:20:12 +00:00
  • 68f78b1dcc Clarify documentation for *what* gets "automatically fired" when the do_mu_upgrade filter evaluates to true in Multisite. Drew Jaynes (DrewAPicture) 2014-05-13 04:17:16 +00:00
  • d59c371180 Fix incomplete inline documentation for the wp_header_image_attachment_metadata filter. Drew Jaynes (DrewAPicture) 2014-05-13 04:12:02 +00:00
  • 4e0809e3e4 Eliminate use of extract() in wp_insert_category(). Adds unit tests. All unit tests pass. Scott Taylor 2014-05-13 03:26:51 +00:00
  • b3ff5285f8 Eliminate use of extract() in wp-activate.php. Scott Taylor 2014-05-13 03:13:21 +00:00
  • 961f52d367 Add xps and oxps extensions to list of supported document types. Scott Taylor 2014-05-11 07:18:06 +00:00
  • 8dc4b88fcf In wp.media.view.Settings::update(), when handling checkboxes, check for a value of 'false' in addition to casting value to boolean. !! 'false' evaluates to true. Scott Taylor 2014-05-11 07:02:05 +00:00
  • e8b8e881b2 Allow users to set overrides for MediaElement instances by always passing _wpmejsSettings instead of just _wpmejsSettings.pluginPath. Scott Taylor 2014-05-11 06:24:58 +00:00
  • e1b341cc59 In the Attachment Details section of the media modal, only add box-shadow to images. Other mime-type icons look strange with an arbitrary border. Scott Taylor 2014-05-11 06:18:02 +00:00
  • 3f59b86ec5 In media_upload_gallery_form()'s inline JavaScript, remove unnecessary comment tags. Scott Taylor 2014-05-11 06:11:08 +00:00
  • 3a554b5249 In wp_read_image_metadata(), the values from exif_read_data() should only override values from iptcparse() that are empty. Scott Taylor 2014-05-11 05:53:27 +00:00
  • 147eeb2147 Avoid a notice in wp_save_image() by checking $meta['sizes']['thumbnail'] for ! empty() before setting a variable to it. Scott Taylor 2014-05-11 03:41:31 +00:00
  • 4826c12c47 Update the default (WP-defined) styles for MediaElement players to be more in-line with our flat aesthetic. Use the new official colors. Scott Taylor 2014-05-11 02:22:42 +00:00
  • 9705736cdf When pausing "all" players attached to MCE views, don't reach into global scope and pause "every" player. Only pause the players bound to MCE views. Scott Taylor 2014-05-11 02:06:36 +00:00
  • 487da46928 Support loop for [audio] and [video] shortcodes that specify files that are played using MediaElement's Flash plugin bridge. Scott Taylor 2014-05-11 01:27:29 +00:00
  • b70967302b In get_the_author_posts(), if there is no current $post, return 0 and bail. Scott Taylor 2014-05-11 00:25:29 +00:00
  • 8998c015b3 MediaElement players need clear: both to play nice with adjacent floated elements. Scott Taylor 2014-05-11 00:13:49 +00:00
  • d007994bf3 In WP_Terms_List_Table::single_row(), call sanitize_term() on the passed term ($tag). Scott Taylor 2014-05-11 00:04:38 +00:00
  • 2808673b0c Remove the title attribute from markup generated in wp-includes/category-template.php: Scott Taylor 2014-05-10 23:56:12 +00:00
  • a398f38024 First pass at wpview logic for the [embed] shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet. Scott Taylor 2014-05-10 23:35:08 +00:00
  • cb5852a813 Add inline documentation of the default arguments for wp_list_pages(). Drew Jaynes (DrewAPicture) 2014-05-10 08:01:13 +00:00
  • f3d9e1ed7e Fix mid-file section header style in wp-admin/includes/ajax-actions.php. Drew Jaynes (DrewAPicture) 2014-05-10 05:01:15 +00:00
  • de13f1a60c Add baseline doc blocks for all ajax handlers in ajax-actions.php. Drew Jaynes (DrewAPicture) 2014-05-10 04:59:34 +00:00
  • 0b51b6da2e Minor phpDoc fixes for the got_rewrite, got_url_rewrite, and documentation_ignore_functions hooks. Drew Jaynes (DrewAPicture) 2014-05-08 11:12:11 +00:00
  • 272f7533dc Rename the $action hook in wp-admin/admin-post.php to admin_post{$action}. Drew Jaynes (DrewAPicture) 2014-05-08 10:59:17 +00:00
  • b0d7e6fe3c Revert [28349] in favor of retaining the single dynamic admin_post* hook. Drew Jaynes (DrewAPicture) 2014-05-08 10:46:41 +00:00
  • 9392b42e97 Convert and rename the $action hook in wp-admin/admin-post to two dynamic hook sets. Drew Jaynes (DrewAPicture) 2014-05-08 10:26:07 +00:00
  • bbd130fe15 Use interpolation instead of concatenation for the manage_{$screen->id}_columns hook name. Drew Jaynes (DrewAPicture) 2014-05-08 09:57:11 +00:00
  • 30c21227be Use an interpolated hook name for edit_{$post_type}_per_page instead of $per_page and adjust docs accordingly. Drew Jaynes (DrewAPicture) 2014-05-08 08:15:48 +00:00
  • 7531fd0070 Leverage size_format() when displaying max_upload_size: * In media_upload_form() * The uploader-inline Underscore template in the media modal. Scott Taylor 2014-05-07 18:24:47 +00:00
  • bfe7d38650 audio, video, and playlist shortcodes: Scott Taylor 2014-05-07 17:35:09 +00:00
  • 28d6842538 Bundled themes: use correct logic in IE conditional comments in header template. Props mikemanger, fixes #28151. Lance Willett 2014-05-07 04:26:07 +00:00
  • 451319728b In wp-login.php, break is unreachable after exit Scott Taylor 2014-05-07 03:57:17 +00:00
  • 4bddd84276 In wpdb, remove dead code: Scott Taylor 2014-05-07 03:55:32 +00:00
  • e47eb14575 In WP_Widget::update_callback(), $sidebars_widgets is unused. Scott Taylor 2014-05-07 03:51:31 +00:00
  • f945487f45 In wp-includes/theme.php, break is unreachable after return. Scott Taylor 2014-05-07 03:49:19 +00:00
  • b99dead052 In print_admin_styles(), $zip is never used after being set. $compress_css does not need to be imported. Scott Taylor 2014-05-07 03:46:11 +00:00
  • b62ca9c298 In wp_default_scripts(), $max_upload_size and its entangled children $max_up and $max_post create quite the ternary operator... that is never used. Scott Taylor 2014-05-07 03:44:06 +00:00
  • f63b6cde3a In wp-includes/revision.php - remove dead code: Scott Taylor 2014-05-07 03:37:45 +00:00
  • 098a5145c5 In WP_Query, remove duplicate variable setting: Scott Taylor 2014-05-06 21:42:28 +00:00
  • 16a58e34a2 In get_pages(), $cache does not need to be reset to an empty array. update_post_cache( $pages ) takes care of priming. Scott Taylor 2014-05-06 21:38:23 +00:00
  • 11e65eb200 In wp_get_attachment_link(), $post_title is set and then not used. Scott Taylor 2014-05-06 21:34:10 +00:00
  • b626b11590 In Walker_Nav_Menu::start_el(), $class_names is set twice before it is used. Scott Taylor 2014-05-06 21:32:25 +00:00
  • 3f2a078f5e In get_network_by_path(), $exact_domains is unused. Scott Taylor 2014-05-06 21:31:14 +00:00
  • 24b03d819b In update_metadata_by_mid(), $original_value is unused. Scott Taylor 2014-05-06 21:28:02 +00:00
  • e95edb29aa In edit_post_link(), $post_type_obj is unused. Scott Taylor 2014-05-06 21:26:20 +00:00
  • 5cf2a50dba In paginate_links(), break is unreachable after return. Scott Taylor 2014-05-06 21:24:22 +00:00
  • ef5998eabb In wp-includes/functions.php, remove dead code: Scott Taylor 2014-05-06 21:22:22 +00:00
  • 5e90fb1b3e In wp_set_comment_status(), the default case returns, so no default value for $status is needed. Scott Taylor 2014-05-06 21:16:42 +00:00
  • 5530fe4c11 In wp-includes/comment-template.php, remove dead code: Scott Taylor 2014-05-06 21:14:35 +00:00
  • 2b1c764ec7 In Walker::walk() and Walker::paged_walk(), $id_field is set and never used. wonderboymusic 2014-05-06 21:08:02 +00:00
  • 18916debfd Update deleted site message in ms_site_check(). Sergey Biryukov 2014-05-06 18:45:54 +00:00
  • 0f4f941900 In WP_Image_Editor::get_output_format(), $file_mime and $file_ext are set twice before they are used. Scott Taylor 2014-05-06 18:36:34 +00:00
  • 9ad07c8c28 In wp-includes/class-wp-customize-setting.php, break is unreachable after return. Scott Taylor 2014-05-06 18:33:03 +00:00
  • 376125e0b7 In wp-includes/class-wp-admin-bar.php, break is unreachabled after return. Scott Taylor 2014-05-06 18:28:46 +00:00
  • c5463c5cb2 In WP_Http_Curl::request(), $theResponse is unused. There are other curl_exec() calls that do not return as well. Scott Taylor 2014-05-06 18:26:00 +00:00
  • 5df63351b2 In wp-includes/bookmark.php, remove dead code: Scott Taylor 2014-05-06 18:21:50 +00:00
  • 22743ee2c4 In wp-admin/users.php, break is unreachabled after exit. Scott Taylor 2014-05-06 18:18:12 +00:00
  • 64fbddfcd5 In core_upgrade_preamble(), $alternate is set then never used. Scott Taylor 2014-05-06 18:16:34 +00:00
  • cb0578d77e In wp-admin/theme-editor.php, break is unreachabled after exit. Scott Taylor 2014-05-06 18:15:18 +00:00
  • 0f9b925ed5 In wp-admin/post.php, break is unreachabled after exit. Scott Taylor 2014-05-06 18:14:16 +00:00
  • a9dfbabfe7 In wp-admin/plugins.php, break is unreachabled after exit. Scott Taylor 2014-05-06 18:12:44 +00:00
  • e742c23af9 In wp-admin/plugin-editor.php, break is unreachabled after exit. Scott Taylor 2014-05-06 18:11:30 +00:00
  • 1da6728dc0 In wp-admin/network/users.php, break is unreachabled after exit. wonderboymusic 2014-05-06 18:10:01 +00:00
  • aa7cef0549 In wp-admin/network/themes.php, break is unreachabled after exit. Scott Taylor 2014-05-06 18:07:33 +00:00
  • 81acc42361 In wp-admin/link.php, break is unreachabled after exit. Scott Taylor 2014-05-06 18:05:09 +00:00