mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2025-10-16 12:05:38 +00:00
8a8f0149b5
Previously errors were not displayed or logged, but the original intention was only to prevent them from being displayed. Hiding them from logs makes problems like #53492 much harder to debug. This makes the handling of errors in `ms-files` consistent with the REST API, `admin-ajax`, and XML-RPC. Props iandunn, johnjamesjacoby. Fixes #53493. git-svn-id: https://develop.svn.wordpress.org/trunk@51358 602fd350-edb4-49c9-b593-d223f7449a82
63 lines
2.0 KiB
PHP
63 lines
2.0 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Unit tests for `wp_debug_mode()`.
|
|
*
|
|
* @package WordPress
|
|
* @subpackage UnitTests
|
|
* @since 5.9.0
|
|
*/
|
|
|
|
/**
|
|
* Class Test_WP_Debug_Mode.
|
|
*
|
|
* @group load.php
|
|
* @group wp-debug-mode
|
|
* @covers ::wp_debug_mode
|
|
*
|
|
* @since 5.9.0
|
|
*/
|
|
class Test_WP_Debug_Mode extends WP_UnitTestCase {
|
|
/**
|
|
* Test: `wp_debug_mode()` should log, but not display, errors for `ms-files.php`.
|
|
*
|
|
* @ticket 53493
|
|
*
|
|
* @since 5.9.0
|
|
*/
|
|
public function test_ms_files_logs_but_doesnt_display_errors() {
|
|
/*
|
|
* Global constants can't be mocked in PHPUnit, so this can only run with the expected
|
|
* values already set in `wp-tests-config.php`. Unfortunately, that means it won't run in
|
|
* automated workflows, but it's still useful when testing locally.
|
|
*
|
|
* It may be possible to enable automated workflows by mocking `define()`, or by setting up
|
|
* addition automated flows that initialize the tests with different values for the constants.
|
|
* At the moment, though, neither of those seem to provide enough benefit to justify the time
|
|
* investment.
|
|
*
|
|
* @link https://theaveragedev.com/mocking-constants-in-tests/
|
|
*/
|
|
if ( true !== WP_DEBUG || true !== WP_DEBUG_DISPLAY || true !== WP_DEBUG_LOG ) {
|
|
$this->markTestSkipped( 'Test requires setting `WP_DEBUG_*` constants in `wp-tests-config.php` to expected values.' );
|
|
}
|
|
|
|
// `display_errors` should be _on_ because of `WP_DEBUG_DISPLAY`.
|
|
wp_debug_mode();
|
|
|
|
$this->assertSame( E_ALL, (int) ini_get( 'error_reporting' ) );
|
|
$this->assertSame( '1', ini_get( 'display_errors' ) );
|
|
$this->assertSame( '1', ini_get( 'log_errors' ) );
|
|
$this->assertStringContainsString( 'debug.log', ini_get( 'error_log' ) );
|
|
|
|
// `display_errors` should be _off_ now, because of `MS_FILES_REQUEST`.
|
|
define( 'MS_FILES_REQUEST', true );
|
|
wp_debug_mode();
|
|
|
|
$this->assertSame( E_ALL, (int) ini_get( 'error_reporting' ) );
|
|
$this->assertSame( '0', ini_get( 'display_errors' ) );
|
|
$this->assertSame( '1', ini_get( 'log_errors' ) );
|
|
$this->assertStringContainsString( 'debug.log', ini_get( 'error_log' ) );
|
|
}
|
|
}
|