Boone Gorges 0adb6877b2 Improve validation of user_login and user_nicename length. ... The `user_login` field only allows 60 characters, and `user_nicename` allows 50. However, there are no protections in the interface, and few in the code, that prevent the creation of users with values in excess of these limits. Prior to recent changes in `$wpdb`, users were generally created anyway, MySQL having performed the necessary truncation. More recently, the `INSERT`s and `UPDATE`s simply fail, with no real feedback on the nature of the failure. This changeset addresses the issue in a number of ways: * On the user-new.php and network/user-new.php panels, don't allow input in excess of the maximum field length. * In `wp_insert_user()`, throw an error if the value provided for `'user_login'` or `'user_nicename'` exceeds the maximum field length. * In `wp_insert_user()`, when using `'user_login'` to generate a default value for `'user_nicename'`, ensure that the nicename is properly truncated, even when suffixed for uniqueness (username-2, etc). Props dipesh.kakadiya, utkarshpatel, tommarshall, boonebgorges. Fixes #33793. git-svn-id: https://develop.svn.wordpress.org/trunk@34218 602fd350-edb4-49c9-b593-d223f7449a82		2015-09-15 22:13:51 +00:00
..
actions	Move PHPUnit tests into a tests/phpunit directory.	2013-08-29 18:39:34 +00:00
admin	Implement a priority system for Help Tabs to add them at specific positions.	2015-09-10 01:26:26 +00:00
ajax	Initialise $_SERVER[ 'REMOTE_ADDR' ] during the test bootstrap so individual tests need not.	2015-09-15 08:04:33 +00:00
attachment	Fix typo in a comment in slashing tests.	2015-01-07 07:08:47 +00:00
canonical	In PHPUnit test classes, parent::tearDown() should be the last thing done in tearDown() methods.	2015-03-05 13:14:15 +00:00
category	In wp_list_categories(), 'current_category' should accept an array of values.	2015-08-29 19:45:35 +00:00
comment	WP_Comment_Query: add comment__in to allowed values for $orderby.	2015-09-15 16:34:14 +00:00
customize	Customizer: Fix failing tests on PHP 5.2 after [33488].	2015-07-31 13:01:16 +00:00
date	WP_Date_Query date validation should not fail for hour = 0.	2015-01-20 19:12:48 +00:00
db	Remove svn:executable from test files.	2015-07-26 09:40:58 +00:00
dependencies	Add a return value to wp_register_script() and wp_register_style() which matches the return value of WP_Dependencies::add().	2015-05-10 19:56:15 +00:00
feed	Tests: Update Tests_Feed_RSS::test_items to expect new comment permalink structure.	2015-09-12 23:30:11 +00:00
filesystem	Require dependencies when appropriate in some unit test files.	2015-07-14 03:07:13 +00:00
formatting	Formatting: maintain the content of HTML comments when they contain <object> tags. Add more tests for wpaitop().	2015-09-08 22:54:08 +00:00
functions	Ignore case when checking string 'false' in wp_validate_boolean().	2014-11-03 15:54:42 +00:00
general	In paginate_links(), improve handling of custom pagination query vars.	2015-05-05 21:58:23 +00:00
http	Fix the case-sensitivity of some HTTP class usage.	2015-09-14 17:36:37 +00:00
image	After [34188], fix unit test for image header.	2015-09-15 18:43:51 +00:00
import	Require dependencies when appropriate in some unit test files.	2015-07-14 03:07:13 +00:00
includes	Remove svn:executable from test files.	2015-07-26 09:40:58 +00:00
link	In get_next_comments_link(), ensure proper pagination when no 'cpage' query var is found.	2015-03-05 03:56:21 +00:00
meta	Avoid returning duplicate matches when using a meta query in WP_User_Query.	2015-06-09 17:41:35 +00:00
multisite	Missed files from [34172].	2015-09-15 08:08:15 +00:00
option	Initialise $_SERVER[ 'REMOTE_ADDR' ] during the test bootstrap so individual tests need not.	2015-09-15 08:04:33 +00:00
pomo	Fix strict notices in Tests_POMO_PO.	2013-12-01 12:47:35 +00:00
post	Update post thumbnail functions to allow a WP_Post to be passed.	2015-09-15 03:45:23 +00:00
query	Allow setup_postdata() to accept a post ID.	2015-09-12 20:57:06 +00:00
rewrite	When parsing what appears to be a date archive request, check for a post with a clashing permalink before resolving to the archive.	2015-05-29 13:09:26 +00:00
template	Tests: Update Site Icon tests to account for changes in [33605].	2015-08-11 18:41:01 +00:00
term	Add unit tests for get_term().	2015-09-11 03:10:47 +00:00
theme	Clean up 'post-thumbnail' theme support unit tests.	2014-11-01 04:00:59 +00:00
user	Initialise $_SERVER[ 'REMOTE_ADDR' ] during the test bootstrap so individual tests need not.	2015-09-15 08:04:33 +00:00
xmlrpc	After [33325], supply a missing post_type in ->mw_editPost().	2015-08-13 15:27:57 +00:00
actions.php	Introduce doing_filter() and doing_action() to identify hooks in progress.	2014-02-26 18:43:59 +00:00
adminbar.php	Update links to the user profile editing screen in the admin toolbar when the current logged in user has no role on the current site. Covers single site and Multisite and introduces tests.	2015-09-14 17:09:58 +00:00
auth.php	Add 'wp_verify_nonce_failed' action that fires when nonce verification fails.	2015-08-26 00:05:11 +00:00
avatar.php	Remove svn:executable from test files.	2015-07-26 09:40:58 +00:00
basic.php	Tests: Check that readme.html is recommending an actively supported version of MySQL.	2015-09-08 03:23:29 +00:00
cache.php	In PHPUnit test classes, parent::tearDown() should be the last thing done in tearDown() methods.	2015-03-05 13:14:15 +00:00
canonical.php	Implement canonical and url_to_postid() tests for child pages which share a post name with other child pages.	2015-06-24 00:40:45 +00:00
category.php	In Walker_CategoryDropdown::start_el(), cast values to strings before deciding whether to append 'selected' attribute.	2015-08-21 01:10:34 +00:00
comment.php	Initialise $_SERVER[ 'REMOTE_ADDR' ] during the test bootstrap so individual tests need not.	2015-09-15 08:04:33 +00:00
compat.php	WPDB: When checking that a string can be sent to MySQL, we shouldn't use mb_convert_encoding(), as it behaves differently to MySQL's character encoding conversion.	2015-05-06 02:59:50 +00:00
cron.php	In PHPUnit test classes, parent::tearDown() should be the last thing done in tearDown() methods.	2015-03-05 13:14:15 +00:00
db.php	WPDB: get_table_from_query() didn't find table names with hyphens in them.	2015-08-24 00:18:49 +00:00
dbdelta.php	Remove svn:executable from test files.	2015-07-26 09:40:58 +00:00
dependencies.php	Remove tests for code still in development, see #22229. If accidentally run, they produce fatal errors.	2013-10-07 14:17:13 +00:00
file.php	Tests: Clean up the resulting /tmp/foo* files from the tempnam call.	2015-03-31 02:10:52 +00:00
filters.php	In remove_all_filters(), only remove callbacks that match the $priority parameter.	2014-12-31 19:06:29 +00:00
functions.php	When running on windows systems, normalise the capitalisation of the drive letter for more reliable string comparisons.	2015-09-14 01:58:03 +00:00
kses.php	Shortcodes: Improve the reliablity of shortcodes inside HTML tags.	2015-07-22 05:14:50 +00:00
l10n.php	Remove failing is_textdomain_loaded() test.	2014-11-22 20:36:51 +00:00
link.php	Remove extraneous table join in get_adjacent_post().	2015-09-12 20:33:07 +00:00
mail.php	Update PHPMailer to 5.2.10 from 5.2.7.	2015-07-08 17:15:02 +00:00
media.php	Ensure that attachment_url_to_postid() matches cross-scheme when front-end and back-end schemes are different.	2015-08-22 16:38:09 +00:00
meta.php	Update the tests for get_metadata() to reflect the revert in r30701.	2014-12-02 03:43:17 +00:00
multisite.php	Initialise $_SERVER[ 'REMOTE_ADDR' ] during the test bootstrap so individual tests need not.	2015-09-15 08:04:33 +00:00
pluggable.php	Implement unit tests which use reflection to test functions in pluggable.php. This means any changes to these functions will need explicit changes to their corresponding tests, which helps prevent unintentional breakage.	2015-09-14 19:14:38 +00:00
post.php	In wp_insert_post(), when setting $post_author, use isset() instead of ! empty() to allow 0 to be passed as the value for $post_author.	2015-09-12 18:53:56 +00:00
query.php	Better default values in WP_Query::get_queried_object().	2015-09-12 03:36:12 +00:00
rewrite.php	In WP::parse_request(), don't add query vars of non-viewable post types to WP::public_query_vars. In register_post_type(), don't add query vars of non-viewable post types to WP::public_query_vars.	2015-09-15 18:53:12 +00:00
shortcode.php	Add some more data for Shortcode unit tests.	2015-08-25 21:50:55 +00:00
taxonomy.php	Add Unit Tests for get_objects_in_term()	2015-07-12 20:12:19 +00:00
term.php	Improve unit tests for wp_unique_term_slug().	2015-05-15 20:37:51 +00:00
theme.php	Themes: Get the correct theme when template and stylesheet were both passed as arguments.	2015-08-30 21:44:38 +00:00
upload.php	wp_upload_dir() has a (little-known?) side effect: if you call it, it will attempt to create an uploads directory for the current month. As such, tearDown() and cleanup routines have to be in sync with this behavior when deleting bogus directories used in unit tests.	2014-11-30 19:05:52 +00:00
url.php	In get_adjacent_post(), return private post if the current user has the capacity to read it.	2015-01-30 02:19:46 +00:00
user.php	Improve validation of user_login and user_nicename length.	2015-09-15 22:13:51 +00:00
walker.php	Add unit tests for Walker class.	2014-08-01 20:35:25 +00:00
widgets.php	Add support for WP_Widget::get_settings() returning ArrayIterator/ArrayObject instances.	2015-05-26 16:50:03 +00:00