mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2025-10-16 12:05:38 +00:00
17a01ed185
A collection of fixes for `wp_prime_option_caches()`: * cache arrays and objects in their serialized form for consistency with `get_option()` and `wp_load_alloptions()` * prevent repeat database queries for falsey and known non-existent options (notoptions) Additional tests for `wp_prime_option_caches()` to ensure: * additional database queries are not made repriming options (known, known-unknown and alloptions) * cache is primed consistently * `get_option()` returns a consistent value regardless of how it is primed * database queries do not contain earlier primed options * `get_option` does not prime the cache when testing the cache has been successfully primed Fixes a test for `wp_prime_option_caches_by_group()` to ensure `get_option` does not prime the cache when testing the cache has been successfully primed. Follow up to [56445],[56990],[57013]. Props peterwilsoncc, costdev, flixos90, hellofromTonya, mikeschroder, joemcgill. Fixes #59738. See #58962. git-svn-id: https://develop.svn.wordpress.org/trunk@57029 602fd350-edb4-49c9-b593-d223f7449a82
83 lines
2.7 KiB
PHP
83 lines
2.7 KiB
PHP
<?php
|
|
/**
|
|
* Test wp_prime_option_caches_by_group().
|
|
*
|
|
* @group option
|
|
*
|
|
* @covers ::wp_prime_option_caches_by_group
|
|
*/
|
|
class Tests_Option_WpPrimeOptionCachesByGroup extends WP_UnitTestCase {
|
|
|
|
/**
|
|
* Tests that wp_prime_option_caches_by_group() only primes options in the specified group.
|
|
*
|
|
* @ticket 58962
|
|
*/
|
|
public function test_wp_prime_option_caches_by_group() {
|
|
global $new_allowed_options;
|
|
|
|
// Create some options to prime.
|
|
$new_allowed_options = array(
|
|
'group1' => array(
|
|
'option1',
|
|
'option2',
|
|
),
|
|
'group2' => array(
|
|
'option3',
|
|
),
|
|
);
|
|
|
|
$options_to_prime = array(
|
|
'option1',
|
|
'option2',
|
|
'option3',
|
|
);
|
|
|
|
/*
|
|
* Set values for the options,
|
|
* clear the cache for the options,
|
|
* check options are not in cache initially.
|
|
*/
|
|
foreach ( $options_to_prime as $option ) {
|
|
update_option( $option, "value_$option", false );
|
|
wp_cache_delete( $option, 'options' );
|
|
$this->assertFalse( wp_cache_get( $option, 'options' ), "$option was not deleted from the cache." );
|
|
}
|
|
|
|
// Call the wp_prime_option_caches_by_group function to prime the options.
|
|
wp_prime_option_caches_by_group( 'group1' );
|
|
|
|
/*
|
|
* Check that options are now in the cache.
|
|
*
|
|
* Repeat the string here rather than using get_option as get_option
|
|
* will prime the cache before the call to wp_cache_get if the option
|
|
* is not in the cache. Thus causing the tests to pass when they should
|
|
* fail.
|
|
*/
|
|
$this->assertSame( 'value_option1', wp_cache_get( 'option1', 'options' ), 'option1\'s cache was not primed.' );
|
|
$this->assertSame( 'value_option2', wp_cache_get( 'option2', 'options' ), 'option2\'s cache was not primed.' );
|
|
|
|
// Make sure option3 is still not in cache.
|
|
$this->assertFalse( wp_cache_get( 'option3', 'options' ), 'option3 was not deleted from the cache.' );
|
|
}
|
|
|
|
/**
|
|
* Tests wp_prime_option_caches_by_group() with a nonexistent option group.
|
|
*
|
|
* @ticket 58962
|
|
*/
|
|
public function test_wp_prime_option_caches_by_group_with_nonexistent_group() {
|
|
// Make sure options are not in cache or database initially.
|
|
$this->assertFalse( wp_cache_get( 'option1', 'options' ), 'option1 was not deleted from the cache.' );
|
|
$this->assertFalse( wp_cache_get( 'option2', 'options' ), 'option2 was not deleted from the cache.' );
|
|
|
|
// Call the wp_prime_option_caches_by_group function with a nonexistent group.
|
|
wp_prime_option_caches_by_group( 'nonexistent_group' );
|
|
|
|
// Check that options are still not in the cache or database.
|
|
$this->assertFalse( wp_cache_get( 'option1', 'options' ), 'option1 was not deleted from the cache.' );
|
|
$this->assertFalse( wp_cache_get( 'option2', 'options' ), 'option2 was not deleted from the cache.' );
|
|
}
|
|
}
|