mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2025-10-16 12:05:38 +00:00
a875f9dae7
In `WP_REST_Controller::get_fields_for_response()`, exclude fields which are not registered to appear in the request's context. In conjunction with r45705 this prevents the unnecessary computation of the sample permalink when making a request that is not context=edit. Props dlh. Fixes #45605. git-svn-id: https://develop.svn.wordpress.org/trunk@45706 602fd350-edb4-49c9-b593-d223f7449a82
387 lines
9.4 KiB
PHP
387 lines
9.4 KiB
PHP
<?php
|
|
/**
|
|
* Unit tests covering WP_REST_Controller functionality
|
|
*
|
|
* @package WordPress
|
|
* @subpackage REST API
|
|
*/
|
|
|
|
/**
|
|
* @group restapi
|
|
*/
|
|
class WP_Test_REST_Controller extends WP_Test_REST_TestCase {
|
|
|
|
public function setUp() {
|
|
parent::setUp();
|
|
$this->request = new WP_REST_Request(
|
|
'GET',
|
|
'/wp/v2/testroute',
|
|
array(
|
|
'args' => array(
|
|
'someinteger' => array(
|
|
'type' => 'integer',
|
|
),
|
|
'someboolean' => array(
|
|
'type' => 'boolean',
|
|
),
|
|
'somestring' => array(
|
|
'type' => 'string',
|
|
),
|
|
'someenum' => array(
|
|
'type' => 'string',
|
|
'enum' => array( 'a' ),
|
|
),
|
|
'somedate' => array(
|
|
'type' => 'string',
|
|
'format' => 'date-time',
|
|
),
|
|
'someemail' => array(
|
|
'type' => 'string',
|
|
'format' => 'email',
|
|
),
|
|
),
|
|
)
|
|
);
|
|
}
|
|
|
|
public function test_validate_schema_type_integer() {
|
|
|
|
$this->assertTrue(
|
|
rest_validate_request_arg( '123', $this->request, 'someinteger' )
|
|
);
|
|
|
|
$this->assertErrorResponse(
|
|
'rest_invalid_param',
|
|
rest_validate_request_arg( 'abc', $this->request, 'someinteger' )
|
|
);
|
|
}
|
|
|
|
public function test_validate_schema_type_boolean() {
|
|
|
|
$this->assertTrue(
|
|
rest_validate_request_arg( true, $this->request, 'someboolean' )
|
|
);
|
|
$this->assertTrue(
|
|
rest_validate_request_arg( false, $this->request, 'someboolean' )
|
|
);
|
|
|
|
$this->assertTrue(
|
|
rest_validate_request_arg( 'true', $this->request, 'someboolean' )
|
|
);
|
|
$this->assertTrue(
|
|
rest_validate_request_arg( 'TRUE', $this->request, 'someboolean' )
|
|
);
|
|
$this->assertTrue(
|
|
rest_validate_request_arg( 'false', $this->request, 'someboolean' )
|
|
);
|
|
$this->assertTrue(
|
|
rest_validate_request_arg( 'False', $this->request, 'someboolean' )
|
|
);
|
|
$this->assertTrue(
|
|
rest_validate_request_arg( '1', $this->request, 'someboolean' )
|
|
);
|
|
$this->assertTrue(
|
|
rest_validate_request_arg( '0', $this->request, 'someboolean' )
|
|
);
|
|
$this->assertTrue(
|
|
rest_validate_request_arg( 1, $this->request, 'someboolean' )
|
|
);
|
|
$this->assertTrue(
|
|
rest_validate_request_arg( 0, $this->request, 'someboolean' )
|
|
);
|
|
|
|
// Check sanitize testing.
|
|
$this->assertEquals(
|
|
false,
|
|
rest_sanitize_request_arg( 'false', $this->request, 'someboolean' )
|
|
);
|
|
$this->assertEquals(
|
|
false,
|
|
rest_sanitize_request_arg( '0', $this->request, 'someboolean' )
|
|
);
|
|
$this->assertEquals(
|
|
false,
|
|
rest_sanitize_request_arg( 0, $this->request, 'someboolean' )
|
|
);
|
|
$this->assertEquals(
|
|
false,
|
|
rest_sanitize_request_arg( 'FALSE', $this->request, 'someboolean' )
|
|
);
|
|
$this->assertEquals(
|
|
true,
|
|
rest_sanitize_request_arg( 'true', $this->request, 'someboolean' )
|
|
);
|
|
$this->assertEquals(
|
|
true,
|
|
rest_sanitize_request_arg( '1', $this->request, 'someboolean' )
|
|
);
|
|
$this->assertEquals(
|
|
true,
|
|
rest_sanitize_request_arg( 1, $this->request, 'someboolean' )
|
|
);
|
|
$this->assertEquals(
|
|
true,
|
|
rest_sanitize_request_arg( 'TRUE', $this->request, 'someboolean' )
|
|
);
|
|
|
|
$this->assertErrorResponse(
|
|
'rest_invalid_param',
|
|
rest_validate_request_arg( '123', $this->request, 'someboolean' )
|
|
);
|
|
}
|
|
|
|
public function test_validate_schema_type_string() {
|
|
|
|
$this->assertTrue(
|
|
rest_validate_request_arg( '123', $this->request, 'somestring' )
|
|
);
|
|
|
|
$this->assertErrorResponse(
|
|
'rest_invalid_param',
|
|
rest_validate_request_arg( array( 'foo' => 'bar' ), $this->request, 'somestring' )
|
|
);
|
|
}
|
|
|
|
public function test_validate_schema_enum() {
|
|
|
|
$this->assertTrue(
|
|
rest_validate_request_arg( 'a', $this->request, 'someenum' )
|
|
);
|
|
|
|
$this->assertErrorResponse(
|
|
'rest_invalid_param',
|
|
rest_validate_request_arg( 'd', $this->request, 'someenum' )
|
|
);
|
|
}
|
|
|
|
public function test_validate_schema_format_email() {
|
|
|
|
$this->assertTrue(
|
|
rest_validate_request_arg( 'joe@foo.bar', $this->request, 'someemail' )
|
|
);
|
|
|
|
$this->assertErrorResponse(
|
|
'rest_invalid_email',
|
|
rest_validate_request_arg( 'd', $this->request, 'someemail' )
|
|
);
|
|
}
|
|
|
|
public function test_validate_schema_format_date_time() {
|
|
|
|
$this->assertTrue(
|
|
rest_validate_request_arg( '2010-01-01T12:00:00', $this->request, 'somedate' )
|
|
);
|
|
|
|
$this->assertErrorResponse(
|
|
'rest_invalid_date',
|
|
rest_validate_request_arg( '2010-18-18T12:00:00', $this->request, 'somedate' )
|
|
);
|
|
}
|
|
|
|
public function test_get_endpoint_args_for_item_schema_description() {
|
|
$controller = new WP_REST_Test_Controller();
|
|
$args = $controller->get_endpoint_args_for_item_schema();
|
|
$this->assertEquals( 'A pretty string.', $args['somestring']['description'] );
|
|
$this->assertFalse( isset( $args['someinteger']['description'] ) );
|
|
}
|
|
|
|
public function test_get_endpoint_args_for_item_schema_arg_options() {
|
|
|
|
$controller = new WP_REST_Test_Controller();
|
|
$args = $controller->get_endpoint_args_for_item_schema();
|
|
|
|
$this->assertFalse( $args['someargoptions']['required'] );
|
|
$this->assertEquals( '__return_true', $args['someargoptions']['sanitize_callback'] );
|
|
}
|
|
|
|
public function test_get_endpoint_args_for_item_schema_default_value() {
|
|
|
|
$controller = new WP_REST_Test_Controller();
|
|
|
|
$args = $controller->get_endpoint_args_for_item_schema();
|
|
|
|
$this->assertEquals( 'a', $args['somedefault']['default'] );
|
|
}
|
|
|
|
/**
|
|
* @dataProvider data_get_fields_for_response,
|
|
*/
|
|
public function test_get_fields_for_response( $param, $expected ) {
|
|
$controller = new WP_REST_Test_Controller();
|
|
$request = new WP_REST_Request( 'GET', '/wp/v2/testroute' );
|
|
$fields = $controller->get_fields_for_response( $request );
|
|
$this->assertEquals(
|
|
array(
|
|
'somestring',
|
|
'someinteger',
|
|
'someboolean',
|
|
'someurl',
|
|
'somedate',
|
|
'someemail',
|
|
'someenum',
|
|
'someargoptions',
|
|
'somedefault',
|
|
),
|
|
$fields
|
|
);
|
|
$request->set_param( '_fields', $param );
|
|
$fields = $controller->get_fields_for_response( $request );
|
|
$this->assertEquals( $expected, $fields );
|
|
}
|
|
|
|
public function data_get_fields_for_response() {
|
|
return array(
|
|
array(
|
|
'somestring,someinteger',
|
|
array(
|
|
'somestring',
|
|
'someinteger',
|
|
),
|
|
),
|
|
array(
|
|
',,',
|
|
array(
|
|
'somestring',
|
|
'someinteger',
|
|
'someboolean',
|
|
'someurl',
|
|
'somedate',
|
|
'someemail',
|
|
'someenum',
|
|
'someargoptions',
|
|
'somedefault',
|
|
),
|
|
),
|
|
);
|
|
}
|
|
|
|
public function test_get_fields_for_response_filters_by_context() {
|
|
$controller = new WP_REST_Test_Controller();
|
|
|
|
$request = new WP_REST_Request( 'GET', '/wp/v2/testroute' );
|
|
$request->set_param( 'context', 'view' );
|
|
|
|
$schema = $controller->get_item_schema();
|
|
$field = 'somefield';
|
|
|
|
$listener = new MockAction();
|
|
$method = 'action';
|
|
|
|
register_rest_field(
|
|
$schema['title'],
|
|
$field,
|
|
array(
|
|
'schema' => array(
|
|
'type' => 'string',
|
|
'context' => array( 'embed' ),
|
|
),
|
|
'get_callback' => array( $listener, $method ),
|
|
)
|
|
);
|
|
|
|
$controller->prepare_item_for_response( array(), $request );
|
|
|
|
$this->assertSame( 0, $listener->get_call_count( $method ) );
|
|
|
|
$request->set_param( 'context', 'embed' );
|
|
|
|
$controller->prepare_item_for_response( array(), $request );
|
|
|
|
$this->assertGreaterThan( 0, $listener->get_call_count( $method ) );
|
|
}
|
|
|
|
public function test_filtering_fields_for_response_by_context_returns_fields_with_no_context() {
|
|
$controller = new WP_REST_Test_Controller();
|
|
|
|
$request = new WP_REST_Request( 'GET', '/wp/v2/testroute' );
|
|
$request->set_param( 'context', 'view' );
|
|
|
|
$schema = $controller->get_item_schema();
|
|
$field = 'somefield';
|
|
|
|
$listener = new MockAction();
|
|
$method = 'action';
|
|
|
|
register_rest_field(
|
|
$schema['title'],
|
|
$field,
|
|
array(
|
|
'schema' => array(
|
|
'type' => 'string',
|
|
),
|
|
'get_callback' => array( $listener, $method ),
|
|
)
|
|
);
|
|
|
|
$controller->prepare_item_for_response( array(), $request );
|
|
|
|
$this->assertGreaterThan( 0, $listener->get_call_count( $method ) );
|
|
}
|
|
|
|
public function test_filtering_fields_for_response_by_context_returns_fields_with_no_schema() {
|
|
$controller = new WP_REST_Test_Controller();
|
|
|
|
$request = new WP_REST_Request( 'GET', '/wp/v2/testroute' );
|
|
$request->set_param( 'context', 'view' );
|
|
|
|
$schema = $controller->get_item_schema();
|
|
$field = 'somefield';
|
|
|
|
$listener = new MockAction();
|
|
$method = 'action';
|
|
|
|
register_rest_field(
|
|
$schema['title'],
|
|
$field,
|
|
array(
|
|
'get_callback' => array( $listener, $method ),
|
|
)
|
|
);
|
|
|
|
$controller->prepare_item_for_response( array(), $request );
|
|
|
|
$this->assertGreaterThan( 0, $listener->get_call_count( $method ) );
|
|
}
|
|
|
|
public function test_add_additional_fields_to_object_respects_fields_param() {
|
|
$controller = new WP_REST_Test_Controller();
|
|
$request = new WP_REST_Request( 'GET', '/wp/v2/testroute' );
|
|
$schema = $controller->get_item_schema();
|
|
$field = 'somefield';
|
|
|
|
$listener = new MockAction();
|
|
$method = 'action';
|
|
|
|
register_rest_field(
|
|
$schema['title'],
|
|
$field,
|
|
array(
|
|
'get_callback' => array( $listener, $method ),
|
|
'schema' => array(
|
|
'type' => 'string',
|
|
),
|
|
)
|
|
);
|
|
|
|
$item = array();
|
|
|
|
$controller->prepare_item_for_response( $item, $request );
|
|
|
|
$first_call_count = $listener->get_call_count( $method );
|
|
|
|
$this->assertTrue( $first_call_count > 0 );
|
|
|
|
$request->set_param( '_fields', 'somestring' );
|
|
|
|
$controller->prepare_item_for_response( $item, $request );
|
|
|
|
$this->assertSame( $first_call_count, $listener->get_call_count( $method ) );
|
|
|
|
$request->set_param( '_fields', $field );
|
|
|
|
$controller->prepare_item_for_response( $item, $request );
|
|
|
|
$this->assertTrue( $listener->get_call_count( $method ) > $first_call_count );
|
|
}
|
|
}
|