Scott Taylor 2ed007c023 Calling ->chown() and ->chgrp() in WP_Filesystem_ftpsockets produces no side-effects. Remove the calls. ->chgrp() is defined in the super class, and does nothing, can be removed from the child class. ...

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31216 602fd350-edb4-49c9-b593-d223f7449a82

2015-01-16 21:09:18 +00:00

..

admin.php

Fix syntax for single- and multi-line comments in wp-admin-directory files.

2014-07-17 09:13:53 +00:00

ajax-actions.php

In wp_ajax_parse_media_shortcode(), don't require a global $post for all passed shortcodes.

2015-01-16 05:18:17 +00:00

bookmark.php

Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors.

2014-11-16 06:15:29 +00:00

class-ftp-pure.php

First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.

2013-12-24 18:56:05 +00:00

class-ftp-sockets.php

First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.

2013-12-24 18:56:05 +00:00

class-ftp.php

PHP 5.2 compatibility for [30310], __DIR__ wasn't added until PHP 5.3. Props TobiasBg. Fixes #29628

2014-11-12 10:43:09 +00:00

class-pclzip.php

New develop.svn.wordpress.org repository based on the old core.svn repository.

2013-08-07 05:25:25 +00:00

class-wp-comments-list-table.php

After [31146], properly declare $user_can as a private field in WP_Comments_List_Table.

2015-01-12 16:01:53 +00:00

class-wp-filesystem-base.php

@param cleanup:

2015-01-16 19:02:26 +00:00

class-wp-filesystem-direct.php

Improve some wp-admin/includes/class-wp-filesystem-*.php docs for @param.

2014-12-20 20:39:41 +00:00

class-wp-filesystem-ftpext.php

Calling ->chown() and ->chgrp() in WP_Filesystem_FTPext produces no side-effects. Remove the calls. ->chgrp() is defined in the super class, and does nothing, can be removed from the child class.

2015-01-16 21:06:29 +00:00

class-wp-filesystem-ftpsockets.php

Calling ->chown() and ->chgrp() in WP_Filesystem_ftpsockets produces no side-effects. Remove the calls. ->chgrp() is defined in the super class, and does nothing, can be removed from the child class.

2015-01-16 21:09:18 +00:00

class-wp-filesystem-ssh2.php

In WP_Filesystem_Base subclasses that set $wp_base, remove this dead code.

2015-01-16 17:22:07 +00:00

class-wp-importer.php

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value - anything that is returned is discarded.

2015-01-10 06:12:25 +00:00

class-wp-links-list-table.php

List tables: Use CSS :nth-child() selectors for zebra striping.

2015-01-14 22:13:03 +00:00

class-wp-list-table.php

[31210] broke Supportflow on dotorg, which declares these methods as protected. Switch to protected for the noop methods. The subclasses can make them more visible using public.

2015-01-16 18:36:46 +00:00

class-wp-media-list-table.php

List tables: Use CSS :nth-child() selectors for zebra striping.

2015-01-14 22:13:03 +00:00

class-wp-ms-sites-list-table.php

List tables: Use CSS :nth-child() selectors for zebra striping.

2015-01-14 22:13:03 +00:00

class-wp-ms-themes-list-table.php

In lieu of refactoring, add a private field to WP_MS_Themes_List_Table, $has_items. Ideally, this class would overload ->has_items() and not set a private field.

2015-01-12 16:16:16 +00:00

class-wp-ms-users-list-table.php

List tables: Use CSS :nth-child() selectors for zebra striping.

2015-01-14 22:13:03 +00:00

class-wp-plugin-install-list-table.php

Add a private field to WP_Plugin_Install_List_Table, $error.

2015-01-12 16:18:52 +00:00

class-wp-plugins-list-table.php

Improve various @param docs for List Tables.

2014-12-01 00:32:19 +00:00

class-wp-posts-list-table.php

In HTML5, the action attribute is no longer required. Remove this attribute when empty.

2015-01-16 04:15:52 +00:00

class-wp-terms-list-table.php

In HTML5, the action attribute is no longer required. Remove this attribute when empty.

2015-01-16 04:15:52 +00:00

class-wp-theme-install-list-table.php

Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*.

2014-11-30 11:27:19 +00:00

class-wp-themes-list-table.php

Improve various @param docs for List Tables.

2014-12-01 00:32:19 +00:00

class-wp-upgrader-skins.php

WP_Upgrader will take any "skin" that is passed to it, and set ->skin via composition. The default type of ->skin is WP_Upgrader_Skin, which doesn't have methods declared for ->bulk_header() and ->bulk_footer(). Add noop methods to WP_Upgrader_Skin.

2015-01-10 05:41:05 +00:00

class-wp-upgrader.php

Jump statements should not be followed by other statements (there were 5 lingering).

2015-01-08 21:14:56 +00:00

class-wp-users-list-table.php

In PHP 5.0.0, is_a() became deprecated in favour of the instanceof operator. Calling is_a() would result in an E_STRICT warning.

2015-01-16 01:05:52 +00:00

comment.php

Correct references of @uses $wpdb in core documentation to use @global.

2014-10-31 17:55:39 +00:00

continents-cities.php

New develop.svn.wordpress.org repository based on the old core.svn repository.

2013-08-07 05:25:25 +00:00

dashboard.php

In HTML5, the action attribute is no longer required. Remove this attribute when empty.

2015-01-16 04:15:52 +00:00

deprecated.php

Correctly capitalize JavaScript throughout core docs.

2014-12-02 00:30:59 +00:00

export.php

The keyword elseif should be used instead of else if so that all control keywords look like single words.

2015-01-08 07:04:40 +00:00

file.php

@param cleanup:

2015-01-16 19:02:26 +00:00

image-edit.php

Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167.

2015-01-07 22:47:32 +00:00

image.php

Use && instead of and in the 3 places where and was used.

2015-01-08 21:11:46 +00:00

import.php

In wp_import_handle_upload():

2014-12-20 21:09:11 +00:00

list-table.php

Fix mismatches in access modifiers for WP_List_Table + subclasses.

2014-07-13 22:08:22 +00:00

media.php

In HTML5, the action attribute is no longer required. Remove this attribute when empty.

2015-01-16 04:15:52 +00:00

menu.php

Fix syntax for single- and multi-line comments in wp-admin-directory files.

2014-07-17 09:13:53 +00:00

meta-boxes.php

The keyword elseif should be used instead of else if so that all control keywords look like single words.

2015-01-08 07:04:40 +00:00

misc.php

Fill in the @param types for the args for functions missing them in wp-admin/includes/misc.php.

2014-11-03 06:00:25 +00:00

ms-deprecated.php

Fix syntax for single- and multi-line comments in wp-admin-directory files.

2014-07-17 09:13:53 +00:00

ms.php

Add variable type for sync_category_tag_slugs() parameters.

2015-01-09 11:18:22 +00:00

nav-menu.php

For clarity, initialize some arrays that previously were only assigned via short circuit in loops.

2014-12-20 22:46:53 +00:00

plugin-install.php

In HTML5, the action attribute is no longer required. Remove this attribute when empty.

2015-01-16 04:15:52 +00:00

plugin.php

After [31105], don't ditch the isset() calls for BC. Declare $page_hook as null so it is initialized for all execution paths but will still fail isset() checks.

2015-01-08 22:51:30 +00:00

post.php

Replace the 3 remaining occurrences of wpspin GIF with spinner.

2015-01-16 00:32:45 +00:00

revision.php

In wp-admin/includes/revision.php, $post->modified is a coding error. It should be $post->post_modified.

2015-01-10 05:49:24 +00:00

schema.php

Adjust [29806] and revert [29807] to restore placeholder and email copy order.

2014-12-05 01:14:03 +00:00

screen.php

In HTML5, the action attribute is no longer required. Remove this attribute when empty.

2015-01-16 04:15:52 +00:00

taxonomy.php

Default $parent in category_exists() should default to null rather than 0.

2015-01-11 01:25:19 +00:00

template.php

In HTML5, the action attribute is no longer required. Remove this attribute when empty.

2015-01-16 04:15:52 +00:00

theme-install.php

In HTML5, the action attribute is no longer required. Remove this attribute when empty.

2015-01-16 04:15:52 +00:00

theme.php

In PHP 5.0.0, is_a() became deprecated in favour of the instanceof operator. Calling is_a() would result in an E_STRICT warning.

2015-01-16 01:05:52 +00:00

translation-install.php

Call the init() method for the upgrader in wp_can_install_language_pack() to avoid undefined index notices.

2015-01-07 23:42:48 +00:00

update-core.php

Declare $wp_version, $required_php_version, and $required_mysql_version as globals in install and upgrade admin files.

2015-01-10 05:56:45 +00:00

update.php

The keyword elseif should be used instead of else if so that all control keywords look like single words.

2015-01-08 07:04:40 +00:00

upgrade.php

By initializing this array before a loop, Scrutinizer reports 0 (zero) "Coding Style" errors.

2015-01-16 19:12:15 +00:00

user.php

Correct all @return unknown instances.

2014-11-03 06:16:34 +00:00

widgets.php

In HTML5, the action attribute is no longer required. Remove this attribute when empty.

2015-01-16 04:15:52 +00:00