Ian Dunn cac678f807 Multisite: Cache absolute dirsize paths to avoid PHP 8 fatal. ... r49212 greatly improved the performance of `get_dirsize()`, but also changed the structure of the data stored in the `dirsize_cache` transient. It stored relative paths instead of absolute ones, and also removed the unnecessary `size` array. That difference in data structures led to a fatal error in the following environment: * PHP 8 * Multisite * A custom `WP_CONTENT_DIR` which is not a child of WP's `ABSPATH` folder (e.g., [https://roots.io/bedrock/ Bedrock]) * The `upload_space_check_disabled` option set to `0` After upgrading to WP 5.6, the `dirsize_cache` transient still had data in the old format. When `wp-admin.php/index.php` was visited, `get_space_used()` received an `array` instead of an `int`, and tried to divide it by another `int`. PHP 7 would silently cast the arguments to match data types, but [https://wiki.php.net/rfc/arithmetic_operator_type_checks PHP 8 throws a fatal error]: `Uncaught TypeError: Unsupported operand types: array / int` `recurse_dirsize()` was using `ABSPATH` to convert the absolute paths to relative ones, but some upload locations are not located under `ABSPATH`. In those cases, `$directory` and `$cache_path` were identical, and that triggered the early return of the old `array`, instead of the expected `int`. In order to avoid that, this commit restores the absolute paths, but without the `size` array. It also adds a type check when returning cached values. Using absolute paths without `size` has the result of overwriting the old data, so that it matches the new format. The type check and upgrade routine are additional safety measures. Props peterwilsoncc, janthiel, helen, hellofromtonya, francina, pbiron. Fixes #51913. See #19879. git-svn-id: https://develop.svn.wordpress.org/trunk@49744 602fd350-edb4-49c9-b593-d223f7449a82		2020-12-03 20:37:43 +00:00
..
bootstrap.php	Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.	2020-11-15 13:59:32 +00:00
cleanDirsizeCache.php	Multisite: Cache absolute dirsize paths to avoid PHP 8 fatal.	2020-12-03 20:37:43 +00:00
getBlogDetails.php	Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.	2020-11-15 13:59:32 +00:00
getIdFromBlogname.php	Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.	2020-11-15 13:59:32 +00:00
getMainSiteId.php	Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.	2020-11-15 13:59:32 +00:00
getSite.php	Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.	2020-11-15 13:59:32 +00:00
getSpaceAllowed.php	Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.	2020-09-02 00:35:36 +00:00
getSpaceUsed.php	Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.	2020-09-02 00:35:36 +00:00
isEmailAddressUnsafe.php	Code is Poetry.	2017-11-30 23:09:33 +00:00
isUploadSpaceAvailable.php	Code is Poetry.	2017-11-30 23:09:33 +00:00
ms-files-rewriting.php	Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.	2020-09-02 00:35:36 +00:00
network.php	Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.	2020-11-15 13:59:32 +00:00
networkQuery.php	Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.	2020-11-15 13:59:32 +00:00
site.php	Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.	2020-11-15 13:59:32 +00:00
siteDetails.php	General: Remove “whitelist” and “blacklist” in favor of more clear and inclusive language.	2020-06-22 17:24:34 +00:00
siteMeta.php	Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.	2020-11-15 13:59:32 +00:00
siteQuery.php	Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.	2020-11-15 13:59:32 +00:00
updateBlogDetails.php	Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.	2020-09-02 00:35:36 +00:00
uploadIsUserOverQuota.php	Code is Poetry.	2017-11-30 23:09:33 +00:00
wpGetSites.php	Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.	2020-11-15 13:59:32 +00:00
wpInstallDefaults.php	Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.	2020-09-02 00:35:36 +00:00
wpMSSitesListTable.php	Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.	2020-11-15 13:59:32 +00:00
wpmuValidateBlogSignup.php	Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.	2020-11-15 13:59:32 +00:00
wpmuValidateUserSignup.php	Multisite: Delete the signup entry when a user is deleted from the database.	2020-07-05 11:19:35 +00:00