wordpress-develop/tests/phpunit/tests/term/slashes.php
Sergey Biryukov bafecbeab5 Code Modernization: Remove dynamic properties in Tests_*_Slashes.
Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.

In this particular case, the test classes contain a `set_up()` method that sets a group of properties, which are ''used'' by the tests, but the values of these properties are never ''changed'' by the tests.

In other words, setting these properties in the `set_up()` is an unnecessary overhead and the properties should be changed to class constants.

Follow-up to [1041/tests], [1071/tests].

Props jrf.
See #56033.

git-svn-id: https://develop.svn.wordpress.org/trunk@53557 602fd350-edb4-49c9-b593-d223f7449a82
2022-06-23 14:24:08 +00:00

136 lines
3.5 KiB
PHP

<?php
/**
* @group term
* @group slashes
* @ticket 21767
*/
class Tests_Term_Slashes extends WP_Ajax_UnitTestCase {
/*
* It is important to test with both even and odd numbered slashes,
* as KSES does a strip-then-add slashes in some of its function calls.
*/
const SLASH_1 = 'String with 1 slash \\';
const SLASH_2 = 'String with 2 slashes \\\\';
const SLASH_3 = 'String with 3 slashes \\\\\\';
const SLASH_4 = 'String with 4 slashes \\\\\\\\';
const SLASH_5 = 'String with 5 slashes \\\\\\\\\\';
const SLASH_6 = 'String with 6 slashes \\\\\\\\\\\\';
const SLASH_7 = 'String with 7 slashes \\\\\\\\\\\\\\';
protected static $author_id;
public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
self::$author_id = $factory->user->create( array( 'role' => 'administrator' ) );
}
public function set_up() {
parent::set_up();
wp_set_current_user( self::$author_id );
}
/**
* Tests the model function that expects slashed data.
*/
public function test_wp_insert_term() {
$taxonomies = array(
'category',
'post_tag',
);
foreach ( $taxonomies as $taxonomy ) {
$insert = wp_insert_term(
self::SLASH_1,
$taxonomy,
array(
'slug' => 'slash_test_1_' . $taxonomy,
'description' => self::SLASH_3,
)
);
$term = get_term( $insert['term_id'], $taxonomy );
$this->assertSame( wp_unslash( self::SLASH_1 ), $term->name );
$this->assertSame( wp_unslash( self::SLASH_3 ), $term->description );
$insert = wp_insert_term(
self::SLASH_3,
$taxonomy,
array(
'slug' => 'slash_test_2_' . $taxonomy,
'description' => self::SLASH_5,
)
);
$term = get_term( $insert['term_id'], $taxonomy );
$this->assertSame( wp_unslash( self::SLASH_3 ), $term->name );
$this->assertSame( wp_unslash( self::SLASH_5 ), $term->description );
$insert = wp_insert_term(
self::SLASH_2,
$taxonomy,
array(
'slug' => 'slash_test_3_' . $taxonomy,
'description' => self::SLASH_4,
)
);
$term = get_term( $insert['term_id'], $taxonomy );
$this->assertSame( wp_unslash( self::SLASH_2 ), $term->name );
$this->assertSame( wp_unslash( self::SLASH_4 ), $term->description );
}
}
/**
* Tests the model function that expects slashed data.
*/
public function test_wp_update_term() {
$taxonomies = array(
'category',
'post_tag',
);
foreach ( $taxonomies as $taxonomy ) {
$term_id = self::factory()->term->create(
array(
'taxonomy' => $taxonomy,
)
);
$update = wp_update_term(
$term_id,
$taxonomy,
array(
'name' => self::SLASH_1,
'description' => self::SLASH_3,
)
);
$term = get_term( $term_id, $taxonomy );
$this->assertSame( wp_unslash( self::SLASH_1 ), $term->name );
$this->assertSame( wp_unslash( self::SLASH_3 ), $term->description );
$update = wp_update_term(
$term_id,
$taxonomy,
array(
'name' => self::SLASH_3,
'description' => self::SLASH_5,
)
);
$term = get_term( $term_id, $taxonomy );
$this->assertSame( wp_unslash( self::SLASH_3 ), $term->name );
$this->assertSame( wp_unslash( self::SLASH_5 ), $term->description );
$update = wp_update_term(
$term_id,
$taxonomy,
array(
'name' => self::SLASH_2,
'description' => self::SLASH_4,
)
);
$term = get_term( $term_id, $taxonomy );
$this->assertSame( wp_unslash( self::SLASH_2 ), $term->name );
$this->assertSame( wp_unslash( self::SLASH_4 ), $term->description );
}
}
}