mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2025-10-16 12:05:38 +00:00
ddb409edca
> PHPUnit 8.0.0 introduced a `void` return type declaration to the "fixture" methods – `setUpBeforeClass()`, `setUp()`, `tearDown()` and `tearDownAfterClass()`. As the `void` return type was not introduced until PHP 7.1, this makes it more difficult to create cross-version compatible tests when using fixtures, due to signature mismatches. > > The `Yoast\PHPUnitPolyfills\TestCases\TestCase` overcomes the signature mismatch by having two versions. The correct one will be loaded depending on the PHPUnit version being used. > > When using this TestCase, if an individual test, or another TestCase which extends this TestCase, needs to overload any of the "fixture" methods, it should do so by using a snake_case variant of the original fixture method name, i.e. `set_up_before_class()`, `set_up()`, `assert_pre_conditions()`, `assert_post_conditions()`, `tear_down()`, and `tear_down_after_class()`. > > The snake_case methods will automatically be called by PHPUnit. > > > IMPORTANT: The snake_case methods should not call the PHPUnit parent, i.e. do not use `parent::setUp()` from within an overloaded `set_up()` method. If necessary, DO call `parent::set_up()`. Reference: https://github.com/Yoast/PHPUnit-Polyfills#testcases This commit renames all declared fixture methods, and calls to parent versions of those fixture methods, from camelCase to snake_case. Follow-up to [51559-51567]. Props jrf, hellofromTonya, johnbillion, netweb, dd32, pputzer, SergeyBiryukov. See #46149. git-svn-id: https://develop.svn.wordpress.org/trunk@51568 602fd350-edb4-49c9-b593-d223f7449a82
66 lines
1.7 KiB
PHP
66 lines
1.7 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group comment
|
|
*/
|
|
class Tests_Comment_Walker extends WP_UnitTestCase {
|
|
|
|
function set_up() {
|
|
parent::set_up();
|
|
|
|
$this->post_id = self::factory()->post->create();
|
|
}
|
|
|
|
/**
|
|
* @ticket 14041
|
|
*/
|
|
function test_has_children() {
|
|
$comment_parent = self::factory()->comment->create( array( 'comment_post_ID' => $this->post_id ) );
|
|
$comment_child = self::factory()->comment->create(
|
|
array(
|
|
'comment_post_ID' => $this->post_id,
|
|
'comment_parent' => $comment_parent,
|
|
)
|
|
);
|
|
$comment_parent = get_comment( $comment_parent );
|
|
$comment_child = get_comment( $comment_child );
|
|
|
|
$comment_walker = new Walker_Comment();
|
|
$comment_callback = new Comment_Callback_Test( $this, $comment_walker );
|
|
|
|
wp_list_comments(
|
|
array(
|
|
'callback' => array( $comment_callback, 'comment' ),
|
|
'walker' => $comment_walker,
|
|
'echo' => false,
|
|
),
|
|
array( $comment_parent, $comment_child )
|
|
);
|
|
wp_list_comments(
|
|
array(
|
|
'callback' => array( $comment_callback, 'comment' ),
|
|
'walker' => $comment_walker,
|
|
'echo' => false,
|
|
),
|
|
array( $comment_child, $comment_parent )
|
|
);
|
|
}
|
|
}
|
|
|
|
class Comment_Callback_Test {
|
|
public function __construct( Tests_Comment_Walker $test_walker, Walker_Comment $walker ) {
|
|
$this->test_walker = $test_walker;
|
|
$this->walker = $walker;
|
|
}
|
|
|
|
public function comment( $comment, $args, $depth ) {
|
|
if ( 1 === $depth ) {
|
|
$this->test_walker->assertTrue( $this->walker->has_children );
|
|
$this->test_walker->assertTrue( $args['has_children'] ); // Back compat.
|
|
} elseif ( 2 === $depth ) {
|
|
$this->test_walker->assertFalse( $this->walker->has_children );
|
|
$this->test_walker->assertFalse( $args['has_children'] ); // Back compat.
|
|
}
|
|
}
|
|
}
|