mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2025-10-16 12:05:38 +00:00
Previously, a trailing slash was appended to the link returned from `get_pagenum_link()`. If the permalink structure didn't contain a trailing slash, this link could fail. This change removes trailing slashes and only appends one if the site is set for adding trailing slashes. This adds a new test file for the accompanying tests, `tests/phpunit/tests/link/getPagenumLink.php`, and moves an existing test for `get_pagenum_link()` to the same file. Props davemad-davenet, darkfate, Nazgul, scribu, nacin, obenland, chriscct7, jesin, matthewppelsheimer, audrasjb, petitphp, mukesh27, oglekler, mai21, webtechpooja, tejwanihemant, nicolefurlan, hellofromTonya, costdev. Fixes #2877. git-svn-id: https://develop.svn.wordpress.org/trunk@56939 602fd350-edb4-49c9-b593-d223f7449a82
191 lines
5.8 KiB
PHP
191 lines
5.8 KiB
PHP
<?php
|
|
/**
|
|
* @group link
|
|
*/
|
|
class Tests_Link extends WP_UnitTestCase {
|
|
|
|
public function test_wp_get_shortlink() {
|
|
$post_id = self::factory()->post->create();
|
|
$post_id2 = self::factory()->post->create();
|
|
|
|
// Basic case.
|
|
$this->assertSame( get_permalink( $post_id ), wp_get_shortlink( $post_id, 'post' ) );
|
|
|
|
unset( $GLOBALS['post'] );
|
|
|
|
// Global post is not set.
|
|
$this->assertSame( '', wp_get_shortlink( 0, 'post' ) );
|
|
$this->assertSame( '', wp_get_shortlink( 0 ) );
|
|
$this->assertSame( '', wp_get_shortlink() );
|
|
|
|
$GLOBALS['post'] = get_post( $post_id );
|
|
|
|
// Global post is set.
|
|
$this->assertSame( get_permalink( $post_id ), wp_get_shortlink( 0, 'post' ) );
|
|
$this->assertSame( get_permalink( $post_id ), wp_get_shortlink( 0 ) );
|
|
$this->assertSame( get_permalink( $post_id ), wp_get_shortlink() );
|
|
|
|
// Not the global post.
|
|
$this->assertSame( get_permalink( $post_id2 ), wp_get_shortlink( $post_id2, 'post' ) );
|
|
|
|
unset( $GLOBALS['post'] );
|
|
|
|
// Global post is not set, once again.
|
|
$this->assertSame( '', wp_get_shortlink( 0, 'post' ) );
|
|
$this->assertSame( '', wp_get_shortlink( 0 ) );
|
|
$this->assertSame( '', wp_get_shortlink() );
|
|
|
|
$this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
|
|
|
|
// With a permalink structure set, get_permalink() will no longer match.
|
|
$this->assertNotEquals( get_permalink( $post_id ), wp_get_shortlink( $post_id, 'post' ) );
|
|
$this->assertSame( home_url( '?p=' . $post_id ), wp_get_shortlink( $post_id, 'post' ) );
|
|
|
|
// Global post and permalink structure are set.
|
|
$GLOBALS['post'] = get_post( $post_id );
|
|
$this->assertSame( home_url( '?p=' . $post_id ), wp_get_shortlink( 0, 'post' ) );
|
|
$this->assertSame( home_url( '?p=' . $post_id ), wp_get_shortlink( 0 ) );
|
|
$this->assertSame( home_url( '?p=' . $post_id ), wp_get_shortlink() );
|
|
}
|
|
|
|
public function test_wp_get_shortlink_with_page() {
|
|
$post_id = self::factory()->post->create( array( 'post_type' => 'page' ) );
|
|
|
|
// Basic case.
|
|
// Don't test against get_permalink() since it uses ?page_id= for pages.
|
|
$this->assertSame( home_url( '?p=' . $post_id ), wp_get_shortlink( $post_id, 'post' ) );
|
|
|
|
$this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
|
|
|
|
$this->assertSame( home_url( '?p=' . $post_id ), wp_get_shortlink( $post_id, 'post' ) );
|
|
}
|
|
|
|
/**
|
|
* @ticket 26871
|
|
*/
|
|
public function test_wp_get_shortlink_with_home_page() {
|
|
$post_id = self::factory()->post->create( array( 'post_type' => 'page' ) );
|
|
update_option( 'show_on_front', 'page' );
|
|
update_option( 'page_on_front', $post_id );
|
|
|
|
$this->assertSame( home_url( '/' ), wp_get_shortlink( $post_id, 'post' ) );
|
|
|
|
$this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
|
|
|
|
$this->assertSame( home_url( '/' ), wp_get_shortlink( $post_id, 'post' ) );
|
|
}
|
|
|
|
/**
|
|
* @ticket 30910
|
|
*/
|
|
public function test_get_permalink_should_not_reveal_post_name_for_post_with_post_status_future() {
|
|
update_option( 'permalink_structure', '/%year%/%monthnum%/%day%/%postname%/' );
|
|
|
|
flush_rewrite_rules();
|
|
|
|
$p = self::factory()->post->create(
|
|
array(
|
|
'post_status' => 'publish',
|
|
'post_date' => date_format( date_create( '+1 day' ), 'Y-m-d H:i:s' ),
|
|
)
|
|
);
|
|
|
|
$non_pretty_permalink = add_query_arg( 'p', $p, trailingslashit( home_url() ) );
|
|
|
|
$this->assertSame( $non_pretty_permalink, get_permalink( $p ) );
|
|
}
|
|
|
|
/**
|
|
* @ticket 30910
|
|
*/
|
|
public function test_get_permalink_should_not_reveal_post_name_for_cpt_with_post_status_future() {
|
|
update_option( 'permalink_structure', '/%year%/%monthnum%/%day%/%postname%/' );
|
|
|
|
register_post_type( 'wptests_pt', array( 'public' => true ) );
|
|
|
|
flush_rewrite_rules();
|
|
|
|
$p = self::factory()->post->create(
|
|
array(
|
|
'post_status' => 'future',
|
|
'post_type' => 'wptests_pt',
|
|
'post_date' => date_format( date_create( '+1 day' ), 'Y-m-d H:i:s' ),
|
|
)
|
|
);
|
|
|
|
$non_pretty_permalink = add_query_arg(
|
|
array(
|
|
'post_type' => 'wptests_pt',
|
|
'p' => $p,
|
|
),
|
|
trailingslashit( home_url() )
|
|
);
|
|
|
|
$this->assertSame( $non_pretty_permalink, get_permalink( $p ) );
|
|
}
|
|
|
|
/**
|
|
* @ticket 1914
|
|
*/
|
|
public function test_unattached_attachment_has_a_pretty_permalink() {
|
|
$this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
|
|
|
|
$attachment_id = self::factory()->attachment->create_object(
|
|
'image.jpg',
|
|
0,
|
|
array(
|
|
'post_mime_type' => 'image/jpeg',
|
|
'post_type' => 'attachment',
|
|
'post_title' => 'An Attachment!',
|
|
'post_status' => 'inherit',
|
|
)
|
|
);
|
|
|
|
$attachment = get_post( $attachment_id );
|
|
|
|
$this->assertSame( home_url( user_trailingslashit( $attachment->post_name ) ), get_permalink( $attachment_id ) );
|
|
}
|
|
|
|
/**
|
|
* @ticket 1914
|
|
*/
|
|
public function test_attachment_attached_to_non_existent_post_type_has_a_pretty_permalink() {
|
|
global $wp_post_types;
|
|
|
|
$this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
|
|
|
|
register_post_type( 'not_a_post_type', array( 'public' => true ) );
|
|
|
|
flush_rewrite_rules();
|
|
|
|
$post_id = self::factory()->post->create( array( 'post_type' => 'not_a_post_type' ) );
|
|
|
|
$attachment_id = self::factory()->attachment->create_object(
|
|
'image.jpg',
|
|
$post_id,
|
|
array(
|
|
'post_mime_type' => 'image/jpeg',
|
|
'post_type' => 'attachment',
|
|
'post_title' => 'An Attachment!',
|
|
'post_status' => 'inherit',
|
|
)
|
|
);
|
|
|
|
$attachment = get_post( $attachment_id );
|
|
|
|
$this->assertSame( get_permalink( $post_id ) . user_trailingslashit( $attachment->post_name ), get_permalink( $attachment_id ) );
|
|
|
|
foreach ( $wp_post_types as $id => $pt ) {
|
|
if ( 'not_a_post_type' === $pt->name ) {
|
|
unset( $wp_post_types[ $id ] );
|
|
break;
|
|
}
|
|
}
|
|
|
|
$this->assertSame( home_url( "/?attachment_id={$attachment->ID}" ), get_permalink( $attachment_id ) );
|
|
// Visit permalink.
|
|
$this->go_to( get_permalink( $attachment_id ) );
|
|
$this->assertQueryTrue( 'is_attachment', 'is_single', 'is_singular' );
|
|
}
|
|
}
|