wordpress-develop

mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00

History

Sergey Biryukov 5f5895bf61 Code Modernization: Check the return type of `parse_url()` in `download_url()`. As per the PHP manual: > If the `component` parameter is omitted, an associative array is returned. > If the `component` parameter is specified, `parse_url()` returns a string (or an int, in the case of `PHP_URL_PORT`) instead of an array. If the requested component doesn't exist within the given URL, `null` will be returned. Reference: [https://www.php.net/manual/en/function.parse-url.php#refsect1-function.parse-url-returnvalues PHP Manual: parse_url(): Return Values] This commit adds three unit tests for `download_url()`: * The first test is "girl-scouting" to make sure that the code up to the point where the error is expected is tested. * The second test exposed a PHP 8.1 `basename(): Passing null to parameter #1 ($path) of type string is deprecated` error due to the call to `parse_url()` returning `null` when the component requested does not exist in the passed URL. * The output of the call to `parse_url()` stored in the `$url_path` variable is used in more places in the function logic. The third test exposes a second PHP 8.1 deprecation notice, this time for `substr(): Passing null to parameter #1 ($string) of type string is deprecated`. This commit also removes duplicate `parse_url()` calls. Neither `$url` nor `$url_filename` are changed between when they are first received/defined and when they are re-used, so there is no need to repeat the function calls. Follow-up to [51606], [51622]. Props jrf, hellofromTonya, SergeyBiryukov. See #53635. git-svn-id: https://develop.svn.wordpress.org/trunk@51626 602fd350-edb4-49c9-b593-d223f7449a82		2021-08-17 00:14:20 +00:00
..
data	Tests: Fix failing i18n unit tests for block metadata	2021-08-11 10:37:17 +00:00
includes	Tests: Add unit tests for the `wp_nonce_ays()` function.	2021-08-13 14:00:05 +00:00
tests	Code Modernization: Check the return type of `parse_url()` in `download_url()`.	2021-08-17 00:14:20 +00:00
build.xml	Coding Standards: Replace spaced indentation sections of `phpunit.xml.dist`, `multisite.xml`, and `build.xml` with tabs.	2019-01-28 17:20:06 +00:00
multisite.xml	Code Modernization: Rename the `readonly()` function to `wp_readonly()`.	2021-08-09 17:19:21 +00:00
README.txt	Update tests/README.txt to reflect the new tests directory structure. props jdgrimes. fixes #25133 .	2013-08-31 13:42:56 +00:00
wp-mail-real-test.php	Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant.	2020-02-06 06:31:22 +00:00

README.txt

The short version:

1. Create a clean MySQL database and user.  DO NOT USE AN EXISTING DATABASE or you will lose data, guaranteed.

2. Copy wp-tests-config-sample.php to wp-tests-config.php, edit it and include your database name/user/password.

3. $ svn up

4. Run the tests from the "trunk" directory:
   To execute a particular test:
      $ phpunit tests/phpunit/tests/test_case.php
   To execute all tests:
      $ phpunit

Notes:

Test cases live in the 'tests' subdirectory.  All files in that directory will be included by default.  Extend the WP_UnitTestCase class to ensure your test is run.

phpunit will initialize and install a (more or less) complete running copy of WordPress each time it is run.  This makes it possible to run functional interface and module tests against a fully working database and codebase, as opposed to pure unit tests with mock objects and stubs.  Pure unit tests may be used also, of course.

Changes to the test database will be rolled back as tests are finished, to ensure a clean start next time the tests are run.

phpunit is intended to run at the command line, not via a web server.