mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2026-04-12 08:34:35 +00:00
The test `Tests_Comment_CheckComment::test_should_return_true_when_content_does_not_match_moderation_keys()` did not, in fact, test for a `true` value, but for a false one. Switching to `assertTrue()` caused a failure, because the test comment triggered the 'comment_moderation' test. As in other tests in the file, the solution is to force 'comment_moderation' to 0 for the purposes of the test. Introduced in [32519]. Props stephdau. Fixes #40584. git-svn-id: https://develop.svn.wordpress.org/trunk@40557 602fd350-edb4-49c9-b593-d223f7449a82
176 lines
6.5 KiB
PHP
176 lines
6.5 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group comment
|
|
*/
|
|
class Tests_Comment_CheckComment extends WP_UnitTestCase {
|
|
public function test_should_return_true_when_comment_whitelist_is_disabled() {
|
|
$author = 'BobtheBuilder';
|
|
$author_email = 'bob@example.com';
|
|
$author_url = 'http://example.com';
|
|
$comment = 'Can we fix it? Yes, we can (thanks to Wendy).';
|
|
$author_ip = '192.168.0.1';
|
|
$user_agent = '';
|
|
$comment_type = '';
|
|
|
|
update_option( 'comment_whitelist', 0 );
|
|
$results = check_comment( $author, $author_email, $author_url, $comment, $author_ip, $user_agent, $comment_type );
|
|
$this->assertTrue( $results );
|
|
}
|
|
|
|
public function test_should_return_false_when_comment_whitelist_is_enabled_and_author_does_not_have_approved_comment() {
|
|
$author = 'BobtheBuilder';
|
|
$author_email = 'bob@example.com';
|
|
$author_url = 'http://example.com';
|
|
$comment = 'Can we fix it? Yes, we can (thanks to Wendy).';
|
|
$author_ip = '192.168.0.1';
|
|
$user_agent = '';
|
|
$comment_type = '';
|
|
|
|
update_option( 'comment_whitelist', 1 );
|
|
$results = check_comment( $author, $author_email, $author_url, $comment, $author_ip, $user_agent, $comment_type );
|
|
$this->assertFalse( $results );
|
|
|
|
}
|
|
|
|
public function test_should_return_true_when_comment_whitelist_is_enabled_and_author_has_approved_comment() {
|
|
$post_id = self::factory()->post->create();
|
|
$prev_args = array(
|
|
'comment_post_ID' => $post_id,
|
|
'comment_content' => 'Can we build it?',
|
|
'comment_approved' => 0,
|
|
'comment_author_email' => 'bob@example.com',
|
|
'comment_author' => 'BobtheBuilder',
|
|
);
|
|
$prev_comment_id = self::factory()->comment->create( $prev_args );
|
|
|
|
update_option( 'comment_whitelist', 1 );
|
|
|
|
$author = 'BobtheBuilder';
|
|
$author_email = 'bob@example.com';
|
|
$author_url = 'http://example.com';
|
|
$comment = 'Can we fix it? Yes, we can (thanks to Wendy).';
|
|
$author_ip = '192.168.0.1';
|
|
$user_agent = '';
|
|
$comment_type = '';
|
|
|
|
$results = check_comment( $author, $author_email, $author_url, $comment, $author_ip, $user_agent, $comment_type );
|
|
$this->assertFalse( $results );
|
|
|
|
// Approve the previous comment.
|
|
wp_update_comment( array(
|
|
'comment_ID' => $prev_comment_id,
|
|
'comment_approved' => 1,
|
|
) );
|
|
$results = check_comment( $author, $author_email, $author_url, $comment, $author_ip, $user_agent, $comment_type );
|
|
$this->assertTrue( $results );
|
|
}
|
|
|
|
public function test_should_return_false_when_content_matches_moderation_key() {
|
|
update_option( 'comment_whitelist', 0 );
|
|
|
|
$author = 'WendytheBuilder';
|
|
$author_email = 'wendy@example.com';
|
|
$author_url = 'http://example.com';
|
|
$comment = 'Has anyone seen Scoop?';
|
|
$author_ip = '192.168.0.1';
|
|
$user_agent = '';
|
|
$comment_type = '';
|
|
|
|
update_option( 'moderation_keys',"foo\nbar\nscoop" );
|
|
$results = check_comment( $author, $author_email, $author_url, $comment, $author_ip, $user_agent, $comment_type );
|
|
$this->assertFalse( $results );
|
|
}
|
|
|
|
public function test_should_return_true_when_content_does_not_match_moderation_keys() {
|
|
update_option( 'comment_whitelist', 0 );
|
|
|
|
$author = 'WendytheBuilder';
|
|
$author_email = 'wendy@example.com';
|
|
$author_url = 'http://example.com';
|
|
$comment = 'Has anyone seen Scoop?';
|
|
$author_ip = '192.168.0.1';
|
|
$user_agent = '';
|
|
$comment_type = '';
|
|
|
|
update_option( 'moderation_keys',"foo\nbar" );
|
|
$results = check_comment( $author, $author_email, $author_url, $comment, $author_ip, $user_agent, $comment_type );
|
|
$this->assertTrue( $results );
|
|
}
|
|
|
|
public function test_should_return_false_when_link_count_exceeds_comment_max_length_setting() {
|
|
update_option( 'comment_whitelist', 0 );
|
|
|
|
$author = 'BobtheBuilder';
|
|
$author_email = 'bob@example.com';
|
|
$author_url = 'http://example.com';
|
|
$comment = 'This is a comment with <a href="http://example.com">multiple</a> <a href="http://bob.example.com">links</a>.';
|
|
$author_ip = '192.168.0.1';
|
|
$user_agent = '';
|
|
$comment_type = '';
|
|
|
|
update_option( 'comment_max_links', 2 );
|
|
$results = check_comment( $author, $author_email, $author_url, $comment, $author_ip, $user_agent, $comment_type );
|
|
$this->assertFalse( $results );
|
|
}
|
|
|
|
public function test_should_return_true_when_link_count_does_not_exceed_comment_max_length_setting() {
|
|
update_option( 'comment_whitelist', 0 );
|
|
|
|
$author = 'BobtheBuilder';
|
|
$author_email = 'bob@example.com';
|
|
$author_url = 'http://example.com';
|
|
$comment = 'This is a comment with <a href="http://example.com">multiple</a> <a href="http://bob.example.com">links</a>.';
|
|
$author_ip = '192.168.0.1';
|
|
$user_agent = '';
|
|
$comment_type = '';
|
|
|
|
update_option( 'comment_max_links', 3 );
|
|
$results = check_comment( $author, $author_email, $author_url, $comment, $author_ip, $user_agent, $comment_type );
|
|
$this->assertTrue( $results );
|
|
}
|
|
|
|
/**
|
|
* @ticket 28603
|
|
*/
|
|
public function test_should_return_true_when_comment_whitelist_is_enabled_and_user_has_previously_approved_comments_with_different_email() {
|
|
$subscriber_id = $this->factory()->user->create( array(
|
|
'role' => 'subscriber',
|
|
'email' => 'sub@example.com',
|
|
) );
|
|
|
|
// Make sure comment author has an approved comment.
|
|
$this->factory->comment->create( array( 'user_id' => $subscriber_id, 'comment_approved' => '1', 'comment_author' => 'foo', 'comment_author_email' => 'sub@example.com' ) );
|
|
|
|
$subscriber_user = new WP_User( $subscriber_id );
|
|
$subscriber_user->user_email = 'newsub@example.com';
|
|
|
|
wp_update_user( $subscriber_user );
|
|
|
|
update_option( 'comment_whitelist', 1 );
|
|
|
|
$results = check_comment( 'foo', 'newsub@example.com', 'http://example.com', 'This is a comment.', '66.155.40.249', 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:35.0) Gecko/20100101 Firefox/35.0', 'comment', 4 );
|
|
$this->assertTrue( $results );
|
|
}
|
|
|
|
/**
|
|
* @ticket 28603
|
|
*/
|
|
public function test_should_return_false_when_comment_whitelist_is_enabled_and_user_does_not_have_a_previously_approved_comment_with_any_email() {
|
|
$subscriber_id = $this->factory()->user->create( array(
|
|
'role' => 'subscriber',
|
|
'email' => 'zig@example.com',
|
|
) );
|
|
|
|
$subscriber_user = new WP_User( $subscriber_id );
|
|
$subscriber_user->user_email = 'zag@example.com';
|
|
|
|
wp_update_user( $subscriber_user );
|
|
|
|
update_option( 'comment_whitelist', 1 );
|
|
|
|
$results = check_comment( 'bar', 'zag@example.com', 'http://example.com', 'This is my first comment.', '66.155.40.249', 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:35.0) Gecko/20100101 Firefox/35.0', 'comment', 4 );
|
|
$this->assertFalse( $results );
|
|
}
|
|
}
|