mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2025-10-16 12:05:38 +00:00
683ae35c33
On certain permalink structures, a numeric post slug will result in a post permalink that conflicts with a date archive URL. For example, with permastruct `/%year%/%monthnum%/%postname%/`, a post published in May 2015 with slug `'15'` will result in a URL (`/2015/05/15/`) that conflicts with the archive for May 15, 2015. To avoid this problem, `wp_unique_post_slug()` rejects a requested slug when it would generate a conflict of this type. Thus, in our example, `'15'` would become `'15-2'`. Props valendesigns, boonebgorges, Denis-de-Bernardy, loushou. See #5305. git-svn-id: https://develop.svn.wordpress.org/trunk@32647 602fd350-edb4-49c9-b593-d223f7449a82
481 lines
15 KiB
PHP
481 lines
15 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group admin
|
|
*/
|
|
class Tests_Admin_includesPost extends WP_UnitTestCase {
|
|
|
|
function tearDown() {
|
|
wp_set_current_user( 0 );
|
|
parent::tearDown();
|
|
}
|
|
|
|
function test__wp_translate_postdata_cap_checks_contributor() {
|
|
$contributor_id = $this->factory->user->create( array( 'role' => 'contributor' ) );
|
|
$editor_id = $this->factory->user->create( array( 'role' => 'editor' ) );
|
|
|
|
wp_set_current_user( $contributor_id );
|
|
|
|
// Create New Draft Post
|
|
$_post_data = array();
|
|
$_post_data['post_author'] = $contributor_id;
|
|
$_post_data['post_type'] = 'post';
|
|
$_post_data['saveasdraft'] = true;
|
|
|
|
$_results = _wp_translate_postdata( false, $_post_data );
|
|
$this->assertNotInstanceOf( 'WP_Error', $_results );
|
|
$this->assertEquals( $_post_data['post_author'], $_results['post_author'] );
|
|
$this->assertEquals( 'draft', $_results['post_status'] );
|
|
|
|
// Submit Post for Approval
|
|
$_post_data = array();
|
|
$_post_data['post_author'] = $contributor_id;
|
|
$_post_data['post_type'] = 'post';
|
|
$_post_data['publish'] = true;
|
|
|
|
$_results = _wp_translate_postdata( false, $_post_data );
|
|
$this->assertNotInstanceOf( 'WP_Error', $_results );
|
|
$this->assertEquals( $_post_data['post_author'], $_results['post_author'] );
|
|
$this->assertEquals( 'pending', $_results['post_status'] );
|
|
|
|
// Create New Draft Post for another user
|
|
$_post_data = array();
|
|
$_post_data['post_author'] = $editor_id;
|
|
$_post_data['post_type'] = 'post';
|
|
$_post_data['saveasdraft'] = true;
|
|
|
|
$_results = _wp_translate_postdata( false, $_post_data );
|
|
$this->assertInstanceOf( 'WP_Error', $_results );
|
|
$this->assertEquals( 'edit_others_posts', $_results->get_error_code() );
|
|
$this->assertEquals( 'You are not allowed to create posts as this user.', $_results->get_error_message() );
|
|
|
|
// Edit Draft Post for another user
|
|
$_post_data = array();
|
|
$_post_data['post_ID'] = $this->factory->post->create( array( 'post_author' => $editor_id ) );
|
|
$_post_data['post_author'] = $editor_id;
|
|
$_post_data['post_type'] = 'post';
|
|
$_post_data['post_status'] = 'draft';
|
|
$_post_data['saveasdraft'] = true;
|
|
|
|
$_results = _wp_translate_postdata( true, $_post_data );
|
|
$this->assertInstanceOf( 'WP_Error', $_results );
|
|
$this->assertEquals( 'edit_others_posts', $_results->get_error_code() );
|
|
$this->assertEquals( 'You are not allowed to edit posts as this user.', $_results->get_error_message() );
|
|
}
|
|
|
|
function test__wp_translate_postdata_cap_checks_editor() {
|
|
$contributor_id = $this->factory->user->create( array( 'role' => 'contributor' ) );
|
|
$editor_id = $this->factory->user->create( array( 'role' => 'editor' ) );
|
|
|
|
wp_set_current_user( $editor_id );
|
|
|
|
// Create New Draft Post
|
|
$_post_data = array();
|
|
$_post_data['post_author'] = $editor_id;
|
|
$_post_data['post_type'] = 'post';
|
|
$_post_data['saveasdraft'] = true;
|
|
|
|
$_results = _wp_translate_postdata( false, $_post_data );
|
|
$this->assertNotInstanceOf( 'WP_Error', $_results );
|
|
$this->assertEquals( $_post_data['post_author'], $_results['post_author'] );
|
|
$this->assertEquals( 'draft', $_results['post_status'] );
|
|
|
|
// Publish Post
|
|
$_post_data = array();
|
|
$_post_data['post_author'] = $editor_id;
|
|
$_post_data['post_type'] = 'post';
|
|
$_post_data['publish'] = true;
|
|
|
|
$_results = _wp_translate_postdata( false, $_post_data );
|
|
$this->assertNotInstanceOf( 'WP_Error', $_results );
|
|
$this->assertEquals( $_post_data['post_author'], $_results['post_author'] );
|
|
$this->assertEquals( 'publish', $_results['post_status'] );
|
|
|
|
// Create New Draft Post for another user
|
|
$_post_data = array();
|
|
$_post_data['post_author'] = $contributor_id;
|
|
$_post_data['post_type'] = 'post';
|
|
$_post_data['saveasdraft'] = true;
|
|
|
|
$_results = _wp_translate_postdata( false, $_post_data );
|
|
$this->assertNotInstanceOf( 'WP_Error', $_results );
|
|
$this->assertEquals( $_post_data['post_author'], $_results['post_author'] );
|
|
$this->assertEquals( 'draft', $_results['post_status'] );
|
|
|
|
// Edit Draft Post for another user
|
|
$_post_data = array();
|
|
$_post_data['post_ID'] = $this->factory->post->create( array( 'post_author' => $contributor_id ) );
|
|
$_post_data['post_author'] = $contributor_id;
|
|
$_post_data['post_type'] = 'post';
|
|
$_post_data['post_status'] = 'draft';
|
|
$_post_data['saveasdraft'] = true;
|
|
|
|
$_results = _wp_translate_postdata( true, $_post_data );
|
|
$this->assertNotInstanceOf( 'WP_Error', $_results );
|
|
$this->assertEquals( $_post_data['post_author'], $_results['post_author'] );
|
|
$this->assertEquals( 'draft', $_results['post_status'] );
|
|
}
|
|
|
|
/**
|
|
* edit_post() should convert an existing auto-draft to a draft.
|
|
*
|
|
* @ticket 25272
|
|
*/
|
|
function test_edit_post_auto_draft() {
|
|
$user_id = $this->factory->user->create( array( 'role' => 'editor' ) );
|
|
wp_set_current_user( $user_id );
|
|
$post = $this->factory->post->create_and_get( array( 'post_status' => 'auto-draft' ) );
|
|
$this->assertEquals( 'auto-draft', $post->post_status );
|
|
$post_data = array(
|
|
'post_title' => 'Post title',
|
|
'content' => 'Post content',
|
|
'post_type' => 'post',
|
|
'post_ID' => $post->ID,
|
|
);
|
|
edit_post( $post_data );
|
|
$this->assertEquals( 'draft', get_post( $post->ID )->post_status );
|
|
}
|
|
|
|
/**
|
|
* @ticket 30615
|
|
*/
|
|
public function test_edit_post_should_parse_tax_input_by_name_rather_than_slug_for_nonhierarchical_taxonomies() {
|
|
$u = $this->factory->user->create( array( 'role' => 'editor' ) );
|
|
wp_set_current_user( $u );
|
|
|
|
register_taxonomy( 'wptests_tax', array( 'post' ) );
|
|
$t1 = $this->factory->term->create( array(
|
|
'taxonomy' => 'wptests_tax',
|
|
'name' => 'foo',
|
|
'slug' => 'bar',
|
|
) );
|
|
$t2 = $this->factory->term->create( array(
|
|
'taxonomy' => 'wptests_tax',
|
|
'name' => 'bar',
|
|
'slug' => 'foo',
|
|
) );
|
|
|
|
$p = $this->factory->post->create();
|
|
|
|
$post_data = array(
|
|
'post_ID' => $p,
|
|
'tax_input' => array(
|
|
'wptests_tax' => 'foo,baz',
|
|
),
|
|
);
|
|
|
|
edit_post( $post_data );
|
|
|
|
$found = wp_get_post_terms( $p, 'wptests_tax' );
|
|
|
|
// Should contain the term with the name 'foo', not the slug.
|
|
$this->assertContains( $t1, wp_list_pluck( $found, 'term_id' ) );
|
|
|
|
// The 'baz' tag should have been created.
|
|
$this->assertContains( 'baz', wp_list_pluck( $found, 'name' ) );
|
|
}
|
|
|
|
/**
|
|
* @ticket 30615
|
|
*/
|
|
public function test_edit_post_should_not_create_terms_for_an_empty_tag_input_field() {
|
|
$u = $this->factory->user->create( array( 'role' => 'editor' ) );
|
|
wp_set_current_user( $u );
|
|
|
|
register_taxonomy( 'wptests_tax', array( 'post' ) );
|
|
$t1 = $this->factory->term->create( array(
|
|
'taxonomy' => 'wptests_tax',
|
|
'name' => 'foo',
|
|
'slug' => 'bar',
|
|
) );
|
|
|
|
$p = $this->factory->post->create();
|
|
|
|
$post_data = array(
|
|
'post_ID' => $p,
|
|
'tax_input' => array(
|
|
'wptests_tax' => ' ',
|
|
),
|
|
);
|
|
|
|
edit_post( $post_data );
|
|
|
|
$found = wp_get_post_terms( $p, 'wptests_tax' );
|
|
|
|
$this->assertEmpty( $found );
|
|
}
|
|
|
|
/**
|
|
* @ticket 27792
|
|
*/
|
|
function test_bulk_edit_posts_stomping() {
|
|
$admin = $this->factory->user->create( array( 'role' => 'administrator' ) );
|
|
$users = $this->factory->user->create_many( 2, array( 'role' => 'author' ) );
|
|
wp_set_current_user( $admin );
|
|
|
|
$post1 = $this->factory->post->create( array(
|
|
'post_author' => $users[0],
|
|
'comment_status' => 'open',
|
|
'ping_status' => 'open',
|
|
'post_status' => 'publish',
|
|
) );
|
|
|
|
$post2 = $this->factory->post->create( array(
|
|
'post_author' => $users[1],
|
|
'comment_status' => 'closed',
|
|
'ping_status' => 'closed',
|
|
'post_status' => 'draft',
|
|
) );
|
|
|
|
$request = array(
|
|
'post_type' => 'post',
|
|
'post_author' => -1,
|
|
'ping_status' => -1,
|
|
'comment_status' => -1,
|
|
'_status' => -1,
|
|
'post' => array( $post1, $post2 ),
|
|
);
|
|
|
|
$done = bulk_edit_posts( $request );
|
|
|
|
$post = get_post( $post2 );
|
|
|
|
// Check that the first post's values don't stomp the second post.
|
|
$this->assertEquals( 'draft', $post->post_status );
|
|
$this->assertEquals( $users[1], $post->post_author );
|
|
$this->assertEquals( 'closed', $post->comment_status );
|
|
$this->assertEquals( 'closed', $post->ping_status );
|
|
}
|
|
|
|
/**
|
|
* @ticket 30910
|
|
*/
|
|
public function test_get_sample_permalink_should_return_pretty_permalink_for_posts_with_post_status_future() {
|
|
global $wp_rewrite;
|
|
|
|
$old_permalink_structure = get_option( 'permalink_structure' );
|
|
$permalink_structure = '%postname%';
|
|
$wp_rewrite->set_permalink_structure( "/$permalink_structure/" );
|
|
flush_rewrite_rules();
|
|
|
|
$future_date = date( 'Y-m-d H:i:s', time() + 100 );
|
|
$p = $this->factory->post->create( array( 'post_status' => 'future', 'post_name' => 'foo', 'post_date' => $future_date ) );
|
|
|
|
$found = get_sample_permalink( $p );
|
|
$expected = trailingslashit( home_url( $permalink_structure ) );
|
|
|
|
$this->assertSame( $expected, $found[0] );
|
|
|
|
$wp_rewrite->set_permalink_structure( $old_permalink_structure );
|
|
flush_rewrite_rules();
|
|
}
|
|
|
|
/**
|
|
* @ticket 30910
|
|
*/
|
|
public function test_get_sample_permalink_html_should_use_default_permalink_for_view_post_button_when_pretty_permalinks_are_disabled() {
|
|
global $wp_rewrite;
|
|
$old_permalink_structure = get_option( 'permalink_structure' );
|
|
$wp_rewrite->set_permalink_structure( '' );
|
|
flush_rewrite_rules();
|
|
|
|
wp_set_current_user( $this->factory->user->create( array( 'role' => 'administrator' ) ) );
|
|
|
|
$future_date = date( 'Y-m-d H:i:s', time() + 100 );
|
|
$p = $this->factory->post->create( array( 'post_status' => 'future', 'post_name' => 'foo', 'post_date' => $future_date ) );
|
|
|
|
$found = get_sample_permalink_html( $p );
|
|
$this->assertContains( "span id='view-post-btn'><a href='" . get_option( 'home' ) . "/?p=$p'", $found );
|
|
|
|
$wp_rewrite->set_permalink_structure( $old_permalink_structure );
|
|
flush_rewrite_rules();
|
|
}
|
|
|
|
/**
|
|
* @ticket 30910
|
|
*/
|
|
public function test_get_sample_permalink_html_should_use_pretty_permalink_for_view_post_button_when_pretty_permalinks_are_enabled() {
|
|
global $wp_rewrite;
|
|
$old_permalink_structure = get_option( 'permalink_structure' );
|
|
$permalink_structure = '%postname%';
|
|
$wp_rewrite->set_permalink_structure( "/$permalink_structure/" );
|
|
flush_rewrite_rules();
|
|
|
|
wp_set_current_user( $this->factory->user->create( array( 'role' => 'administrator' ) ) );
|
|
|
|
$future_date = date( 'Y-m-d H:i:s', time() + 100 );
|
|
$p = $this->factory->post->create( array( 'post_status' => 'future', 'post_name' => 'foo', 'post_date' => $future_date ) );
|
|
|
|
$found = get_sample_permalink_html( $p );
|
|
$post = get_post( $p );
|
|
$this->assertContains( "span id='view-post-btn'><a href='" . get_option( 'home' ) . "/" . $post->post_name . "/'", $found );
|
|
|
|
$wp_rewrite->set_permalink_structure( $old_permalink_structure );
|
|
flush_rewrite_rules();
|
|
}
|
|
|
|
/**
|
|
* @ticket 5305
|
|
*/
|
|
public function test_get_sample_permalink_should_avoid_slugs_that_would_create_clashes_with_year_archives() {
|
|
global $wp_rewrite;
|
|
$wp_rewrite->init();
|
|
$wp_rewrite->set_permalink_structure( '/%postname%/' );
|
|
$wp_rewrite->flush_rules();
|
|
|
|
$p = $this->factory->post->create( array(
|
|
'post_name' => '2015',
|
|
) );
|
|
|
|
$found = get_sample_permalink( $p );
|
|
$this->assertEquals( '2015-2', $found[1] );
|
|
|
|
$wp_rewrite->set_permalink_structure( '' );
|
|
flush_rewrite_rules();
|
|
}
|
|
|
|
/**
|
|
* @ticket 5305
|
|
*/
|
|
public function test_get_sample_permalink_should_allow_yearlike_slugs_if_permastruct_does_not_cause_an_archive_conflict() {
|
|
global $wp_rewrite;
|
|
$wp_rewrite->init();
|
|
$wp_rewrite->set_permalink_structure( '/%year%/%postname%/' );
|
|
$wp_rewrite->flush_rules();
|
|
|
|
$p = $this->factory->post->create( array(
|
|
'post_name' => '2015',
|
|
) );
|
|
|
|
$found = get_sample_permalink( $p );
|
|
$this->assertEquals( '2015', $found[1] );
|
|
|
|
$wp_rewrite->set_permalink_structure( '' );
|
|
flush_rewrite_rules();
|
|
}
|
|
|
|
/**
|
|
* @ticket 5305
|
|
*/
|
|
public function test_get_sample_permalink_should_avoid_slugs_that_would_create_clashes_with_month_archives() {
|
|
global $wp_rewrite;
|
|
$wp_rewrite->init();
|
|
$wp_rewrite->set_permalink_structure( '/%year%/%postname%/' );
|
|
$wp_rewrite->flush_rules();
|
|
|
|
$p = $this->factory->post->create( array(
|
|
'post_name' => '11',
|
|
) );
|
|
|
|
$found = get_sample_permalink( $p );
|
|
$this->assertEquals( '11-2', $found[1] );
|
|
|
|
$wp_rewrite->set_permalink_structure( '' );
|
|
flush_rewrite_rules();
|
|
}
|
|
|
|
/**
|
|
* @ticket 5305
|
|
*/
|
|
public function test_get_sample_permalink_should_ignore_potential_month_conflicts_for_invalid_monthnum() {
|
|
global $wp_rewrite;
|
|
$wp_rewrite->init();
|
|
$wp_rewrite->set_permalink_structure( '/%year%/%postname%/' );
|
|
$wp_rewrite->flush_rules();
|
|
|
|
$p = $this->factory->post->create( array(
|
|
'post_name' => '13',
|
|
) );
|
|
|
|
$found = get_sample_permalink( $p );
|
|
$this->assertEquals( '13', $found[1] );
|
|
|
|
$wp_rewrite->set_permalink_structure( '' );
|
|
flush_rewrite_rules();
|
|
}
|
|
|
|
/**
|
|
* @ticket 5305
|
|
*/
|
|
public function test_get_sample_permalink_should_avoid_slugs_that_would_create_clashes_with_day_archives() {
|
|
global $wp_rewrite;
|
|
$wp_rewrite->init();
|
|
$wp_rewrite->set_permalink_structure( '/%year%/%monthnum%/%postname%/' );
|
|
$wp_rewrite->flush_rules();
|
|
|
|
$p = $this->factory->post->create( array(
|
|
'post_name' => '30',
|
|
) );
|
|
|
|
$found = get_sample_permalink( $p );
|
|
$this->assertEquals( '30-2', $found[1] );
|
|
|
|
$wp_rewrite->set_permalink_structure( '' );
|
|
flush_rewrite_rules();
|
|
}
|
|
|
|
/**
|
|
* @ticket 5305
|
|
*/
|
|
public function test_get_sample_permalink_should_iterate_slug_suffix_when_a_date_conflict_is_found() {
|
|
global $wp_rewrite;
|
|
$wp_rewrite->init();
|
|
$wp_rewrite->set_permalink_structure( '/%year%/%monthnum%/%postname%/' );
|
|
$wp_rewrite->flush_rules();
|
|
|
|
$this->factory->post->create( array(
|
|
'post_name' => '30-2',
|
|
) );
|
|
|
|
$p = $this->factory->post->create( array(
|
|
'post_name' => '30',
|
|
) );
|
|
|
|
$found = get_sample_permalink( $p );
|
|
$this->assertEquals( '30-3', $found[1] );
|
|
|
|
$wp_rewrite->set_permalink_structure( '' );
|
|
flush_rewrite_rules();
|
|
}
|
|
|
|
/**
|
|
* @ticket 5305
|
|
*/
|
|
public function test_get_sample_permalink_should_ignore_potential_day_conflicts_for_invalid_day() {
|
|
global $wp_rewrite;
|
|
$wp_rewrite->init();
|
|
$wp_rewrite->set_permalink_structure( '/%year%/%monthnum%/%postname%/' );
|
|
$wp_rewrite->flush_rules();
|
|
|
|
$p = $this->factory->post->create( array(
|
|
'post_name' => '32',
|
|
) );
|
|
|
|
$found = get_sample_permalink( $p );
|
|
$this->assertEquals( '32', $found[1] );
|
|
|
|
$wp_rewrite->set_permalink_structure( '' );
|
|
flush_rewrite_rules();
|
|
}
|
|
|
|
/**
|
|
* @ticket 5305
|
|
*/
|
|
public function test_get_sample_permalink_should_allow_daylike_slugs_if_permastruct_does_not_cause_an_archive_conflict() {
|
|
global $wp_rewrite;
|
|
$wp_rewrite->init();
|
|
$wp_rewrite->set_permalink_structure( '/%year%/%month%/%day%/%postname%/' );
|
|
$wp_rewrite->flush_rules();
|
|
|
|
$p = $this->factory->post->create( array(
|
|
'post_name' => '30',
|
|
) );
|
|
|
|
$found = get_sample_permalink( $p );
|
|
$this->assertEquals( '30', $found[1] );
|
|
|
|
$wp_rewrite->set_permalink_structure( '' );
|
|
flush_rewrite_rules();
|
|
}
|
|
}
|