mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2026-04-07 22:24:36 +00:00
ffb2db0521
When `IMAGE_EDIT_OVERWRITE` is set to true, edited image files are supposed to be deleted when an image is restored to the original. However, when an image was edited more than once, and then restored, files created during previous edits were left behind. Fixes this behavior by updating `wp_save_image()` to clean up leftover images after each edit when `IMAGE_EDIT_OVERWRITE` is true. Props bradt, chriscct7, joemcgill. Fixes #32171. git-svn-id: https://develop.svn.wordpress.org/trunk@38113 602fd350-edb4-49c9-b593-d223f7449a82
101 lines
2.8 KiB
PHP
101 lines
2.8 KiB
PHP
<?php
|
|
/**
|
|
* Admin ajax functions to be tested
|
|
*/
|
|
require_once( ABSPATH . 'wp-admin/includes/ajax-actions.php' );
|
|
|
|
/**
|
|
* Testing ajax media editing
|
|
*
|
|
* @package WordPress
|
|
* @subpackage UnitTests
|
|
* @since 3.5.0
|
|
* @group ajax
|
|
*/
|
|
class Tests_Ajax_MediaEdit extends WP_Ajax_UnitTestCase {
|
|
|
|
/**
|
|
* Tear down the test fixture.
|
|
*/
|
|
public function tearDown() {
|
|
// Cleanup
|
|
$this->remove_added_uploads();
|
|
parent::tearDown();
|
|
}
|
|
|
|
/**
|
|
* @ticket 22985
|
|
*/
|
|
public function testCropImageThumbnail() {
|
|
include_once( ABSPATH . 'wp-admin/includes/image-edit.php' );
|
|
|
|
$filename = DIR_TESTDATA . '/images/canola.jpg';
|
|
$contents = file_get_contents($filename);
|
|
|
|
$upload = wp_upload_bits(basename($filename), null, $contents);
|
|
$id = $this->_make_attachment($upload);
|
|
|
|
$_REQUEST['action'] = 'image-editor';
|
|
$_REQUEST['context'] = 'edit-attachment';
|
|
$_REQUEST['postid'] = $id;
|
|
$_REQUEST['target'] = 'thumbnail';
|
|
$_REQUEST['do'] = 'save';
|
|
$_REQUEST['history'] = '[{"c":{"x":5,"y":8,"w":289,"h":322}}]';
|
|
|
|
$media_meta = wp_get_attachment_metadata($id);
|
|
$this->assertArrayHasKey('sizes', $media_meta, 'attachment should have size data');
|
|
$this->assertArrayHasKey('medium', $media_meta['sizes'], 'attachment should have data for medium size');
|
|
$ret = wp_save_image($id);
|
|
|
|
$media_meta = wp_get_attachment_metadata($id);
|
|
$this->assertArrayHasKey('sizes', $media_meta, 'cropped attachment should have size data');
|
|
$this->assertArrayHasKey('medium', $media_meta['sizes'], 'cropped attachment should have data for medium size');
|
|
}
|
|
|
|
/**
|
|
* @ticket 32171
|
|
*/
|
|
public function testImageEditOverwriteConstant() {
|
|
define( 'IMAGE_EDIT_OVERWRITE', true );
|
|
|
|
include_once( ABSPATH . 'wp-admin/includes/image-edit.php' );
|
|
|
|
$filename = DIR_TESTDATA . '/images/canola.jpg';
|
|
$contents = file_get_contents( $filename );
|
|
|
|
$upload = wp_upload_bits( basename( $filename ), null, $contents );
|
|
$id = $this->_make_attachment( $upload );
|
|
|
|
$_REQUEST['action'] = 'image-editor';
|
|
$_REQUEST['context'] = 'edit-attachment';
|
|
$_REQUEST['postid'] = $id;
|
|
$_REQUEST['target'] = 'all';
|
|
$_REQUEST['do'] = 'save';
|
|
$_REQUEST['history'] = '[{"c":{"x":5,"y":8,"w":289,"h":322}}]';
|
|
|
|
$ret = wp_save_image( $id );
|
|
|
|
$media_meta = wp_get_attachment_metadata( $id );
|
|
$sizes1 = $media_meta['sizes'];
|
|
|
|
$_REQUEST['history'] = '[{"c":{"x":5,"y":8,"w":189,"h":322}}]';
|
|
|
|
$ret = wp_save_image( $id );
|
|
|
|
$media_meta = wp_get_attachment_metadata( $id );
|
|
$sizes2 = $media_meta['sizes'];
|
|
|
|
$file_path = dirname( get_attached_file( $id ) );
|
|
|
|
foreach ( $sizes1 as $key => $size ) {
|
|
if ( $sizes2[ $key ]['file'] !== $size['file'] ) {
|
|
$files_that_shouldnt_exist[] = $file_path . '/' . $size['file'];
|
|
}
|
|
}
|
|
|
|
foreach ( $files_that_shouldnt_exist as $file ) {
|
|
$this->assertFalse( file_exists( $file ), 'IMAGE_EDIT_OVERWRITE is leaving garbage image files behind.' );
|
|
}
|
|
}
|
|
}
|