mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2025-10-16 12:05:38 +00:00
ddb409edca
> PHPUnit 8.0.0 introduced a `void` return type declaration to the "fixture" methods – `setUpBeforeClass()`, `setUp()`, `tearDown()` and `tearDownAfterClass()`. As the `void` return type was not introduced until PHP 7.1, this makes it more difficult to create cross-version compatible tests when using fixtures, due to signature mismatches. > > The `Yoast\PHPUnitPolyfills\TestCases\TestCase` overcomes the signature mismatch by having two versions. The correct one will be loaded depending on the PHPUnit version being used. > > When using this TestCase, if an individual test, or another TestCase which extends this TestCase, needs to overload any of the "fixture" methods, it should do so by using a snake_case variant of the original fixture method name, i.e. `set_up_before_class()`, `set_up()`, `assert_pre_conditions()`, `assert_post_conditions()`, `tear_down()`, and `tear_down_after_class()`. > > The snake_case methods will automatically be called by PHPUnit. > > > IMPORTANT: The snake_case methods should not call the PHPUnit parent, i.e. do not use `parent::setUp()` from within an overloaded `set_up()` method. If necessary, DO call `parent::set_up()`. Reference: https://github.com/Yoast/PHPUnit-Polyfills#testcases This commit renames all declared fixture methods, and calls to parent versions of those fixture methods, from camelCase to snake_case. Follow-up to [51559-51567]. Props jrf, hellofromTonya, johnbillion, netweb, dd32, pputzer, SergeyBiryukov. See #46149. git-svn-id: https://develop.svn.wordpress.org/trunk@51568 602fd350-edb4-49c9-b593-d223f7449a82
39 lines
938 B
PHP
39 lines
938 B
PHP
<?php
|
|
|
|
/**
|
|
* @group wp
|
|
*/
|
|
class Tests_WP extends WP_UnitTestCase {
|
|
/**
|
|
* @var WP
|
|
*/
|
|
protected $wp;
|
|
|
|
public function set_up() {
|
|
parent::set_up();
|
|
$this->wp = new WP();
|
|
}
|
|
|
|
public function test_add_query_var() {
|
|
$public_qv_count = count( $this->wp->public_query_vars );
|
|
|
|
$this->wp->add_query_var( 'test' );
|
|
$this->wp->add_query_var( 'test2' );
|
|
$this->wp->add_query_var( 'test' );
|
|
|
|
$this->assertCount( $public_qv_count + 2, $this->wp->public_query_vars );
|
|
$this->assertContains( 'test', $this->wp->public_query_vars );
|
|
$this->assertContains( 'test2', $this->wp->public_query_vars );
|
|
}
|
|
|
|
public function test_remove_query_var() {
|
|
$public_qv_count = count( $this->wp->public_query_vars );
|
|
|
|
$this->wp->add_query_var( 'test' );
|
|
$this->assertContains( 'test', $this->wp->public_query_vars );
|
|
$this->wp->remove_query_var( 'test' );
|
|
|
|
$this->assertCount( $public_qv_count, $this->wp->public_query_vars );
|
|
}
|
|
}
|