mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2025-10-16 12:05:38 +00:00
When running PHPCS scans (both for checking coding standards and PHP version compatibility), the results are currently only returned silently in a format that GitHub can consume for contextually annotating any code being flagged. This changes workflows using PHPCS to also display the results of each scan in the GitHub Action log, making it easier to find and understand what is causing failures. Props jrf. See #55652. git-svn-id: https://develop.svn.wordpress.org/trunk@54371 602fd350-edb4-49c9-b593-d223f7449a82
215 lines
7.4 KiB
YAML
215 lines
7.4 KiB
YAML
name: Coding Standards
|
|
|
|
on:
|
|
# JSHint was introduced in WordPress 3.8.
|
|
# PHPCS checking was introduced in WordPress 5.1.
|
|
push:
|
|
branches:
|
|
- trunk
|
|
- '3.[89]'
|
|
- '[4-9].[0-9]'
|
|
tags:
|
|
- '[0-9]+.[0-9]'
|
|
- '[0-9]+.[0-9].[0-9]+'
|
|
- '!3.7.[0-9]+'
|
|
pull_request:
|
|
branches:
|
|
- trunk
|
|
- '3.[89]'
|
|
- '[4-9].[0-9]'
|
|
paths:
|
|
# Any change to a PHP or JavaScript file should run checks.
|
|
- '**.js'
|
|
- '**.php'
|
|
# These files configure NPM. Changes could affect the outcome.
|
|
- 'package*.json'
|
|
# These files configure Composer. Changes could affect the outcome.
|
|
- 'composer.*'
|
|
# This file configures JSHint. Changes could affect the outcome.
|
|
- '.jshintrc'
|
|
# This file configures PHPCS. Changes could affect the outcome.
|
|
- 'phpcs.xml.dist'
|
|
# Changes to workflow files should always verify all workflows are successful.
|
|
- '.github/workflows/*.yml'
|
|
workflow_dispatch:
|
|
|
|
# Cancels all previous workflow runs for pull requests that have not completed.
|
|
concurrency:
|
|
# The concurrency group contains the workflow name and the branch name for pull requests
|
|
# or the commit hash for any other events.
|
|
group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
# Runs PHP coding standards checks.
|
|
#
|
|
# Violations are reported inline with annotations.
|
|
#
|
|
# Performs the following steps:
|
|
# - Checks out the repository.
|
|
# - Sets up PHP.
|
|
# - Logs debug information.
|
|
# - Configures caching for PHPCS scans.
|
|
# - Installs Composer dependencies (use cache if possible).
|
|
# - Make Composer packages available globally.
|
|
# - Logs PHP_CodeSniffer debug information.
|
|
# - Runs PHPCS on the full codebase with warnings suppressed.
|
|
# - Runs PHPCS on the `tests` directory without warnings suppressed.
|
|
# - Ensures version-controlled files are not modified or deleted.
|
|
phpcs:
|
|
name: PHP coding standards
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 20
|
|
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
|
|
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
|
|
|
|
- name: Set up PHP
|
|
uses: shivammathur/setup-php@e04e1d97f0c0481c6e1ba40f8a538454fe5d7709 # v2.21.2
|
|
with:
|
|
php-version: '7.4'
|
|
coverage: none
|
|
tools: composer, cs2pr
|
|
|
|
- name: Log debug information
|
|
run: |
|
|
php --version
|
|
composer --version
|
|
|
|
# This date is used to ensure that the PHPCS cache is cleared at least once every week.
|
|
# http://man7.org/linux/man-pages/man1/date.1.html
|
|
- name: "Get last Monday's date"
|
|
id: get-date
|
|
run: echo "::set-output name=date::$(/bin/date -u --date='last Mon' "+%F")"
|
|
|
|
- name: Cache PHPCS scan cache
|
|
uses: actions/cache@fd5de65bc895cf536527842281bea11763fefd77 # v3.0.8
|
|
with:
|
|
path: .cache/phpcs.json
|
|
key: ${{ runner.os }}-date-${{ steps.get-date.outputs.date }}-phpcs-cache-${{ hashFiles('**/composer.json', 'phpcs.xml.dist') }}
|
|
|
|
- name: Install Composer dependencies
|
|
uses: ramsey/composer-install@f680dac46551dffb2234a240d65ae806c2999dd6 # v2.1.0
|
|
with:
|
|
composer-options: "--no-progress --no-ansi"
|
|
|
|
- name: Make Composer packages available globally
|
|
run: echo "${PWD}/vendor/bin" >> $GITHUB_PATH
|
|
|
|
- name: Log PHPCS debug information
|
|
run: phpcs -i
|
|
|
|
- name: Run PHPCS on all Core files
|
|
continue-on-error: true
|
|
run: phpcs -n --report-full --report-checkstyle=./.cache/phpcs-report.xml
|
|
|
|
- name: Show PHPCS results in PR
|
|
run: cs2pr ./.cache/phpcs-report.xml
|
|
|
|
- name: Check test suite files for warnings
|
|
continue-on-error: true
|
|
run: phpcs tests --report-full --report-checkstyle=./.cache/phpcs-tests-report.xml
|
|
|
|
- name: Show test suite scan results in PR
|
|
run: cs2pr ./.cache/phpcs-tests-report.xml
|
|
|
|
- name: Ensure version-controlled files are not modified during the tests
|
|
run: git diff --exit-code
|
|
|
|
# Runs the JavaScript coding standards checks.
|
|
#
|
|
# JSHint violations are not currently reported inline with annotations.
|
|
#
|
|
# Performs the following steps:
|
|
# - Checks out the repository.
|
|
# - Logs debug information about the GitHub Action runner.
|
|
# - Installs NodeJS.
|
|
# - Logs updated debug information.
|
|
# _ Installs NPM dependencies.
|
|
# - Run the WordPress JSHint checks.
|
|
# - Ensures version-controlled files are not modified or deleted.
|
|
jshint:
|
|
name: JavaScript coding standards
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 20
|
|
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
|
|
env:
|
|
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
|
|
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
|
|
|
|
- name: Log debug information
|
|
run: |
|
|
npm --version
|
|
node --version
|
|
git --version
|
|
svn --version
|
|
|
|
- name: Install NodeJS
|
|
uses: actions/setup-node@2fddd8803e2f5c9604345a0b591c3020ee971a93 # v3.4.1
|
|
with:
|
|
node-version-file: '.nvmrc'
|
|
cache: npm
|
|
|
|
- name: Log debug information
|
|
run: |
|
|
npm --version
|
|
node --version
|
|
|
|
- name: Install Dependencies
|
|
run: npm ci
|
|
|
|
- name: Run JSHint
|
|
run: npm run grunt jshint
|
|
|
|
- name: Ensure version-controlled files are not modified or deleted
|
|
run: git diff --exit-code
|
|
|
|
slack-notifications:
|
|
name: Slack Notifications
|
|
uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
|
|
needs: [ phpcs, jshint ]
|
|
if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
|
|
with:
|
|
calling_status: ${{ needs.phpcs.result == 'success' && needs.jshint.result == 'success' && 'success' || ( needs.phpcs.result == 'cancelled' || needs.jshint.result == 'cancelled' ) && 'cancelled' || 'failure' }}
|
|
secrets:
|
|
SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
|
|
SLACK_GHA_CANCELLED_WEBHOOK: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
|
|
SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
|
|
SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
|
|
|
|
failed-workflow:
|
|
name: Failed workflow tasks
|
|
runs-on: ubuntu-latest
|
|
needs: [ phpcs, jshint, slack-notifications ]
|
|
if: |
|
|
always() &&
|
|
github.repository == 'WordPress/wordpress-develop' &&
|
|
github.event_name != 'pull_request' &&
|
|
github.run_attempt < 2 &&
|
|
(
|
|
needs.phpcs.result == 'cancelled' || needs.phpcs.result == 'failure' ||
|
|
needs.jshint.result == 'cancelled' || needs.jshint.result == 'failure'
|
|
)
|
|
|
|
steps:
|
|
- name: Dispatch workflow run
|
|
uses: actions/github-script@d4560e157075e2d93aa3022b5b51a42a880f1f93 # v6.3.0
|
|
with:
|
|
retries: 2
|
|
retry-exempt-status-codes: 418
|
|
script: |
|
|
github.rest.actions.createWorkflowDispatch({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
workflow_id: 'failed-workflow.yml',
|
|
ref: '${{ github.ref_name }}',
|
|
inputs: {
|
|
run_id: '${{ github.run_id }}'
|
|
}
|
|
});
|