wordpress-develop

mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00

History

Jonny Harris c1247f6a27 Taxonomy: Stop double sanitization in get_term function. In the `get_term` function, the filter method is invoked on the `WP_Term` object, which subsequently triggers the execution of `sanitize_term`. The filter method is also executed within `WP_Term::get_instance`. A common scenario when calling the `get_term` function is to invoke the function with an integer ID for the term and a filter set to "raw." This results in a call to `WP_Term::get_instance`. However, since both `get_term` and `WP_Term::get_instance` invoke the filter method, it leads to double sanitization of the term. Considering that `get_term` may be called thousands of times on a page, especially when priming a large number of terms into memory, this redundancy can result in thousands of unnecessary calls to `sanitize_term`. Performing the same sanitization operation twice with the same parameters is wasteful and detrimental to performance. To address this issue, the code has been updated to execute the filter method only when the filter parameter does not match or when changes have been made to the term object within the get_term hook. This optimization ensures that the filter is applied selectively, mitigating performance concerns and avoiding unnecessary sanitization calls. Props spacedmonkey, flixos90, costdev, mukesh27, joemcgill, oglekler, peterwilsoncc. Fixes #58329. git-svn-id: https://develop.svn.wordpress.org/trunk@56650 602fd350-edb4-49c9-b593-d223f7449a82		2023-09-21 16:34:59 +00:00
..
data	Editor: Fix post editor layout when Post Content has no attributes.	2023-09-20 01:24:32 +00:00
includes	Code Modernization: Use `dirname()` with the `$levels` parameter.	2023-09-11 04:51:09 +00:00
tests	Taxonomy: Stop double sanitization in get_term function.	2023-09-21 16:34:59 +00:00
multisite.xml	Build/Test Tools: Update PHPUnit configuration for PHPUnit 9.5.10/8.5.21+.	2021-09-26 03:11:18 +00:00
README.txt	Docs: Remove double spaces in `tests/phpunit/README.txt`.	2022-04-29 13:31:48 +00:00
wp-mail-real-test.php	Coding Standards: Remove superfluous blank lines at the end of various files.	2023-09-07 14:57:30 +00:00

README.txt

The short version:

1. Create a clean MySQL database and user. DO NOT USE AN EXISTING DATABASE or you will lose data, guaranteed.

2. Copy wp-tests-config-sample.php to wp-tests-config.php, edit it and include your database name/user/password.

3. $ svn up

4. Run the tests from the "trunk" directory:
   To execute a particular test:
      $ phpunit tests/phpunit/tests/test_case.php
   To execute all tests:
      $ phpunit

Notes:

Test cases live in the 'tests' subdirectory. All files in that directory will be included by default. Extend the WP_UnitTestCase class to ensure your test is run.

phpunit will initialize and install a (more or less) complete running copy of WordPress each time it is run. This makes it possible to run functional interface and module tests against a fully working database and codebase, as opposed to pure unit tests with mock objects and stubs. Pure unit tests may be used also, of course.

Changes to the test database will be rolled back as tests are finished, to ensure a clean start next time the tests are run.

phpunit is intended to run at the command line, not via a web server.