mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2025-10-16 12:05:38 +00:00
54c4de13ed
In this commit, enhancements have been made by replacing manually constructed style tags with calls to `wp_add_inline_style`. Previously, numerous style tags were generated and output directly in the header, resulting in redundant code and bypassing the core's style enqueueing system. This approach made it challenging for third-party developers to manage and control the output of these style tags. To ensure backward compatibility, the following functions have been deprecated and replaced: - print_embed_styles - print_emoji_styles - wp_admin_bar_header - _admin_bar_bump_cb Backward compatibility shims have also been added, ensuring that if these functions were previously unhooked from there actions, they will continue to not output a style tag. However, for the following functions, conversion to use inline styles was not feasible due to the potential disruption it might cause by changing the style tag IDs, potentially breaking JavaScript functionality for a number of plugins in the repository: - custom-background - wp-custom These changes improve code maintainability and enhance the flexibility and control available to developers when managing style outputs within WordPress core. Props spacedmonkey, hlunter, westonruter, flixos90. Fixes #58775. git-svn-id: https://develop.svn.wordpress.org/trunk@56682 602fd350-edb4-49c9-b593-d223f7449a82
248 lines
6.6 KiB
PHP
248 lines
6.6 KiB
PHP
<?php
|
|
|
|
require_once __DIR__ . '/base.php';
|
|
|
|
/**
|
|
* Tests wp_add_global_styles_for_blocks().
|
|
*
|
|
* @group themes
|
|
*
|
|
* @covers ::wp_add_global_styles_for_blocks
|
|
*/
|
|
class Tests_Theme_WpAddGlobalStylesForBlocks extends WP_Theme_UnitTestCase {
|
|
|
|
/**
|
|
* Test blocks to unregister at cleanup.
|
|
*
|
|
* @var array
|
|
*/
|
|
private $test_blocks = array();
|
|
|
|
public function set_up() {
|
|
parent::set_up();
|
|
remove_action( 'wp_print_styles', 'print_emoji_styles' );
|
|
}
|
|
|
|
public function tear_down() {
|
|
// Unregister test blocks.
|
|
if ( ! empty( $this->test_blocks ) ) {
|
|
foreach ( $this->test_blocks as $test_block ) {
|
|
unregister_block_type( $test_block );
|
|
}
|
|
$this->test_blocks = array();
|
|
}
|
|
|
|
parent::tear_down();
|
|
}
|
|
|
|
/**
|
|
* @ticket 56915
|
|
*/
|
|
public function test_third_party_blocks_inline_styles_not_register_to_global_styles() {
|
|
switch_theme( 'block-theme' );
|
|
|
|
wp_register_style( 'global-styles', false, array(), true, true );
|
|
wp_add_global_styles_for_blocks();
|
|
|
|
$this->assertNotContains(
|
|
'.wp-block-my-third-party-block{background-color: hotpink;}',
|
|
$this->get_global_styles()
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @ticket 56915
|
|
*/
|
|
public function test_third_party_blocks_inline_styles_get_registered_to_global_styles() {
|
|
$this->set_up_third_party_block();
|
|
|
|
wp_register_style( 'global-styles', false, array(), true, true );
|
|
|
|
$this->assertNotContains(
|
|
'.wp-block-my-third-party-block{background-color: hotpink;}',
|
|
$this->get_global_styles(),
|
|
'Third party block inline style should not be registered before running wp_add_global_styles_for_blocks()'
|
|
);
|
|
|
|
wp_add_global_styles_for_blocks();
|
|
|
|
$this->assertContains(
|
|
'.wp-block-my-third-party-block{background-color: hotpink;}',
|
|
$this->get_global_styles(),
|
|
'Third party block inline style should be registered after running wp_add_global_styles_for_blocks()'
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @ticket 56915
|
|
*/
|
|
public function test_third_party_blocks_inline_styles_get_registered_to_global_styles_when_per_block() {
|
|
$this->set_up_third_party_block();
|
|
add_filter( 'should_load_separate_core_block_assets', '__return_true' );
|
|
|
|
wp_register_style( 'global-styles', false, array(), true, true );
|
|
|
|
$this->assertNotContains(
|
|
'.wp-block-my-third-party-block{background-color: hotpink;}',
|
|
$this->get_global_styles(),
|
|
'Third party block inline style should not be registered before running wp_add_global_styles_for_blocks()'
|
|
);
|
|
|
|
wp_add_global_styles_for_blocks();
|
|
|
|
$this->assertContains(
|
|
'.wp-block-my-third-party-block{background-color: hotpink;}',
|
|
$this->get_global_styles(),
|
|
'Third party block inline style should be registered after running wp_add_global_styles_for_blocks()'
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @ticket 56915
|
|
*/
|
|
public function test_third_party_blocks_inline_styles_get_rendered_when_per_block() {
|
|
$this->set_up_third_party_block();
|
|
add_filter( 'should_load_separate_core_block_assets', '__return_true' );
|
|
|
|
wp_register_style( 'global-styles', false, array(), true, true );
|
|
wp_enqueue_style( 'global-styles' );
|
|
wp_add_global_styles_for_blocks();
|
|
|
|
$actual = get_echo( 'wp_print_styles' );
|
|
|
|
$this->assertStringContainsString(
|
|
'.wp-block-my-third-party-block{background-color: hotpink;}',
|
|
$actual,
|
|
'Third party block inline style should render'
|
|
);
|
|
$this->assertStringNotContainsString(
|
|
'.wp-block-post-featured-image',
|
|
$actual,
|
|
'Core block should not render'
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @ticket 56915
|
|
*/
|
|
public function test_blocks_inline_styles_get_rendered() {
|
|
wp_register_style( 'global-styles', false, array(), true, true );
|
|
wp_enqueue_style( 'global-styles' );
|
|
wp_add_global_styles_for_blocks();
|
|
|
|
$actual = get_echo( 'wp_print_styles' );
|
|
|
|
$this->assertStringContainsString(
|
|
'.wp-block-my-third-party-block{background-color: hotpink;}',
|
|
$actual,
|
|
'Third party block inline style should render'
|
|
);
|
|
$this->assertStringContainsString(
|
|
'.wp-block-post-featured-image',
|
|
$actual,
|
|
'Core block should render'
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @ticket 57868
|
|
*/
|
|
public function test_third_party_blocks_inline_styles_for_elements_get_rendered_when_per_block() {
|
|
$this->set_up_third_party_block();
|
|
add_filter( 'should_load_separate_core_block_assets', '__return_true' );
|
|
|
|
wp_register_style( 'global-styles', false, array(), true, true );
|
|
wp_enqueue_style( 'global-styles' );
|
|
wp_add_global_styles_for_blocks();
|
|
|
|
$actual = get_echo( 'wp_print_styles' );
|
|
|
|
$this->assertStringContainsString(
|
|
'.wp-block-my-third-party-block cite{color: white;}',
|
|
$actual
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @ticket 57868
|
|
*/
|
|
public function test_third_party_blocks_inline_styles_for_elements_get_rendered() {
|
|
wp_register_style( 'global-styles', false, array(), true, true );
|
|
wp_enqueue_style( 'global-styles' );
|
|
wp_add_global_styles_for_blocks();
|
|
|
|
$actual = get_echo( 'wp_print_styles' );
|
|
|
|
$this->assertStringContainsString(
|
|
'.wp-block-my-third-party-block cite{color: white;}',
|
|
$actual
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @ticket 57868
|
|
*
|
|
* @dataProvider data_wp_get_block_name_from_theme_json_path
|
|
*
|
|
* @param array $path An array of keys describing the path to a property in theme.json.
|
|
* @param string $expected The expected block name.
|
|
*/
|
|
public function test_wp_get_block_name_from_theme_json_path( $path, $expected ) {
|
|
$block_name = wp_get_block_name_from_theme_json_path( $path );
|
|
$this->assertSame( $expected, $block_name );
|
|
}
|
|
|
|
/**
|
|
* Data provider.
|
|
*
|
|
* @return array[]
|
|
*/
|
|
public function data_wp_get_block_name_from_theme_json_path() {
|
|
return array(
|
|
'core block styles' => array(
|
|
array( 'styles', 'blocks', 'core/navigation' ),
|
|
'core/navigation',
|
|
),
|
|
'core block element styles' => array(
|
|
array( 'styles', 'blocks', 'core/navigation', 'elements', 'link' ),
|
|
'core/navigation',
|
|
),
|
|
'custom block styles' => array(
|
|
array( 'styles', 'blocks', 'my/third-party-block' ),
|
|
'my/third-party-block',
|
|
),
|
|
'custom block element styles' => array(
|
|
array( 'styles', 'blocks', 'my/third-party-block', 'elements', 'cite' ),
|
|
'my/third-party-block',
|
|
),
|
|
'custom block wrong format' => array(
|
|
array( 'styles', 'my/third-party-block' ),
|
|
'',
|
|
),
|
|
'invalid path but works for BC' => array(
|
|
array( 'something', 'core/image' ),
|
|
'core/image',
|
|
),
|
|
);
|
|
}
|
|
|
|
private function set_up_third_party_block() {
|
|
switch_theme( 'block-theme' );
|
|
|
|
$name = 'my/third-party-block';
|
|
$settings = array(
|
|
'icon' => 'text',
|
|
'category' => 'common',
|
|
'render_callback' => 'foo',
|
|
);
|
|
register_block_type( $name, $settings );
|
|
|
|
$this->test_blocks[] = $name;
|
|
}
|
|
|
|
private function get_global_styles() {
|
|
$actual = wp_styles()->get_data( 'global-styles', 'after' );
|
|
return is_array( $actual ) ? $actual : array();
|
|
}
|
|
}
|