mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2025-10-16 12:05:38 +00:00
This is a major release and contains breaking changes. Most important changes to be aware of for this release: * All code is now namespaced. Though there is a full backward compatibility layer available and the old class names are still supported, using them will generate a deprecation notice (which can be silenced by plugins if they'd need to support multiple WP versions). See the [https://requests.ryanmccue.info/docs/upgrading.html upgrade guide] for more details. * A lot of classes have been marked `final`. This should generally not affect userland code as care has been taken to not apply the `final` keyword to classes which are known to be extended in userland code. * Extensive input validation has been added to Requests. When Requests is used as documented though, this will be unnoticable. * A new `WpOrg\Requests\Requests::has_capabilities()` method has been introduced which can be used to address #37708. * A new `WpOrg\Requests\Response::decode_body()` method has been introduced which may be usable to simplify some of the WP native wrapper code. * Remaining PHP 8.0 compatibility fixed (support for named parameters). * PHP 8.1 compatibility. Release notes: https://github.com/WordPress/Requests/releases/tag/v2.0.0 For a full list of changes in this update, see the Requests GitHub: https://github.com/WordPress/Requests/compare/v1.8.1...v2.0.0 This commit also resolves 2 blocking issues which previously caused the revert of [52244]: * New Requests files are loaded into `wp-includes/Requests/src/`, matching the location of the library. In doing so, filesystems that are case-insensitive are not impacted (see #54582). * Preload: During a Core update, the old Requests files are preloaded into memory before the update deletes the files. Preloading avoids fatal errors noted in #54562. Follow-up to [50842], [51078], [52244], [52315], [52327], [52328]. Props jrf, schlessera, datagutten, wojsmol, dustinrue, soulseekah, szepeviktor. costdev, sergeybiryukov, peterwilsoncc, ironprogrammer, antonvlasenko, hellofromTonya, swissspidy, dd32, azaozz, TobiasBg, audrasjb. Fixes #54504. See #54582, #54562. git-svn-id: https://develop.svn.wordpress.org/trunk@54997 602fd350-edb4-49c9-b593-d223f7449a82
247 lines
6.5 KiB
PHP
247 lines
6.5 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Tests for `maybe_serialize()` and `maybe_unserialize()`.
|
|
*
|
|
* @group functions.php
|
|
* @covers ::maybe_serialize
|
|
* @covers ::maybe_unserialize
|
|
*/
|
|
class Tests_Functions_MaybeSerialize extends WP_UnitTestCase {
|
|
|
|
/**
|
|
* @dataProvider data_is_not_serialized
|
|
*/
|
|
public function test_maybe_serialize( $value ) {
|
|
if ( is_array( $value ) || is_object( $value ) ) {
|
|
$expected = serialize( $value );
|
|
} else {
|
|
$expected = $value;
|
|
}
|
|
|
|
$this->assertSame( $expected, maybe_serialize( $value ) );
|
|
}
|
|
|
|
/**
|
|
* @dataProvider data_is_serialized
|
|
*/
|
|
public function test_maybe_serialize_with_double_serialization( $value ) {
|
|
$expected = serialize( $value );
|
|
|
|
$this->assertSame( $expected, maybe_serialize( $value ) );
|
|
}
|
|
|
|
/**
|
|
* @dataProvider data_is_serialized
|
|
* @dataProvider data_is_not_serialized
|
|
*/
|
|
public function test_maybe_unserialize( $value, $is_serialized ) {
|
|
if ( $is_serialized ) {
|
|
$expected = unserialize( trim( $value ) );
|
|
} else {
|
|
$expected = $value;
|
|
}
|
|
|
|
if ( is_object( $expected ) ) {
|
|
$this->assertEquals( $expected, maybe_unserialize( $value ) );
|
|
} else {
|
|
$this->assertSame( $expected, maybe_unserialize( $value ) );
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Data provider for `test_maybe_unserialize()`.
|
|
*
|
|
* @return array
|
|
*/
|
|
public function data_is_serialized() {
|
|
return array(
|
|
'serialized empty array' => array(
|
|
'data' => serialize( array() ),
|
|
'expected' => true,
|
|
),
|
|
'serialized non-empty array' => array(
|
|
'data' => serialize( array( 1, 1, 2, 3, 5, 8, 13 ) ),
|
|
'expected' => true,
|
|
),
|
|
'serialized empty object' => array(
|
|
'data' => serialize( new stdClass() ),
|
|
'expected' => true,
|
|
),
|
|
'serialized non-empty object' => array(
|
|
'data' => serialize(
|
|
(object) array(
|
|
'test' => true,
|
|
'1',
|
|
2,
|
|
)
|
|
),
|
|
'expected' => true,
|
|
),
|
|
'serialized null' => array(
|
|
'data' => serialize( null ),
|
|
'expected' => true,
|
|
),
|
|
'serialized boolean true' => array(
|
|
'data' => serialize( true ),
|
|
'expected' => true,
|
|
),
|
|
'serialized boolean false' => array(
|
|
'data' => serialize( false ),
|
|
'expected' => true,
|
|
),
|
|
'serialized integer -1' => array(
|
|
'data' => serialize( -1 ),
|
|
'expected' => true,
|
|
),
|
|
'serialized integer 1' => array(
|
|
'data' => serialize( -1 ),
|
|
'expected' => true,
|
|
),
|
|
'serialized float 1.1' => array(
|
|
'data' => serialize( 1.1 ),
|
|
'expected' => true,
|
|
),
|
|
'serialized string' => array(
|
|
'data' => serialize( 'this string will be serialized' ),
|
|
'expected' => true,
|
|
),
|
|
'serialized string with line break' => array(
|
|
'data' => serialize( "a\nb" ),
|
|
'expected' => true,
|
|
),
|
|
'serialized string with leading and trailing spaces' => array(
|
|
'data' => ' s:25:"this string is serialized"; ',
|
|
'expected' => true,
|
|
),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Data provider for `test_maybe_serialize()`.
|
|
*
|
|
* @return array
|
|
*/
|
|
public function data_is_not_serialized() {
|
|
return array(
|
|
'an empty array' => array(
|
|
'data' => array(),
|
|
'expected' => false,
|
|
),
|
|
'a non-empty array' => array(
|
|
'data' => array( 1, 1, 2, 3, 5, 8, 13 ),
|
|
'expected' => false,
|
|
),
|
|
'an empty object' => array(
|
|
'data' => new stdClass(),
|
|
'expected' => false,
|
|
),
|
|
'a non-empty object' => array(
|
|
'data' => (object) array(
|
|
'test' => true,
|
|
'1',
|
|
2,
|
|
),
|
|
'expected' => false,
|
|
),
|
|
'null' => array(
|
|
'data' => null,
|
|
'expected' => false,
|
|
),
|
|
'a boolean true' => array(
|
|
'data' => true,
|
|
'expected' => false,
|
|
),
|
|
'a boolean false' => array(
|
|
'data' => false,
|
|
'expected' => false,
|
|
),
|
|
'an integer -1' => array(
|
|
'data' => -1,
|
|
'expected' => false,
|
|
),
|
|
'an integer 0' => array(
|
|
'data' => 0,
|
|
'expected' => false,
|
|
),
|
|
'an integer 1' => array(
|
|
'data' => 1,
|
|
'expected' => false,
|
|
),
|
|
'a float 0.0' => array(
|
|
'data' => 0.0,
|
|
'expected' => false,
|
|
),
|
|
'a float 1.1' => array(
|
|
'data' => 1.1,
|
|
'expected' => false,
|
|
),
|
|
'a string' => array(
|
|
'data' => 'a string',
|
|
'expected' => false,
|
|
),
|
|
'a string with line break' => array(
|
|
'data' => "a\nb",
|
|
'expected' => false,
|
|
),
|
|
'a string with leading and trailing garbage' => array(
|
|
'data' => 'garbage:a:0:garbage;',
|
|
'expected' => false,
|
|
),
|
|
'a string with missing double quotes' => array(
|
|
'data' => 's:4:test;',
|
|
'expected' => false,
|
|
),
|
|
'a string that is too short' => array(
|
|
'data' => 's:3',
|
|
'expected' => false,
|
|
),
|
|
'not a colon in second position' => array(
|
|
'data' => 's!3:"foo";',
|
|
'expected' => false,
|
|
),
|
|
'no trailing semicolon (strict check)' => array(
|
|
'data' => 's:3:"foo"',
|
|
'expected' => false,
|
|
),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @dataProvider data_serialize_deserialize_objects
|
|
*/
|
|
public function test_deserialize_request_utility_filtered_iterator_objects( $value ) {
|
|
$serialized = maybe_serialize( $value );
|
|
|
|
if ( get_class( $value ) === 'WpOrg\Requests\Utility\FilteredIterator' ) {
|
|
$new_value = unserialize( $serialized );
|
|
$property = ( new ReflectionClass( 'WpOrg\Requests\Utility\FilteredIterator' ) )->getProperty( 'callback' );
|
|
$property->setAccessible( true );
|
|
$callback_value = $property->getValue( $new_value );
|
|
|
|
$this->assertSame( null, $callback_value );
|
|
} else {
|
|
$this->assertSame( $value->count(), unserialize( $serialized )->count() );
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Data provider for test_deserialize_request_utility_filtered_iterator_objects().
|
|
*
|
|
* @return array
|
|
*/
|
|
public function data_serialize_deserialize_objects() {
|
|
return array(
|
|
'filtered iterator using md5' => array(
|
|
new WpOrg\Requests\Utility\FilteredIterator( array( 1 ), 'md5' ),
|
|
),
|
|
'filtered iterator using sha1' => array(
|
|
new WpOrg\Requests\Utility\FilteredIterator( array( 1, 2 ), 'sha1' ),
|
|
),
|
|
'array iterator' => array(
|
|
new ArrayIterator( array( 1, 2, 3 ) ),
|
|
),
|
|
);
|
|
}
|
|
}
|