mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2025-10-16 12:05:38 +00:00
3196ab6db0
In the tests for updating a theme via Ajax, `wp_installing( true )` is called to prevent `wp_update_themes()` from running.
This worked as expected in `test_update_theme()`, however, it was missed in `test_uppercase_theme_slug()`, which was accidentally relying on the `wp_installing()` status not being properly restored in the previous test.
Now that the `wp_installing()` status was corrected in [54723], the latter test started throwing an error on PHP 8.2:
{{{
1) Tests_Ajax_wpAjaxUpdateTheme::test_uppercase_theme_slug
http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated
/var/www/src/wp-includes/Requests/Transport/cURL.php:345
/var/www/src/wp-includes/Requests/Transport/cURL.php:135
/var/www/src/wp-includes/class-requests.php:381
/var/www/src/wp-includes/class-wp-http.php:395
/var/www/src/wp-includes/class-wp-http.php:615
/var/www/src/wp-includes/http.php:179
/var/www/src/wp-includes/update.php:719
/var/www/src/wp-admin/includes/ajax-actions.php:4292
/var/www/src/wp-includes/class-wp-hook.php:308
/var/www/src/wp-includes/class-wp-hook.php:332
/var/www/src/wp-includes/plugin.php:517
/var/www/tests/phpunit/includes/testcase-ajax.php:265
/var/www/tests/phpunit/tests/ajax/wpAjaxUpdateTheme.php:157
}}}
Replicating the `wp_installing()` status changes in this test too resolves the error.
Follow-up to [38168], [38710], [54722], [54723].
See #56793.
git-svn-id: https://develop.svn.wordpress.org/trunk@54725 602fd350-edb4-49c9-b593-d223f7449a82
|
||
|---|---|---|
| .. | ||
| wpAjaxAddMeta.php | ||
| wpAjaxAddTag.php | ||
| wpAjaxAjaxTagSearch.php | ||
| wpAjaxCropImage.php | ||
| wpAjaxDeleteComment.php | ||
| wpAjaxDeletePlugin.php | ||
| wpAjaxDimComment.php | ||
| wpAjaxEditComment.php | ||
| wpAjaxGetComments.php | ||
| wpAjaxHeartbeat.php | ||
| wpAjaxImageEditor.php | ||
| wpAjaxInlineSave.php | ||
| wpAjaxReplytoComment.php | ||
| wpAjaxResponse.php | ||
| wpAjaxSendAttachmentToEditor.php | ||
| wpAjaxUpdatePlugin.php | ||
| wpAjaxUpdateTheme.php | ||
| wpAjaxWpCompressionTest.php | ||
| wpAjaxWpPrivacyErasePersonalData.php | ||
| wpAjaxWpPrivacyExportPersonalData.php | ||
| wpCustomizeManager.php | ||
| wpCustomizeNavMenus.php | ||