vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-08-11 20:40:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #17401 from DefinitelyTyped/master_fix-react-fa

Browse Source 
[Master] Fix type of children in react-fa
This commit is contained in:
Nathan Shively-Sanders
2017-06-22 14:36:42 -07:00
committed by GitHub
parent fcb37f9fe0 22cfe3f882
commit 0dce3c855c
1 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
types/react-fa/index.d.ts
Vendored
+2 -10
View File
@@ -4,7 +4,7 @@
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// TypeScript Version: 2.3
import { Component, ComponentClass, HTMLProps, StatelessComponent } from "react";
import { Component, ComponentClass, HTMLProps, StatelessComponent, ReactElement } from "react";
// fake intermediate interface to remove typing on size, as the typing
// is overrided by react-fa
@@ -37,15 +37,7 @@ export const Icon: ComponentClass<IconProps>;
export interface IconStackProps extends SizeOverrideHTMLProps<IconStack> {
size?: IconSize;
// Does not work with TypeScript 2.3:
// Type '{ size: "lg"; children: Element[]; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<IconStackProps, ComponentState>> & Reado...'.
// Type '{ size: "lg"; children: Element[]; }' is not assignable to type 'Readonly<IconStackProps>'.
// Types of property 'children' are incompatible.
// Type 'Element[]' is not assignable to type 'IconProps[]'.
// Type 'Element' is not assignable to type 'IconProps'.
// Property 'name' is missing in type 'Element'.
// children?: IconProps[];
children?: ReactElement<IconProps> | Array<ReactElement<IconProps>>;
}
export type IconStack = Component<IconStackProps>;