Merge pull request #32207 from amiram/inboxsdk-fix-route-ids

convert route ids to enum
This commit is contained in:
Daniel Rosenwasser
2019-01-22 15:56:36 -08:00
committed by GitHub
2 changed files with 43 additions and 37 deletions
+2 -1
View File
@@ -571,6 +571,7 @@ InboxSDK.load(1, '1234').then((sdk: InboxSDK.InboxSDKInstance) => {
InboxSDK.load(1, '1234').then((sdk: InboxSDK.InboxSDKInstance) => {
sdk.Router.createLink('1234', {p1: 1, 0: 1}).toLowerCase();
sdk.Router.goto('1234', {p1: 1, 0: 1});
sdk.Router.goto(sdk.Router.NativeRouteIDs.ALL_MAIL, {p1: 1, 0: 1});
const unregister1 = sdk.Router.handleCustomRoute('1234', customRouteView => {
customRouteView.getParams();
@@ -591,7 +592,7 @@ InboxSDK.load(1, '1234').then((sdk: InboxSDK.InboxSDKInstance) => {
unregister2();
const unregister3 = sdk.Router.handleListRoute('ALL_MAIL', listRouteView => {
const unregister3 = sdk.Router.handleListRoute(sdk.Router.NativeListRouteIDs.DRAFTS, listRouteView => {
const sectionDescriptor: SectionDescriptor = {
contentElement: new HTMLElement(),
footerLinkText: 'text',
+41 -36
View File
@@ -657,6 +657,9 @@ declare namespace InboxSDK {
handleCustomListRoute(routeID: string, handler: (offset: number, max: number) => CustomListDescriptor | Promise<CustomListDescriptor>): () => void;
getCurrentRouteView(): RouteView;
NativeListRouteIDs: typeof NativeListRouteIDs;
NativeRouteIDs: typeof NativeRouteIDs;
}
interface CustomListDescriptor {
@@ -754,43 +757,45 @@ declare namespace InboxSDK {
onClick?: () => void;
}
type NativeRouteIDs =
'INBOX' |
'ALL_MAIL' |
'SENT' |
'STARRED' |
'DRAFTS' |
'SNOOZED' |
'DONE' |
'REMINDERS' |
'LABEL' |
'TRASH' |
'SPAM' |
'IMPORTANT' |
'SEARCH' |
'THREAD' |
'CHATS' |
'CHAT' |
'CONTACTS' |
'CONTACT' |
'SETTINGS' |
'ANY_LIST';
enum NativeRouteIDs {
INBOX,
ALL_MAIL,
SENT,
STARRED,
DRAFTS,
SNOOZED,
DONE,
REMINDERS,
LABEL,
TRASH,
SPAM,
IMPORTANT,
SEARCH,
THREAD,
CHATS,
CHAT,
CONTACTS,
CONTACT,
SETTINGS,
ANY_LIST
}
type NativeListRouteIDs =
'INBOX'
| 'ALL_MAIL'
| 'SENT'
| 'STARRED'
| 'DRAFTS'
| 'SNOOZED'
| 'DONE'
| 'REMINDERS'
| 'LABEL'
| 'TRASH'
| 'SPAM'
| 'IMPORTANT'
| 'SEARCH'
| 'ANY_LIST';
enum NativeListRouteIDs {
INBOX,
ALL_MAIL,
SENT,
STARRED,
DRAFTS,
SNOOZED,
DONE,
REMINDERS,
LABEL,
TRASH,
SPAM,
IMPORTANT,
SEARCH,
ANY_LIST
}
}
export namespace NavMenu {