[statuses] remove unnecessary any, enable strict null checks & linting (#18935)

types/statuses/index.d.ts

@@ -1,20 +1,26 @@
-// Type definitions for statuses v1.2.1
+// Type definitions for statuses 1.3
 // Project: https://github.com/jshttp/statuses
 // Definitions by: Tanguy Krotoff <https://github.com/tkrotoff>
+//                 BendingBender <https://github.com/BendingBender>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
 
+export = status;
+
+declare const status: Status & CodesToMessages & MessagesToCodes;
 
 interface Status {
-    [code: number]: string;
-    [msg: string]: any | number;
-
-    codes: Array<number>;
-    redirect: { [code: number]: boolean };
-    empty: { [code: number]: boolean };
-    retry: { [code: number]: boolean };
+    codes: number[];
+    redirect: { [code: number]: boolean | undefined };
+    empty: { [code: number]: boolean | undefined };
+    retry: { [code: number]: boolean | undefined };
 
     (code: number | string): number;
 }
 
-declare var status: Status;
-export = status;
+interface CodesToMessages {
+    [code: number]: string | undefined;
+}
+
+interface MessagesToCodes {
+    [msg: string]: number | undefined;
+}

types/statuses/statuses-tests.ts

@@ -1,32 +1,31 @@
-
 import status = require('statuses');
 
-var code: number;
+let code: number | undefined;
 
-code = status(403) // => 403
-code = status('403') // => 403
-code = status('forbidden') // => 403
-code = status('Forbidden') // => 403
-code = status(306) // throws, as it's not supported by node.js
+code = status(403); // => 403
+code = status('403'); // => 403
+code = status('forbidden'); // => 403
+code = status('Forbidden'); // => 403
+code = status(306); // throws, as it's not supported by node.js
 
-var codes: Array<number>;
+let codes: number[];
 codes = status.codes;
 
-var msg: string;
-msg = status[404] // => 'Not Found'
+let msg: string | undefined;
+msg = status[404]; // => 'Not Found'
 
-code = status['not found'] // => 404
-code = status['Not Found'] // => 404
+code = status['not found']; // => 404
+code = status['Not Found']; // => 404
 
-var isRedirect: boolean;
-isRedirect = status.redirect[200] // => undefined
-isRedirect = status.redirect[301] // => true
+let isRedirect: boolean | undefined;
+isRedirect = status.redirect[200]; // => undefined
+isRedirect = status.redirect[301]; // => true
 
-var isEmpty: boolean;
-isEmpty = status.empty[200] // => undefined
-isEmpty = status.empty[204] // => true
-isEmpty = status.empty[304] // => true
+let isEmpty: boolean | undefined;
+isEmpty = status.empty[200]; // => undefined
+isEmpty = status.empty[204]; // => true
+isEmpty = status.empty[304]; // => true
 
-var isRetry: boolean;
-isRetry = status.retry[501] // => undefined
-isRetry = status.retry[503] // => true
+let isRetry: boolean | undefined;
+isRetry = status.retry[501]; // => undefined
+isRetry = status.retry[503]; // => true

types/statuses/tsconfig.json

@@ -6,7 +6,7 @@
         ],
         "noImplicitAny": true,
         "noImplicitThis": true,
-        "strictNullChecks": false,
+        "strictNullChecks": true,
         "baseUrl": "../",
         "typeRoots": [
             "../"
@@ -19,4 +19,4 @@
         "index.d.ts",
         "statuses-tests.ts"
     ]
-}
+}

types/statuses/tslint.json

@@ -0,0 +1 @@
+{ "extends": "dtslint/dt.json" }