vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-10-03 22:37:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[express-serve-static-core] Fix listen callback type (#35883)

Browse Source 
* [express-serve-static-core] Add tests

* [express-serve-static-core] listen's callback can take some parameters

* [express-serve-static-core] Add a definitions by section
This commit is contained in:
aereal
2019-06-06 12:59:30 -07:00
committed by Andrew Casey
parent e1e63171f3
commit 34f4572c07
2 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
types/express-serve-static-core/express-serve-static-core-tests.ts
+5 -1
View File
@@ -1,3 +1,7 @@
import * as express from 'express-serve-static-core';
// null test file - everything should be tested from express.d.ts and serve-static.d.ts
const app: express.Application = {} as any;
app.listen(3000);
app.listen(3000, (err: any) => {
// no-op error callback
});
types/express-serve-static-core/index.d.ts
Vendored
+6 -5
View File
@@ -5,6 +5,7 @@
// Kacper Polak <https://github.com/kacepe>
// Satana Charuwichitratana <https://github.com/micksatana>
// Sami Jaber <https://github.com/samijaber>
// aereal <https://github.com/aereal>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// TypeScript Version: 2.2
@@ -996,11 +997,11 @@ export interface Application extends EventEmitter, IRouter, Express.Application
* http.createServer(app).listen(80);
* https.createServer({ ... }, app).listen(443);
*/
listen(port: number, hostname: string, backlog: number, callback?: () => void): http.Server;
listen(port: number, hostname: string, callback?: () => void): http.Server;
listen(port: number, callback?: () => void): http.Server;
listen(callback?: () => void): http.Server;
listen(path: string, callback?: () => void): http.Server;
listen(port: number, hostname: string, backlog: number, callback?: (...args: any[]) => void): http.Server;
listen(port: number, hostname: string, callback?: (...args: any[]) => void): http.Server;
listen(port: number, callback?: (...args: any[]) => void): http.Server;
listen(callback?: (...args: any[]) => void): http.Server;
listen(path: string, callback?: (...args: any[]) => void): http.Server;
listen(handle: any, listeningListener?: () => void): http.Server;
router: string;