add missing Options (#37959)

This commit is contained in:
Claas Ahlrichs
2019-09-04 01:40:47 +02:00
committed by Ron Buckton
parent ba6b2827ff
commit 3a47df29de
2 changed files with 15 additions and 5 deletions

View File

@@ -5,6 +5,9 @@ http.request({
path: '/a/b',
port: 8000,
maxRedirects: 12,
beforeRedirect: (options) => {
options.followRedirects = false;
}
}, (response) => {
console.log(response.responseUrl, response.redirects);
response.on('data', (chunk) => {

View File

@@ -1,6 +1,6 @@
// Type definitions for follow-redirects 1.5
// Type definitions for follow-redirects 1.8
// Project: https://github.com/follow-redirects/follow-redirects
// Definitions by: Emily Klassen <https://github.com/forivall>
// Definitions by: Emily Klassen <https://github.com/forivall>, Claas Ahlrichs <https://github.com/claasahl>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// TypeScript Version: 2.8
@@ -70,19 +70,26 @@ export interface RedirectableRequest<Request extends WrappableRequest, Response>
export interface RedirectScheme<Options, Request extends WrappableRequest, Response> {
request(
options: string | Options & FollowOptions,
options: string | Options & FollowOptions<Options>,
callback?: (res: Response & FollowResponse) => void
): RedirectableRequest<Request, Response>;
get(
options: string | Options & FollowOptions,
options: string | Options & FollowOptions<Options>,
callback?: (res: Response & FollowResponse) => void
): RedirectableRequest<Request, Response>;
}
export type Override<T, U> = Pick<T, Exclude<keyof T, keyof U>> & U;
export interface FollowOptions {
export interface FollowOptions<Options> {
followRedirects?: boolean;
maxRedirects?: number;
maxBodyLength?: number;
beforeRedirect?: (options: Options & FollowOptions<Options>) => void;
agents?: {
http?: coreHttp.Agent;
https?: coreHttps.Agent;
};
trackRedirects?: boolean;
}
export interface FollowResponse {