[@types/eslint]: add missing extends to override config definition (#38601)

* [@types/eslint]: add missing extends to override config definition

* fixup! [@types/eslint]: add missing extends to override config definition
This commit is contained in:
Martin Hochel
2019-10-02 14:48:00 -07:00
committed by Ryan Cavanaugh
parent 634abdf468
commit 5c0bb53def
4 changed files with 51 additions and 35 deletions
+17 -12
View File
@@ -389,18 +389,23 @@ linter.verify(SOURCE, { rules: { 'no-unused-vars': [2, { vars: 'all' }] } }, 'te
linter.verify(SOURCE, { rules: { 'no-console': 1 } }, 'test.js');
linter.verify(SOURCE, { rules: { 'no-console': 0 } }, 'test.js');
linter.verify(SOURCE, { rules: { 'no-console': 'error' } }, 'test.js');
linter.verify(SOURCE, {
rules: { 'no-console': 'error' },
overrides: [
{
excludedFiles: ['*-test.js', '*.spec.js'],
files: ['*-test.js', '*.spec.js'],
rules: {
'no-unused-expressions': 'off'
}
}
]
}, 'test.js');
linter.verify(
SOURCE,
{
rules: { 'no-console': 'error' },
overrides: [
{
extends: ['eslint-config-bad-guy'],
excludedFiles: ['*-test.js', '*.spec.js'],
files: ['*-test.js', '*.spec.js'],
rules: {
'no-unused-expressions': 'off',
},
},
],
},
'test.js',
);
linter.verify(SOURCE, { rules: { 'no-console': 'warn' } }, 'test.js');
linter.verify(SOURCE, { rules: { 'no-console': 'off' } }, 'test.js');
+9 -6
View File
@@ -385,11 +385,12 @@ export namespace Linter {
}
interface HasRules {
rules?: {
[name: string]: RuleLevel | RuleLevelAndOptions
[name: string]: RuleLevel | RuleLevelAndOptions;
};
}
interface RuleOverride extends HasRules {
extends?: string | string[];
excludedFiles?: string[];
files?: string[];
}
@@ -452,11 +453,13 @@ export namespace Linter {
messages: LintMessage[];
}
type ParserModule = {
parse(text: string, options?: any): AST.Program;
} | {
parseForESLint(text: string, options?: any): ESLintParseResult;
};
type ParserModule =
| {
parse(text: string, options?: any): AST.Program;
}
| {
parseForESLint(text: string, options?: any): ESLintParseResult;
};
interface ESLintParseResult {
ast: AST.Program;
+17 -12
View File
@@ -389,18 +389,23 @@ linter.verify(SOURCE, { rules: { 'no-unused-vars': [2, { vars: 'all' }] } }, 'te
linter.verify(SOURCE, { rules: { 'no-console': 1 } }, 'test.js');
linter.verify(SOURCE, { rules: { 'no-console': 0 } }, 'test.js');
linter.verify(SOURCE, { rules: { 'no-console': 'error' } }, 'test.js');
linter.verify(SOURCE, {
rules: { 'no-console': 'error' },
overrides: [
{
excludedFiles: ['*-test.js', '*.spec.js'],
files: ['*-test.js', '*.spec.js'],
rules: {
'no-unused-expressions': 'off'
}
}
]
}, 'test.js');
linter.verify(
SOURCE,
{
rules: { 'no-console': 'error' },
overrides: [
{
extends: ['eslint-config-bad-guy'],
excludedFiles: ['*-test.js', '*.spec.js'],
files: ['*-test.js', '*.spec.js'],
rules: {
'no-unused-expressions': 'off',
},
},
],
},
'test.js',
);
linter.verify(SOURCE, { rules: { 'no-console': 'warn' } }, 'test.js');
linter.verify(SOURCE, { rules: { 'no-console': 'off' } }, 'test.js');
+8 -5
View File
@@ -386,6 +386,7 @@ export namespace Linter {
}
interface RuleOverride<Rules extends RulesRecord = RulesRecord> extends HasRules<Rules> {
extends?: string | string[];
excludedFiles?: string[];
files?: string[];
}
@@ -448,11 +449,13 @@ export namespace Linter {
messages: LintMessage[];
}
type ParserModule = {
parse(text: string, options?: any): AST.Program;
} | {
parseForESLint(text: string, options?: any): ESLintParseResult;
};
type ParserModule =
| {
parse(text: string, options?: any): AST.Program;
}
| {
parseForESLint(text: string, options?: any): ESLintParseResult;
};
interface ESLintParseResult {
ast: AST.Program;